169769 2017-03-16 11:08:13 -0700 std::get for tuple should be declared before struct TupleHash is defined 2020-06-01 14:53:30 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 179926 P2 Normal --- 1 yoshiaki.jitsukawa webkit-unassigned benjamin cdumez cmarcelo commit-queue dbates don.olmstead fujii mjs oldest_to_newest 1288619 0 yoshiaki.jitsukawa 2017-03-16 11:08:13 -0700 As TupleHash::hash() refers to std::get(std::tuple), it should be declared beforehand. Otherwise clang's two phase lookup cannot resolve the proper function. 1288646 1 304663 yoshiaki.jitsukawa 2017-03-16 11:55:17 -0700 Created attachment 304663 patch 1288648 2 304664 yoshiaki.jitsukawa 2017-03-16 11:58:31 -0700 Created attachment 304664 patch 1288838 3 304664 achristensen 2017-03-16 16:38:43 -0700 Comment on attachment 304664 patch What file fails to compile without this? We would ideally not add another #include to this widely-included file if we can get away with just including tuple before wtf/HashFunctions.h in the file that instantiates TupleHash 1288849 4 yoshiaki.jitsukawa 2017-03-16 17:01:25 -0700 JSClassRef.cpp, for example. Adding #include <tuple> to it works fine. The completeness of HashFunctions.h doesn't matter? 1289000 5 yoshiaki.jitsukawa 2017-03-17 08:05:52 -0700 #include <utility> template <typename T> auto myget(const T& t) { return std::get<0>(t); } #include <tuple> int foo() { return myget(std::tuple<int, int, int>(1, 2, 3)); } --- Here's a simplified code which causes a compilation error with clang while MSVC is ok. 1307801 6 yoshiaki.jitsukawa 2017-05-12 00:04:06 -0700 There seems to be two factors in this issue: - <tuple> is implicitly included or not - compiler does two phase lookup or not On mac and ubuntu, <tuple> is implicitly included in HashFunctions.h. On windows, <tuple> is not included there but cl compiler doesn't do two phase lookup so webkit can build. However if we use clang-cl with "-fno-delayed-template-parsing", which enables two phase lookup, the compiler reports compilation errors of std::get(std::tuple), so there's still a problem of header inclusion. Anyways, if toolchain supports, passing "-fdelayed-template-parsing" (not "-fno-delayed-template-parsing") can be a workaround. 1374111 7 don.olmstead 2017-11-21 16:16:16 -0800 *** This bug has been marked as a duplicate of bug 179926 *** 1658067 8 304664 mjs 2020-06-01 14:53:30 -0700 Comment on attachment 304664 patch Unflagging and obsoleting since this was resolved as a dupe. 304663 2017-03-16 11:55:17 -0700 2017-03-16 11:58:31 -0700 patch bug169769.diff text/plain 908 yoshiaki.jitsukawa ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMTQ3ODc1ZC4uODMyNmE0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0wMy0xNiAg WW9zaGlha2kgSml0c3VrYXdhICA8WW9zaGlha2kuSml0c3VrYXdhQHNvbnkuY29tPgorCisgICAg ICAgIHN0ZDo6Z2V0IGZvciB0dXBsZSBzaG91bGQgYmUgZGVjbGFyZWQgYmVmb3JlIHN0cnVjdCBU dXBsZUhhc2ggaXMgZGVmaW5lZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY5NzY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3dGYvSGFzaEZ1bmN0aW9ucy5oOgorCiAyMDE3LTAzLTEzICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gT25seSByZXBvcnQgYmFj a2dyb3VuZCBXZWJQcm9jZXNzZXMgYXMgdW5yZXNwb25zaXZlIGluIHRoZSBiYWNrZ3JvdW5kIGFm dGVyIDkwIHNlY29uZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0hhc2hGdW5jdGlvbnMu aCBiL1NvdXJjZS9XVEYvd3RmL0hhc2hGdW5jdGlvbnMuaAppbmRleCBhZjBhNTFmLi5jMzg5ZjBk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoRnVuY3Rpb25zLmgKKysrIGIvU291cmNl L1dURi93dGYvSGFzaEZ1bmN0aW9ucy5oCkBAIC0yMiw2ICsyMiw3IEBACiAjZGVmaW5lIFdURl9I YXNoRnVuY3Rpb25zX2gKIAogI2luY2x1ZGUgPHN0ZGludC5oPgorI2luY2x1ZGUgPHR1cGxlLmg+ CiAjaW5jbHVkZSA8d3RmL0dldFB0ci5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KIAo= 304664 2017-03-16 11:58:31 -0700 2020-06-01 14:53:30 -0700 patch bug169769.diff text/plain 906 yoshiaki.jitsukawa ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMTQ3ODc1ZC4uODMyNmE0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0wMy0xNiAg WW9zaGlha2kgSml0c3VrYXdhICA8WW9zaGlha2kuSml0c3VrYXdhQHNvbnkuY29tPgorCisgICAg ICAgIHN0ZDo6Z2V0IGZvciB0dXBsZSBzaG91bGQgYmUgZGVjbGFyZWQgYmVmb3JlIHN0cnVjdCBU dXBsZUhhc2ggaXMgZGVmaW5lZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY5NzY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3dGYvSGFzaEZ1bmN0aW9ucy5oOgorCiAyMDE3LTAzLTEzICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gT25seSByZXBvcnQgYmFj a2dyb3VuZCBXZWJQcm9jZXNzZXMgYXMgdW5yZXNwb25zaXZlIGluIHRoZSBiYWNrZ3JvdW5kIGFm dGVyIDkwIHNlY29uZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0hhc2hGdW5jdGlvbnMu aCBiL1NvdXJjZS9XVEYvd3RmL0hhc2hGdW5jdGlvbnMuaAppbmRleCBhZjBhNTFmLi5jMzg5ZjBk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoRnVuY3Rpb25zLmgKKysrIGIvU291cmNl L1dURi93dGYvSGFzaEZ1bmN0aW9ucy5oCkBAIC0yMiw2ICsyMiw3IEBACiAjZGVmaW5lIFdURl9I YXNoRnVuY3Rpb25zX2gKIAogI2luY2x1ZGUgPHN0ZGludC5oPgorI2luY2x1ZGUgPHR1cGxlPgog I2luY2x1ZGUgPHd0Zi9HZXRQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CiAK