169757 2017-03-16 09:02:09 -0700 webktpy: Fix device regular expression for parsing simctl output 2017-03-16 10:12:56 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 168397 1 jbedard jbedard commit-queue glenn lforschler oldest_to_newest 1288564 0 jbedard 2017-03-16 09:02:09 -0700 The fix in <http://trac.webkit.org/changeset/213164> was insufficient. We should make the UDID portion of the regular expression more strict to ensure that an unavailable device is correctly parsed. 1288565 1 304644 jbedard 2017-03-16 09:06:41 -0700 Created attachment 304644 Patch 1288575 2 304644 dbates 2017-03-16 09:27:13 -0700 Comment on attachment 304644 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304644&action=review > Tools/ChangeLog:7 > + Please explain the purpose of this change. Specifically, what this change is fixing as well as how it relates the fix in bug #168394. 1288578 3 304646 jbedard 2017-03-16 09:32:01 -0700 Created attachment 304646 Patch for landing 1288593 4 304646 commit-queue 2017-03-16 10:12:42 -0700 Comment on attachment 304646 Patch for landing Clearing flags on attachment: 304646 Committed r214046: <http://trac.webkit.org/changeset/214046> 1288594 5 commit-queue 2017-03-16 10:12:56 -0700 All reviewed patches have been landed. Closing bug. 304644 2017-03-16 09:06:41 -0700 2017-03-16 09:31:58 -0700 Patch bug-169757-20170316090640.patch text/plain 3454 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNDA0MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTAzLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJrdHB5OiBGaXggZGV2aWNlIHJlZ3VsYXIgZXhwcmVzc2lvbiBmb3Ig cGFyc2luZyBzaW1jdGwgb3V0cHV0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjk3NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5OgorICAg ICAgICAoU2ltdWxhdG9yKTogTWFrZSBVRElEIHJlZ3VsYXIgZXhwcmVzc2lvbiBtb3JlIHN0cmlj dC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvcl91bml0dGVzdC5w eTogVGVzdCBhbiB1bmF2YWlsYWJsZSBkZXZpY2UuCisKIDIwMTctMDMtMTUgIFRpbSBIb3J0b24g IDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTnVsbCBkZXJlZiB1bmRlciBj YWxsQWZ0ZXJOZXh0UHJlc2VudGF0aW9uVXBkYXRlCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3hjb2RlL3NpbXVsYXRvci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3hjb2RlL3NpbXVsYXRvci5weQkocmV2aXNpb24gMjEzOTk1KQorKysgVG9vbHMvU2NyaXB0 cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkJKHdvcmtpbmcgY29weSkKQEAgLTE3OSw3ICsx NzksNyBAQCBjbGFzcyBTaW11bGF0b3Iob2JqZWN0KToKICAgICB1bmF2YWlsYWJsZV92ZXJzaW9u X3JlID0gcmUuY29tcGlsZSgnLS0gVW5hdmFpbGFibGU6ICg/UDxpZGVudGlmaWVyPlteIF0rKSAt LScpCiAgICAgdmVyc2lvbl9yZSA9IHJlLmNvbXBpbGUoJy0tIChpfHdhdGNofHR2KU9TICg/UDx2 ZXJzaW9uPlxkK1wuXGQrKSg/UDxpbnRlcm5hbD4gSW50ZXJuYWwpPyAtLScpCiAgICAgZGV2aWNl c19yZSA9IHJlLmNvbXBpbGUoCi0gICAgICAgICdccyooP1A8bmFtZT4uKykgXCgoP1A8dWRpZD5b XildKylcKSBcKCg/UDxzdGF0ZT5bXildKylcKSggXCgoP1A8YXZhaWxhYmlsaXR5PlteKV0rKVwp KT8nKQorICAgICAgICAnXHMqKD9QPG5hbWU+LispIFwoKD9QPHVkaWQ+W0EtWjAtOVwtXSspXCkg XCgoP1A8c3RhdGU+W14pXSspXCkoIFwoKD9QPGF2YWlsYWJpbGl0eT5bXildKylcKSk/JykKIAog ICAgIG1hbmFnZWRfZGV2aWNlcyA9IHt9CiAgICAgRGV2aWNlID0gTm9uZQpJbmRleDogVG9vbHMv U2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3JfdW5pdHRlc3QucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3JfdW5pdHRlc3QucHkJKHJl dmlzaW9uIDIxMzk5NSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9y X3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC02OCw2ICs2OCw3IEBAIHdhdGNoT1MgMi4w ICgyLjAgLSAxM1MzNDMpIChjb20uYXBwbGUuQ28KICAgICBpUGFkIFJldGluYSAoNzMzRkM3MUUt MjJGNC00MDc3LUJGNzktMjVDMjdFQTg4MUZDKSAoU2h1dGRvd24pCiAgICAgaVBhZCBBaXIgKDY3 MjY2ODQxLTgyRjMtNDU0NS1BRUQ2LTU2OEIxMTdFNDFBOCkgKFNodXRkb3duKQogICAgIGlQYWQg UHJvICg5LjcgaW5jaCkgKERFQkQ1MEI4LTA1NjYtNEQ3QS1CQ0RCLTQxMzRDRkU1REE0MCkgKFNo dXRkb3duKQorICAgIGlQaG9uZSA3ICgyQUU1OEJCRS0wOTk1LTQzMjYtOUI2NS0yRjQxM0UyRTMz REMpIChTaHV0ZG93bikgKHVuYXZhaWxhYmxlLCBydW50aW1lIHByb2ZpbGUgbm90IGZvdW5kKQog LS0gaU9TIDguMCBJbnRlcm5hbCAtLQogLS0gdHZPUyA5LjAgLS0KIEFwcGxlIFRWIDEwODBwICg1 NTI4MUFCRS05QzI3LTQzOEItQUQ1MC1DNTQwRDdCQzRCQUMpIChTaHV0ZG93bikKQEAgLTEzMyw3 ICsxMzQsNyBAQCBBcHBsZSBUViAxMDgwcCAoNTUyODFBQkUtOUMyNy00MzhCLUFENTAtCiAgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWwoVHJ1ZSwgcnVudGltZV9pb3NfOC5hdmFpbGFibGUpCiAgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWwoRmFsc2UsIHJ1bnRpbWVfaW9zXzguaXNfaW50ZXJuYWxfcnVu dGltZSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCh0dXBsZShbOCwgMF0pLCBydW50aW1lX2lv c184LnZlcnNpb24pCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoMTAsIGxlbihydW50aW1lX2lv c184LmRldmljZXMpKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKDExLCBsZW4ocnVudGltZV9p b3NfOC5kZXZpY2VzKSkKIAogICAgICAgICBkZXZpY2VfaXBob25lXzRzID0gcnVudGltZV9pb3Nf OC5kZXZpY2VzWzBdCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoJ2lQaG9uZSA0cycsIGRldmlj ZV9pcGhvbmVfNHMubmFtZSkKQEAgLTE5NSw2ICsxOTYsMTIgQEAgQXBwbGUgVFYgMTA4MHAgKDU1 MjgxQUJFLTlDMjctNDM4Qi1BRDUwLQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKFRydWUsIGRl dmljZV9pcGFkX3Byby5hdmFpbGFibGUpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocnVudGlt ZV9pb3NfOCwgZGV2aWNlX2lwYWRfcHJvLnJ1bnRpbWUpCiAKKyAgICAgICAgZGV2aWNlX2lwaG9u ZV83ID0gcnVudGltZV9pb3NfOC5kZXZpY2VzWzEwXQorICAgICAgICBzZWxmLmFzc2VydEVxdWFs KCdpUGhvbmUgNycsIGRldmljZV9pcGhvbmVfNy5uYW1lKQorICAgICAgICBzZWxmLmFzc2VydEVx dWFsKCcyQUU1OEJCRS0wOTk1LTQzMjYtOUI2NS0yRjQxM0UyRTMzREMnLCBkZXZpY2VfaXBob25l XzcudWRpZCkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChGYWxzZSwgZGV2aWNlX2lwaG9uZV83 LmF2YWlsYWJsZSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChydW50aW1lX2lvc184LCBkZXZp Y2VfaXBob25lXzcucnVudGltZSkKKwogICAgICAgICBydW50aW1lX2lvc184X2ludGVybmFsID0g c2ltdWxhdG9yLnJ1bnRpbWVzWzFdCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoJ2NvbS5hcHBs ZS5Db3JlU2ltdWxhdG9yLlNpbVJ1bnRpbWUuaU9TLTgtMC1JbnRlcm5hbCcsIHJ1bnRpbWVfaW9z XzhfaW50ZXJuYWwuaWRlbnRpZmllcikKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChGYWxzZSwg cnVudGltZV9pb3NfOF9pbnRlcm5hbC5hdmFpbGFibGUpCg== 304646 2017-03-16 09:32:01 -0700 2017-03-16 10:12:42 -0700 Patch for landing bug-169757-20170316093200.patch text/plain 3680 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNDA0NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE3LTAzLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJrdHB5OiBGaXggZGV2aWNlIHJlZ3VsYXIgZXhwcmVzc2lvbiBmb3Ig cGFyc2luZyBzaW1jdGwgb3V0cHV0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjk3NTcKKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4IENocmlzdGVu c2VuLgorCisgICAgICAgIElmIGEgZGV2aWNlIGlzIHVuYXZhaWxhYmxlLCB0aGUgY2hhbmdlcyBp biByMjEzMTY0IG1lYW4gdGhhdCB0aGUKKyAgICAgICAgbmFtZSBvZiB0aGUgZGV2aWNlIHdpbGwg Y29uc3VtZSB0aGUgVURJRCBhbmQgcmV0dXJuIHRoZSBzdGF0ZSBhcworICAgICAgICB0aGUgZGV2 aWNlIFVESUQgYW5kIHRoZSBhdmFpbGFiaWxpdHkgc3RyaW5nIGFzIHRoZSBkZXZpY2Ugc3RhdGUu CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weToKKyAgICAg ICAgKFNpbXVsYXRvcik6IE1ha2UgVURJRCByZWd1bGFyIGV4cHJlc3Npb24gbW9yZSBzdHJpY3Qu CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3JfdW5pdHRlc3QucHk6 IFRlc3QgYW4gdW5hdmFpbGFibGUgZGV2aWNlLgorCiAyMDE3LTAzLTE1ICBUaW0gSG9ydG9uICA8 dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIE51bGwgZGVyZWYgdW5kZXIgY2Fs bEFmdGVyTmV4dFByZXNlbnRhdGlvblVwZGF0ZQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRw eS94Y29kZS9zaW11bGF0b3IucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRw eS94Y29kZS9zaW11bGF0b3IucHkJKHJldmlzaW9uIDIxNDA0NCkKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNzksNyArMTc5 LDcgQEAgY2xhc3MgU2ltdWxhdG9yKG9iamVjdCk6CiAgICAgdW5hdmFpbGFibGVfdmVyc2lvbl9y ZSA9IHJlLmNvbXBpbGUoJy0tIFVuYXZhaWxhYmxlOiAoP1A8aWRlbnRpZmllcj5bXiBdKykgLS0n KQogICAgIHZlcnNpb25fcmUgPSByZS5jb21waWxlKCctLSAoaXx3YXRjaHx0dilPUyAoP1A8dmVy c2lvbj5cZCtcLlxkKykoP1A8aW50ZXJuYWw+IEludGVybmFsKT8gLS0nKQogICAgIGRldmljZXNf cmUgPSByZS5jb21waWxlKAotICAgICAgICAnXHMqKD9QPG5hbWU+LispIFwoKD9QPHVkaWQ+W14p XSspXCkgXCgoP1A8c3RhdGU+W14pXSspXCkoIFwoKD9QPGF2YWlsYWJpbGl0eT5bXildKylcKSk/ JykKKyAgICAgICAgJ1xzKig/UDxuYW1lPi4rKSBcKCg/UDx1ZGlkPltBLVowLTlcLV0rKVwpIFwo KD9QPHN0YXRlPlteKV0rKVwpKCBcKCg/UDxhdmFpbGFiaWxpdHk+W14pXSspXCkpPycpCiAKICAg ICBtYW5hZ2VkX2RldmljZXMgPSB7fQogICAgIERldmljZSA9IE5vbmUKSW5kZXg6IFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yX3VuaXR0ZXN0LnB5CShyZXZp c2lvbiAyMTQwNDQpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvcl91 bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNjgsNiArNjgsNyBAQCB3YXRjaE9TIDIuMCAo Mi4wIC0gMTNTMzQzKSAoY29tLmFwcGxlLkNvCiAgICAgaVBhZCBSZXRpbmEgKDczM0ZDNzFFLTIy RjQtNDA3Ny1CRjc5LTI1QzI3RUE4ODFGQykgKFNodXRkb3duKQogICAgIGlQYWQgQWlyICg2NzI2 Njg0MS04MkYzLTQ1NDUtQUVENi01NjhCMTE3RTQxQTgpIChTaHV0ZG93bikKICAgICBpUGFkIFBy byAoOS43IGluY2gpIChERUJENTBCOC0wNTY2LTREN0EtQkNEQi00MTM0Q0ZFNURBNDApIChTaHV0 ZG93bikKKyAgICBpUGhvbmUgNyAoMkFFNThCQkUtMDk5NS00MzI2LTlCNjUtMkY0MTNFMkUzM0RD KSAoU2h1dGRvd24pICh1bmF2YWlsYWJsZSwgcnVudGltZSBwcm9maWxlIG5vdCBmb3VuZCkKIC0t IGlPUyA4LjAgSW50ZXJuYWwgLS0KIC0tIHR2T1MgOS4wIC0tCiBBcHBsZSBUViAxMDgwcCAoNTUy ODFBQkUtOUMyNy00MzhCLUFENTAtQzU0MEQ3QkM0QkFDKSAoU2h1dGRvd24pCkBAIC0xMzMsNyAr MTM0LDcgQEAgQXBwbGUgVFYgMTA4MHAgKDU1MjgxQUJFLTlDMjctNDM4Qi1BRDUwLQogICAgICAg ICBzZWxmLmFzc2VydEVxdWFsKFRydWUsIHJ1bnRpbWVfaW9zXzguYXZhaWxhYmxlKQogICAgICAg ICBzZWxmLmFzc2VydEVxdWFsKEZhbHNlLCBydW50aW1lX2lvc184LmlzX2ludGVybmFsX3J1bnRp bWUpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwodHVwbGUoWzgsIDBdKSwgcnVudGltZV9pb3Nf OC52ZXJzaW9uKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKDEwLCBsZW4ocnVudGltZV9pb3Nf OC5kZXZpY2VzKSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCgxMSwgbGVuKHJ1bnRpbWVfaW9z XzguZGV2aWNlcykpCiAKICAgICAgICAgZGV2aWNlX2lwaG9uZV80cyA9IHJ1bnRpbWVfaW9zXzgu ZGV2aWNlc1swXQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKCdpUGhvbmUgNHMnLCBkZXZpY2Vf aXBob25lXzRzLm5hbWUpCkBAIC0xOTUsNiArMTk2LDEyIEBAIEFwcGxlIFRWIDEwODBwICg1NTI4 MUFCRS05QzI3LTQzOEItQUQ1MC0KICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChUcnVlLCBkZXZp Y2VfaXBhZF9wcm8uYXZhaWxhYmxlKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHJ1bnRpbWVf aW9zXzgsIGRldmljZV9pcGFkX3Byby5ydW50aW1lKQogCisgICAgICAgIGRldmljZV9pcGhvbmVf NyA9IHJ1bnRpbWVfaW9zXzguZGV2aWNlc1sxMF0KKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCgn aVBob25lIDcnLCBkZXZpY2VfaXBob25lXzcubmFtZSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVh bCgnMkFFNThCQkUtMDk5NS00MzI2LTlCNjUtMkY0MTNFMkUzM0RDJywgZGV2aWNlX2lwaG9uZV83 LnVkaWQpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoRmFsc2UsIGRldmljZV9pcGhvbmVfNy5h dmFpbGFibGUpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocnVudGltZV9pb3NfOCwgZGV2aWNl X2lwaG9uZV83LnJ1bnRpbWUpCisKICAgICAgICAgcnVudGltZV9pb3NfOF9pbnRlcm5hbCA9IHNp bXVsYXRvci5ydW50aW1lc1sxXQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKCdjb20uYXBwbGUu Q29yZVNpbXVsYXRvci5TaW1SdW50aW1lLmlPUy04LTAtSW50ZXJuYWwnLCBydW50aW1lX2lvc184 X2ludGVybmFsLmlkZW50aWZpZXIpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoRmFsc2UsIHJ1 bnRpbWVfaW9zXzhfaW50ZXJuYWwuYXZhaWxhYmxlKQo=