169746 2017-03-16 04:26:31 -0700 [Cairo] Handle the blend mode in GraphicsContext::drawPattern 2017-03-17 01:23:10 -0700 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED Cairo, Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply zan oldest_to_newest 1288517 0 cgarcia 2017-03-16 04:26:31 -0700 We are not taking into account the blend mode when passing the cairo operator to drawPatternToCairoContext(). 1288520 1 304632 cgarcia 2017-03-16 04:32:23 -0700 Created attachment 304632 Patch 1288541 2 304632 zan 2017-03-16 07:00:29 -0700 Comment on attachment 304632 Patch r=me 1288962 3 cgarcia 2017-03-17 01:23:10 -0700 Committed r214100: <http://trac.webkit.org/changeset/214100> 304632 2017-03-16 04:32:23 -0700 2017-03-16 07:00:29 -0700 Patch wk-blend-mode.diff text/plain 4923 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZmQ3MjM0OGRmNS4uMGNjMDNkZTNmZTAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNy0wMy0xNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0NhaXJvXSBIYW5kbGUgdGhlIGJsZW5kIG1vZGUgaW4gR3Jh cGhpY3NDb250ZXh0OjpkcmF3UGF0dGVybgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY5NzQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2UgYXJlIG5vdCB0YWtpbmcgaW50byBhY2NvdW50IHRoZSBibGVu ZCBtb2RlIHdoZW4gcGFzc2luZyB0aGUgY2Fpcm8gb3BlcmF0b3IgdG8gZHJhd1BhdHRlcm5Ub0Nh aXJvQ29udGV4dCgpLgorICAgICAgICBUaGlzIGlzIGJhc2VkIG9uIHBhdGNoIGJ5IMW9YW4gRG9i ZXLFoWVrLCBqdXN0IGFkZGluZyB0aGUgdG9DYWlyb09wZXJhdG9yIGNoYW5nZXMgdG8gbWFrZSBp dCBlYXNpZXIgdG8gaGFuZGxlCisgICAgICAgIGl0LiBJbnN0ZWFkIG9mIGNoZWNraW5nIGV2ZXJ5 d2hlcmUgaWYgYmxlbmQgbW9kZSBpcyBOb3JtYWwgdG8gZGVjaWRlIHdoZXRoZXIgdG8gdXNlIHRv Q2Fpcm9PcGVyYXRvciB3aXRoCisgICAgICAgIENvbXBvc2l0ZU9wZXJhdG9yIG9yIEJsZW5kTW9k ZSwgdGhlcmUncyBubyBhIHNpbmdsZSB0b0NhaXJvT3BlcmF0b3IgdGhhdCByZWNlaXZlcyBib3Ro IHBhcmFtZXRlcnMsIGJ1dCBCbGVuZE1vZGUKKyAgICAgICAgaXMgb3B0aW9uYWwgYW5kIGRlZmF1 bHRzIHRvIE5vcm1hbC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJv VXRpbGl0aWVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRvQ2Fpcm9Db21wb3NpdGVPcGVyYXRv cik6CisgICAgICAgIChXZWJDb3JlOjp0b0NhaXJvT3BlcmF0b3IpOgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJvVXRpbGl0aWVzLmg6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6R3JhcGhpY3NDb250ZXh0OjpzZXRQbGF0Zm9ybUNvbXBvc2l0ZU9wZXJhdGlvbik6CisgICAg ICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmRyYXdQYXR0ZXJuKToKKwogMjAxNy0wMy0x NSAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgRmxhdHRlbiBSVEMgZW51 bSBuYW1pbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nh aXJvL0NhaXJvVXRpbGl0aWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0NhaXJvVXRpbGl0aWVzLmNwcAppbmRleCAxZmQ1MWQ3NmU3Ny4uNTgyMDc1NTliNGYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJv VXRpbGl0aWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWly by9DYWlyb1V0aWxpdGllcy5jcHAKQEAgLTEwOCw3ICsxMDgsNyBAQCB2b2lkIGFwcGVuZFJlZ2lv blRvQ2Fpcm9Db250ZXh0KGNhaXJvX3QqIHRvLCBjb25zdCBjYWlyb19yZWdpb25fdCogcmVnaW9u KQogICAgIH0KIH0KIAotY2Fpcm9fb3BlcmF0b3JfdCB0b0NhaXJvT3BlcmF0b3IoQ29tcG9zaXRl T3BlcmF0b3Igb3ApCitzdGF0aWMgY2Fpcm9fb3BlcmF0b3JfdCB0b0NhaXJvQ29tcG9zaXRlT3Bl cmF0b3IoQ29tcG9zaXRlT3BlcmF0b3Igb3ApCiB7CiAgICAgc3dpdGNoIChvcCkgewogICAgIGNh c2UgQ29tcG9zaXRlQ2xlYXI6CkBAIC0xNDMsMTEgKzE0MywxMiBAQCBjYWlyb19vcGVyYXRvcl90 IHRvQ2Fpcm9PcGVyYXRvcihDb21wb3NpdGVPcGVyYXRvciBvcCkKICAgICAgICAgcmV0dXJuIENB SVJPX09QRVJBVE9SX1NPVVJDRTsKICAgICB9CiB9Ci1jYWlyb19vcGVyYXRvcl90IHRvQ2Fpcm9P cGVyYXRvcihCbGVuZE1vZGUgYmxlbmRPcCkKKworY2Fpcm9fb3BlcmF0b3JfdCB0b0NhaXJvT3Bl cmF0b3IoQ29tcG9zaXRlT3BlcmF0b3Igb3AsIEJsZW5kTW9kZSBibGVuZE9wKQogewogICAgIHN3 aXRjaCAoYmxlbmRPcCkgewogICAgIGNhc2UgQmxlbmRNb2RlTm9ybWFsOgotICAgICAgICByZXR1 cm4gQ0FJUk9fT1BFUkFUT1JfT1ZFUjsKKyAgICAgICAgcmV0dXJuIHRvQ2Fpcm9Db21wb3NpdGVP cGVyYXRvcihvcCk7CiAgICAgY2FzZSBCbGVuZE1vZGVNdWx0aXBseToKICAgICAgICAgcmV0dXJu IENBSVJPX09QRVJBVE9SX01VTFRJUExZOwogICAgIGNhc2UgQmxlbmRNb2RlU2NyZWVuOgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQ2Fpcm9VdGls aXRpZXMuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJvVXRp bGl0aWVzLmgKaW5kZXggNDg2MjkxZDMxMDcuLjE1ZjZlODExNTYxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9DYWlyb1V0aWxpdGllcy5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJvVXRpbGl0aWVzLmgK QEAgLTc5LDggKzc5LDcgQEAgdm9pZCBhcHBlbmRQYXRoVG9DYWlyb0NvbnRleHQoY2Fpcm9fdCog dG8sIGNhaXJvX3QqIGZyb20pOwogdm9pZCBzZXRQYXRoT25DYWlyb0NvbnRleHQoY2Fpcm9fdCog dG8sIGNhaXJvX3QqIGZyb20pOwogdm9pZCBhcHBlbmRXZWJDb3JlUGF0aFRvQ2Fpcm9Db250ZXh0 KGNhaXJvX3QqIGNvbnRleHQsIGNvbnN0IFBhdGgmIHBhdGgpOwogdm9pZCBhcHBlbmRSZWdpb25U b0NhaXJvQ29udGV4dChjYWlyb190KiwgY29uc3QgY2Fpcm9fcmVnaW9uX3QqKTsKLWNhaXJvX29w ZXJhdG9yX3QgdG9DYWlyb09wZXJhdG9yKENvbXBvc2l0ZU9wZXJhdG9yIG9wKTsKLWNhaXJvX29w ZXJhdG9yX3QgdG9DYWlyb09wZXJhdG9yKEJsZW5kTW9kZSBibGVuZE9wKTsKK2NhaXJvX29wZXJh dG9yX3QgdG9DYWlyb09wZXJhdG9yKENvbXBvc2l0ZU9wZXJhdG9yLCBCbGVuZE1vZGUgPSBCbGVu ZE1vZGVOb3JtYWwpOwogdm9pZCBkcmF3UGF0dGVyblRvQ2Fpcm9Db250ZXh0KGNhaXJvX3QqIGNy LCBjYWlyb19zdXJmYWNlX3QqIGltYWdlLCBjb25zdCBJbnRTaXplJiBpbWFnZVNpemUsIGNvbnN0 IEZsb2F0UmVjdCYgdGlsZVJlY3QsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29u c3QgQWZmaW5lVHJhbnNmb3JtJiBwYXR0ZXJuVHJhbnNmb3JtLCBjb25zdCBGbG9hdFBvaW50JiBw aGFzZSwgY2Fpcm9fb3BlcmF0b3JfdCBvcCwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCk7CiBS ZWZQdHI8Y2Fpcm9fc3VyZmFjZV90PiBjb3B5Q2Fpcm9JbWFnZVN1cmZhY2UoY2Fpcm9fc3VyZmFj ZV90Kik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWly by9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKaW5kZXggYTE2YWNiZGZjOWIuLmFj NGI0YTA4OTljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCkBAIC0xMDM2LDEzICsx MDM2LDcgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OnNldFBsYXRmb3JtQ29tcG9zaXRlT3BlcmF0 aW9uKENvbXBvc2l0ZU9wZXJhdG9yIG9wLCBCbGVuZE0KICAgICBpZiAocGFpbnRpbmdEaXNhYmxl ZCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBjYWlyb19vcGVyYXRvcl90IGNhaXJvX29wOwot ICAgIGlmIChibGVuZE9wID09IEJsZW5kTW9kZU5vcm1hbCkKLSAgICAgICAgY2Fpcm9fb3AgPSB0 b0NhaXJvT3BlcmF0b3Iob3ApOwotICAgIGVsc2UKLSAgICAgICAgY2Fpcm9fb3AgPSB0b0NhaXJv T3BlcmF0b3IoYmxlbmRPcCk7Ci0KLSAgICBjYWlyb19zZXRfb3BlcmF0b3IocGxhdGZvcm1Db250 ZXh0KCktPmNyKCksIGNhaXJvX29wKTsKKyAgICBjYWlyb19zZXRfb3BlcmF0b3IocGxhdGZvcm1D b250ZXh0KCktPmNyKCksIHRvQ2Fpcm9PcGVyYXRvcihvcCwgYmxlbmRPcCkpOwogfQogCiB2b2lk IEdyYXBoaWNzQ29udGV4dDo6Y2FudmFzQ2xpcChjb25zdCBQYXRoJiBwYXRoLCBXaW5kUnVsZSB3 aW5kUnVsZSkKQEAgLTExODMsNyArMTE3Nyw3IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3 UGF0dGVybihJbWFnZSYgaW1hZ2UsIGNvbnN0IEZsb2F0UmVjdCYgZGVzdFJlY3QsIGNvbnN0CiAg ICAgICAgIHJldHVybjsKIAogICAgIGNhaXJvX3QqIGNyID0gcGxhdGZvcm1Db250ZXh0KCktPmNy KCk7Ci0gICAgZHJhd1BhdHRlcm5Ub0NhaXJvQ29udGV4dChjciwgc3VyZmFjZS5nZXQoKSwgSW50 U2l6ZShpbWFnZS5zaXplKCkpLCB0aWxlUmVjdCwgcGF0dGVyblRyYW5zZm9ybSwgcGhhc2UsIHRv Q2Fpcm9PcGVyYXRvcihvcCksIGRlc3RSZWN0KTsKKyAgICBkcmF3UGF0dGVyblRvQ2Fpcm9Db250 ZXh0KGNyLCBzdXJmYWNlLmdldCgpLCBJbnRTaXplKGltYWdlLnNpemUoKSksIHRpbGVSZWN0LCBw YXR0ZXJuVHJhbnNmb3JtLCBwaGFzZSwgdG9DYWlyb09wZXJhdG9yKG9wLCBibGVuZE1vZGUpLCBk ZXN0UmVjdCk7CiB9CiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpzZXRQbGF0Zm9ybVNob3VsZEFu dGlhbGlhcyhib29sIGVuYWJsZSkK