169739 2017-03-16 02:05:16 -0700 [css-grid] Crash on debug removing a positioned child 2017-03-16 08:20:41 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.chromium.org/p/chromium/issues/detail?id=700383 BlinkMergeCandidate P2 Normal --- 60731 1 rego rego bfulgham commit-queue hodovan jfernandez simon.fraser svillar zalan oldest_to_newest 1288494 0 304619 rego 2017-03-16 02:05:16 -0700 Created attachment 304619 Example to reproduce the issue The problem is that when we remove a positioned child, the grid is not relayout but we're marking it as dirty. So when it's repainted we got a crash. The crash is: ASSERTION FAILED: !m_grid.needsItemsPlacement() /home/rego/checkout/WebKit/Source/WebCore/rendering/RenderGrid.cpp(1643) : virtual void WebCore::RenderGrid::paintChildren(WebCore::PaintInfo&, const WebCore::LayoutPoint&, WebCore::PaintInfo&, bool) This has been already fixed in Blink: https://codereview.chromium.org/2748983003/ 1288500 1 304623 rego 2017-03-16 02:31:39 -0700 Created attachment 304623 Patch 1288529 2 304623 svillar 2017-03-16 05:26:36 -0700 Comment on attachment 304623 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304623&action=review Nice! > LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html:11 > + after removing the positioned item. --> Nit: don't need to split this comment in 3 lines 1288530 3 304635 rego 2017-03-16 05:30:27 -0700 Created attachment 304635 Patch for landing 1288534 4 304635 commit-queue 2017-03-16 06:13:05 -0700 Comment on attachment 304635 Patch for landing Clearing flags on attachment: 304635 Committed r214039: <http://trac.webkit.org/changeset/214039> 1288535 5 commit-queue 2017-03-16 06:13:12 -0700 All reviewed patches have been landed. Closing bug. 1288549 6 rego 2017-03-16 08:20:41 -0700 *** Bug 169749 has been marked as a duplicate of this bug. *** 304619 2017-03-16 02:05:16 -0700 2017-03-16 02:05:16 -0700 Example to reproduce the issue grid-crash-remove-positioned-item.html text/html 683 rego PCFET0NUWVBFIGh0bWw+CjxzY3JpcHQ+CiAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQogICAgdGVz dFJ1bm5lci5kdW1wQXNUZXh0KCk7Cjwvc2NyaXB0Pgo8cD5jcmJ1Zy5jb20vNzAwMzgzIC0gW2Nz cy1ncmlkXSBHcmlkIGxheW91dHMgZ28gbW9zdGx5IGJsYW5rPC9wPgo8cD5UaGlzIHRlc3QgaGFz IFBBU1NFRCBpZiBpdCBkb2VzIG5vdCBDUkFTSCBvbiBkZWJ1Zy48L3A+CjxkaXYgaWQ9ImdyaWQi IHN0eWxlPSJkaXNwbGF5OiBncmlkOyI+CiAgPCEtLSBUaGlzIGdyaWQgaXRlbSB3aXRoIHNvbWUg dGV4dCBpcyBuZWVkZWQsCiAgICAgICBvdGhlcndpc2UgTGF5b3V0R3JpZDo6cGFpbnRDaGlsZHJl bigpIHdvbid0IGJlIGNhbGxlZAogICAgICAgYWZ0ZXIgcmVtb3ZpbmcgdGhlIHBvc2l0aW9uZWQg aXRlbS4gLS0+CiAgPGRpdj5pdGVtPC9kaXY+CjwvZGl2Pgo8c2NyaXB0PgogIHZhciBhYnNwb3Np dGVtID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgYWJzcG9zaXRlbS5zdHlsZS5w b3NpdGlvbiA9ICJhYnNvbHV0ZSI7CiAgdmFyIGdyaWQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgiZ3JpZCIpOwogIGdyaWQuYXBwZW5kQ2hpbGQoYWJzcG9zaXRlbSk7CiAgZG9jdW1lbnQuYm9k eS5vZmZzZXRMZWZ0OwogIGdyaWQucmVtb3ZlQ2hpbGQoYWJzcG9zaXRlbSk7Cjwvc2NyaXB0Pgo= 304623 2017-03-16 02:31:39 -0700 2017-03-16 05:30:20 -0700 Patch bug-169739-20170316103137.patch text/plain 5150 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZkNzIzNDhkZjUyNWU0 OWUyYTgwZjQyNzhmMzFlY2E1ZjUwNTg2My4uOTc0NmVlYzNmYzYyM2QxMTJhODQxN2NkZGM1YTk1 MTZlNTE5MjZiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE3LTAzLTE2ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gQ3Jhc2ggb24gZGVidWcgcmVtb3ZpbmcgYSBwb3NpdGlvbmVkIGNoaWxkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk3MzkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlIGFkZCBvciByZW1v dmUgYSBwb3NpdGlvbmVkIGl0ZW0gd2UgZG9uJ3QgbmVlZCB0byBtYXJrCisgICAgICAgIHRoZSBn cmlkIGFzIGRpcnR5LCBiZWNhdXNlIHBvc2l0aW9uZWQgaXRlbXMgZG8gbm90IGFmZmVjdCB0aGUg bGF5b3V0CisgICAgICAgIG9mIHRoZSBncmlkIGF0IGFsbC4KKworICAgICAgICBUaGlzIHdhcyBj YXVzaW5nIGEgY3Jhc2ggd2hlbiBhIHBvc2l0aW9uZWQgaXRlbSB3YXMgcmVtb3ZlZAorICAgICAg ICBhZnRlciBhIGxheW91dC4gQXMgYWZ0ZXIgdGhlIHBvc2l0aW9uZWQgaXRlbSB3YXMgcmVtb3Zl ZCwKKyAgICAgICAgdGhlIG1ldGhvZCBSZW5kZXJHcmlkOjpsYXlvdXRCbG9jaygpIHdhcyBub3Qg Y2FsbGVkLAorICAgICAgICBzbyB3aGVuIHRoZSBncmlkIHdhcyByZXBhaW50ZWQgd2UgZ290IGEg Y3Jhc2guCisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC1jcmFzaC1y ZW1vdmUtcG9zaXRpb25lZC1pdGVtLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJH cmlkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckdyaWQ6OmFkZENoaWxkKTogQWRkIGVh cmx5IHJldHVybiB0byBhdm9pZCBtYXJraW5nCisgICAgICAgIHRoZSBncmlkIGFzIGRpcnR5IGZv ciBwb3NpdGlvbmVkIGdyaWQgaXRlbXMuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJHcmlkOjpy ZW1vdmVDaGlsZCk6IERpdHRvLgorCiAyMDE3LTAzLTE1ICBKb24gTGVlICA8am9ubGVlQGFwcGxl LmNvbT4KIAogICAgICAgICBGbGF0dGVuIFJUQyBlbnVtIG5hbWluZwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckdyaWQuY3BwCmluZGV4IGQ5MDk0NmQ5MWViZjE1N2IzOTkzMjk4Yzc0NWM5 M2NkNWQxMjRmMGEuLmQ0YzFlNGUwZjFlYjI1MTA5MzE1MDIyMzIxYmNhOGQxYTNhNzE1NzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKQEAgLTY5LDYgKzY5LDEyIEBA IHZvaWQgUmVuZGVyR3JpZDo6YWRkQ2hpbGQoUmVuZGVyT2JqZWN0KiBuZXdDaGlsZCwgUmVuZGVy T2JqZWN0KiBiZWZvcmVDaGlsZCkKIHsKICAgICBSZW5kZXJCbG9jazo6YWRkQ2hpbGQobmV3Q2hp bGQsIGJlZm9yZUNoaWxkKTsKIAorICAgIC8vIFBvc2l0aW9uZWQgZ3JpZCBpdGVtcyBkbyBub3Qg dGFrZSB1cCBzcGFjZSBvciBvdGhlcndpc2UgcGFydGljaXBhdGUgaW4gdGhlCisgICAgLy8gbGF5 b3V0IG9mIHRoZSBncmlkLCBmb3IgdGhhdCByZWFzb24gd2UgZG9uJ3QgbmVlZCB0byBtYXJrIHRo ZSBncmlkIGFzIGRpcnR5CisgICAgLy8gd2hlbiB0aGV5IGFyZSBhZGRlZC4KKyAgICBpZiAobmV3 Q2hpbGQtPmlzT3V0T2ZGbG93UG9zaXRpb25lZCgpKQorICAgICAgICByZXR1cm47CisKICAgICAv LyBUaGUgZ3JpZCBuZWVkcyB0byBiZSByZWNvbXB1dGVkIGFzIGl0IG1pZ2h0IGNvbnRhaW4gYXV0 by1wbGFjZWQgaXRlbXMgdGhhdAogICAgIC8vIHdpbGwgY2hhbmdlIHRoZWlyIHBvc2l0aW9uLgog ICAgIGRpcnR5R3JpZCgpOwpAQCAtNzgsNiArODQsMTIgQEAgdm9pZCBSZW5kZXJHcmlkOjpyZW1v dmVDaGlsZChSZW5kZXJPYmplY3QmIGNoaWxkKQogewogICAgIFJlbmRlckJsb2NrOjpyZW1vdmVD aGlsZChjaGlsZCk7CiAKKyAgICAvLyBQb3NpdGlvbmVkIGdyaWQgaXRlbXMgZG8gbm90IHRha2Ug dXAgc3BhY2Ugb3Igb3RoZXJ3aXNlIHBhcnRpY2lwYXRlIGluIHRoZQorICAgIC8vIGxheW91dCBv ZiB0aGUgZ3JpZCwgZm9yIHRoYXQgcmVhc29uIHdlIGRvbid0IG5lZWQgdG8gbWFyayB0aGUgZ3Jp ZCBhcyBkaXJ0eQorICAgIC8vIHdoZW4gdGhleSBhcmUgcmVtb3ZlZC4KKyAgICBpZiAoY2hpbGQu aXNPdXRPZkZsb3dQb3NpdGlvbmVkKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIC8vIFRoZSBn cmlkIG5lZWRzIHRvIGJlIHJlY29tcHV0ZWQgYXMgaXQgbWlnaHQgY29udGFpbiBhdXRvLXBsYWNl ZCBpdGVtcyB0aGF0CiAgICAgLy8gd2lsbCBjaGFuZ2UgdGhlaXIgcG9zaXRpb24uCiAgICAgZGly dHlHcmlkKCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggOWRlN2FiNDgwZGUwYWVlY2Y1MTU1NTg4N2VjMGM0MjAxZmYwYjY4 Ny4uYjE0ZjFhOTI0OGNkMzg0ZjAzYTRmYTc0ZWVmNWRkNjFkNmEwOTVhNyAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDE3LTAzLTE2ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2Fs aWEuY29tPgorCisgICAgICAgIFtjc3MtZ3JpZF0gQ3Jhc2ggb24gZGVidWcgcmVtb3ZpbmcgYSBw b3NpdGlvbmVkIGNoaWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjk3MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgbmV3IHRlc3QgdGhhdCBjaGVja3MgdGhhdCBhZGRpbmcgYW5kIHJlbW92aW5n IGEgcG9zaXRpb25lZCBncmlkIGl0ZW0KKyAgICAgICAgZG9lc24ndCBjYXVzZSBhbnkgY3Jhc2hl cy4KKworICAgICAgICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtY3Jhc2gtcmVtb3ZlLXBv c2l0aW9uZWQtaXRlbS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzLWdy aWQtbGF5b3V0L2dyaWQtY3Jhc2gtcmVtb3ZlLXBvc2l0aW9uZWQtaXRlbS5odG1sOiBBZGRlZC4K KwogMjAxNy0wMy0xNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IERvIG5vdCByZXBhcmVudCBmbG9hdGluZyBvYmplY3QgdW50aWwgYWZ0ZXIgaW50cnVkaW5nL292 ZXJoYW5naW5nIGRlcGVuZGVuY3kgaXMgY2xlYXJlZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtY3Jhc2gtcmVtb3ZlLXBvc2l0aW9uZWQtaXRlbS1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNyYXNo LXJlbW92ZS1wb3NpdGlvbmVkLWl0ZW0tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk0OTE5ZTlj NDdkYTY2MzlmODRlMDEwMDdmYzUwZjJlNzkwOTIzYWQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNyYXNoLXJlbW92ZS1wb3NpdGlvbmVk LWl0ZW0tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAord2Via2l0Lm9yZy9iLzE2OTczOSAt IFtjc3MtZ3JpZF0gQ3Jhc2ggb24gZGVidWcgcmVtb3ZpbmcgYSBwb3NpdGlvbmVkIGNoaWxkCisK K1RoaXMgdGVzdCBoYXMgUEFTU0VEIGlmIGl0IGRvZXMgbm90IENSQVNIIG9uIGRlYnVnLgorCitp dGVtCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNy YXNoLXJlbW92ZS1wb3NpdGlvbmVkLWl0ZW0uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdy aWQtbGF5b3V0L2dyaWQtY3Jhc2gtcmVtb3ZlLXBvc2l0aW9uZWQtaXRlbS5odG1sCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjQ4OWU1MWY0ZDFkM2FmZDQ3Y2EwMWJmZWQ5Zjk4YzViYjUzMDU1ZTEKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNyYXNoLXJlbW92 ZS1wb3NpdGlvbmVkLWl0ZW0uaHRtbApAQCAtMCwwICsxLDIxIEBACis8IURPQ1RZUEUgaHRtbD4K KzxzY3JpcHQ+CisgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBB c1RleHQoKTsKKzwvc2NyaXB0PgorPHA+d2Via2l0Lm9yZy9iLzE2OTczOSAtIFtjc3MtZ3JpZF0g Q3Jhc2ggb24gZGVidWcgcmVtb3ZpbmcgYSBwb3NpdGlvbmVkIGNoaWxkPC9wPgorPHA+VGhpcyB0 ZXN0IGhhcyBQQVNTRUQgaWYgaXQgZG9lcyBub3QgQ1JBU0ggb24gZGVidWcuPC9wPgorPGRpdiBp ZD0iZ3JpZCIgc3R5bGU9ImRpc3BsYXk6IGdyaWQ7Ij4KKyAgPCEtLSBUaGlzIGdyaWQgaXRlbSB3 aXRoIHNvbWUgdGV4dCBpcyBuZWVkZWQsCisgICAgICAgb3RoZXJ3aXNlIFJlbmRlckdyaWQ6OnBh aW50Q2hpbGRyZW4oKSB3b24ndCBiZSBjYWxsZWQKKyAgICAgICBhZnRlciByZW1vdmluZyB0aGUg cG9zaXRpb25lZCBpdGVtLiAtLT4KKyAgPGRpdj5pdGVtPC9kaXY+Cis8L2Rpdj4KKzxzY3JpcHQ+ CisgIHZhciBhYnNwb3NpdGVtID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgIGFi c3Bvc2l0ZW0uc3R5bGUucG9zaXRpb24gPSAiYWJzb2x1dGUiOworICB2YXIgZ3JpZCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJncmlkIik7CisgIGdyaWQuYXBwZW5kQ2hpbGQoYWJzcG9zaXRl bSk7CisgIGRvY3VtZW50LmJvZHkub2Zmc2V0TGVmdDsKKyAgZ3JpZC5yZW1vdmVDaGlsZChhYnNw b3NpdGVtKTsKKzwvc2NyaXB0Pgo= 304635 2017-03-16 05:30:27 -0700 2017-03-16 06:13:05 -0700 Patch for landing bug-169739-20170316133025.patch text/plain 5136 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZkNzIzNDhkZjUyNWU0 OWUyYTgwZjQyNzhmMzFlY2E1ZjUwNTg2My4uNzY1YzVmNzRiYzhkNjMxMjZhMzBhN2JkODUxZmZm M2U2MWNkMTljNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE3LTAzLTE2ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gQ3Jhc2ggb24gZGVidWcgcmVtb3ZpbmcgYSBwb3NpdGlvbmVkIGNoaWxkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk3MzkKKworICAgICAgICBS ZXZpZXdlZCBieSBTZXJnaW8gVmlsbGFyIFNlbmluLgorCisgICAgICAgIFdoZW4gd2UgYWRkIG9y IHJlbW92ZSBhIHBvc2l0aW9uZWQgaXRlbSB3ZSBkb24ndCBuZWVkIHRvIG1hcmsKKyAgICAgICAg dGhlIGdyaWQgYXMgZGlydHksIGJlY2F1c2UgcG9zaXRpb25lZCBpdGVtcyBkbyBub3QgYWZmZWN0 IHRoZSBsYXlvdXQKKyAgICAgICAgb2YgdGhlIGdyaWQgYXQgYWxsLgorCisgICAgICAgIFRoaXMg d2FzIGNhdXNpbmcgYSBjcmFzaCB3aGVuIGEgcG9zaXRpb25lZCBpdGVtIHdhcyByZW1vdmVkCisg ICAgICAgIGFmdGVyIGEgbGF5b3V0LiBBcyBhZnRlciB0aGUgcG9zaXRpb25lZCBpdGVtIHdhcyBy ZW1vdmVkLAorICAgICAgICB0aGUgbWV0aG9kIFJlbmRlckdyaWQ6OmxheW91dEJsb2NrKCkgd2Fz IG5vdCBjYWxsZWQsCisgICAgICAgIHNvIHdoZW4gdGhlIGdyaWQgd2FzIHJlcGFpbnRlZCB3ZSBn b3QgYSBjcmFzaC4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNy YXNoLXJlbW92ZS1wb3NpdGlvbmVkLWl0ZW0uaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckdyaWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyR3JpZDo6YWRkQ2hpbGQpOiBB ZGQgZWFybHkgcmV0dXJuIHRvIGF2b2lkIG1hcmtpbmcKKyAgICAgICAgdGhlIGdyaWQgYXMgZGly dHkgZm9yIHBvc2l0aW9uZWQgZ3JpZCBpdGVtcy4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckdy aWQ6OnJlbW92ZUNoaWxkKTogRGl0dG8uCisKIDIwMTctMDMtMTUgIEpvbiBMZWUgIDxqb25sZWVA YXBwbGUuY29tPgogCiAgICAgICAgIEZsYXR0ZW4gUlRDIGVudW0gbmFtaW5nCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKaW5kZXggZDkwOTQ2ZDkxZWJmMTU3YjM5OTMyOThj NzQ1YzkzY2Q1ZDEyNGYwYS4uNWFmMDY4YTAzNWIwZGYwOTA5ZTc1MzdlMTQ3ZWFkNDgwNWQ2NjRk MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcApAQCAtNjksNiArNjks MTEgQEAgdm9pZCBSZW5kZXJHcmlkOjphZGRDaGlsZChSZW5kZXJPYmplY3QqIG5ld0NoaWxkLCBS ZW5kZXJPYmplY3QqIGJlZm9yZUNoaWxkKQogewogICAgIFJlbmRlckJsb2NrOjphZGRDaGlsZChu ZXdDaGlsZCwgYmVmb3JlQ2hpbGQpOwogCisgICAgLy8gUG9zaXRpb25lZCBncmlkIGl0ZW1zIGRv IG5vdCB0YWtlIHVwIHNwYWNlIG9yIG90aGVyd2lzZSBwYXJ0aWNpcGF0ZSBpbiB0aGUgbGF5b3V0 IG9mIHRoZSBncmlkLAorICAgIC8vIGZvciB0aGF0IHJlYXNvbiB3ZSBkb24ndCBuZWVkIHRvIG1h cmsgdGhlIGdyaWQgYXMgZGlydHkgd2hlbiB0aGV5IGFyZSBhZGRlZC4KKyAgICBpZiAobmV3Q2hp bGQtPmlzT3V0T2ZGbG93UG9zaXRpb25lZCgpKQorICAgICAgICByZXR1cm47CisKICAgICAvLyBU aGUgZ3JpZCBuZWVkcyB0byBiZSByZWNvbXB1dGVkIGFzIGl0IG1pZ2h0IGNvbnRhaW4gYXV0by1w bGFjZWQgaXRlbXMgdGhhdAogICAgIC8vIHdpbGwgY2hhbmdlIHRoZWlyIHBvc2l0aW9uLgogICAg IGRpcnR5R3JpZCgpOwpAQCAtNzgsNiArODMsMTEgQEAgdm9pZCBSZW5kZXJHcmlkOjpyZW1vdmVD aGlsZChSZW5kZXJPYmplY3QmIGNoaWxkKQogewogICAgIFJlbmRlckJsb2NrOjpyZW1vdmVDaGls ZChjaGlsZCk7CiAKKyAgICAvLyBQb3NpdGlvbmVkIGdyaWQgaXRlbXMgZG8gbm90IHRha2UgdXAg c3BhY2Ugb3Igb3RoZXJ3aXNlIHBhcnRpY2lwYXRlIGluIHRoZSBsYXlvdXQgb2YgdGhlIGdyaWQs CisgICAgLy8gZm9yIHRoYXQgcmVhc29uIHdlIGRvbid0IG5lZWQgdG8gbWFyayB0aGUgZ3JpZCBh cyBkaXJ0eSB3aGVuIHRoZXkgYXJlIHJlbW92ZWQuCisgICAgaWYgKGNoaWxkLmlzT3V0T2ZGbG93 UG9zaXRpb25lZCgpKQorICAgICAgICByZXR1cm47CisKICAgICAvLyBUaGUgZ3JpZCBuZWVkcyB0 byBiZSByZWNvbXB1dGVkIGFzIGl0IG1pZ2h0IGNvbnRhaW4gYXV0by1wbGFjZWQgaXRlbXMgdGhh dAogICAgIC8vIHdpbGwgY2hhbmdlIHRoZWlyIHBvc2l0aW9uLgogICAgIGRpcnR5R3JpZCgpOwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IDlkZTdhYjQ4MGRlMGFlZWNmNTE1NTU4ODdlYzBjNDIwMWZmMGI2ODcuLjE1NjliNmQx ZDhkOTE3MmFiYjM0OTlkNjFjNTg1OWUxMWZhOTMxNWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAor MjAxNy0wMy0xNiAgTWFudWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdhbGlhLmNvbT4KKwor ICAgICAgICBbY3NzLWdyaWRdIENyYXNoIG9uIGRlYnVnIHJlbW92aW5nIGEgcG9zaXRpb25lZCBj aGlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5 NzM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2VyZ2lvIFZpbGxhciBTZW5pbi4KKworICAgICAg ICBBZGQgbmV3IHRlc3QgdGhhdCBjaGVja3MgdGhhdCBhZGRpbmcgYW5kIHJlbW92aW5nIGEgcG9z aXRpb25lZCBncmlkIGl0ZW0KKyAgICAgICAgZG9lc24ndCBjYXVzZSBhbnkgY3Jhc2hlcy4KKwor ICAgICAgICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtY3Jhc2gtcmVtb3ZlLXBvc2l0aW9u ZWQtaXRlbS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzLWdyaWQtbGF5 b3V0L2dyaWQtY3Jhc2gtcmVtb3ZlLXBvc2l0aW9uZWQtaXRlbS5odG1sOiBBZGRlZC4KKwogMjAx Ny0wMy0xNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIERvIG5v dCByZXBhcmVudCBmbG9hdGluZyBvYmplY3QgdW50aWwgYWZ0ZXIgaW50cnVkaW5nL292ZXJoYW5n aW5nIGRlcGVuZGVuY3kgaXMgY2xlYXJlZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv Y3NzLWdyaWQtbGF5b3V0L2dyaWQtY3Jhc2gtcmVtb3ZlLXBvc2l0aW9uZWQtaXRlbS1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNyYXNoLXJlbW92 ZS1wb3NpdGlvbmVkLWl0ZW0tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk0OTE5ZTljNDdkYTY2 MzlmODRlMDEwMDdmYzUwZjJlNzkwOTIzYWQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNyYXNoLXJlbW92ZS1wb3NpdGlvbmVkLWl0ZW0t ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAord2Via2l0Lm9yZy9iLzE2OTczOSAtIFtjc3Mt Z3JpZF0gQ3Jhc2ggb24gZGVidWcgcmVtb3ZpbmcgYSBwb3NpdGlvbmVkIGNoaWxkCisKK1RoaXMg dGVzdCBoYXMgUEFTU0VEIGlmIGl0IGRvZXMgbm90IENSQVNIIG9uIGRlYnVnLgorCitpdGVtCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNyYXNoLXJl bW92ZS1wb3NpdGlvbmVkLWl0ZW0uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5 b3V0L2dyaWQtY3Jhc2gtcmVtb3ZlLXBvc2l0aW9uZWQtaXRlbS5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc5 YzBmOTAzZTUxNTBkZGEzZGYxYzI2MDAzOGQ4ZmEwMjhhMjhkNTgKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNyYXNoLXJlbW92ZS1wb3Np dGlvbmVkLWl0ZW0uaHRtbApAQCAtMCwwICsxLDIwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxzY3Jp cHQ+CisgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQo KTsKKzwvc2NyaXB0PgorPHA+d2Via2l0Lm9yZy9iLzE2OTczOSAtIFtjc3MtZ3JpZF0gQ3Jhc2gg b24gZGVidWcgcmVtb3ZpbmcgYSBwb3NpdGlvbmVkIGNoaWxkPC9wPgorPHA+VGhpcyB0ZXN0IGhh cyBQQVNTRUQgaWYgaXQgZG9lcyBub3QgQ1JBU0ggb24gZGVidWcuPC9wPgorPGRpdiBpZD0iZ3Jp ZCIgc3R5bGU9ImRpc3BsYXk6IGdyaWQ7Ij4KKyAgPCEtLSBUaGlzIGdyaWQgaXRlbSB3aXRoIHNv bWUgdGV4dCBpcyBuZWVkZWQsIG90aGVyd2lzZSBSZW5kZXJHcmlkOjpwYWludENoaWxkcmVuKCkK KyAgICAgICB3b24ndCBiZSBjYWxsZWQgYWZ0ZXIgcmVtb3ZpbmcgdGhlIHBvc2l0aW9uZWQgaXRl bS4gLS0+CisgIDxkaXY+aXRlbTwvZGl2PgorPC9kaXY+Cis8c2NyaXB0PgorICB2YXIgYWJzcG9z aXRlbSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworICBhYnNwb3NpdGVtLnN0eWxl LnBvc2l0aW9uID0gImFic29sdXRlIjsKKyAgdmFyIGdyaWQgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgiZ3JpZCIpOworICBncmlkLmFwcGVuZENoaWxkKGFic3Bvc2l0ZW0pOworICBkb2N1bWVu dC5ib2R5Lm9mZnNldExlZnQ7CisgIGdyaWQucmVtb3ZlQ2hpbGQoYWJzcG9zaXRlbSk7Cis8L3Nj cmlwdD4K