169721 2017-03-15 17:05:00 -0700 [DFG] Don't use ArraySlice intrinsic on MIPS 2017-03-22 10:15:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Other Linux RESOLVED FIXED P2 Normal --- 1 guijemont webkit-unassigned annulen commit-queue guijemont jbriance keith_miller mark.lam msaboff saam ysuzuki oldest_to_newest 1288361 0 guijemont 2017-03-15 17:05:00 -0700 The ArraySlice intrinsic in DFG uses more registers than we have available on MIPS, so we have to do the same as for X86 and not use it. 1288363 1 304584 guijemont 2017-03-15 17:12:00 -0700 Created attachment 304584 Patch The patch. 1289901 2 304584 ysuzuki 2017-03-21 16:57:04 -0700 Comment on attachment 304584 Patch r=me 1290003 3 annulen 2017-03-22 00:41:35 -0700 I don't believe that MIPS, having 2x more GPRs than 32-bit ARM, cannot have ArraySlice 1290042 4 ysuzuki 2017-03-22 04:39:22 -0700 (In reply to Konstantin Tokarev from comment #3) > I don't believe that MIPS, having 2x more GPRs than 32-bit ARM, cannot have > ArraySlice I think we should disable it right now since MIPS' temporary registers listed in GPRInfo is less than ARM. If we would like to enable it, first, I think we should modify this part to increase temporary registers. 1290080 5 304584 commit-queue 2017-03-22 10:15:20 -0700 Comment on attachment 304584 Patch Clearing flags on attachment: 304584 Committed r214253: <http://trac.webkit.org/changeset/214253> 1290081 6 commit-queue 2017-03-22 10:15:23 -0700 All reviewed patches have been landed. Closing bug. 304584 2017-03-15 17:12:00 -0700 2017-03-22 10:15:20 -0700 Patch bug-169721-20170315191156.patch text/plain 2168 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw OWYwYmI5MjQ3NTgzY2Q1ODI4MWQ2MDRkMTMyNjUyNzY5NWMwYzQ3Li5hOGFmYWMwYTRhZTFhMzc1 YTZhODRmOGE3ZjZlYzg0YTRhNDc1OTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxNy0wMy0xNSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CiAKKyAgICAgICAgW0RGR10gRG9uJ3QgdXNlIEFycmF5U2xpY2UgaW50cmluc2ljIG9u IE1JUFMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 OTcyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExp a2Ugb24geDg2LCB3ZSBkb24ndCBoYXZlIGVub3VnaCByZWdpc3RlcnMgYXZhaWxhYmxlIGZvciB0 aGlzLgorCisgICAgICAgICogYXNzZW1ibGVyL0NQVS5oOgorICAgICAgICAoSlNDOjppc01JUFMp OiBBZGRlZC4KKyAgICAgICAgKiBkZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwOgorICAgICAgICAo SlNDOjpERkc6OkJ5dGVDb2RlUGFyc2VyOjpoYW5kbGVJbnRyaW5zaWNDYWxsKToKKyAgICAgICAg RG9uJ3QgdXNlIHRoZSBBcnJheVNsaWNlIGludHJpbnNpYyBvbiBNSVBTLgorCisyMDE3LTAzLTE1 ICBHdWlsbGF1bWUgRW1vbnQgIDxndWlqZW1vbnRAaWdhbGlhLmNvbT4KKwogICAgICAgICBbanNj XSBpbXBsZW1lbnQgTUlQU0Fzc2VtYmxlcjo6cmVsaW5rSnVtcFRvTm9wKCkKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTcyMAogCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0NQVS5oIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9DUFUuaAppbmRleCA4ZThjODJmOWI2M2JiMzBjNjU3OGI3YTY2Y2Fi MmVkNTA1NzFjMjZkLi5kNWNjOTIxYzUwNzhiYWMyZGE1ODdjYjIxMTAwNWFlMWZmYTM3NGZlIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0NQVS5oCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQ1BVLmgKQEAgLTY1LDYgKzY1LDE1IEBAIGlu bGluZSBib29sIGlzWDg2XzY0KCkKICNlbmRpZgogfQogCitpbmxpbmUgYm9vbCBpc01JUFMoKQor eworI2lmIENQVShNSVBTKQorICAgIHJldHVybiB0cnVlOworI2Vsc2UKKyAgICByZXR1cm4gZmFs c2U7CisjZW5kaWYKK30KKwogaW5saW5lIGJvb2wgb3B0aW1pemVGb3JBUk12N0lESVZTdXBwb3J0 ZWQoKQogewogICAgIHJldHVybiBpc0FSTXY3SURJVlN1cHBvcnRlZCgpICYmIE9wdGlvbnM6OnVz ZUFyY2hpdGVjdHVyZVNwZWNpZmljT3B0aW1pemF0aW9ucygpOwpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAppbmRleCAzYTQ1NGRkMzE0Y2U5OGZh OTM1Zjg3YWM1N2VjMWViYWIwN2I2NGVkLi4wN2VhODc2MGJlMmFiMDkyYzI0MTljMTgzNWRmMDI3 NmYwMzhlMWUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVD b2RlUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2Rl UGFyc2VyLmNwcApAQCAtMjI1MSw3ICsyMjUxLDcgQEAgYm9vbCBCeXRlQ29kZVBhcnNlcjo6aGFu ZGxlSW50cmluc2ljQ2FsbChOb2RlKiBjYWxsZWUsIGludCByZXN1bHRPcGVyYW5kLCBJbnRyaW4K IAogICAgIGNhc2UgQXJyYXlTbGljZUludHJpbnNpYzogewogI2lmIFVTRShKU1ZBTFVFMzJfNjQp Ci0gICAgICAgIGlmIChpc1g4NigpKSB7CisgICAgICAgIGlmIChpc1g4NigpIHx8IGlzTUlQUygp KSB7CiAgICAgICAgICAgICAvLyBUaGVyZSBhcmVuJ3QgZW5vdWdoIHJlZ2lzdGVycyBmb3IgdGhp cyB0byBiZSBkb25lIGVhc2lseS4KICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAg fQo=