<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>169717</bug_id>
          
          <creation_ts>2017-03-15 16:30:37 -0700</creation_ts>
          <short_desc>[jsc] MacroAssemblerMIPS: implement the branchPtr(RelationalCondition, BaseIndex, RegisterID) overload.</short_desc>
          <delta_ts>2017-03-21 01:35:02 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>Other</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Guillaume Emont">guijemont</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>annulen</cc>
    
    <cc>commit-queue</cc>
    
    <cc>guijemont</cc>
    
    <cc>jbriance</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1288342</commentid>
    <comment_count>0</comment_count>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2017-03-15 16:30:37 -0700</bug_when>
    <thetext>One of the few things missing for MIPS to work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1288344</commentid>
    <comment_count>1</comment_count>
      <attachid>304577</attachid>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2017-03-15 16:33:34 -0700</bug_when>
    <thetext>Created attachment 304577
Patch

Patch by Žan Doberšek.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1288350</commentid>
    <comment_count>2</comment_count>
      <attachid>304579</attachid>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2017-03-15 16:42:24 -0700</bug_when>
    <thetext>Created attachment 304579
Patch

More complete version that also exposes branchPtr on MIPS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1289726</commentid>
    <comment_count>3</comment_count>
      <attachid>304579</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-03-21 01:04:43 -0700</bug_when>
    <thetext>Comment on attachment 304579
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1289731</commentid>
    <comment_count>4</comment_count>
      <attachid>304579</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-21 01:34:54 -0700</bug_when>
    <thetext>Comment on attachment 304579
Patch

Clearing flags on attachment: 304579

Committed r214213: &lt;http://trac.webkit.org/changeset/214213&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1289732</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-21 01:35:02 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>304577</attachid>
            <date>2017-03-15 16:33:34 -0700</date>
            <delta_ts>2017-03-15 16:42:18 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-169717-20170315183332.patch</filename>
            <type>text/plain</type>
            <size>1566</size>
            <attacher name="Guillaume Emont">guijemont</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzOTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl
MGU0ZGQxZDMxZjFiZDcyOWE3YzY0YzdkY2UxYWZjMjk5ODlkMjc5Li5jODlhNzg0ZTIxMjNkZjU2
Mjk5M2MyNmJlZjU2NmRlMzEyY2EwZTk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
NSArMSwxNSBAQAogMjAxNy0wMy0xNSAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5j
b20+CiAKKyAgICAgICAgW2pzY10gTWFjcm9Bc3NlbWJsZXJNSVBTOiBpbXBsZW1lbnQgdGhlIGJy
YW5jaFB0cihSZWxhdGlvbmFsQ29uZGl0aW9uLCBCYXNlSW5kZXgsIFJlZ2lzdGVySUQpIG92ZXJs
b2FkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5
NzE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBh
c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1i
bGVyTUlQUzo6YnJhbmNoUHRyKTogQWRkZWQuCisKKzIwMTctMDMtMTUgIFphbiBEb2JlcnNlayAg
PHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFtqc2NdIEFkZCBwYXRjaGFibGVKdW1w
U2l6ZSgpIGZvciBNSVBTCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xNjk3MTYKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt
Ymxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs
ZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKaW5kZXggOTkwNGVhMzc4MGEyMWFiOGUyMDhiNjZjNTRh
NDcwYzkzYzI1MWY5Yy4uNzYyMWI0ZWZmMDZiODNjNjJkZjcxNTFjOGIxYzZiZDIzZTY0MWM0ZiAx
MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxl
ck1JUFMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1i
bGVyTUlQUy5oCkBAIC0xNTUzLDYgKzE1NTMsMTIgQEAgcHVibGljOgogICAgICAgICByZXR1cm4g
YnJhbmNoMzIoY29uZCwgZGF0YVRlbXBSZWdpc3RlciwgaW1tVGVtcFJlZ2lzdGVyKTsKICAgICB9
CiAKKyAgICBKdW1wIGJyYW5jaFB0cihSZWxhdGlvbmFsQ29uZGl0aW9uIGNvbmQsIEJhc2VJbmRl
eCBsZWZ0LCBSZWdpc3RlcklEIHJpZ2h0KQorICAgIHsKKyAgICAgICAgbG9hZDMyKGxlZnQsIGRh
dGFUZW1wUmVnaXN0ZXIpOworICAgICAgICByZXR1cm4gYnJhbmNoMzIoY29uZCwgZGF0YVRlbXBS
ZWdpc3RlciwgcmlnaHQpOworICAgIH0KKwogICAgIEp1bXAgYnJhbmNoMzIoUmVsYXRpb25hbENv
bmRpdGlvbiBjb25kLCBSZWdpc3RlcklEIGxlZnQsIFJlZ2lzdGVySUQgcmlnaHQpCiAgICAgewog
ICAgICAgICBpZiAoY29uZCA9PSBFcXVhbCkK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>304579</attachid>
            <date>2017-03-15 16:42:24 -0700</date>
            <delta_ts>2017-03-21 01:34:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-169717-20170315184223.patch</filename>
            <type>text/plain</type>
            <size>2369</size>
            <attacher name="Guillaume Emont">guijemont</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzOTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl
MGU0ZGQxZDMxZjFiZDcyOWE3YzY0YzdkY2UxYWZjMjk5ODlkMjc5Li5hZjEwYTcwMWEzNjQwYzQy
MjI3YjBkZThmMjZkOWNmMjFlZDgwMDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
NSArMSwxNiBAQAogMjAxNy0wMy0xNSAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5j
b20+CiAKKyAgICAgICAgW2pzY10gTWFjcm9Bc3NlbWJsZXJNSVBTOiBpbXBsZW1lbnQgdGhlIGJy
YW5jaFB0cihSZWxhdGlvbmFsQ29uZGl0aW9uLCBCYXNlSW5kZXgsIFJlZ2lzdGVySUQpIG92ZXJs
b2FkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5
NzE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBh
c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXIuaDogRXhwb3NlIGJyYW5jaFB0cigpIG9uIE1JUFMgYXMg
d2VsbC4KKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6CisgICAgICAg
IChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6YnJhbmNoUHRyKTogQWRkZWQuCisKKzIwMTctMDMt
MTUgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFtqc2Nd
IEFkZCBwYXRjaGFibGVKdW1wU2l6ZSgpIGZvciBNSVBTCiAgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk3MTYKIApkaWZmIC0tZ2l0IGEvU291cmNlL0ph
dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oIGIvU291cmNlL0phdmFTY3Jp
cHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCmluZGV4IGRkZmM5MjgyOTM1MTM4Zjcw
OTAxYmFmNWI3NTQxZDkxYmFmMjY5ZWUuLjkyN2ViNDNlNWI2NWRiNzZhNDFhMWE1NTY3MGE2YzZj
MzdlZTQ5YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFj
cm9Bc3NlbWJsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv
QXNzZW1ibGVyLmgKQEAgLTExNiw3ICsxMTYsNyBAQCBwdWJsaWM6CiAgICAgdXNpbmcgTWFjcm9B
c3NlbWJsZXJCYXNlOjphbmQzMjsKICAgICB1c2luZyBNYWNyb0Fzc2VtYmxlckJhc2U6OmJyYW5j
aEFkZDMyOwogICAgIHVzaW5nIE1hY3JvQXNzZW1ibGVyQmFzZTo6YnJhbmNoTXVsMzI7Ci0jaWYg
Q1BVKEFSTTY0KSB8fCBDUFUoQVJNX1RIVU1CMikgfHwgQ1BVKEFSTV9UUkFESVRJT05BTCkgfHwg
Q1BVKFg4Nl82NCkKKyNpZiBDUFUoQVJNNjQpIHx8IENQVShBUk1fVEhVTUIyKSB8fCBDUFUoQVJN
X1RSQURJVElPTkFMKSB8fCBDUFUoWDg2XzY0KSB8fCBDUFUoTUlQUykKICAgICB1c2luZyBNYWNy
b0Fzc2VtYmxlckJhc2U6OmJyYW5jaFB0cjsKICNlbmRpZgogICAgIHVzaW5nIE1hY3JvQXNzZW1i
bGVyQmFzZTo6YnJhbmNoU3ViMzI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz
c2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAppbmRleCA5OTA0ZWEzNzgwYTIxYWI4ZTIwOGI2
NmM1NGE0NzBjOTNjMjUxZjljLi43NjIxYjRlZmYwNmI4M2M2MmRmNzE1MWM4YjFjNmJkMjNlNjQx
YzRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz
ZW1ibGVyTUlQUy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B
c3NlbWJsZXJNSVBTLmgKQEAgLTE1NTMsNiArMTU1MywxMiBAQCBwdWJsaWM6CiAgICAgICAgIHJl
dHVybiBicmFuY2gzMihjb25kLCBkYXRhVGVtcFJlZ2lzdGVyLCBpbW1UZW1wUmVnaXN0ZXIpOwog
ICAgIH0KIAorICAgIEp1bXAgYnJhbmNoUHRyKFJlbGF0aW9uYWxDb25kaXRpb24gY29uZCwgQmFz
ZUluZGV4IGxlZnQsIFJlZ2lzdGVySUQgcmlnaHQpCisgICAgeworICAgICAgICBsb2FkMzIobGVm
dCwgZGF0YVRlbXBSZWdpc3Rlcik7CisgICAgICAgIHJldHVybiBicmFuY2gzMihjb25kLCBkYXRh
VGVtcFJlZ2lzdGVyLCByaWdodCk7CisgICAgfQorCiAgICAgSnVtcCBicmFuY2gzMihSZWxhdGlv
bmFsQ29uZGl0aW9uIGNvbmQsIFJlZ2lzdGVySUQgbGVmdCwgUmVnaXN0ZXJJRCByaWdodCkKICAg
ICB7CiAgICAgICAgIGlmIChjb25kID09IEVxdWFsKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>