169676 2017-03-15 08:05:16 -0700 Fix uninitialized public members in WTF 2017-03-23 07:56:05 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104114 1 tpopela tpopela benjamin cdumez cmarcelo commit-queue darin dbates oldest_to_newest 1288054 0 tpopela 2017-03-15 08:05:16 -0700 Found by Coverity scan. 1288055 1 304500 tpopela 2017-03-15 08:07:57 -0700 Created attachment 304500 Patch 1288407 2 304500 ap 2017-03-15 19:28:31 -0700 Comment on attachment 304500 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304500&action=review > Source/WTF/ChangeLog:8 > + Found by Coverity scan. Does this fix any bugs? 1288492 3 tpopela 2017-03-16 01:51:48 -0700 (In reply to comment #2) > Comment on attachment 304500 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=304500&action=review > > > Source/WTF/ChangeLog:8 > > + Found by Coverity scan. > > Does this fix any bugs? No known bugs yet, but only initializes uninitialized members. 1290395 4 304500 tpopela 2017-03-23 02:10:43 -0700 Comment on attachment 304500 Patch Clearing flags on attachment: 304500 Committed r214299: <http://trac.webkit.org/changeset/214299> 1290396 5 tpopela 2017-03-23 02:10:51 -0700 All reviewed patches have been landed. Closing bug. 1290444 6 darin 2017-03-23 07:56:05 -0700 While I suppose this is OK, I am not sure why it’s important to initialize data members in code paths where they are never read from. 304500 2017-03-15 08:07:57 -0700 2017-03-23 02:10:43 -0700 Patch bug-169676-20170315160757.patch text/plain 3423 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzOTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDU4MmE2NzA4OGM4MmI3YjU3Y2UwNzc3 MGE5Y2Q1ZDVlM2FiNzFkMjIuLjU0NWM4ODhlNGE5NjEzNzBhN2UyYTU2NDczMmZlZjI2M2FhZGMx OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTctMDMtMTUgIFRvbWFzIFBvcGVsYSAgPHRwb3Bl bGFAcmVkaGF0LmNvbT4KKworICAgICAgICBGaXggdW5pbml0aWFsaXplZCBwdWJsaWMgbWVtYmVy cyBpbiBXVEYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2OTY3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZvdW5kIGJ5IENvdmVyaXR5IHNjYW4uCisKKyAgICAgICAgKiB3dGYvQmFnLmg6CisgICAgICAg ICogd3RmL0hhc2hUYWJsZS5oOgorICAgICAgICAqIHd0Zi9IYXNoVHJhaXRzLmg6CisgICAgICAg ICogd3RmL0luc2VydGlvbi5oOgorICAgICAgICAqIHd0Zi9PcmRlck1ha2VyLmg6CisgICAgICAg ICogd3RmL1BhcmFsbGVsSm9ic0dlbmVyaWMuaDoKKwogMjAxNy0wMy0xNSAgRGVhbiBKYWNrc29u ICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgU29ydCBYY29kZSBwcm9qZWN0IGZpbGVzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9CYWcuaCBiL1NvdXJjZS9XVEYvd3RmL0JhZy5oCmlu ZGV4IDAxZWNhNzQ3Mjc3YjgzMjc4NDU1YWZhYzE2ODY1Yzg3NDJiYTI0MGQuLjJkMDI2MjBiOGYz MTVjMWYxMmQ3ZDk0MzlkNmIwMmE0MzVkZDQwY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L0JhZy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0JhZy5oCkBAIC00Myw3ICs0Myw3IEBAIHByaXZh dGU6CiAgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIFQgbV9pdGVtOwotICAgICAgICBOb2Rl KiBtX25leHQ7CisgICAgICAgIE5vZGUqIG1fbmV4dCB7IG51bGxwdHIgfTsKICAgICB9OwogICAg IAogcHVibGljOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvSGFzaFRhYmxlLmggYi9Tb3Vy Y2UvV1RGL3d0Zi9IYXNoVGFibGUuaAppbmRleCBhNTc2ZTYyY2VjNDljMGNjOTcyYjhlNzczOGE5 Y2M5NGFkNWJiZTRhLi43ZjRmYTlmYjMwMWM4YzVhYTY0MDA2ZmQxMGI3ZjgxNjRiZDJhOWQ2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuaAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9IYXNoVGFibGUuaApAQCAtMjI1LDggKzIyNSw4IEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAg ICB2b2lkIGNoZWNrVmFsaWRpdHkoY29uc3QgY29uc3RfaXRlcmF0b3ImKSBjb25zdCB7IH0KICNl bmRpZgogCi0gICAgICAgIFBvaW50ZXJUeXBlIG1fcG9zaXRpb247Ci0gICAgICAgIFBvaW50ZXJU eXBlIG1fZW5kUG9zaXRpb247CisgICAgICAgIFBvaW50ZXJUeXBlIG1fcG9zaXRpb24geyBudWxs cHRyIH07CisgICAgICAgIFBvaW50ZXJUeXBlIG1fZW5kUG9zaXRpb24geyBudWxscHRyIH07CiAK ICNpZiBDSEVDS19IQVNIVEFCTEVfSVRFUkFUT1JTCiAgICAgcHVibGljOgpkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvSGFzaFRyYWl0cy5oIGIvU291cmNlL1dURi93dGYvSGFzaFRyYWl0cy5o CmluZGV4IDMyM2NlYTA3MjNhMjBhMTM1OWEzZDFkYzgwZTU2NTc0MjllOThmNzEuLmFhNTNlNzIx MjJhZjE3YzRjNTE3ZmZkYzhkNmYyNTEwNjk1NGM4ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL0hhc2hUcmFpdHMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9IYXNoVHJhaXRzLmgKQEAgLTMw Miw3ICszMDIsNyBAQCBzdHJ1Y3QgS2V5VmFsdWVQYWlyIHsKICAgICB9CiAKICAgICBLZXlUeXBl QXJnIGtleTsKLSAgICBWYWx1ZVR5cGVBcmcgdmFsdWU7CisgICAgVmFsdWVUeXBlQXJnIHZhbHVl IHsgfTsKIH07CiAKIHRlbXBsYXRlPHR5cGVuYW1lIEtleVRyYWl0c0FyZywgdHlwZW5hbWUgVmFs dWVUcmFpdHNBcmc+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9JbnNlcnRpb24uaCBiL1Nv dXJjZS9XVEYvd3RmL0luc2VydGlvbi5oCmluZGV4IDkwMWQ4YmIzMDcwZjNkZTYxODEzYzI0MTZh OTgwMzA1M2QzOGU5Y2MuLjhhMjg3YTBjMGQyMDY1YzJjYWFmZjVhZGY3Y2MyYTZlNjAwYzZkM2Mg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0luc2VydGlvbi5oCisrKyBiL1NvdXJjZS9XVEYv d3RmL0luc2VydGlvbi5oCkBAIC01MCw4ICs1MCw4IEBAIHB1YmxpYzoKICAgICB9CiAgICAgCiBw cml2YXRlOgotICAgIHNpemVfdCBtX2luZGV4OwotICAgIFQgbV9lbGVtZW50OworICAgIHNpemVf dCBtX2luZGV4IHsgMCB9OworICAgIFQgbV9lbGVtZW50IHsgfTsKIH07CiAKIHRlbXBsYXRlPHR5 cGVuYW1lIFRhcmdldFZlY3RvclR5cGUsIHR5cGVuYW1lIEluc2VydGlvblZlY3RvclR5cGU+CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9PcmRlck1ha2VyLmggYi9Tb3VyY2UvV1RGL3d0Zi9P cmRlck1ha2VyLmgKaW5kZXggMTJjOWRlMDVmYjFmYzAxMDNlMDczNzdjNjBjZTJmNjUwNDc0ZmFm Mi4uNzA4OTc3N2UzNTM3OGEzZjY0MzRhZmJkZWQ3ZmMxODc0OWUyNWQxNCAxMDA2NDQKLS0tIGEv U291cmNlL1dURi93dGYvT3JkZXJNYWtlci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL09yZGVyTWFr ZXIuaApAQCAtNTAsNyArNTAsNyBAQCBjbGFzcyBPcmRlck1ha2VyIHsKICAgICAgICAgewogICAg ICAgICB9CiAKLSAgICAgICAgVCBwYXlsb2FkOworICAgICAgICBUIHBheWxvYWQgeyB9OwogICAg IH07CiAgICAgCiBwdWJsaWM6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QYXJhbGxlbEpv YnNHZW5lcmljLmggYi9Tb3VyY2UvV1RGL3d0Zi9QYXJhbGxlbEpvYnNHZW5lcmljLmgKaW5kZXgg NTJmNDc5OWYxODZiMTQ0MmM4NTdkNTA2YjMyNDM1MjAxMjU4MzU3Yy4uNDU4NDA3YzRjYjRhM2Y5 OTVjOTBjNTU1NjI3YzFjYmQyMmI0MWI1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGFy YWxsZWxKb2JzR2VuZXJpYy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BhcmFsbGVsSm9ic0dlbmVy aWMuaApAQCAtODEsOCArODEsOCBAQCBwdWJsaWM6CiAgICAgICAgIG11dGFibGUgTG9jayBtX211 dGV4OwogICAgICAgICBDb25kaXRpb24gbV90aHJlYWRDb25kaXRpb247CiAKLSAgICAgICAgVGhy ZWFkRnVuY3Rpb24gbV90aHJlYWRGdW5jdGlvbjsKLSAgICAgICAgdm9pZCogbV9wYXJhbWV0ZXJz OworICAgICAgICBUaHJlYWRGdW5jdGlvbiBtX3RocmVhZEZ1bmN0aW9uIHsgbnVsbHB0ciB9Owor ICAgICAgICB2b2lkKiBtX3BhcmFtZXRlcnMgeyBudWxscHRyIH07CiAgICAgfTsKIAogcHJpdmF0 ZToK