169671 2017-03-15 03:01:14 -0700 [Modern Media Controls] Using the arrow keys to navigate in the tracks menu also scrolls the page 2017-03-15 11:51:59 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue webkit-bug-importer oldest_to_newest 1288034 0 graouts 2017-03-15 03:01:14 -0700 We should not be scrolling the page when navigating tracks in the tracks menu using the arrow up and down keys. 1288035 1 webkit-bug-importer 2017-03-15 03:01:32 -0700 <rdar://problem/31060091> 1288114 2 304513 graouts 2017-03-15 10:32:11 -0700 Created attachment 304513 Patch 1288116 3 304513 eric.carlson 2017-03-15 10:33:33 -0700 Comment on attachment 304513 Patch nice test! 1288162 4 304513 commit-queue 2017-03-15 11:51:53 -0700 Comment on attachment 304513 Patch Clearing flags on attachment: 304513 Committed r213996: <http://trac.webkit.org/changeset/213996> 1288163 5 commit-queue 2017-03-15 11:51:59 -0700 All reviewed patches have been landed. Closing bug. 304513 2017-03-15 10:32:11 -0700 2017-03-15 11:51:53 -0700 Patch bug-169671-20170315183210.patch text/plain 5407 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzOTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWM1ZjA5NGI4Y2Y4NzNh NDc5N2NmNzYwOWZmMTAxMzZkMDgzYmMzMC4uYmFkYzQ1MTZmZWJkOWY4YTc1OGJmNjhmZjBiOWQ3 YTEwNTY4ZTliNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAzLTE1ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW01vZGVybiBNZWRpYSBD b250cm9sc10gVXNpbmcgdGhlIGFycm93IGtleXMgdG8gbmF2aWdhdGUgaW4gdGhlIHRyYWNrcyBt ZW51IGFsc28gc2Nyb2xscyB0aGUgcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY5NjcxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMTA2MDA5 MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBu ZWVkIHRvIGNhbGwgcHJldmVudERlZmF1bHQoKSB3aGVuIGhhbmRsaW5nIGEgImtleWRvd24iIGV2 ZW50IHRoYXQgd2UgcmVjb2duaXplLgorCisgICAgICAgIFRlc3Q6IG1lZGlhL21vZGVybi1tZWRp YS1jb250cm9scy90cmFja3MtcGFuZWwvdHJhY2tzLXBhbmVsLXByZXZlbnQtZGVmYXVsdC1vbi1r ZXlkb3duLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2Nv bnRyb2xzL3RyYWNrcy1wYW5lbC5qczoKKyAgICAgICAgKFRyYWNrc1BhbmVsLnByb3RvdHlwZS5f aGFuZGxlS2V5ZG93bik6CisKIDIwMTctMDMtMTQgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxh cGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUgcmVkdW5kYW50IGNoZWNrIGZvciAi Zmlyc3RMaW5lIiBpbiBSZW5kZXJCbG9jazo6bGluZUhlaWdodCgpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy90cmFja3Mt cGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9j b250cm9scy90cmFja3MtcGFuZWwuanMKaW5kZXggOGE1N2I2NDk2NjZkMmE1NDFkNDdmYWYzMDAw MjdmYjk1OWE2NzA2NC4uMDk0MWQzNGMyM2IzNGVkNjVhMWJhNzkyODBkYTRhNmU0OWRkNmI1YyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMv Y29udHJvbHMvdHJhY2tzLXBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9k ZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL3RyYWNrcy1wYW5lbC5qcwpAQCAtMjI1LDcgKzIy NSwxMyBAQCBjbGFzcyBUcmFja3NQYW5lbCBleHRlbmRzIExheW91dE5vZGUKICAgICAgICAgY2Fz ZSAiRXNjYXBlIjoKICAgICAgICAgICAgIHRoaXMuX2Rpc21pc3MoKTsKICAgICAgICAgICAgIGJy ZWFrOworICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CisK KyAgICAgICAgLy8gRW5zdXJlIHRoYXQgd2UgZG9uJ3QgbGV0IHRoZSBicm93c2VyIHJlYWN0IHRv IGEga2V5IGNvZGUgd2UgaGFuZGxlZCwKKyAgICAgICAgLy8gZm9yIGluc3RhbmNlIHNjcm9sbGlu ZyB0aGUgcGFnZSBpZiB3ZSBoYW5kbGVkIGFuIGFycm93IGtleS4KKyAgICAgICAgZXZlbnQucHJl dmVudERlZmF1bHQoKTsKICAgICB9CiAKICAgICBfZGlzbWlzcygpCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTM3ZWFjNDg3 ZmIwMThjMDA2MmY4NzA3MTdhNGM1YjM0MDVhM2E2My4uZTViYjExOGNlOTcwZTBiNDI2ZDdmZjQw YzA2ODhkZTlkM2FkNzU1MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAzLTE1ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW01vZGVybiBNZWRpYSBD b250cm9sc10gVXNpbmcgdGhlIGFycm93IGtleXMgdG8gbmF2aWdhdGUgaW4gdGhlIHRyYWNrcyBt ZW51IGFsc28gc2Nyb2xscyB0aGUgcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY5NjcxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMTA2MDA5 MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg YSB0ZXN0IHRoYXQgY2hlY2tzIHRoYXQgcHJldmVudERlZmF1bHQoKSBpcyBjYWxsZWQgb24gImtl eWRvd24iIGV2ZW50cyB0aGF0IHdlIGtub3cgdG8gaGFuZGxlLgorCisgICAgICAgICogbWVkaWEv bW9kZXJuLW1lZGlhLWNvbnRyb2xzL3RyYWNrcy1wYW5lbC90cmFja3MtcGFuZWwtcHJldmVudC1k ZWZhdWx0LW9uLWtleWRvd24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRpYS9t b2Rlcm4tbWVkaWEtY29udHJvbHMvdHJhY2tzLXBhbmVsL3RyYWNrcy1wYW5lbC1wcmV2ZW50LWRl ZmF1bHQtb24ta2V5ZG93bi5odG1sOiBBZGRlZC4KKwogMjAxNy0wMy0xNCAgQW50b2luZSBRdWlu dCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFtNb2Rlcm4gTWVkaWEgQ29udHJvbHNd IEZ1bGxzY3JlZW4gY29udHJvbHMgZHVyaW5nIExpdmUgQnJvYWRjYXN0IGlzIGNvbXBsZXRlbHkg YnJva2VuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJv bHMvdHJhY2tzLXBhbmVsL3RyYWNrcy1wYW5lbC1wcmV2ZW50LWRlZmF1bHQtb24ta2V5ZG93bi1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvdHJh Y2tzLXBhbmVsL3RyYWNrcy1wYW5lbC1wcmV2ZW50LWRlZmF1bHQtb24ta2V5ZG93bi1leHBlY3Rl ZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uMDIxYmE2ZDk1ODA2YTlkODQxZThhZmViNTI1NzQ3Nzk1MDI5NDg0 ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250 cm9scy90cmFja3MtcGFuZWwvdHJhY2tzLXBhbmVsLXByZXZlbnQtZGVmYXVsdC1vbi1rZXlkb3du LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDE2IEBACitUZXN0aW5nIGEgVHJhY2tzUGFuZWwgY2Fs bHMgcHJldmVudERlZmF1bHQoKSBvbiBldmVudHMgaXQgaGFuZGxlcy4KKworT24gc3VjY2Vzcywg eW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRF U1QgQ09NUExFVEUiLgorCisKK21lZGlhQ29udHJvbHMuc2hvd1RyYWNrc1BhbmVsKCkKKworUHJl c3NpbmcgdGhlIEFycm93RG93biBrZXkKK1BBU1MgZXZlbnQuZGVmYXVsdFByZXZlbnRlZCBpcyB0 cnVlCitQcmVzc2luZyB0aGUgQXJyb3dSaWdodCBrZXkKK1BBU1MgZXZlbnQuZGVmYXVsdFByZXZl bnRlZCBpcyBmYWxzZQorCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1Qg Q09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNv bnRyb2xzL3RyYWNrcy1wYW5lbC90cmFja3MtcGFuZWwtcHJldmVudC1kZWZhdWx0LW9uLWtleWRv d24uaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy90cmFja3Mt cGFuZWwvdHJhY2tzLXBhbmVsLXByZXZlbnQtZGVmYXVsdC1vbi1rZXlkb3duLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uN2Y1YzkwMGEwY2MzNjJlNDkxMTUwYTNlYmQyZjU5MWY0ZmQzNDYxMQotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy90cmFja3Mt cGFuZWwvdHJhY2tzLXBhbmVsLXByZXZlbnQtZGVmYXVsdC1vbi1rZXlkb3duLmh0bWwKQEAgLTAs MCArMSw0MCBAQAorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL21lZGlhLWNvbnRyb2xzLWxv YWRlci5qcyIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij48L3NjcmlwdD4KKzxib2R5IHN0eWxlPSJo ZWlnaHQ6IDMwMDBweCI+Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisKK3dpbmRv dy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKworZGVzY3JpcHRpb24oIlRlc3RpbmcgYSA8Y29kZT5U cmFja3NQYW5lbDwvY29kZT4gY2FsbHMgcHJldmVudERlZmF1bHQoKSBvbiBldmVudHMgaXQgaGFu ZGxlcy4iKTsKKworY29uc3QgbWVkaWFDb250cm9scyA9IG5ldyBNYWNPU0lubGluZU1lZGlhQ29u dHJvbHMoeyB3aWR0aDogNjgwLCBoZWlnaHQ6IDMwMCB9KTsKK2RvY3VtZW50LmJvZHkuYXBwZW5k Q2hpbGQobWVkaWFDb250cm9scy5lbGVtZW50KTsKKworZGVidWcoIm1lZGlhQ29udHJvbHMuc2hv d1RyYWNrc1BhbmVsKCkiKTsKK21lZGlhQ29udHJvbHMuc2hvd1RyYWNrc1BhbmVsKCk7CisKK3Nj aGVkdWxlci5mcmFtZURpZEZpcmUgPSBmdW5jdGlvbigpCit7CisgICAgd2luZG93LnJlcXVlc3RB bmltYXRpb25GcmFtZSgoKSA9PiB7CisgICAgICAgIGRlYnVnKCIiKTsKKyAgICAgICAgZGVidWco IlByZXNzaW5nIHRoZSBBcnJvd0Rvd24ga2V5Iik7CisgICAgICAgIGV2ZW50U2VuZGVyLmtleURv d24oIkFycm93RG93biIpOworICAgICAgICBkZWJ1ZygiUHJlc3NpbmcgdGhlIEFycm93UmlnaHQg a2V5Iik7CisgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oIkFycm93UmlnaHQiKTsKKyAgICAg ICAgZGVidWcoIiIpOworICAgICAgICBtZWRpYUNvbnRyb2xzLmVsZW1lbnQucmVtb3ZlKCk7Cisg ICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAgIH0pOworICAgIHNjaGVkdWxlci5mcmFtZURpZEZp cmUgPSBudWxsOworfQorCitkb2N1bWVudC5ib2R5LmFkZEV2ZW50TGlzdGVuZXIoImtleWRvd24i LCBldmVudCA9PiB7CisgICAgaWYgKGV2ZW50LmtleSA9PT0gIkFycm93UmlnaHQiKQorICAgICAg ICBzaG91bGRCZUZhbHNlKCJldmVudC5kZWZhdWx0UHJldmVudGVkIik7CisgICAgZWxzZSBpZiAo ZXZlbnQua2V5ID09PSAiQXJyb3dEb3duIikKKyAgICAgICAgc2hvdWxkQmVUcnVlKCJldmVudC5k ZWZhdWx0UHJldmVudGVkIik7Cit9KTsKKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4v Li4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cg==