169665 2017-03-15 01:31:17 -0700 [TexMap] Add missing class member initializations 2017-04-03 00:56:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104114 1 zan zan annulen cmarcelo commit-queue kondapallykalyan luiz noam oldest_to_newest 1288013 0 zan 2017-03-15 01:31:17 -0700 [TexMap] Add missing class member initializations 1288016 1 304489 zan 2017-03-15 01:33:11 -0700 Created attachment 304489 Patch 1288067 2 304489 mcatanzaro 2017-03-15 08:50:58 -0700 Comment on attachment 304489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304489&action=review > Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:62 > + double m_lastUsedTime { 0 }; So I know it doesn't matter... but that's an int. I like to write 0.0. > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:235 > + double m_lastAnimationStartTime { 0 }; Ditto. 1288131 3 zan 2017-03-15 11:02:12 -0700 Committed r213989: <http://trac.webkit.org/changeset/213989> 1293604 4 annulen 2017-04-03 00:56:34 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 304489 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=304489&action=review > > > Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:62 > > + double m_lastUsedTime { 0 }; > > So I know it doesn't matter... but that's an int. I like to write 0.0. Coding style says we should write "0" https://webkit.org/code-style-guidelines/#floating-point-literals > > > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:235 > > + double m_lastAnimationStartTime { 0 }; > > Ditto. 304489 2017-03-15 01:33:11 -0700 2017-03-15 08:50:58 -0700 Patch bug-169665-20170315093309.patch text/plain 4049 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzOTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM2NWMwNTg0NzYzYTQ2 ZTc2NmFhYmI4NmJiNWQ4MmFkOTRmNDUyYS4uYWNiMWNmZjUzNDFkYTQ1NjZmYjg2NzBiZjc4YjA2 NTYwNjk3MmE5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE3LTAzLTE1ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAorICAgICAgICBbVGV4TWFwXSBBZGQg bWlzc2luZyBjbGFzcyBtZW1iZXIgaW5pdGlhbGl6YXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk2NjUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBaZXJvLWluaXRpYWxpemUgdGhlIG1lbWJlcnMg aW4gdmFyaW91cyBUZXh0dXJlTWFwcGVyIGNsYXNzZXMKKyAgICAgICAgdGhhdCBhcmUgbWlzc2lu ZyB0aGUgcHJvcGVyIGluaXRpYWxpemF0aW9uLCBhcyByZXBvcnRlZCBieQorICAgICAgICB0aGUg Q292ZXJpdHkgdG9vbC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9CaXRt YXBUZXh0dXJlUG9vbC5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29y ZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc1N0YXRlLmg6Cisg ICAgICAgIChXZWJDb3JlOjpDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXJTdGF0ZTo6Q29vcmRpbmF0 ZWRHcmFwaGljc0xheWVyU3RhdGUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9jb29yZGluYXRlZC9TdXJmYWNlVXBkYXRlSW5mby5oOgorCisyMDE3LTAzLTE1ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKwogICAgICAgICBVbnJldmlld2VkIEdUSysg YnVpbGQgZml4LiBTcHJpbmtsZSBFTkFCTEUoTUVESUFfU1RSRUFNKSBidWlsZCBndWFyZHMKICAg ICAgICAgaW4gdGhlIEludGVybmFscyBjbGFzcyB0byBhdm9pZCBjb21waWxhdGlvbiBmYWlsdXJl cyB3aGVuIGJ1aWxkaW5nCiAgICAgICAgIHdpdGggdGhpcyBmZWF0dXJlIGRpc2FibGVkLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0JpdG1hcFRl eHR1cmVQb29sLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0 bWFwVGV4dHVyZVBvb2wuaAppbmRleCA5NWJhMjQ5YWE3YTZiODgzNDllMTNlMDRiODcyNTU2YzBj Y2NmMTIyLi5hNDVkYjM4MzhlOWZlOWNiMDUwYzRkY2JkMTU0OWI5ZDFiMzRlNWFkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0bWFwVGV4dHVy ZVBvb2wuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvQml0 bWFwVGV4dHVyZVBvb2wuaApAQCAtNTksNyArNTksNyBAQCBwcml2YXRlOgogICAgICAgICB2b2lk IG1hcmtJc0luVXNlKCkgeyBtX2xhc3RVc2VkVGltZSA9IG1vbm90b25pY2FsbHlJbmNyZWFzaW5n VGltZSgpOyB9CiAKICAgICAgICAgUmVmUHRyPEJpdG1hcFRleHR1cmU+IG1fdGV4dHVyZTsKLSAg ICAgICAgZG91YmxlIG1fbGFzdFVzZWRUaW1lOworICAgICAgICBkb3VibGUgbV9sYXN0VXNlZFRp bWUgeyAwIH07CiAgICAgfTsKIAogICAgIHZvaWQgc2NoZWR1bGVSZWxlYXNlVW51c2VkVGV4dHVy ZXMoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNz TGF5ZXIuaAppbmRleCAwMjE1MGIwNzk4OTM1NzZjMGZhNzc4NTU2YmZjNTI1YjMwMTg4MWVhLi4y MzEwMzkzZDU2ODFiZTcwMmE5ODg5NzQ2ZjEyODE2Yjg5NTMyOTJhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0 ZWRHcmFwaGljc0xheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5oCkBAIC0yMzIsNyAr MjMyLDcgQEAgcHJpdmF0ZToKICAgICBQbGF0Zm9ybUxheWVyKiBtX3BsYXRmb3JtTGF5ZXI7CiAg ICAgVGltZXIgbV9hbmltYXRpb25TdGFydGVkVGltZXI7CiAgICAgVGV4dHVyZU1hcHBlckFuaW1h dGlvbnMgbV9hbmltYXRpb25zOwotICAgIGRvdWJsZSBtX2xhc3RBbmltYXRpb25TdGFydFRpbWU7 CisgICAgZG91YmxlIG1fbGFzdEFuaW1hdGlvblN0YXJ0VGltZSB7IDAgfTsKIAogICAgIFNjcm9s bGFibGVBcmVhKiBtX3Njcm9sbGFibGVBcmVhOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBo aWNzU3RhdGUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29y ZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzU3RhdGUuaAppbmRleCBiNmIzMGRjMjdhYjdmN2Mw MDYxMDFkNzdkZmFlZDA0MDU1MTIyYjliLi5jODEwNTMwYjVlN2ZmZjY1MzRkMjUyYzM0NjkwMWQ1 YTNkZmE1ZjkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90 ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc1N0YXRlLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVk R3JhcGhpY3NTdGF0ZS5oCkBAIC0xMjYsNiArMTI2LDcgQEAgc3RydWN0IENvb3JkaW5hdGVkR3Jh cGhpY3NMYXllclN0YXRlIHsKICAgICAgICAgLCByZXBsaWNhKEludmFsaWRDb29yZGluYXRlZExh eWVySUQpCiAgICAgICAgICwgbWFzayhJbnZhbGlkQ29vcmRpbmF0ZWRMYXllcklEKQogICAgICAg ICAsIGltYWdlSUQoSW52YWxpZENvb3JkaW5hdGVkSW1hZ2VCYWNraW5nSUQpCisgICAgICAgICwg cmVwYWludENvdW50KDApCiAjaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNTX1RIUkVBREVEKQog ICAgICAgICAsIHBsYXRmb3JtTGF5ZXJQcm94eSgwKQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvU3VyZmFjZVVw ZGF0ZUluZm8uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29y ZGluYXRlZC9TdXJmYWNlVXBkYXRlSW5mby5oCmluZGV4IDM4YzcyZTM3MDJjMDk5ODc5ZTM1NTNk ZGVhNjAyYmViNzQzNjhhYTAuLjBlNzQ5YmU5M2JhYWNhMjg4YWE2YTBmYzM2ZDA3MjZkMTI1Y2E4 ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9j b29yZGluYXRlZC9TdXJmYWNlVXBkYXRlSW5mby5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9TdXJmYWNlVXBkYXRlSW5mby5oCkBAIC0z NSw3ICszNSw3IEBAIHB1YmxpYzoKICAgICBJbnRSZWN0IHVwZGF0ZVJlY3Q7CiAKICAgICAvLyBU aGUgaWQgb2YgdGhlIHVwZGF0ZSBhdGxhcyBpbmNsdWRpbmcgdGhlIHNoYXJlYWJsZSBiaXRtYXAg Y29udGFpbmluZyB0aGUgdXBkYXRlcy4KLSAgICB1aW50MzJfdCBhdGxhc0lEOworICAgIHVpbnQz Ml90IGF0bGFzSUQgeyAwIH07CiAKICAgICAvLyBUaGUgb2Zmc2V0IGluIHRoZSBiaXRtYXAgd2hl cmUgdGhlIHJlbmRlcmVkIGNvbnRlbnRzIGFyZS4KICAgICBJbnRQb2ludCBzdXJmYWNlT2Zmc2V0 Owo=