169661 2017-03-14 22:16:11 -0700 Preventive clean-up: ensure RTCPeerConnection stays valid when calling postTask 2017-03-15 09:35:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue oldest_to_newest 1287984 0 youennf 2017-03-14 22:16:11 -0700 Preventive clean-up: ensure RTCPeerConnection stays valid when calling postTask 1287986 1 304478 youennf 2017-03-14 22:21:14 -0700 Created attachment 304478 Patch 1288084 2 304478 commit-queue 2017-03-15 09:35:22 -0700 Comment on attachment 304478 Patch Clearing flags on attachment: 304478 Committed r213982: <http://trac.webkit.org/changeset/213982> 1288085 3 commit-queue 2017-03-15 09:35:25 -0700 All reviewed patches have been landed. Closing bug. 304478 2017-03-14 22:21:14 -0700 2017-03-15 09:35:22 -0700 Patch bug-169661-20170314222114.patch text/plain 6508 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzODk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZjY2JlNTRjZTI5OWQx YmM1N2Q3MWVlN2E5M2YzYTM4YjhiODRhYS4uNzYyZWRkODZiMGI0NmIyMGE3NGFkOTY0NGY5MmRm NmY4YWJhMGRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE3LTAzLTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBQcmV2ZW50aXZlIGNsZWFu LXVwOiBlbnN1cmUgUlRDUGVlckNvbm5lY3Rpb24gc3RheXMgdmFsaWQgd2hlbiBjYWxsaW5nIHBv c3RUYXNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Njk2NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ cm90ZWN0aW5nIHRoZSBSVENQZWVyQ29ubmVjdGlvbiBvYmplY3Qgd2hlbiBjYWxsaW5nIHBvc3RU YXNrIHNpbmNlIGl0IG1pZ2h0IGdldCBjb2xsZWN0ZWQgYmV0d2VlbiB0aGUgdGFzayBwb3N0Cisg ICAgICAgIGFuZCB0YXNrIHJ1bi4gQWxzbyBkbyBub3Qgc2VuZCBuZWdvdGlhdGlvbk5lZWRlZCBl dmVudCBpZiBSVENQZWVyQ29ubmVjdGlvbiBpcyBjbG9zZWQgKGNvdmVyZWQgYnkgYWRkZWQgdGVz dCkuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJUQ1BlZXJDb25uZWN0aW9uOjp1cGRhdGVJY2VHYXRoZXJp bmdTdGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpSVENQZWVyQ29ubmVjdGlvbjo6dXBkYXRlSWNl Q29ubmVjdGlvblN0YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OlJUQ1BlZXJDb25uZWN0aW9uOjpz Y2hlZHVsZU5lZ290aWF0aW9uTmVlZGVkRXZlbnQpOgorCisyMDE3LTAzLTE0ICBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKwogICAgICAgICBBY3RpdmF0ZSByZWxlYXNlIGxpYndl YnJ0YyBsb2dnaW5nIHdoZW4gV2ViUlRDIGxvZyBjaGFubmVsIGlzIG9uCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk2NTkKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNw cAppbmRleCBmYTgwNWU4YzAyZTEyNzlmYTBmZWNiYjkxYjdiYjQ4MmJhOTRhNmE0Li43NjZiOWY2 ODEzZjFmODk4M2FjNmM5NTFmOWE4YmZlM2U0OTQ5NTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcApAQCAt NDc3LDMzICs0NzcsMzUgQEAgdm9pZCBSVENQZWVyQ29ubmVjdGlvbjo6c2V0U2lnbmFsaW5nU3Rh dGUoU2lnbmFsaW5nU3RhdGUgbmV3U3RhdGUpCiAKIHZvaWQgUlRDUGVlckNvbm5lY3Rpb246OnVw ZGF0ZUljZUdhdGhlcmluZ1N0YXRlKEljZUdhdGhlcmluZ1N0YXRlIG5ld1N0YXRlKQogewotICAg IHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+cG9zdFRhc2soWz1dKFNjcmlwdEV4ZWN1dGlvbkNv bnRleHQmKSB7Ci0gICAgICAgIGlmIChtX3NpZ25hbGluZ1N0YXRlID09IFNpZ25hbGluZ1N0YXRl OjpDbG9zZWQgfHwgbV9pY2VHYXRoZXJpbmdTdGF0ZSA9PSBuZXdTdGF0ZSkKKyAgICBzY3JpcHRF eGVjdXRpb25Db250ZXh0KCktPnBvc3RUYXNrKFtwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhp cyksIG5ld1N0YXRlXShTY3JpcHRFeGVjdXRpb25Db250ZXh0JikgeworICAgICAgICBpZiAocHJv dGVjdGVkVGhpcy0+bV9zaWduYWxpbmdTdGF0ZSA9PSBTaWduYWxpbmdTdGF0ZTo6Q2xvc2VkIHx8 IHByb3RlY3RlZFRoaXMtPm1faWNlR2F0aGVyaW5nU3RhdGUgPT0gbmV3U3RhdGUpCiAgICAgICAg ICAgICByZXR1cm47CiAKLSAgICAgICAgbV9pY2VHYXRoZXJpbmdTdGF0ZSA9IG5ld1N0YXRlOwot ICAgICAgICBkaXNwYXRjaEV2ZW50KEV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLmljZWdhdGhl cmluZ3N0YXRlY2hhbmdlRXZlbnQsIGZhbHNlLCBmYWxzZSkpOworICAgICAgICBwcm90ZWN0ZWRU aGlzLT5tX2ljZUdhdGhlcmluZ1N0YXRlID0gbmV3U3RhdGU7CisgICAgICAgIHByb3RlY3RlZFRo aXMtPmRpc3BhdGNoRXZlbnQoRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkuaWNlZ2F0aGVyaW5n c3RhdGVjaGFuZ2VFdmVudCwgZmFsc2UsIGZhbHNlKSk7CiAgICAgfSk7CiB9CiAKIHZvaWQgUlRD UGVlckNvbm5lY3Rpb246OnVwZGF0ZUljZUNvbm5lY3Rpb25TdGF0ZShJY2VDb25uZWN0aW9uU3Rh dGUgbmV3U3RhdGUpCiB7Ci0gICAgc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLT5wb3N0VGFzayhb PV0oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYpIHsKLSAgICAgICAgaWYgKG1fc2lnbmFsaW5nU3Rh dGUgPT0gU2lnbmFsaW5nU3RhdGU6OkNsb3NlZCB8fCBtX2ljZUNvbm5lY3Rpb25TdGF0ZSA9PSBu ZXdTdGF0ZSkKKyAgICBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCktPnBvc3RUYXNrKFtwcm90ZWN0 ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIG5ld1N0YXRlXShTY3JpcHRFeGVjdXRpb25Db250ZXh0 JikgeworICAgICAgICBpZiAocHJvdGVjdGVkVGhpcy0+bV9zaWduYWxpbmdTdGF0ZSA9PSBTaWdu YWxpbmdTdGF0ZTo6Q2xvc2VkIHx8IHByb3RlY3RlZFRoaXMtPm1faWNlQ29ubmVjdGlvblN0YXRl ID09IG5ld1N0YXRlKQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIG1faWNlQ29ubmVj dGlvblN0YXRlID0gbmV3U3RhdGU7Ci0gICAgICAgIGRpc3BhdGNoRXZlbnQoRXZlbnQ6OmNyZWF0 ZShldmVudE5hbWVzKCkuaWNlY29ubmVjdGlvbnN0YXRlY2hhbmdlRXZlbnQsIGZhbHNlLCBmYWxz ZSkpOworICAgICAgICBwcm90ZWN0ZWRUaGlzLT5tX2ljZUNvbm5lY3Rpb25TdGF0ZSA9IG5ld1N0 YXRlOworICAgICAgICBwcm90ZWN0ZWRUaGlzLT5kaXNwYXRjaEV2ZW50KEV2ZW50OjpjcmVhdGUo ZXZlbnROYW1lcygpLmljZWNvbm5lY3Rpb25zdGF0ZWNoYW5nZUV2ZW50LCBmYWxzZSwgZmFsc2Up KTsKICAgICB9KTsKIH0KIAogdm9pZCBSVENQZWVyQ29ubmVjdGlvbjo6c2NoZWR1bGVOZWdvdGlh dGlvbk5lZWRlZEV2ZW50KCkKIHsKLSAgICBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCktPnBvc3RU YXNrKFs9XShTY3JpcHRFeGVjdXRpb25Db250ZXh0JikgewotICAgICAgICBpZiAobV9iYWNrZW5k LT5pc05lZ290aWF0aW9uTmVlZGVkKCkpIHsKLSAgICAgICAgICAgIG1fYmFja2VuZC0+Y2xlYXJO ZWdvdGlhdGlvbk5lZWRlZFN0YXRlKCk7Ci0gICAgICAgICAgICBkaXNwYXRjaEV2ZW50KEV2ZW50 OjpjcmVhdGUoZXZlbnROYW1lcygpLm5lZ290aWF0aW9ubmVlZGVkRXZlbnQsIGZhbHNlLCBmYWxz ZSkpOwotICAgICAgICB9CisgICAgc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLT5wb3N0VGFzayhb cHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpXShTY3JpcHRFeGVjdXRpb25Db250ZXh0Jikg eworICAgICAgICBpZiAocHJvdGVjdGVkVGhpcy0+bV9zaWduYWxpbmdTdGF0ZSA9PSBTaWduYWxp bmdTdGF0ZTo6Q2xvc2VkKQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBpZiAoIXByb3Rl Y3RlZFRoaXMtPm1fYmFja2VuZC0+aXNOZWdvdGlhdGlvbk5lZWRlZCgpKQorICAgICAgICAgICAg cmV0dXJuOworICAgICAgICBwcm90ZWN0ZWRUaGlzLT5tX2JhY2tlbmQtPmNsZWFyTmVnb3RpYXRp b25OZWVkZWRTdGF0ZSgpOworICAgICAgICBwcm90ZWN0ZWRUaGlzLT5kaXNwYXRjaEV2ZW50KEV2 ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLm5lZ290aWF0aW9ubmVlZGVkRXZlbnQsIGZhbHNlLCBm YWxzZSkpOwogICAgIH0pOwogfQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDIxZGM4NzY0MTM0MGJkODc3ZjlkNGQ0Njcy ZmY5MjEyNTczYzQ0OS4uODJmMGMyZGU2NDc4ZmI1YTlkYWY2NzEyYmU4OGMwZGUwMzhkZjcxNSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE3LTAzLTE0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5u QGFwcGxlLmNvbT4KIAorICAgICAgICBQcmV2ZW50aXZlIGNsZWFuLXVwOiBlbnN1cmUgUlRDUGVl ckNvbm5lY3Rpb24gc3RheXMgdmFsaWQgd2hlbiBjYWxsaW5nIHBvc3RUYXNrCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk2NjEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdlYnJ0Yy9uZWdvdGlhdGVk bmVlZGVkLWV2ZW50LWFkZFN0cmVhbS1leHBlY3RlZC50eHQ6CisgICAgICAgICogd2VicnRjL25l Z290aWF0ZWRuZWVkZWQtZXZlbnQtYWRkU3RyZWFtLmh0bWw6CisKKzIwMTctMDMtMTQgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCiAgICAgICAgIHJ1bi13ZWJraXQtdGVzdHMg aXMgYWx3YXlzIGNyZWF0aW5nIG1vY2sgbGlid2VicnRjIHRyYWNrcwogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5NjU4CiAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3dlYnJ0Yy9uZWdvdGlhdGVkbmVlZGVkLWV2ZW50LWFkZFN0cmVhbS1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy93ZWJydGMvbmVnb3RpYXRlZG5lZWRlZC1ldmVudC1hZGRTdHJl YW0tZXhwZWN0ZWQudHh0CmluZGV4IGYyNjk0MTIyOWViMGJiMTMxNTYxNDU2NjU0ZjExNmRlOWRk MGEzYzMuLmZlMTg0NTYxZWY1MTY3NzE1YjdmZGNlMTNiZTQwMjcyMTk0N2QyMDAgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3dlYnJ0Yy9uZWdvdGlhdGVkbmVlZGVkLWV2ZW50LWFkZFN0cmVhbS1l eHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvd2VicnRjL25lZ290aWF0ZWRuZWVkZWQtZXZl bnQtYWRkU3RyZWFtLWV4cGVjdGVkLnR4dApAQCAtMSw0ICsxLDUgQEAKIAogCiBQQVNTIG9uIG5l Z290aWF0aW9uIG5lZWRlZCBpbiBjYXNlIG9mIGFkZGluZyBhIHN0cmVhbSAKK1BBU1Mgb24gbmVn b3RpYXRpb24gbmVlZGVkIG5vdCBjYWxsZWQgaWYgcGMgaXMgY2xvc2VkIAogCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy93ZWJydGMvbmVnb3RpYXRlZG5lZWRlZC1ldmVudC1hZGRTdHJlYW0uaHRt bCBiL0xheW91dFRlc3RzL3dlYnJ0Yy9uZWdvdGlhdGVkbmVlZGVkLWV2ZW50LWFkZFN0cmVhbS5o dG1sCmluZGV4IDRmOTJhMjIwZjlkODA4N2NjYTY0NzQ3YjQ0NDBmN2NlYTY4YmU3OWYuLjZlYTY2 YjkwZTk1OWRkYTllNTczN2RjM2VhZGVkMTYxMmM1OGU3YjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3dlYnJ0Yy9uZWdvdGlhdGVkbmVlZGVkLWV2ZW50LWFkZFN0cmVhbS5odG1sCisrKyBiL0xh eW91dFRlc3RzL3dlYnJ0Yy9uZWdvdGlhdGVkbmVlZGVkLWV2ZW50LWFkZFN0cmVhbS5odG1sCkBA IC0yNiw2ICsyNiwyMyBAQCBwcm9taXNlX3Rlc3QoKHRlc3QpID0+IHsKICAgICAgICAgfSk7CiAg ICAgfSk7CiB9LCAib24gbmVnb3RpYXRpb24gbmVlZGVkIGluIGNhc2Ugb2YgYWRkaW5nIGEgc3Ry ZWFtIik7CisKK3Byb21pc2VfdGVzdCgodGVzdCkgPT4geworICAgIGlmICh3aW5kb3cudGVzdFJ1 bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5zZXRVc2VyTWVkaWFQZXJtaXNzaW9uKHRydWUpOwor CisgICAgcmV0dXJuIG5hdmlnYXRvci5tZWRpYURldmljZXMuZ2V0VXNlck1lZGlhKHsgdmlkZW86 IHRydWV9KS50aGVuKChzdHJlYW0pID0+IHsKKyAgICAgICAgcmV0dXJuIG5ldyBQcm9taXNlKChy ZXNvbHZlLCByZWplY3QpID0+IHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQor ICAgICAgICAgICAgICAgIGludGVybmFscy51c2VNb2NrUlRDUGVlckNvbm5lY3Rpb25GYWN0b3J5 KCJPbmVSZWFsUGVlckNvbm5lY3Rpb24iKTsKKyAgICAgICAgICAgIHZhciBwYyA9IG5ldyBSVENQ ZWVyQ29ubmVjdGlvbigpOworICAgICAgICAgICAgcGMub25uZWdvdGlhdGlvbm5lZWRlZCA9ICgp ID0+IHsgcmVqZWN0KCk7IH07CisgICAgICAgICAgICBwYy5hZGRTdHJlYW0oc3RyZWFtKTsKKyAg ICAgICAgICAgIHBjLmNsb3NlKCk7CisgICAgICAgICAgICBzZXRUaW1lb3V0KHJlc29sdmUsIDUw MCk7CisgICAgICAgIH0pOworICAgIH0pOworfSwgIm9uIG5lZ290aWF0aW9uIG5lZWRlZCBub3Qg Y2FsbGVkIGlmIHBjIGlzIGNsb3NlZCIpOwogICAgICAgICA8L3NjcmlwdD4KICAgICA8L2JvZHk+ CiA8L2h0bWw+Cg==