169608 2017-03-14 08:18:43 -0700 [Modern Media Controls] iOS may attempt to load fullscreen icon variants 2017-03-14 09:16:53 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue webkit-bug-importer oldest_to_newest 1287617 0 graouts 2017-03-14 08:18:43 -0700 We may attempt to load fullscreen icon variants on iOS, and this simply shouldn't happen since we only display inline media controls. 1287619 1 webkit-bug-importer 2017-03-14 08:19:45 -0700 <rdar://problem/31037369> 1287620 2 304383 graouts 2017-03-14 08:22:25 -0700 Created attachment 304383 Patch 1287634 3 304383 commit-queue 2017-03-14 09:16:50 -0700 Comment on attachment 304383 Patch Clearing flags on attachment: 304383 Committed r213900: <http://trac.webkit.org/changeset/213900> 1287635 4 commit-queue 2017-03-14 09:16:53 -0700 All reviewed patches have been landed. Closing bug. 304383 2017-03-14 08:22:25 -0700 2017-03-14 09:16:50 -0700 Patch bug-169608-20170314162223.patch text/plain 5976 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjNhYjZhMWFjNTdlZTgz MTQ1MWYyM2Q3Mjk3Y2RkYzE2NmEwYzA1Yi4uNzgwNjgyMDEyNWUwYjUzMjMwYWRiNjFjZTI2MTgy OThhNTc5YzBmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAzLTE0ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW01vZGVybiBNZWRpYSBD b250cm9sc10gaU9TIG1heSBhdHRlbXB0IHRvIGxvYWQgZnVsbHNjcmVlbiBpY29uIHZhcmlhbnRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk2MDgK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxMDM3MzY5PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgcmV0dXJuIGZ1bGxzY3JlZW4gb3IgY29t cGFjdCB2YXJpYW50cyBmb3IgbWFjT1MuCisKKyAgICAgICAgKiBNb2R1bGVzL21vZGVybi1tZWRp YS1jb250cm9scy9jb250cm9scy9pY29uLXNlcnZpY2UuanM6CisgICAgICAgIChjb25zdC5pY29u U2VydmljZS5uZXcuSWNvblNlcnZpY2UucHJvdG90eXBlLl9maWxlTmFtZUFuZFBsYXRmb3JtRm9y SWNvbk5hbWVBbmRMYXlvdXRUcmFpdHMpOgorICAgICAgICAoY29uc3QuaWNvblNlcnZpY2UubmV3 Lkljb25TZXJ2aWNlKToKKwogMjAxNy0wMy0xMyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB1bnVzZWQgbWV0aG9kcyBvZiBSZXNvdXJjZVJl cXVlc3RCYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRp YS1jb250cm9scy9jb250cm9scy9pY29uLXNlcnZpY2UuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9pY29uLXNlcnZpY2UuanMKaW5kZXgg MGY0MjVlMjczZWY5NDA5ZWNmMGZkMGM2NmFkZmMzYTZjMjY4YTdlNS4uNzE1NDY2NGQxY2JlYjRm YzlhMDRjNTliOGNiZjNkOWQyMjZiNmE4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvaWNvbi1zZXJ2aWNlLmpzCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL2lj b24tc2VydmljZS5qcwpAQCAtODksMTAgKzg5LDEyIEBAIGNvbnN0IGljb25TZXJ2aWNlID0gbmV3 IGNsYXNzIEljb25TZXJ2aWNlIHsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgdGhyb3cgIkNv dWxkIG5vdCBpZGVudGlmeSBpY29uJ3MgcGxhdGZvcm0gZnJvbSBsYXlvdXQgdHJhaXRzLiI7CiAK LSAgICAgICAgaWYgKGxheW91dFRyYWl0cyAmIExheW91dFRyYWl0cy5GdWxsc2NyZWVuICYmIElj b25zV2l0aEZ1bGxzY3JlZW5WYXJpYW50cy5pbmNsdWRlcyhpY29uTmFtZSkpCi0gICAgICAgICAg ICBpY29uTmFtZSArPSAiLWZ1bGxzY3JlZW4iOwotICAgICAgICBlbHNlIGlmIChsYXlvdXRUcmFp dHMgJiBMYXlvdXRUcmFpdHMuQ29tcGFjdCAmJiBJY29uc1dpdGhDb21wYWN0VmFyaWFudHMuaW5j bHVkZXMoaWNvbk5hbWUpKQotICAgICAgICAgICAgaWNvbk5hbWUgKz0gIi1jb21wYWN0IjsKKyAg ICAgICAgaWYgKGxheW91dFRyYWl0cyAmIExheW91dFRyYWl0cy5tYWNPUykgeworICAgICAgICAg ICAgaWYgKGxheW91dFRyYWl0cyAmIExheW91dFRyYWl0cy5GdWxsc2NyZWVuICYmIEljb25zV2l0 aEZ1bGxzY3JlZW5WYXJpYW50cy5pbmNsdWRlcyhpY29uTmFtZSkpCisgICAgICAgICAgICAgICAg aWNvbk5hbWUgKz0gIi1mdWxsc2NyZWVuIjsKKyAgICAgICAgICAgIGVsc2UgaWYgKGxheW91dFRy YWl0cyAmIExheW91dFRyYWl0cy5Db21wYWN0ICYmIEljb25zV2l0aENvbXBhY3RWYXJpYW50cy5p bmNsdWRlcyhpY29uTmFtZSkpCisgICAgICAgICAgICAgICAgaWNvbk5hbWUgKz0gIi1jb21wYWN0 IjsKKyAgICAgICAgfQogCiAgICAgICAgIGNvbnN0IGZpbGVOYW1lID0gYCR7aWNvbk5hbWV9QCR7 d2luZG93LmRldmljZVBpeGVsUmF0aW99eGA7CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjMmViYjdiMGU4ODExZjIwMTEz ZWIzNDQ0YjI3ZDQyZTRiZWY3ZTk4Li44ZjAyMTE0NzFiOWQ3Y2EwMGIxNDVjNTVjYWUwNmQ1OThi NDhjNmJkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDMtMTQgIEFudG9pbmUgUXVpbnQg IDxncmFvdXRzQGFwcGxlLmNvbT4KKworICAgICAgICBbTW9kZXJuIE1lZGlhIENvbnRyb2xzXSBp T1MgbWF5IGF0dGVtcHQgdG8gbG9hZCBmdWxsc2NyZWVuIGljb24gdmFyaWFudHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTYwOAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMzEwMzczNjk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQW1lbmQgYW4gZXhpc3RpbmcgdGVzdCB0byBjaGVjayB0aGF0IHdl IGRpc3JlZ2FyZCBmdWxsc2NyZWVuIGFuZCBjb21wYWN0IHZhcmlhbnRzIG9uIGlPUy4KKworICAg ICAgICAqIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9pY29uLXNlcnZpY2UvaWNvbi1zZXJ2 aWNlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMv aWNvbi1zZXJ2aWNlL2ljb24tc2VydmljZS5odG1sOgorCiAyMDE3LTAzLTEzICBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBTeW5jIHdlYi1wbGF0Zm9ybS10ZXN0 cyB1cCB0byByZXZpc2lvbiBhNWI5NWNiMzE5MTQ1MDcwODhhNGVkYTE2Zjc2NzRiYmM2ZjMzMTNm CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvaWNv bi1zZXJ2aWNlL2ljb24tc2VydmljZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9t b2Rlcm4tbWVkaWEtY29udHJvbHMvaWNvbi1zZXJ2aWNlL2ljb24tc2VydmljZS1leHBlY3RlZC50 eHQKaW5kZXggOTQ0ZmE2OTJlODI4MzM3MjI3ZWYwYTEyMzA3ODY0N2RmYzAwNjU3OS4uMTg4NTc2 NTU0YTkxYmY1OWIyMTVlZTY0YzY4MzMwMjFkNzM0MGJjNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2ljb24tc2VydmljZS9pY29uLXNlcnZpY2Ut ZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9s cy9pY29uLXNlcnZpY2UvaWNvbi1zZXJ2aWNlLWV4cGVjdGVkLnR4dApAQCAtOCw2ICs4LDEwIEBA IFBBU1MgaWNvblNlcnZpY2UuaW1hZ2VGb3JJY29uTmFtZUFuZExheW91dFRyYWl0cyhJY29ucy5Q YXVzZSwgTGF5b3V0VHJhaXRzLm1hY09TCiBQQVNTIGljb25TZXJ2aWNlLmltYWdlRm9ySWNvbk5h bWVBbmRMYXlvdXRUcmFpdHMoSWNvbnMuUGF1c2UsIExheW91dFRyYWl0cy5pT1MpLnNyYy5pbmNs dWRlcygiaU9TL3BhdXNlQCIpIGlzIHRydWUKIFBBU1MgaWNvblNlcnZpY2UuaW1hZ2VGb3JJY29u TmFtZUFuZExheW91dFRyYWl0cyhJY29ucy5QYXVzZSwgTGF5b3V0VHJhaXRzLm1hY09TIHwgTGF5 b3V0VHJhaXRzLkZ1bGxzY3JlZW4pLnNyYy5pbmNsdWRlcygibWFjT1MvcGF1c2UtZnVsbHNjcmVl bkAiKSBpcyB0cnVlCiAKK0NoZWNraW5nIGZ1bGxzY3JlZW4gb3IgY29tcGFjdCBsYXlvdXQgdHJh aXRzIGFyZSBpZ25vcmVkIG9uIGlPUworUEFTUyBpY29uU2VydmljZS5pbWFnZUZvckljb25OYW1l QW5kTGF5b3V0VHJhaXRzKEljb25zLlBhdXNlLCBMYXlvdXRUcmFpdHMuaU9TIHwgTGF5b3V0VHJh aXRzLkZ1bGxzY3JlZW4pID09PSBpY29uU2VydmljZS5pbWFnZUZvckljb25OYW1lQW5kTGF5b3V0 VHJhaXRzKEljb25zLlBhdXNlLCBMYXlvdXRUcmFpdHMuaU9TKSBpcyB0cnVlCitQQVNTIGljb25T ZXJ2aWNlLmltYWdlRm9ySWNvbk5hbWVBbmRMYXlvdXRUcmFpdHMoSWNvbnMuUGF1c2UsIExheW91 dFRyYWl0cy5pT1MgfCBMYXlvdXRUcmFpdHMuQ29tcGFjdCkgPT09IGljb25TZXJ2aWNlLmltYWdl Rm9ySWNvbk5hbWVBbmRMYXlvdXRUcmFpdHMoSWNvbnMuUGF1c2UsIExheW91dFRyYWl0cy5pT1Mp IGlzIHRydWUKKwogQ2hlY2tpbmcgcmVxdWVzdGVkIGltYWdlcyBhcmUgY2FjaGVkCiBQQVNTIGlj b25TZXJ2aWNlLmltYWdlRm9ySWNvbk5hbWVBbmRMYXlvdXRUcmFpdHMoSWNvbnMuUGF1c2UsIExh eW91dFRyYWl0cy5tYWNPUykgPT09IGljb25TZXJ2aWNlLmltYWdlRm9ySWNvbk5hbWVBbmRMYXlv dXRUcmFpdHMoSWNvbnMuUGF1c2UsIExheW91dFRyYWl0cy5tYWNPUykgaXMgdHJ1ZQogUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEv bW9kZXJuLW1lZGlhLWNvbnRyb2xzL2ljb24tc2VydmljZS9pY29uLXNlcnZpY2UuaHRtbCBiL0xh eW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9pY29uLXNlcnZpY2UvaWNvbi1z ZXJ2aWNlLmh0bWwKaW5kZXggZWI1NDkxYjY4MmM2Zjg0NWU0YWI3ZjFhM2IzNzFkZjg0ZmZjZDM2 NC4uOTA0OWQ2MDA5NmQxZjk4OTBmMGM2YmVhNjIzYWUzN2EwYjczM2NmMCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2ljb24tc2VydmljZS9pY29u LXNlcnZpY2UuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJv bHMvaWNvbi1zZXJ2aWNlL2ljb24tc2VydmljZS5odG1sCkBAIC0xNSw2ICsxNSwxMSBAQCBzaG91 bGRCZVRydWUoJ2ljb25TZXJ2aWNlLmltYWdlRm9ySWNvbk5hbWVBbmRMYXlvdXRUcmFpdHMoSWNv bnMuUGF1c2UsIExheW91dFRyYQogc2hvdWxkQmVUcnVlKCdpY29uU2VydmljZS5pbWFnZUZvcklj b25OYW1lQW5kTGF5b3V0VHJhaXRzKEljb25zLlBhdXNlLCBMYXlvdXRUcmFpdHMubWFjT1MgfCBM YXlvdXRUcmFpdHMuRnVsbHNjcmVlbikuc3JjLmluY2x1ZGVzKCJtYWNPUy9wYXVzZS1mdWxsc2Ny ZWVuQCIpJyk7CiAKIGRlYnVnKCIiKTsKK2RlYnVnKCJDaGVja2luZyBmdWxsc2NyZWVuIG9yIGNv bXBhY3QgbGF5b3V0IHRyYWl0cyBhcmUgaWdub3JlZCBvbiBpT1MiKTsKK3Nob3VsZEJlVHJ1ZSgn aWNvblNlcnZpY2UuaW1hZ2VGb3JJY29uTmFtZUFuZExheW91dFRyYWl0cyhJY29ucy5QYXVzZSwg TGF5b3V0VHJhaXRzLmlPUyB8IExheW91dFRyYWl0cy5GdWxsc2NyZWVuKSA9PT0gaWNvblNlcnZp Y2UuaW1hZ2VGb3JJY29uTmFtZUFuZExheW91dFRyYWl0cyhJY29ucy5QYXVzZSwgTGF5b3V0VHJh aXRzLmlPUyknKTsKK3Nob3VsZEJlVHJ1ZSgnaWNvblNlcnZpY2UuaW1hZ2VGb3JJY29uTmFtZUFu ZExheW91dFRyYWl0cyhJY29ucy5QYXVzZSwgTGF5b3V0VHJhaXRzLmlPUyB8IExheW91dFRyYWl0 cy5Db21wYWN0KSA9PT0gaWNvblNlcnZpY2UuaW1hZ2VGb3JJY29uTmFtZUFuZExheW91dFRyYWl0 cyhJY29ucy5QYXVzZSwgTGF5b3V0VHJhaXRzLmlPUyknKTsKKworZGVidWcoIiIpOwogZGVidWco IkNoZWNraW5nIHJlcXVlc3RlZCBpbWFnZXMgYXJlIGNhY2hlZCIpOwogc2hvdWxkQmVUcnVlKCdp Y29uU2VydmljZS5pbWFnZUZvckljb25OYW1lQW5kTGF5b3V0VHJhaXRzKEljb25zLlBhdXNlLCBM YXlvdXRUcmFpdHMubWFjT1MpID09PSBpY29uU2VydmljZS5pbWFnZUZvckljb25OYW1lQW5kTGF5 b3V0VHJhaXRzKEljb25zLlBhdXNlLCBMYXlvdXRUcmFpdHMubWFjT1MpJyk7CiAK