169597 2017-03-14 03:53:36 -0700 Wrong condition in offlineasm/risc.rb 2017-03-14 22:52:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104114 1 tpopela tpopela commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1287571 0 tpopela 2017-03-14 03:53:36 -0700 Found by Coverity scan: webkitgtk-2.14.5/Source/JavaScriptCore/offlineasm/risc.rb:378: unused_expr: Discarding the result of operator "==" in "node.operands().size() == 2". What was this code intended to accomplish? webkitgtk-2.14.5/Source/JavaScriptCore/offlineasm/risc.rb:378: remediation: Did you intend to make an assertion or assignment? # 376| (not validImmediates.include? node.operands[0].value) and # 377| validImmediates.include? -node.operands[0].value # 378|-> node.operands.size == 2 # 379| if node.opcode =~ /add/ # 380| newOpcode = "sub" + $~.post_match 1287572 1 304371 tpopela 2017-03-14 03:55:24 -0700 Created attachment 304371 Patch 1287670 2 304371 mark.lam 2017-03-14 10:39:53 -0700 Comment on attachment 304371 Patch r=me 1287991 3 304371 tpopela 2017-03-14 22:52:16 -0700 Comment on attachment 304371 Patch Clearing flags on attachment: 304371 Committed r213973: <http://trac.webkit.org/changeset/213973> 1287992 4 tpopela 2017-03-14 22:52:25 -0700 All reviewed patches have been landed. Closing bug. 304371 2017-03-14 03:55:24 -0700 2017-03-14 22:52:16 -0700 Patch bug-169597-20170314115524.patch text/plain 1612 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh YjE5MWViZDMyN2U5YTg5ZjZkMzg2ZGE4NDZkOGIyMzVlZTU5YTIyLi5iMDBhZmJkN2Q2MjlhNjEy MzBmZjFiZTI5N2MyOGJhN2JmNDNkOTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNy0wMy0xNCAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29t PgorCisgICAgICAgIFdyb25nIGNvbmRpdGlvbiBpbiBvZmZsaW5lYXNtL3Jpc2MucmIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTU5NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0J3MgbWlzc2luZyB0 aGUgJ2FuZCcgb3BlcmF0b3IgYmV0d2VlbiB0aGUgY29uZGl0aW9ucy4KKworICAgICAgICAqIG9m ZmxpbmVhc20vcmlzYy5yYjoKKwogMjAxNy0wMy0xNCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2Vr QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dMaWJdIFVzZSBVU0UoR0xJQikgZ3VhcmRzIGluIEph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9FdmVudExvb3AuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9yaXNjLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L29mZmxpbmVhc20vcmlzYy5yYgppbmRleCAzZmJjMDdkMGI0MTYzNzBmNTlkODE5YWVlNDkzZWMz NGRjMzlhYjdmLi4yOGUwMTY1NGI2YWVkMjZjM2E4YzViMTVlYTIzZGI3NjBmNDlhNTcyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9yaXNjLnJiCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3Jpc2MucmIKQEAgLTM3NCw3ICszNzQsNyBA QCBkZWYgcmlzY0xvd2VyTWFsZm9ybWVkSW1tZWRpYXRlcyhsaXN0LCB2YWxpZEltbWVkaWF0ZXMp CiAgICAgICAgICAgICB3aGVuICJhZGRpIiwgImFkZHAiLCAiYWRkcSIsICJhZGRpcyIsICJzdWJp IiwgInN1YnAiLCAic3VicSIsICJzdWJpcyIKICAgICAgICAgICAgICAgICBpZiBub2RlLm9wZXJh bmRzWzBdLmlzX2E/IEltbWVkaWF0ZSBhbmQKICAgICAgICAgICAgICAgICAgICAgICAgIChub3Qg dmFsaWRJbW1lZGlhdGVzLmluY2x1ZGU/IG5vZGUub3BlcmFuZHNbMF0udmFsdWUpIGFuZAotICAg ICAgICAgICAgICAgICAgICAgICAgdmFsaWRJbW1lZGlhdGVzLmluY2x1ZGU/IC1ub2RlLm9wZXJh bmRzWzBdLnZhbHVlCisgICAgICAgICAgICAgICAgICAgICAgICB2YWxpZEltbWVkaWF0ZXMuaW5j bHVkZT8gLW5vZGUub3BlcmFuZHNbMF0udmFsdWUgYW5kCiAgICAgICAgICAgICAgICAgICAgICAg ICBub2RlLm9wZXJhbmRzLnNpemUgPT0gMgogICAgICAgICAgICAgICAgICAgICBpZiBub2RlLm9w Y29kZSA9fiAvYWRkLwogICAgICAgICAgICAgICAgICAgICAgICAgbmV3T3Bjb2RlID0gInN1YiIg KyAkfi5wb3N0X21hdGNoCg==