169589 2017-03-13 22:38:00 -0700 Web Inspector: Remove unnecessary assert for Number.percentageString 2017-03-14 10:56:44 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes oldest_to_newest 1287518 0 hi 2017-03-13 22:38:00 -0700 It is valid to have a fraction greater than 1, as well as for that fraction to be converted to a percentage point. 1287520 1 304355 hi 2017-03-13 22:38:49 -0700 Created attachment 304355 Patch 1287548 2 304355 mattbaker 2017-03-14 00:59:28 -0700 Comment on attachment 304355 Patch r=me. Did this come up? Are we showing values < 0% or > 100%? 1287554 3 304355 commit-queue 2017-03-14 01:28:10 -0700 Comment on attachment 304355 Patch Clearing flags on attachment: 304355 Committed r213890: <http://trac.webkit.org/changeset/213890> 1287555 4 commit-queue 2017-03-14 01:28:14 -0700 All reviewed patches have been landed. Closing bug. 1287678 5 304355 joepeck 2017-03-14 10:56:44 -0700 Comment on attachment 304355 Patch I think the intent here was originally we only ever expected positive numbers. Was there a case where we could get negative numbers? 304355 2017-03-13 22:38:49 -0700 2017-03-14 01:28:10 -0700 Patch bug-169589-20170313233848.patch text/plain 1366 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI3NzJkMGY4NjFiMzA3Yzk4YmExNWM0MWNmOGQ3 OTBlYjkzNTlhMTcuLjRjNmY3ZDZiYTlhYWM3ZjU1YWFkM2ExM2UwMjIxYzdhYWNiOWQ1OTEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAzLTEzICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFJlbW92ZSB1bm5lY2Vzc2FyeSBhc3NlcnQgZm9yIE51bWJlci5wZXJjZW50YWdlU3RyaW5n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk1ODkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanM6CisgICAgICAgIChOdW1iZXIucGVyY2VudGFnZVN0 cmluZyk6CisKIDIwMTctMDMtMTMgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogV2ViU29ja2V0czogY29sb3Igb2Ygb3V0Z29p bmcgbWVzc2FnZSBpY29uIHNob3VsZCBtYXRjaCB0ZXh0IGNvbG9yCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzCmluZGV4IDYw ZTBlMDlkZjkzNWRlNmIwNjgwY2NkZTk5MDQ4YjkzODM1MjRmYWYuLmZmNWQyYTJmYWVmZjUyZGQ2 ODZkMzdkN2JiMDQ5OGRkMzM0MmEzNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzCkBAIC0xMDAzLDcgKzEwMDMsNiBA QCBPYmplY3QuZGVmaW5lUHJvcGVydHkoTnVtYmVyLCAicGVyY2VudGFnZVN0cmluZyIsCiB7CiAg ICAgdmFsdWU6IGZ1bmN0aW9uKGZyYWN0aW9uLCBwcmVjaXNpb24gPSAxKQogICAgIHsKLSAgICAg ICAgY29uc29sZS5hc3NlcnQoZnJhY3Rpb24gPj0gMCAmJiBmcmFjdGlvbiA8PSAxKTsKICAgICAg ICAgcmV0dXJuIGZyYWN0aW9uLnRvTG9jYWxlU3RyaW5nKHVuZGVmaW5lZCwge21pbmltdW1GcmFj dGlvbkRpZ2l0czogcHJlY2lzaW9uLCBzdHlsZTogInBlcmNlbnQifSk7CiAgICAgfQogfSk7Cg==