169579 2017-03-13 18:38:29 -0700 Remove unused methods of ResourceRequestBase 2017-03-13 23:51:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck achristensen cdumez commit-queue dbates japhet youennf oldest_to_newest 1287450 0 joepeck 2017-03-13 18:38:29 -0700 Summary: Remove unused methods of ResourceRequestBase * setReportLoadTiming - getter/member is never checked, we just always gather load timing data * setReportRawHeaders - getter/member is never checked * setReportUploadProgress - getter/member is never checked, added for Chromium 1287451 1 304330 joepeck 2017-03-13 18:39:49 -0700 Created attachment 304330 [PATCH] Proposed Fix 1287471 2 304330 youennf 2017-03-13 19:58:43 -0700 Comment on attachment 304330 [PATCH] Proposed Fix bots are all orange, let's wait before cq+ing 1287529 3 304330 commit-queue 2017-03-13 23:51:27 -0700 Comment on attachment 304330 [PATCH] Proposed Fix Clearing flags on attachment: 304330 Committed r213885: <http://trac.webkit.org/changeset/213885> 1287530 4 commit-queue 2017-03-13 23:51:33 -0700 All reviewed patches have been landed. Closing bug. 304330 2017-03-13 18:39:49 -0700 2017-03-13 23:51:27 -0700 [PATCH] Proposed Fix remove-1.patch text/plain 5868 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MzQzZTgwODcxYy4uZGQ2ODVmNzgzOWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyOSBAQAogMjAxNy0wMy0xMyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCisgICAgICAgIFJlbW92ZSB1bnVzZWQgbWV0aG9kcyBvZiBSZXNvdXJjZVJlcXVlc3RC YXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk1 NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5oOgorICAgICAgICAoV2ViQ29yZTo6 UmVzb3VyY2VSZXF1ZXN0QmFzZTo6cmVwb3J0VXBsb2FkUHJvZ3Jlc3MpOiBEZWxldGVkLgorICAg ICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0QmFzZTo6c2V0UmVwb3J0VXBsb2FkUHJvZ3Jl c3MpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0QmFzZTo6cmVw b3J0TG9hZFRpbWluZyk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVl c3RCYXNlOjpzZXRSZXBvcnRMb2FkVGltaW5nKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6 OlJlc291cmNlUmVxdWVzdEJhc2U6OnJlcG9ydFJhd0hlYWRlcnMpOiBEZWxldGVkLgorICAgICAg ICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0QmFzZTo6c2V0UmVwb3J0UmF3SGVhZGVycyk6IERl bGV0ZWQuCisgICAgICAgIFJlbW92ZSB1bnVzZWQgY29kZS4KKworICAgICAgICAqIGluc3BlY3Rv ci9JbnNwZWN0b3JOZXR3b3JrQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9y TmV0d29ya0FnZW50Ojp3aWxsU2VuZFJlcXVlc3QpOgorICAgICAgICAqIGxvYWRlci9SZXNvdXJj ZUxvYWROb3RpZmllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUxvYWROb3RpZmll cjo6ZGlzcGF0Y2hXaWxsU2VuZFJlcXVlc3QpOgorICAgICAgICAqIHhtbC9YTUxIdHRwUmVxdWVz dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6Y3JlYXRlUmVxdWVzdCk6 CisgICAgICAgIFJlbW92ZSBjYWxsZXJzIG9mIHNldHRlcnMgdGhhdCBkaWQgbm90aGluZy4KKwor MjAxNy0wMy0xMyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IE1vcmUgYWNjdXJhdGUgUmVzb3VyY2UgVGltaW5nIGRhdGEgaW4g V2ViIEluc3BlY3RvcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY5NTc3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JOZXR3b3JrQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ck5ldHdvcmtBZ2VudC5jcHAKaW5kZXggZTJkODU2ODcwMTEuLmFkMTJhN2Q1NDZlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yTmV0d29ya0FnZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yTmV0d29ya0FnZW50LmNwcApA QCAtMzQyLDkgKzM0Miw2IEBAIHZvaWQgSW5zcGVjdG9yTmV0d29ya0FnZW50Ojp3aWxsU2VuZFJl cXVlc3QodW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBEb2N1bWVudExvCiAgICAgZm9yIChhdXRv JiBlbnRyeSA6IG1fZXh0cmFSZXF1ZXN0SGVhZGVycykKICAgICAgICAgcmVxdWVzdC5zZXRIVFRQ SGVhZGVyRmllbGQoZW50cnkua2V5LCBlbnRyeS52YWx1ZSk7CiAKLSAgICByZXF1ZXN0LnNldFJl cG9ydExvYWRUaW1pbmcodHJ1ZSk7Ci0gICAgcmVxdWVzdC5zZXRSZXBvcnRSYXdIZWFkZXJzKHRy dWUpOwotCiAgICAgaWYgKG1fY2FjaGVEaXNhYmxlZCkgewogICAgICAgICByZXF1ZXN0LnNldEhU VFBIZWFkZXJGaWVsZChIVFRQSGVhZGVyTmFtZTo6UHJhZ21hLCAibm8tY2FjaGUiKTsKICAgICAg ICAgcmVxdWVzdC5zZXRDYWNoZVBvbGljeShSZWxvYWRJZ25vcmluZ0NhY2hlRGF0YSk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkTm90aWZpZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZE5vdGlmaWVyLmNwcAppbmRleCBjZmQ5 NWE2YjI2MC4uN2Y4Mzc3ZDI5YjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9S ZXNvdXJjZUxvYWROb3RpZmllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291 cmNlTG9hZE5vdGlmaWVyLmNwcApAQCAtMTMzLDEzICsxMzMsNiBAQCB2b2lkIFJlc291cmNlTG9h ZE5vdGlmaWVyOjpkaXNwYXRjaFdpbGxTZW5kUmVxdWVzdChEb2N1bWVudExvYWRlciogbG9hZGVy LCB1bnNpZwogICAgICAgICBtX2ZyYW1lLmxvYWRlcigpLmRvY3VtZW50TG9hZGVyKCktPmRpZFRl bGxDbGllbnRBYm91dExvYWQocmVxdWVzdC51cmwoKSk7CiAKICAgICBJbnNwZWN0b3JJbnN0cnVt ZW50YXRpb246OndpbGxTZW5kUmVxdWVzdCgmbV9mcmFtZSwgaWRlbnRpZmllciwgbG9hZGVyLCBy ZXF1ZXN0LCByZWRpcmVjdFJlc3BvbnNlKTsKLQotICAgIGlmIChSdW50aW1lRW5hYmxlZEZlYXR1 cmVzOjpzaGFyZWRGZWF0dXJlcygpLnJlc291cmNlVGltaW5nRW5hYmxlZCgpKQotICAgICAgICBy ZXF1ZXN0LnNldFJlcG9ydExvYWRUaW1pbmcodHJ1ZSk7Ci0gICAgZWxzZSBpZiAobG9hZGVyICYm ICFyZXF1ZXN0LmlzTnVsbCgpICYmIHJlcXVlc3QudXJsKCkgPT0gbG9hZGVyLT51cmwoKSkgewot ICAgICAgICAvLyBSZXBvcnQgV2ViVGltaW5nIGZvciBhbGwgZnJhbWVzLgotICAgICAgICByZXF1 ZXN0LnNldFJlcG9ydExvYWRUaW1pbmcodHJ1ZSk7Ci0gICAgfQogfQogCiB2b2lkIFJlc291cmNl TG9hZE5vdGlmaWVyOjpkaXNwYXRjaERpZFJlY2VpdmVSZXNwb25zZShEb2N1bWVudExvYWRlciog bG9hZGVyLCB1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGNvbnN0IFJlc291cmNlUmVzcG9uc2Um IHIsIFJlc291cmNlTG9hZGVyKiByZXNvdXJjZUxvYWRlcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5oIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmgKaW5kZXggODY0MTVl YWE1ZmUuLmZiNDA1MzBjMDgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaApAQCAtMTQ0LDE5ICsxNDQsNiBAQCBwdWJs aWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgYm9vbCBpc0NvbmRpdGlvbmFsKCkgY29uc3Q7CiAgICAg V0VCQ09SRV9FWFBPUlQgdm9pZCBtYWtlVW5jb25kaXRpb25hbCgpOwogCi0gICAgLy8gV2hldGhl ciB0aGUgYXNzb2NpYXRlZCBSZXNvdXJjZUhhbmRsZUNsaWVudCBuZWVkcyB0byBiZSBub3RpZmll ZCBvZgotICAgIC8vIHVwbG9hZCBwcm9ncmVzcyBtYWRlIGZvciB0aGF0IHJlc291cmNlLgotICAg IGJvb2wgcmVwb3J0VXBsb2FkUHJvZ3Jlc3MoKSBjb25zdCB7IHJldHVybiBtX3JlcG9ydFVwbG9h ZFByb2dyZXNzOyB9Ci0gICAgdm9pZCBzZXRSZXBvcnRVcGxvYWRQcm9ncmVzcyhib29sIHJlcG9y dFVwbG9hZFByb2dyZXNzKSB7IG1fcmVwb3J0VXBsb2FkUHJvZ3Jlc3MgPSByZXBvcnRVcGxvYWRQ cm9ncmVzczsgfQotCi0gICAgLy8gV2hldGhlciB0aGUgdGltaW5nIGluZm9ybWF0aW9uIHNob3Vs ZCBiZSBjb2xsZWN0ZWQgZm9yIHRoZSByZXF1ZXN0LgotICAgIGJvb2wgcmVwb3J0TG9hZFRpbWlu ZygpIGNvbnN0IHsgcmV0dXJuIG1fcmVwb3J0TG9hZFRpbWluZzsgfQotICAgIHZvaWQgc2V0UmVw b3J0TG9hZFRpbWluZyhib29sIHJlcG9ydExvYWRUaW1pbmcpIHsgbV9yZXBvcnRMb2FkVGltaW5n ID0gcmVwb3J0TG9hZFRpbWluZzsgfQotCi0gICAgLy8gV2hldGhlciBhY3R1YWwgaGVhZGVycyBi ZWluZyBzZW50L3JlY2VpdmVkIHNob3VsZCBiZSBjb2xsZWN0ZWQgYW5kIHJlcG9ydGVkIGZvciB0 aGUgcmVxdWVzdC4KLSAgICBib29sIHJlcG9ydFJhd0hlYWRlcnMoKSBjb25zdCB7IHJldHVybiBt X3JlcG9ydFJhd0hlYWRlcnM7IH0KLSAgICB2b2lkIHNldFJlcG9ydFJhd0hlYWRlcnMoYm9vbCBy ZXBvcnRSYXdIZWFkZXJzKSB7IG1fcmVwb3J0UmF3SGVhZGVycyA9IHJlcG9ydFJhd0hlYWRlcnM7 IH0KLQogICAgIC8vIFdoZXRoZXIgdGhpcyByZXF1ZXN0IHNob3VsZCBiZSBoaWRkZW4gZnJvbSB0 aGUgSW5zcGVjdG9yLgogICAgIGJvb2wgaGlkZGVuRnJvbUluc3BlY3RvcigpIGNvbnN0IHsgcmV0 dXJuIG1faGlkZGVuRnJvbUluc3BlY3RvcjsgfQogICAgIHZvaWQgc2V0SGlkZGVuRnJvbUluc3Bl Y3Rvcihib29sIGhpZGRlbkZyb21JbnNwZWN0b3IpIHsgbV9oaWRkZW5Gcm9tSW5zcGVjdG9yID0g aGlkZGVuRnJvbUluc3BlY3RvcjsgfQpAQCAtMjM0LDkgKzIyMSw2IEBAIHByb3RlY3RlZDoKICAg ICBtdXRhYmxlIGJvb2wgbV9wbGF0Zm9ybVJlcXVlc3RVcGRhdGVkIHsgZmFsc2UgfTsKICAgICBt dXRhYmxlIGJvb2wgbV9yZXNvdXJjZVJlcXVlc3RCb2R5VXBkYXRlZCB7IGZhbHNlIH07CiAgICAg bXV0YWJsZSBib29sIG1fcGxhdGZvcm1SZXF1ZXN0Qm9keVVwZGF0ZWQgeyBmYWxzZSB9OwotICAg IGJvb2wgbV9yZXBvcnRVcGxvYWRQcm9ncmVzcyB7IGZhbHNlIH07Ci0gICAgYm9vbCBtX3JlcG9y dExvYWRUaW1pbmcgeyBmYWxzZSB9OwotICAgIGJvb2wgbV9yZXBvcnRSYXdIZWFkZXJzIHsgZmFs c2UgfTsKICAgICBib29sIG1faGlkZGVuRnJvbUluc3BlY3RvciB7IGZhbHNlIH07CiAgICAgYm9v bCBtX2lnbm9yZUZvclJlcXVlc3RDb3VudCB7IGZhbHNlIH07CiAgICAgUmVzb3VyY2VMb2FkUHJp b3JpdHkgbV9wcmlvcml0eSB7IFJlc291cmNlTG9hZFByaW9yaXR5OjpMb3cgfTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCmluZGV4IDgyMjIxMjE2Y2E3Li40N2RlMTg1OTkxZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCkBAIC03NDYsOSArNzQ2LDYgQEAg RXhjZXB0aW9uT3I8dm9pZD4gWE1MSHR0cFJlcXVlc3Q6OmNyZWF0ZVJlcXVlc3QoKQogICAgIG1f ZXJyb3IgPSBmYWxzZTsKIAogICAgIGlmIChtX2FzeW5jKSB7Ci0gICAgICAgIGlmIChtX3VwbG9h ZCkKLSAgICAgICAgICAgIHJlcXVlc3Quc2V0UmVwb3J0VXBsb2FkUHJvZ3Jlc3ModHJ1ZSk7Ci0K ICAgICAgICAgLy8gVGhyZWFkYWJsZUxvYWRlcjo6Y3JlYXRlIGNhbiByZXR1cm4gbnVsbCBoZXJl LCBmb3IgZXhhbXBsZSBpZiB3ZSdyZSBubyBsb25nZXIgYXR0YWNoZWQgdG8gYSBwYWdlIG9yIGlm IGEgY29udGVudCBibG9ja2VyIGJsb2NrcyB0aGUgbG9hZC4KICAgICAgICAgLy8gVGhpcyBpcyB0 cnVlIHdoaWxlIHJ1bm5pbmcgb251bmxvYWQgaGFuZGxlcnMuCiAgICAgICAgIC8vIEZJWE1FOiBN YXliZSB3ZSBuZWVkIHRvIGJlIGFibGUgdG8gc2VuZCBYTUxIdHRwUmVxdWVzdHMgZnJvbSBvbnVu bG9hZCwgPGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTA0Pi4K