<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>169551</bug_id>
          
          <creation_ts>2017-03-13 05:22:45 -0700</creation_ts>
          <short_desc>[cmake] [WK2] Guard flags intended for GCC-like compilers with COMPILER_IS_GCC_OR_CLANG</short_desc>
          <delta_ts>2017-03-13 07:04:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Konstantin Tokarev">annulen</reporter>
          <assigned_to name="Konstantin Tokarev">annulen</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>lforschler</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1287146</commentid>
    <comment_count>0</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-03-13 05:22:45 -0700</bug_when>
    <thetext>This change allows building WK2 code with MSVC</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1287147</commentid>
    <comment_count>1</comment_count>
      <attachid>304252</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2017-03-13 05:24:11 -0700</bug_when>
    <thetext>Created attachment 304252
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1287152</commentid>
    <comment_count>2</comment_count>
      <attachid>304252</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-03-13 06:30:50 -0700</bug_when>
    <thetext>Comment on attachment 304252
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1287156</commentid>
    <comment_count>3</comment_count>
      <attachid>304252</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-13 07:04:41 -0700</bug_when>
    <thetext>Comment on attachment 304252
Patch

Clearing flags on attachment: 304252

Committed r213843: &lt;http://trac.webkit.org/changeset/213843&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1287157</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-13 07:04:45 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>304252</attachid>
            <date>2017-03-13 05:24:11 -0700</date>
            <delta_ts>2017-03-13 07:04:41 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-169551-20170313152410.patch</filename>
            <type>text/plain</type>
            <size>1687</size>
            <attacher name="Konstantin Tokarev">annulen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzNzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYThhZjdmNDhiNTBiNzlh
ZDU5NjFkNTU5ZjBjOThjYzIwNGZkYWIwNC4uOGZkMWU4OTY4YmE0NWFmMDE1NGZmNjVhOTNkYWY2
N2IyNDMwYTY3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAzLTEzICBLb25z
dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBbY21ha2VdIFtX
SzJdIEd1YXJkIGZsYWdzIGludGVuZGVkIGZvciBHQ0MtbGlrZSBjb21waWxlcnMgd2l0aCBDT01Q
SUxFUl9JU19HQ0NfT1JfQ0xBTkcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE2OTU1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIFRoaXMgY2hhbmdlIGFsbG93cyBidWlsZGluZyBXSzIgY29kZSB3aXRoIE1T
VkMuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxNy0wMy0xMyAgQ2FybG9zIEdh
cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgV2ViIEF1dG9tYXRp
b246IGF1dG9tYXRpb24gY29tbWFuZHMgaGFuZyB3aGVuIHRyeWluZyB0byBuYXZpZ2F0ZSBnby9i
YWNrIGFuZCBpdCdzIG5vdCBwb3NzaWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ01h
a2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dAppbmRleCA0NjdiYzUy
MDNmYWI5NzkyY2E2MjE0ZjY4ZTA5OWZlNzhkZDk3MGQyLi42MGVmOWVmMmE0Y2Y5YWNiODAwY2E2
NDM4YTBiODJlMTIyODg1YTNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3Rz
LnR4dAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dApAQCAtNzk0LDEyICs3OTQs
MTQgQEAgV0VCS0lUX0ZSQU1FV09SSyhXZWJLaXQyKQogYWRkX2RlcGVuZGVuY2llcyhXZWJLaXQy
IFdlYkNvcmUgJHtXRUJLSVQyX0VYVFJBX0RFUEVOREVOQ0lFU30pCiBhZGRfd2Via2l0Ml9wcmVm
aXhfaGVhZGVyKFdlYktpdDIpCiAKLWlmIChOT1QgQVBQTEUpCitpZiAoQ09NUElMRVJfSVNfR0ND
X09SX0NMQU5HIEFORCBOT1QgQVBQTEUpCiAgICAgdGFyZ2V0X2xpbmtfbGlicmFyaWVzKFdlYktp
dDIgLVdsLC0tc3RhcnQtZ3JvdXAgV2ViQ29yZSBXZWJDb3JlRGVyaXZlZFNvdXJjZXMgLVdsLC0t
ZW5kLWdyb3VwKQogZW5kaWYgKCkKIAogIyBTdXBwcmVzcyB1bnVzZWQgcGFyYW1ldGVyIHdhcm5p
bmdzIGZvciBzb3VyY2VzIGluIFdlYktpdDIuCi1BRERfVEFSR0VUX1BST1BFUlRJRVMoV2ViS2l0
MiBDT01QSUxFX0ZMQUdTICItV25vLXVudXNlZC1wYXJhbWV0ZXIiKQoraWYgKENPTVBJTEVSX0lT
X0dDQ19PUl9DTEFORykKKyAgICBBRERfVEFSR0VUX1BST1BFUlRJRVMoV2ViS2l0MiBDT01QSUxF
X0ZMQUdTICItV25vLXVudXNlZC1wYXJhbWV0ZXIiKQorZW5kaWYgKCkKIAogaWYgKFdlYktpdDJf
VkVSU0lPTl9TQ1JJUFQpCiAgICAgQUREX1RBUkdFVF9QUk9QRVJUSUVTKFdlYktpdDIgTElOS19G
TEFHUyAiJHtXZWJLaXQyX1ZFUlNJT05fU0NSSVBUfSIpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>