<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>16955</bug_id>
          
          <creation_ts>2008-01-21 03:11:36 -0800</creation_ts>
          <short_desc>Get errors when cross-compile webkit-gtk</short_desc>
          <delta_ts>2008-01-21 22:52:05 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fengmeng">fengmeng</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>alp</cc>
    
    <cc>mrowe</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>67833</commentid>
    <comment_count>0</comment_count>
    <who name="Fengmeng">fengmeng</who>
    <bug_when>2008-01-21 03:11:36 -0800</bug_when>
    <thetext>When I cross-compile webkit-gtk for arm  arch. I get following errors:

arm-linux-g++ -DHAVE_CONFIG_H -I.  -I ./JavaScriptCore -I ./JavaScriptCore/ForwardingHeaders -I ./JavaScriptCore/wtf -I ./JavaScriptCore/kjs -I ./DerivedSources -DBUILDING_GTK__=1 -DWTF_CHANGES   -DNDEBUG  -DENABLE_ICONDATABASE=0   -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter  -fno-rtti -fno-exceptions  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fno-strict-aliasing  -O2 -MT JavaScriptCore/kjs/Programs_testkjs-testkjs.o -MD -MP -MF JavaScriptCore/kjs/.deps/Programs_testkjs-testkjs.Tpo -c -o JavaScriptCore/kjs/Programs_testkjs-testkjs.o `test -f &apos;JavaScriptCore/kjs/testkjs.cpp&apos; || echo &apos;./&apos;`JavaScriptCore/kjs/testkjs.cpp
cc1plus: error: invalid option `64&apos;
cc1plus: error: unrecognized command line option &quot;-fstack-protector&quot;
cc1plus: error: invalid parameter `ssp-buffer-size&apos;
JavaScriptCore/kjs/testkjs.cpp:1: error: bad value (generic) for -mtune= switch
make[1]: *** [JavaScriptCore/kjs/Programs_testkjs-testkjs.o] Error 1
make[1]: Leaving directory `/usr/nthcode/WebKit-r29674&apos;
make: *** [all] Error 2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>67834</commentid>
    <comment_count>1</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2008-01-21 03:15:27 -0800</bug_when>
    <thetext>Discussion in #webkit revealed the erroneous flags were coming from ICU_CFLAGS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>67852</commentid>
    <comment_count>2</comment_count>
      <attachid>18575</attachid>
    <who name="Jan Alonzo">jmalonzo</who>
    <bug_when>2008-01-21 09:57:50 -0800</bug_when>
    <thetext>Created attachment 18575
patch to cleanup ICU_CFLAGS

The patch to cleanup usage of ICU_CFLAGS is attached. The patch also adds ICU_CPPFLAGS in the jsc and webcore/webkitgtk builds.

Please let me know if there are any issues with the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>67895</commentid>
    <comment_count>3</comment_count>
      <attachid>18575</attachid>
    <who name="Alp Toker">alp</who>
    <bug_when>2008-01-21 15:06:38 -0800</bug_when>
    <thetext>Comment on attachment 18575
patch to cleanup ICU_CFLAGS

ICU libs/cflags only need to be added to jsc and webcore, nothing else. There are also other redundant flags we can remove.

Also found tabs in WebKitTools/ChangeLog

Will fix up these issues.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>67896</commentid>
    <comment_count>4</comment_count>
    <who name="Alp Toker">alp</who>
    <bug_when>2008-01-21 15:07:34 -0800</bug_when>
    <thetext>Landed in r29701.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>67916</commentid>
    <comment_count>5</comment_count>
    <who name="Fengmeng">fengmeng</who>
    <bug_when>2008-01-21 22:52:05 -0800</bug_when>
    <thetext>Hi alp

Your patch works , 
Now I have successfully cross-compiled WebKit/Gtk for my arm board.
Thank you guys a lot

Fengmeng

(In reply to comment #3)
&gt; (From update of attachment 18575 [edit])
&gt; ICU libs/cflags only need to be added to jsc and webcore, nothing else. There
&gt; are also other redundant flags we can remove.
&gt; 
&gt; Also found tabs in WebKitTools/ChangeLog
&gt; 
&gt; Will fix up these issues.
&gt; 

</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>18575</attachid>
            <date>2008-01-21 09:57:50 -0800</date>
            <delta_ts>2008-01-21 15:06:38 -0800</delta_ts>
            <desc>patch to cleanup ICU_CFLAGS</desc>
            <filename>webkit-icucflag.patch</filename>
            <type>text/plain</type>
            <size>5004</size>
            <attacher name="Jan Alonzo">jmalonzo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyOTFiNjE3Li5hNGVlYThm
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK
KzIwMDgtMDEtMjEgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHVucGx1Z2dhYmxlLmNv
bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRw
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk1NQorICAgICAgICBHZXQgZXJy
b3JzIHdoZW4gY3Jvc3MtY29tcGlsZSB3ZWJraXQtZ3RrCisKKyAgICAgICAgKiBHTlVtYWtlZmls
ZS5hbTogYWRkZWQgSUNVX0NQUEZMQUdTCisgICAgICAgICogY29uZmlndXJlLmFjOiBhZGRlZCBJ
Q1VfQ1BQRkxBR1MsIHJlbW92ZWQgSUNVX0NGTEFHUworCiAyMDA4LTAxLTE5ICBKYW4gTWljaGFl
bCBBbG9uem8gIDxqbWFsb256b0B1bnBsdWdnYWJsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg
YnkgQWxwIFRva2VyLgpkaWZmIC0tZ2l0IGEvR05VbWFrZWZpbGUuYW0gYi9HTlVtYWtlZmlsZS5h
bQppbmRleCAyNzIyNmI4Li45YjljOGM2IDEwMDY0NAotLS0gYS9HTlVtYWtlZmlsZS5hbQorKysg
Yi9HTlVtYWtlZmlsZS5hbQpAQCAtMTAwLDcgKzEwMCwxMCBAQCBsaWJKYXZhU2NyaXB0Q29yZV9s
YV9DWFhGTEFHUyA9ICQoZ2xvYmFsX2NmbGFncykgLWZzdHJpY3QtYWxpYXNpbmcKIAogbGliSmF2
YVNjcmlwdENvcmVfbGFfQ0ZMQUdTID0gJChnbG9iYWxfY2ZsYWdzKSAtZnN0cmljdC1hbGlhc2lu
ZwogCi1saWJKYXZhU2NyaXB0Q29yZV9sYV9DUFBGTEFHUyA9ICQoZ2xvYmFsX2NwcGZsYWdzKSAk
KGphdmFzY3JpcHRjb3JlX2NwcGZsYWdzKQorbGliSmF2YVNjcmlwdENvcmVfbGFfQ1BQRkxBR1Mg
PSBcCisJJChnbG9iYWxfY3BwZmxhZ3MpIFwKKwkkKGphdmFzY3JpcHRjb3JlX2NwcGZsYWdzKSBc
CisJJChJQ1VfQ1BQRkxBR1MpCiAKICMKICMgV2ViQ29yZQpAQCAtMTU3LDcgKzE2MCw4IEBAIGxp
YldlYktpdEd0a19sYV9DRkxBR1MgPSBcCiBsaWJXZWJLaXRHdGtfbGFfQ1BQRkxBR1MgPSBcCiAJ
JChnbG9iYWxfY3BwZmxhZ3MpIFwKIAkkKHdlYmNvcmVfY3BwZmxhZ3MpIFwKLQkkKHdlYmtpdGd0
a19jcHBmbGFncykKKwkkKHdlYmtpdGd0a19jcHBmbGFncykgXAorCSQoSUNVX0NQUEZMQUdTKQog
CiBsaWJXZWJLaXRHdGtfbGFfTElCQUREID0gbGliSmF2YVNjcmlwdENvcmUubGEKIApkaWZmIC0t
Z2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n
CmluZGV4IDgyNjQwODMuLjhlN2UyNjQgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5n
ZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAw
OC0wMS0yMSAgSmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9AdW5wbHVnZ2FibGUuY29tPgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTU1CisgICAgICAgIEdldCBlcnJvcnMg
d2hlbiBjcm9zcy1jb21waWxlIHdlYmtpdC1ndGsKKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFt
OiByZW1vdmVkIElDVV9DRkxBR1MKKwogMjAwOC0wMS0xOCAgS2V2aW4gTWNDdWxsb3VnaCAgPGtt
Y2N1bGxvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICAtIEJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBh
L0phdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtIGIvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZp
bGUuYW0KaW5kZXggNTJmN2QwZC4uOWQ5MmU2ZSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUv
R05VbWFrZWZpbGUuYW0KKysrIGIvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZpbGUuYW0KQEAgLTE0
OSwxNCArMTQ5LDE0IEBAIFByb2dyYW1zX21pbmlkb21fU09VUkNFUyA9IFwKIAlKYXZhU2NyaXB0
Q29yZS9BUEkvTm9kZUxpc3QuYyBcCiAJSmF2YVNjcmlwdENvcmUvQVBJL21pbmlkb20uYwogUHJv
Z3JhbXNfbWluaWRvbV9DUFBGTEFHUyA9ICQoZ2xvYmFsX2NwcGZsYWdzKQotUHJvZ3JhbXNfbWlu
aWRvbV9DWFhGTEFHUyA9ICQoZ2xvYmFsX2NmbGFncykgJChJQ1VfQ0ZMQUdTKQorUHJvZ3JhbXNf
bWluaWRvbV9DWFhGTEFHUyA9ICQoZ2xvYmFsX2NmbGFncykKIFByb2dyYW1zX21pbmlkb21fTERB
REQgPSAkKElDVV9MSUJTKSBsaWJKYXZhU2NyaXB0Q29yZS5sYQogUHJvZ3JhbXNfbWluaWRvbV9M
REZMQUdTID0gLXJwYXRoICQoQ1VSRElSKS8ubGlicwogCiAjIHRlc3RranMKIFByb2dyYW1zX3Rl
c3RranNfU09VUkNFUyA9IEphdmFTY3JpcHRDb3JlL2tqcy90ZXN0a2pzLmNwcAogUHJvZ3JhbXNf
dGVzdGtqc19DUFBGTEFHUyA9ICQoZ2xvYmFsX2NwcGZsYWdzKQotUHJvZ3JhbXNfdGVzdGtqc19D
WFhGTEFHUyA9ICQoZ2xvYmFsX2NmbGFncykgJChJQ1VfQ0ZMQUdTKQorUHJvZ3JhbXNfdGVzdGtq
c19DWFhGTEFHUyA9ICQoZ2xvYmFsX2NmbGFncykKIFByb2dyYW1zX3Rlc3RranNfTERBREQgPSAk
KElDVV9MSUJTKSBsaWJKYXZhU2NyaXB0Q29yZS5sYQogUHJvZ3JhbXNfdGVzdGtqc19MREZMQUdT
ID0gLXJwYXRoICQoQ1VSRElSKS8ubGlicwogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFu
Z2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggNjIwNjQ3ZS4uNzJmY2Y4ZiAxMDA2
NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDEyIEBACisyMDA4LTAxLTIxICBKYW4gTWljaGFlbCBBbG9uem8gIDxqbWFs
b256b0B1bnBsdWdnYWJsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5
NTUKKyAgICAgICAgR2V0IGVycm9ycyB3aGVuIGNyb3NzLWNvbXBpbGUgd2Via2l0LWd0aworCisJ
KiBHTlVtYWtlZmlsZS5hbTogUmVtb3ZlZCBJQ1VfQ0ZMQUdTIAorCiAyMDA4LTAxLTIxICBEYXJp
biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNaXR6IGFu
ZCBBZGFtLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvR05VbWFrZWZpbGUuYW0gYi9XZWJLaXRU
b29scy9HTlVtYWtlZmlsZS5hbQppbmRleCBlMDcwNTg3Li5iZTBhMWViIDEwMDY0NAotLS0gYS9X
ZWJLaXRUb29scy9HTlVtYWtlZmlsZS5hbQorKysgYi9XZWJLaXRUb29scy9HTlVtYWtlZmlsZS5h
bQpAQCAtMTIsMTUgKzEyLDEyIEBAIFByb2dyYW1zX0d0a0xhdW5jaGVyX1NPVVJDRVMgPSBcCiAK
IFByb2dyYW1zX0d0a0xhdW5jaGVyX0NGTEFHUyA9IFwKIAkkKERFUEVOREVOQ0lFU19DRkxBR1Mp
IFwKLQkkKElDVV9DRkxBR1MpIFwKLQkkKFNRTElURTNfQ0ZMQUdTKSBcCiAJJChHU1RSRUFNRVJf
Q0ZMQUdTKSBcCiAJJChMSUJYU0xUX0NGTEFHUykKIAogUHJvZ3JhbXNfR3RrTGF1bmNoZXJfTERB
REQgPSBcCiAJJChERVBFTkRFTkNJRVNfTElCUykgXAogCSQoSUNVX0xJQlMpIFwKLQkkKFNRTElU
RTNfTElCUykgXAogCSQoR1NUUkVBTUVSX0xJQlMpIFwKIAkkKExJQlhTTFRfTElCUykgXAogCWxp
YkphdmFTY3JpcHRDb3JlLmxhIFwKQEAgLTQ0LDYgKzQxLDE3IEBAIFByb2dyYW1zX0R1bXBSZW5k
ZXJUcmVlX1NPVVJDRVMgPSBcCiAJV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91
dFRlc3RDb250cm9sbGVyR3RrLmNwcCBcCiAJV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3Rr
L1dvcmtRdWV1ZUl0ZW1HdGsuY3BwCiAKLVByb2dyYW1zX0R1bXBSZW5kZXJUcmVlX0NYWEZMQUdT
ID0gJChERVBFTkRFTkNJRVNfQ0ZMQUdTKSAkKEFNX0NYWEZMQUdTKQotUHJvZ3JhbXNfRHVtcFJl
bmRlclRyZWVfTERBREQgPSAkKERFUEVOREVOQ0lFU19MSUJTKSBsaWJKYXZhU2NyaXB0Q29yZS5s
YSBsaWJXZWJLaXRHdGsubGEKK1Byb2dyYW1zX0R1bXBSZW5kZXJUcmVlX0NYWEZMQUdTID0gXAor
CSQoREVQRU5ERU5DSUVTX0NGTEFHUykgXAorCSQoTElCQ1VSTF9DRkxBR1MpIFwKKwkkKExJQlhT
TFRfQ0ZMQUdTKQorCitQcm9ncmFtc19EdW1wUmVuZGVyVHJlZV9MREFERCA9IFwKKwkkKERFUEVO
REVOQ0lFU19MSUJTKSBcCisJJChMSUJDVVJMX0xJQlMpIFwKKwkkKElDVV9MSUJTKSBcCisJJChM
SUJYU0xUX0xJQlMpIFwKKwlsaWJKYXZhU2NyaXB0Q29yZS5sYSBcCisJbGliV2ViS2l0R3RrLmxh
CisKIFByb2dyYW1zX0R1bXBSZW5kZXJUcmVlX0xERkxBR1MgPSAtcnBhdGggJChDVVJESVIpLy5s
aWJzIApkaWZmIC0tZ2l0IGEvY29uZmlndXJlLmFjIGIvY29uZmlndXJlLmFjCmluZGV4IDVlMjQ1
M2UuLjFhN2RjNTcgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1cmUuYWMK
QEAgLTEyOSw5ICsxMjksMTMgQEAgQUNfUEFUSF9QUk9HKGljdV9jb25maWcsIGljdS1jb25maWcs
IG5vKQogaWYgdGVzdCAiJGljdV9jb25maWciID0gIm5vIjsgdGhlbgogICAgQUNfTVNHX0VSUk9S
KFtDYW5ub3QgZmluZCBpY3UtY29uZmlnLiBJQ1UgbGlicmFyeSBpcyBuZWVkZWQuXSkKIGZpCi1J
Q1VfQ0ZMQUdTPWAkaWN1X2NvbmZpZyAtLWNmbGFnc2AKKworIyBXZSBkb24ndCB1c2UgLS1jZmxh
Z3MgYXMgdGhpcyBnaXZlcyB1cyBhIGxvdCBvZiB0aGluZ3MgdGhhdCB3ZSBkb24ndAorIyBuZWNl
c3NhcmlseSB3YW50LCBsaWtlIGRlYnVnZ2luZyBhbmQgb3B0aW1pemF0aW9uIGZsYWdzCisjIFNl
ZSBtYW4gKDEpIGljdS1jb25maWcgZm9yIG1vcmUgaW5mby4KK0lDVV9DUFBGTEFHUz1gJGljdV9j
b25maWcgLS1jcHBmbGFnc2AKIElDVV9MSUJTPWAkaWN1X2NvbmZpZyAtLWxkZmxhZ3NgCi1BQ19T
VUJTVChbSUNVX0NGTEFHU10pCitBQ19TVUJTVChbSUNVX0NQUEZMQUdTXSkKIEFDX1NVQlNUKFtJ
Q1VfTElCU10pCiAKICMgZGV0ZXJtaW5lIHRoZSBHREsvR1RLKyB0YXJnZXQK
</data>
<flag name="review"
          id="8128"
          type_id="1"
          status="+"
          setter="alp"
    />
          </attachment>
      

    </bug>

</bugzilla>