169545 2017-03-13 02:20:31 -0700 [Win] Compile fix. 2017-03-13 13:46:22 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 169490 1 pvollan pvollan achristensen bfulgham commit-queue oldest_to_newest 1287117 0 pvollan 2017-03-13 02:20:31 -0700 MSVC warns about inconsistent dll linkage for exported JS functions. 1287119 1 304244 pvollan 2017-03-13 02:23:43 -0700 Created attachment 304244 Patch 1287176 2 304244 pvollan 2017-03-13 08:58:40 -0700 Comment on attachment 304244 Patch Thanks for reviewing! 1287187 3 304244 commit-queue 2017-03-13 09:26:52 -0700 Comment on attachment 304244 Patch Clearing flags on attachment: 304244 Committed r213846: <http://trac.webkit.org/changeset/213846> 1287188 4 commit-queue 2017-03-13 09:26:55 -0700 All reviewed patches have been landed. Closing bug. 304244 2017-03-13 02:23:43 -0700 2017-03-13 09:26:52 -0700 Patch bug-169545-20170313022342.patch text/plain 7545 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzc5MCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAzLTEz ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBD b21waWxlIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2OTU0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeCBpbmNvbnNpc3RlbnQgZGxsIGxpbmthZ2Ugd2FybmluZ3MuCisgCisgICAgICAgICog V2ViS2l0RExMLmNwcDoKKyAgICAgICAgKiBXZWJLaXRETEwuaDoKKwogMjAxNy0wMy0xMCAgQnJl bnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBSZS1leHBv cnQgYSBmZXcgc3ltYm9scyBmb3IgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkKSW5kZXg6IFNvdXJj ZS9XZWJLaXQvd2luL1dlYktpdERMTC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93 aW4vV2ViS2l0RExMLmNwcAkocmV2aXNpb24gMjEzNzg1KQorKysgU291cmNlL1dlYktpdC93aW4v V2ViS2l0RExMLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjAsNiArNjAsMjAgQEAgQ0xTSUQgZ1Jl Z0NMU0lEc1tdID0gewogfTsKICN1bmRlZiBDTFNJRF9GT1JfQ0xBU1MKIAorI2lmIGRlZmluZWQo REVQUkVDQVRFRF9FWFBPUlRfU1lNQk9MUykKKworLy8gRm9yY2Ugc3ltYm9scyB0byBiZSBpbmNs dWRlZCBzbyB3ZSBjYW4gZXhwb3J0IHRoZW0gZm9yIGxlZ2FjeSBjbGllbnRzLgorLy8gREVQUkVD QVRFRCEgUGVvcGxlIHNob3VsZCBnZXQgdGhlc2Ugc3ltYm9scyBmcm9tIEphdmFTY3JpcHRDb3Jl LmRsbCwgbm90IFdlYktpdC5kbGwhCit0eXBlZGVmIHN0cnVjdCBPcGFxdWVKU0NsYXNzKiBKU0Ns YXNzUmVmOwordHlwZWRlZiBjb25zdCBzdHJ1Y3QgT3BhcXVlSlNDb250ZXh0KiBKU0NvbnRleHRS ZWY7Cit0eXBlZGVmIGNvbnN0IHN0cnVjdCBPcGFxdWVKU1ZhbHVlKiBKU1ZhbHVlUmVmOwordHlw ZWRlZiBzdHJ1Y3QgT3BhcXVlSlNTdHJpbmcqIEpTU3RyaW5nUmVmOwordHlwZWRlZiB3Y2hhcl90 IEpTQ2hhcjsKK3R5cGVkZWYgdW5zaWduZWQgSlNQcm9wZXJ0eUF0dHJpYnV0ZXM7CitzdHJ1Y3Qg SlNDbGFzc0RlZmluaXRpb247CisKKyNlbmRpZgorCiBIYXNoQ291bnRlZFNldDxTdHJpbmc+JiBn Q2xhc3NOYW1lQ291bnQoKQogewogICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxIYXNoQ291bnRl ZFNldDxTdHJpbmc+PiBnQ2xhc3NOYW1lQ291bnQ7CkBAIC0yODYsMTAzICszMDAsMTAzIEBAIHZv aWQgYmluZEphdmFTY3JpcHRUcmFtcG9saW5lKCkKIGV4dGVybiAiQyIKIHsKIAotSlNDbGFzc1Jl ZiBKU0NsYXNzQ3JlYXRlKGNvbnN0IEpTQ2xhc3NEZWZpbml0aW9uKiBkZWZpbml0aW9uKQorV0VC S0lUX0FQSSBKU0NsYXNzUmVmIEpTQ2xhc3NDcmVhdGUoY29uc3QgSlNDbGFzc0RlZmluaXRpb24q IGRlZmluaXRpb24pCiB7CiAgICAgaWYgKG1fanNDbGFzc0NyZWF0ZUZ1bmN0aW9uKQogICAgICAg ICByZXR1cm4gbV9qc0NsYXNzQ3JlYXRlRnVuY3Rpb24oZGVmaW5pdGlvbik7CiAgICAgcmV0dXJu IG51bGxwdHI7CiB9CiAKLXZvaWQqIEpTT2JqZWN0R2V0UHJpdmF0ZShKU09iamVjdFJlZiBvYmpl Y3QpCitXRUJLSVRfQVBJIHZvaWQqIEpTT2JqZWN0R2V0UHJpdmF0ZShKU09iamVjdFJlZiBvYmpl Y3QpCiB7CiAgICAgaWYgKG1fanNPYmplY3RHZXRQcml2YXRlRnVuY3Rpb24pCiAgICAgICAgIHJl dHVybiBtX2pzT2JqZWN0R2V0UHJpdmF0ZUZ1bmN0aW9uKG9iamVjdCk7CiAgICAgcmV0dXJuIG51 bGxwdHI7CiB9CiAKLUpTT2JqZWN0UmVmIEpTT2JqZWN0TWFrZShKU0NvbnRleHRSZWYgY3R4LCBK U0NsYXNzUmVmIGNsYXNzUmVmLCB2b2lkKiBkYXRhKQorV0VCS0lUX0FQSSBKU09iamVjdFJlZiBK U09iamVjdE1ha2UoSlNDb250ZXh0UmVmIGN0eCwgSlNDbGFzc1JlZiBjbGFzc1JlZiwgdm9pZCog ZGF0YSkKIHsKICAgICBpZiAobV9qc09iamVjdE1ha2VGdW5jdGlvbikKICAgICAgICAgcmV0dXJu IG1fanNPYmplY3RNYWtlRnVuY3Rpb24oY3R4LCBjbGFzc1JlZiwgZGF0YSk7CiAgICAgcmV0dXJu IG51bGxwdHI7CiB9CiAKLXZvaWQgSlNPYmplY3RTZXRQcm9wZXJ0eShKU0NvbnRleHRSZWYgY3R4 LCBKU09iamVjdFJlZiBvYmplY3QsIEpTU3RyaW5nUmVmIHByb3BlcnR5TmFtZSwgSlNWYWx1ZVJl ZiB2YWx1ZSwgSlNQcm9wZXJ0eUF0dHJpYnV0ZXMgYXR0cmlidXRlcywgSlNWYWx1ZVJlZiogZXhj ZXB0aW9uKQorV0VCS0lUX0FQSSB2b2lkIEpTT2JqZWN0U2V0UHJvcGVydHkoSlNDb250ZXh0UmVm IGN0eCwgSlNPYmplY3RSZWYgb2JqZWN0LCBKU1N0cmluZ1JlZiBwcm9wZXJ0eU5hbWUsIEpTVmFs dWVSZWYgdmFsdWUsIEpTUHJvcGVydHlBdHRyaWJ1dGVzIGF0dHJpYnV0ZXMsIEpTVmFsdWVSZWYq IGV4Y2VwdGlvbikKIHsKICAgICBpZiAobV9qc09iamVjdFNldFByb3BlcnR5RnVuY3Rpb24pCiAg ICAgICAgIG1fanNPYmplY3RTZXRQcm9wZXJ0eUZ1bmN0aW9uKGN0eCwgb2JqZWN0LCBwcm9wZXJ0 eU5hbWUsIHZhbHVlLCBhdHRyaWJ1dGVzLCBleGNlcHRpb24pOwogfQogCi1KU1N0cmluZ1JlZiBK U1N0cmluZ0NyZWF0ZVdpdGhDRlN0cmluZyhDRlN0cmluZ1JlZiB2YWx1ZSkKK1dFQktJVF9BUEkg SlNTdHJpbmdSZWYgSlNTdHJpbmdDcmVhdGVXaXRoQ0ZTdHJpbmcoQ0ZTdHJpbmdSZWYgdmFsdWUp CiB7CiAgICAgaWYgKG1fanNTdHJpbmdDcmVhdGVXaXRoQ0ZTdHJpbmdGdW5jdGlvbikKICAgICAg ICAgcmV0dXJuIG1fanNTdHJpbmdDcmVhdGVXaXRoQ0ZTdHJpbmdGdW5jdGlvbih2YWx1ZSk7CiAg ICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKLUpTU3RyaW5nUmVmIEpTU3RyaW5nQ3JlYXRlV2l0aFVU RjhDU3RyaW5nKGNvbnN0IGNoYXIqIHZhbHVlKQorV0VCS0lUX0FQSSBKU1N0cmluZ1JlZiBKU1N0 cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhjb25zdCBjaGFyKiB2YWx1ZSkKIHsKICAgICBpZiAo bV9qc1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZ0Z1bmN0aW9uKQogICAgICAgICByZXR1cm4g bV9qc1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZ0Z1bmN0aW9uKHZhbHVlKTsKICAgICByZXR1 cm4gbnVsbHB0cjsKIH0KIAotY29uc3QgSlNDaGFyKiBKU1N0cmluZ0dldENoYXJhY3RlcnNQdHIo SlNTdHJpbmdSZWYgdmFsdWUpCitXRUJLSVRfQVBJIGNvbnN0IEpTQ2hhciogSlNTdHJpbmdHZXRD aGFyYWN0ZXJzUHRyKEpTU3RyaW5nUmVmIHZhbHVlKQogewogICAgIGlmIChtX2pzU3RyaW5nR2V0 Q2hhcmFjdGVyc1B0ckZ1bmN0aW9uKQogICAgICAgICByZXR1cm4gbV9qc1N0cmluZ0dldENoYXJh Y3RlcnNQdHJGdW5jdGlvbih2YWx1ZSk7CiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKLXNpemVf dCBKU1N0cmluZ0dldExlbmd0aChKU1N0cmluZ1JlZiB2YWx1ZSkKK1dFQktJVF9BUEkgc2l6ZV90 IEpTU3RyaW5nR2V0TGVuZ3RoKEpTU3RyaW5nUmVmIHZhbHVlKQogewogICAgIGlmIChtX2pzU3Ry aW5nR2V0TGVuZ3RoRnVuY3Rpb24pCiAgICAgICAgIHJldHVybiBtX2pzU3RyaW5nR2V0TGVuZ3Ro RnVuY3Rpb24odmFsdWUpOwogICAgIHJldHVybiAwOwogfQogCi12b2lkIEpTU3RyaW5nUmVsZWFz ZShKU1N0cmluZ1JlZiB2YWx1ZSkKK1dFQktJVF9BUEkgdm9pZCBKU1N0cmluZ1JlbGVhc2UoSlNT dHJpbmdSZWYgdmFsdWUpCiB7CiAgICAgaWYgKG1fanNTdHJpbmdSZWxlYXNlRnVuY3Rpb24pCiAg ICAgICAgIHJldHVybiBtX2pzU3RyaW5nUmVsZWFzZUZ1bmN0aW9uKHZhbHVlKTsKIH0KIAotYm9v bCBKU1ZhbHVlSXNOdW1iZXIoSlNDb250ZXh0UmVmIGN0eCwgSlNWYWx1ZVJlZiB2YWx1ZSkKK1dF QktJVF9BUEkgYm9vbCBKU1ZhbHVlSXNOdW1iZXIoSlNDb250ZXh0UmVmIGN0eCwgSlNWYWx1ZVJl ZiB2YWx1ZSkKIHsKICAgICBpZiAobV9qc1ZhbHVlSXNOdW1iZXJGdW5jdGlvbikKICAgICAgICAg cmV0dXJuIG1fanNWYWx1ZUlzTnVtYmVyRnVuY3Rpb24oY3R4LCB2YWx1ZSk7CiAgICAgcmV0dXJu IGZhbHNlOwogfQogCi1ib29sIEpTVmFsdWVJc1N0cmluZyhKU0NvbnRleHRSZWYgY3R4LCBKU1Zh bHVlUmVmIHZhbHVlKQorV0VCS0lUX0FQSSBib29sIEpTVmFsdWVJc1N0cmluZyhKU0NvbnRleHRS ZWYgY3R4LCBKU1ZhbHVlUmVmIHZhbHVlKQogewogICAgIGlmIChtX2pzVmFsdWVJc1N0cmluZ0Z1 bmN0aW9uKQogICAgICAgICByZXR1cm4gbV9qc1ZhbHVlSXNTdHJpbmdGdW5jdGlvbihjdHgsIHZh bHVlKTsKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLUpTVmFsdWVSZWYgSlNWYWx1ZU1ha2VTdHJp bmcoSlNDb250ZXh0UmVmIGN0eCwgSlNTdHJpbmdSZWYgdmFsdWUpCitXRUJLSVRfQVBJIEpTVmFs dWVSZWYgSlNWYWx1ZU1ha2VTdHJpbmcoSlNDb250ZXh0UmVmIGN0eCwgSlNTdHJpbmdSZWYgdmFs dWUpCiB7CiAgICAgaWYgKG1fanNWYWx1ZU1ha2VTdHJpbmdGdW5jdGlvbikKICAgICAgICAgcmV0 dXJuIG1fanNWYWx1ZU1ha2VTdHJpbmdGdW5jdGlvbihjdHgsIHZhbHVlKTsKICAgICByZXR1cm4g bnVsbHB0cjsKIH0KIAotSlNWYWx1ZVJlZiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChKU0NvbnRleHRS ZWYgY3R4KQorV0VCS0lUX0FQSSBKU1ZhbHVlUmVmIEpTVmFsdWVNYWtlVW5kZWZpbmVkKEpTQ29u dGV4dFJlZiBjdHgpCiB7CiAgICAgaWYgKG1fanNWYWx1ZU1ha2VVbmRlZmluZWRGdW5jdGlvbikK ICAgICAgICAgcmV0dXJuIG1fanNWYWx1ZU1ha2VVbmRlZmluZWRGdW5jdGlvbihjdHgpOwogICAg IHJldHVybiBudWxscHRyOwogfQogCi1kb3VibGUgSlNWYWx1ZVRvTnVtYmVyKEpTQ29udGV4dFJl ZiBjdHgsIEpTVmFsdWVSZWYgdmFsdWUsIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbikKK1dFQktJVF9B UEkgZG91YmxlIEpTVmFsdWVUb051bWJlcihKU0NvbnRleHRSZWYgY3R4LCBKU1ZhbHVlUmVmIHZh bHVlLCBKU1ZhbHVlUmVmKiBleGNlcHRpb24pCiB7CiAgICAgaWYgKG1fanNWYWx1ZVRvTnVtYmVy RnVuY3Rpb24pCiAgICAgICAgIHJldHVybiBtX2pzVmFsdWVUb051bWJlckZ1bmN0aW9uKGN0eCwg dmFsdWUsIGV4Y2VwdGlvbik7CiAgICAgcmV0dXJuIDA7CiB9CiAKLUpTU3RyaW5nUmVmIEpTVmFs dWVUb1N0cmluZ0NvcHkoSlNDb250ZXh0UmVmIGN0eCwgSlNWYWx1ZVJlZiB2YWx1ZSwgSlNWYWx1 ZVJlZiogZXhjZXB0aW9uKQorV0VCS0lUX0FQSSBKU1N0cmluZ1JlZiBKU1ZhbHVlVG9TdHJpbmdD b3B5KEpTQ29udGV4dFJlZiBjdHgsIEpTVmFsdWVSZWYgdmFsdWUsIEpTVmFsdWVSZWYqIGV4Y2Vw dGlvbikKIHsKICAgICBpZiAobV9qc1ZhbHVlVG9TdHJpbmdDb3B5RnVuY3Rpb24pCiAgICAgICAg IHJldHVybiBtX2pzVmFsdWVUb1N0cmluZ0NvcHlGdW5jdGlvbihjdHgsIHZhbHVlLCBleGNlcHRp b24pOwpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViS2l0RExMLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC93aW4vV2ViS2l0RExMLmgJKHJldmlzaW9uIDIxMzc4NSkKKysrIFNvdXJj ZS9XZWJLaXQvd2luL1dlYktpdERMTC5oCSh3b3JraW5nIGNvcHkpCkBAIC01NiwzNyArNTYsNiBA QCBleHRlcm4gQ0xTSUQgZ1JlZ0NMU0lEc1tdOwogCiBXRUJLSVRfQVBJIHZvaWQgc2h1dERvd25X ZWJLaXQoKTsKIAotI2lmIGRlZmluZWQoREVQUkVDQVRFRF9FWFBPUlRfU1lNQk9MUykKLQotI2lu Y2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTT2JqZWN0UmVmLmg+Ci0KLS8vIEZvcmNlIHN5bWJvbHMg dG8gYmUgaW5jbHVkZWQgc28gd2UgY2FuIGV4cG9ydCB0aGVtIGZvciBsZWdhY3kgY2xpZW50cy4K LS8vIERFUFJFQ0FURUQhIFBlb3BsZSBzaG91bGQgZ2V0IHRoZXNlIHN5bWJvbHMgZnJvbSBKYXZh U2NyaXB0Q29yZS5kbGwsIG5vdCBXZWJLaXQuZGxsIQotdHlwZWRlZiBzdHJ1Y3QgT3BhcXVlSlND bGFzcyogSlNDbGFzc1JlZjsKLXR5cGVkZWYgY29uc3Qgc3RydWN0IE9wYXF1ZUpTQ29udGV4dCog SlNDb250ZXh0UmVmOwotdHlwZWRlZiBjb25zdCBzdHJ1Y3QgT3BhcXVlSlNWYWx1ZSogSlNWYWx1 ZVJlZjsKLXR5cGVkZWYgc3RydWN0IE9wYXF1ZUpTU3RyaW5nKiBKU1N0cmluZ1JlZjsKLXR5cGVk ZWYgd2NoYXJfdCBKU0NoYXI7Ci10eXBlZGVmIHVuc2lnbmVkIEpTUHJvcGVydHlBdHRyaWJ1dGVz OwotCi1XRUJLSVRfQVBJIEpTQ2xhc3NSZWYgSlNDbGFzc0NyZWF0ZShjb25zdCBKU0NsYXNzRGVm aW5pdGlvbiopOwotV0VCS0lUX0FQSSB2b2lkKiBKU09iamVjdEdldFByaXZhdGUoSlNPYmplY3RS ZWYpOwotV0VCS0lUX0FQSSBKU09iamVjdFJlZiBKU09iamVjdE1ha2UoSlNDb250ZXh0UmVmLCBK U0NsYXNzUmVmLCB2b2lkKik7Ci1XRUJLSVRfQVBJIHZvaWQgSlNPYmplY3RTZXRQcm9wZXJ0eShK U0NvbnRleHRSZWYsIEpTT2JqZWN0UmVmLCBKU1N0cmluZ1JlZiBwcm9wZXJ0eU5hbWUsIEpTVmFs dWVSZWYsIEpTUHJvcGVydHlBdHRyaWJ1dGVzLCBKU1ZhbHVlUmVmKiBleGNlcHRpb24pOwotV0VC S0lUX0FQSSBKU1N0cmluZ1JlZiBKU1N0cmluZ0NyZWF0ZVdpdGhDRlN0cmluZyhDRlN0cmluZ1Jl Zik7Ci1XRUJLSVRfQVBJIEpTU3RyaW5nUmVmIEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5n KGNvbnN0IGNoYXIqKTsKLVdFQktJVF9BUEkgY29uc3QgSlNDaGFyKiBKU1N0cmluZ0dldENoYXJh Y3RlcnNQdHIoSlNTdHJpbmdSZWYpOwotV0VCS0lUX0FQSSBzaXplX3QgSlNTdHJpbmdHZXRMZW5n dGgoSlNTdHJpbmdSZWYpOwotV0VCS0lUX0FQSSB2b2lkIEpTU3RyaW5nUmVsZWFzZShKU1N0cmlu Z1JlZik7Ci1XRUJLSVRfQVBJIGJvb2wgSlNWYWx1ZUlzTnVtYmVyKEpTQ29udGV4dFJlZiwgSlNW YWx1ZVJlZik7Ci1XRUJLSVRfQVBJIGJvb2wgSlNWYWx1ZUlzU3RyaW5nKEpTQ29udGV4dFJlZiwg SlNWYWx1ZVJlZik7Ci1XRUJLSVRfQVBJIEpTVmFsdWVSZWYgSlNWYWx1ZU1ha2VTdHJpbmcoSlND b250ZXh0UmVmLCBKU1N0cmluZ1JlZik7Ci1XRUJLSVRfQVBJIEpTVmFsdWVSZWYgSlNWYWx1ZU1h a2VVbmRlZmluZWQoSlNDb250ZXh0UmVmIGN0eCk7Ci1XRUJLSVRfQVBJIGRvdWJsZSBKU1ZhbHVl VG9OdW1iZXIoSlNDb250ZXh0UmVmLCBKU1ZhbHVlUmVmLCBKU1ZhbHVlUmVmKik7Ci1XRUJLSVRf QVBJIEpTU3RyaW5nUmVmIEpTVmFsdWVUb1N0cmluZ0NvcHkoSlNDb250ZXh0UmVmLCBKU1ZhbHVl UmVmLCBKU1ZhbHVlUmVmKiBleGNlcHRpb24pOwotLy8gRW5kCi0jZW5kaWYKLQogI2lmZGVmIF9f Y3BsdXNwbHVzCiB9CiAjZW5kaWYK