169533 2017-03-12 16:22:28 -0700 [GTK] Unbreak build with GTK+ >=3.20 after r213772 2017-03-12 17:34:44 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez berto bugs-noreply cgarcia commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1286965 0 aperez 2017-03-12 16:22:28 -0700 The EWS didn't catch the build failure because we use use GTK+ 3.16 in the Jhbuild. After submitting the patch for bug #169526 I made a build with the system's GTK+ and found this build failure: Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:571:49: error: cannot convert ‘GtkFileChooserNative* {aka _GtkFileChooserNative*}’ to ‘GtkNativeDialog* {aka _GtkNativeDialog*}’ for argument ‘1’ to ‘void gtk_native_dialog_set_modal(GtkNativeDialog*, gboolean)’ gtk_native_dialog_set_modal(dialog, TRUE); ^ The fix is straightforward and involves only adding a missing cast, I'm uploading a patch. 1286966 1 304205 aperez 2017-03-12 16:23:56 -0700 Created attachment 304205 Patch 1286967 2 commit-queue 2017-03-12 16:24:52 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1286979 3 mcatanzaro 2017-03-12 17:34:44 -0700 Committed r213776: <http://trac.webkit.org/changeset/213776> 304205 2017-03-12 16:23:56 -0700 2017-03-12 16:25:48 -0700 Patch bug-169533-20170313012354.patch text/plain 1794 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzNzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWI4NTUxZjAwZTExOGZh MDA2NWQyNzNhMTY5ZTJiZjE0NDg3MzkwMC4uOGJjNjA2YmE5MDU4ZGU5MWMxMWQ5ODRhNzE3Y2Ni MjgxNDMzYjMyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE3LTAzLTEyICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10g VW5icmVhayBidWlsZCB3aXRoIEdUSysgPj0zLjIwIGFmdGVyIHIyMTM3NzIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTUzMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViVmlldy5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3UnVuRmlsZUNob29zZXIp OiBBZGQgbWlzc2luZyBjYXN0LgorCisyMDE3LTAzLTEyICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJv ICA8YXBlcmV6QGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gRmlsZSBjaG9vc2VycyBzaG91 bGQgcnVuIGFzIG1vZGFsIGJ5IGRlZmF1bHQgaWYgcG9zc2libGUKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTUyNgogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCmluZGV4IDQ5OTA0M2I5 NTA2MDU4NmE4NzJmZjRmNjA5ZTg3ODMyMjE2NGQzNTUuLmU3NWQ0ODExODZiYzFlODM5OWIxNTYw Yjg2YmE4NTU4ZmNhNWQyNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCkBAIC01NjgsNyArNTY4LDcgQEAgc3RhdGljIGdib29s ZWFuIHdlYmtpdFdlYlZpZXdSdW5GaWxlQ2hvb3NlcihXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBX ZWJLaXRGaWxlQ2gKICAgICBHdGtGaWxlQ2hvb3Nlck5hdGl2ZSogZGlhbG9nID0gZ3RrX2ZpbGVf Y2hvb3Nlcl9uYXRpdmVfbmV3KGFsbG93c011bHRpcGxlU2VsZWN0aW9uID8gXygiU2VsZWN0IEZp bGVzIikgOiBfKCJTZWxlY3QgRmlsZSIpLAogICAgICAgICB0b3BsZXZlbCA/IEdUS19XSU5ET1co dG9wbGV2ZWwpIDogbnVsbHB0ciwgR1RLX0ZJTEVfQ0hPT1NFUl9BQ1RJT05fT1BFTiwgbnVsbHB0 ciwgbnVsbHB0cik7CiAgICAgaWYgKHRvcGxldmVsKQotICAgICAgICBndGtfbmF0aXZlX2RpYWxv Z19zZXRfbW9kYWwoZGlhbG9nLCBUUlVFKTsKKyAgICAgICAgZ3RrX25hdGl2ZV9kaWFsb2dfc2V0 X21vZGFsKEdUS19OQVRJVkVfRElBTE9HKGRpYWxvZyksIFRSVUUpOwogI2Vsc2UKICAgICBHdGtX aWRnZXQqIGRpYWxvZyA9IGd0a19maWxlX2Nob29zZXJfZGlhbG9nX25ldyhhbGxvd3NNdWx0aXBs ZVNlbGVjdGlvbiA/IF8oIlNlbGVjdCBGaWxlcyIpIDogXygiU2VsZWN0IEZpbGUiKSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0b3BsZXZlbCA/ IEdUS19XSU5ET1codG9wbGV2ZWwpIDogMCwK