169526 2017-03-12 11:29:30 -0700 [GTK] File choosers should run as modal by default if possible 2017-03-12 13:19:12 -0700 1 1 1 Unclassified WebKit WebKitGTK Other All All RESOLVED FIXED P2 Normal --- 1 aperez aperez berto bugs-noreply cgarcia commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1286926 0 aperez 2017-03-12 11:29:30 -0700 Right now file chooser dialogs are never run as modal by default. It would be desirable to try to obtain the GtkWindow where the GtkWebView is embedded, set it as parent of the dialogs, and enable running them as modal. 1286940 1 304203 aperez 2017-03-12 12:35:50 -0700 Created attachment 304203 Patch 1286941 2 commit-queue 2017-03-12 12:37:07 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1286942 3 304203 mcatanzaro 2017-03-12 12:38:05 -0700 Comment on attachment 304203 Patch Although possibly applications might not want this behavior, this definitely ought to be the default behavior to avoid unexpected bugs in applications. 1286945 4 304203 commit-queue 2017-03-12 13:19:07 -0700 Comment on attachment 304203 Patch Clearing flags on attachment: 304203 Committed r213772: <http://trac.webkit.org/changeset/213772> 1286946 5 commit-queue 2017-03-12 13:19:12 -0700 All reviewed patches have been landed. Closing bug. 304203 2017-03-12 12:35:50 -0700 2017-03-12 13:19:07 -0700 Patch bug-169526-20170312213548.patch text/plain 2341 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzNjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTc4N2UwZmMyMjQ3OWNj MWY4ZjZjMTk1OWM3ZDlkN2U2NjkzOTE1MC4uM2RjYWNmMjBkZDY5ZmFhOWM1MGNmYjk0MGZmMjI0 YjFlMDc0ZjcyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAzLTEyICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g RmlsZSBjaG9vc2VycyBzaG91bGQgcnVuIGFzIG1vZGFsIGJ5IGRlZmF1bHQgaWYgcG9zc2libGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTUyNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3UnVu RmlsZUNob29zZXIpOiBJZiBhIHRvcC1sZXZlbCB3aW5kb3cgY29udGFpbmluZyB0aGUgd2ViIHZp ZXcgaXMgZm91bmQsIGNhbGwKKyAgICAgICAgZ3RrX25hdGl2ZV9kaWFsb2dfc2V0X21vZGFsKCkg dG8gY29uZmlndXJlIHRoZSBkaWFsb2cgYWNjb3JkaW5nbHkuCisKIDIwMTctMDMtMDkgIEFkcmlh biBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBV c2UgR3RrRmlsZUNob29zZXJOYXRpdmUgZm9yIG9wZW4vc2F2ZSBkaWFsb2dzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCmluZGV4IDk5 ZTI5OGE4MjY3M2E2MWEwYmNkMzg0MTBhMThjNzJmMmVmOWFiNDIuLmNhYWJjZDNkZmMyZjM2NTEy M2E3ODg0MmE2MjI0NzkyMzJkNWVmYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCkBAIC01NjcsNiArNTY3LDggQEAgc3RhdGlj IGdib29sZWFuIHdlYmtpdFdlYlZpZXdSdW5GaWxlQ2hvb3NlcihXZWJLaXRXZWJWaWV3KiB3ZWJW aWV3LCBXZWJLaXRGaWxlQ2gKICNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigzLCAyMCwgMCkKICAgICBH dGtGaWxlQ2hvb3Nlck5hdGl2ZSogZGlhbG9nID0gZ3RrX2ZpbGVfY2hvb3Nlcl9uYXRpdmVfbmV3 KGFsbG93c011bHRpcGxlU2VsZWN0aW9uID8gXygiU2VsZWN0IEZpbGVzIikgOiBfKCJTZWxlY3Qg RmlsZSIpLAogICAgICAgICB0b3BsZXZlbCA/IEdUS19XSU5ET1codG9wbGV2ZWwpIDogbnVsbHB0 ciwgR1RLX0ZJTEVfQ0hPT1NFUl9BQ1RJT05fT1BFTiwgbnVsbHB0ciwgbnVsbHB0cik7CisgICAg aWYgKHRvcGxldmVsKQorICAgICAgICBndGtfbmF0aXZlX2RpYWxvZ19zZXRfbW9kYWwoZGlhbG9n LCBUUlVFKTsKICNlbHNlCiAgICAgR3RrV2lkZ2V0KiBkaWFsb2cgPSBndGtfZmlsZV9jaG9vc2Vy X2RpYWxvZ19uZXcoYWxsb3dzTXVsdGlwbGVTZWxlY3Rpb24gPyBfKCJTZWxlY3QgRmlsZXMiKSA6 IF8oIlNlbGVjdCBGaWxlIiksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgdG9wbGV2ZWwgPyBHVEtfV0lORE9XKHRvcGxldmVsKSA6IDAsCkBAIC01 NzQsNiArNTc2LDggQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdFdlYlZpZXdSdW5GaWxlQ2hvb3Nl cihXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJLaXRGaWxlQ2gKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHVEtfU1RPQ0tfQ0FOQ0VMLCBHVEtf UkVTUE9OU0VfQ0FOQ0VMLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIEdUS19TVE9DS19PUEVOLCBHVEtfUkVTUE9OU0VfQUNDRVBULAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwpOworICAg IGlmICh0b3BsZXZlbCkKKyAgICAgICAgZ3RrX3dpbmRvd19zZXRfbW9kYWwoR1RLX1dJTkRPVyhk aWFsb2cpLCBUUlVFKTsKICNlbmRpZgogCiAgICAgaWYgKEd0a0ZpbGVGaWx0ZXIqIGZpbHRlciA9 IHdlYmtpdF9maWxlX2Nob29zZXJfcmVxdWVzdF9nZXRfbWltZV90eXBlc19maWx0ZXIocmVxdWVz dCkpCg==