169525 2017-03-12 10:49:23 -0700 [iOS] Some more -respondsToSelector: checks are unnecessary 2017-03-12 11:47:42 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz commit-queue thorton oldest_to_newest 1286915 0 mitz 2017-03-12 10:49:23 -0700 <https://trac.webkit.org/r213643> introduced some unnecessary -respondsToSelector: checks. Patch forthcoming. 1286917 1 304198 mitz 2017-03-12 10:53:03 -0700 Created attachment 304198 Remove runtime checks 1286933 2 304198 commit-queue 2017-03-12 11:47:39 -0700 Comment on attachment 304198 Remove runtime checks Clearing flags on attachment: 304198 Committed r213771: <http://trac.webkit.org/changeset/213771> 1286934 3 commit-queue 2017-03-12 11:47:42 -0700 All reviewed patches have been landed. Closing bug. 304198 2017-03-12 10:53:03 -0700 2017-03-12 11:47:39 -0700 Remove runtime checks bug-169525-20170312105302.patch text/plain 5557 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzc3MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTAzLTEyICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gU29tZSBtb3JlIC1yZXNw b25kc1RvU2VsZWN0b3I6IGNoZWNrcyBhcmUgdW5uZWNlc3NhcnkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTUyNQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQ SS5oOiBNb3ZlZCByZWRlY2xhcmF0aW9ucyBvZiBtZXRob2RzIHRoYXQgYXJlIGRlY2xhcmVkIGlu IHRoZQorICAgICAgICAgIEFwcGxlIGludGVybmFsIFNESyBpbnRvIHRoZSAjaWYgIVVTRShBUFBM RV9JTlRFUk5BTF9TREspIHNlY3Rpb24uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9pbml0aWFsaXplV2l0aENvbmZp Z3VyYXRpb246XSk6IFJlcGxhY2VkIHVubmVjZXNzYXJ5IC1yZXNwb25kc1RvU2VsZWN0b3I6Cisg ICAgICAgICAgY2hlY2sgd2l0aCBjb21waWxlLXRpbWUgY2hlY2sgZm9yIHRoZSBkZXBsb3ltZW50 IHRhcmdldC4KKyAgICAgICAgKC1bV0tXZWJWaWV3IF9jb21wdXRlZENvbnRlbnRJbnNldF0pOiBE aXR0by4KKyAgICAgICAgKGFjdGl2ZU1pbmltdW1MYXlvdXRTaXplKTogRGl0dG8uCisgICAgICAg ICgtW1dLV2ViVmlldyBzYWZlQXJlYUluc2V0c0RpZENoYW5nZV0pOiBEaXR0by4KKwogMjAxNy0w My0xMSAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAg ICAgIEVuYWJsZSBhc3luYyBpbWFnZSBkZWNvZGluZyBmb3IgbGFyZ2UgaW1hZ2VzCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCShyZXZpc2lvbiAyMTM3 NjkpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgJKHdvcmtp bmcgY29weSkKQEAgLTMxNCw2ICszMTQsMTAgQEAgdHlwZWRlZiBlbnVtIHsKIEBwcm9wZXJ0eSAo bm9uYXRvbWljKSBDR0Zsb2F0IGhvcml6b250YWxTY3JvbGxEZWNlbGVyYXRpb25GYWN0b3I7CiBA cHJvcGVydHkgKG5vbmF0b21pYykgQ0dGbG9hdCB2ZXJ0aWNhbFNjcm9sbERlY2VsZXJhdGlvbkZh Y3RvcjsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgQk9PTCBfaXNJbnRlcnJ1cHRp bmdEZWNlbGVyYXRpb247CisjaWYgX19JUEhPTkVfT1NfVkVSU0lPTl9NQVhfQUxMT1dFRCA+PSAx MTAwMDAKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldEVkZ2VzU2Nyb2xsaW5nQ29u dGVudEludG9TYWZlQXJlYTopIFVJUmVjdEVkZ2UgX2VkZ2VzU2Nyb2xsaW5nQ29udGVudEludG9T YWZlQXJlYTsKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgVUlFZGdlSW5zZXRzIF9z eXN0ZW1Db250ZW50SW5zZXQ7CisjZW5kaWYKIEBlbmQKIAogQGludGVyZmFjZSBOU1N0cmluZyAo VUlLaXREZXRhaWxzKQpAQCAtNDU1LDYgKzQ1OSw5IEBAIHR5cGVkZWYgTlNfRU5VTSAoTlNJbnRl Z2VyLCBfVUlCYWNrZHJvcE0KIC0gKHZvaWQpc2V0U2l6ZTooQ0dTaXplKXNpemU7CiBAcHJvcGVy dHkgKG5vbmF0b21pYywgYXNzaWduLCBzZXR0ZXI9X3NldEJhY2tkcm9wTWFza1ZpZXdGbGFnczop IE5TSW50ZWdlciBfYmFja2Ryb3BNYXNrVmlld0ZsYWdzOwogLSAodm9pZClfcG9wdWxhdGVBcmNo aXZlZFN1YnZpZXdzOihOU011dGFibGVTZXQgKillbmNvZGVkVmlld3M7CisjaWYgX19JUEhPTkVf T1NfVkVSU0lPTl9NQVhfQUxMT1dFRCA+PSAxMTAwMDAKKy0gKHZvaWQpc2FmZUFyZWFJbnNldHNE aWRDaGFuZ2U7CisjZW5kaWYKIEBlbmQKIAogQGludGVyZmFjZSBVSVdlYlNlbGVjdGlvblZpZXcg OiBVSVZpZXcKQEAgLTg3MywxNSArODgwLDYgQEAgdHlwZWRlZiBlbnVtIHsKIC0gKFVJUmVzcG9u ZGVyICopZmlyc3RSZXNwb25kZXI7CiBAZW5kCiAKLUBpbnRlcmZhY2UgVUlWaWV3ICgpCi0tICh2 b2lkKXNhZmVBcmVhSW5zZXRzRGlkQ2hhbmdlOwotQGVuZAotCi1AaW50ZXJmYWNlIFVJU2Nyb2xs VmlldyAoKQotQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0RWRnZXNTY3JvbGxpbmdD b250ZW50SW50b1NhZmVBcmVhOikgVUlSZWN0RWRnZSBfZWRnZXNTY3JvbGxpbmdDb250ZW50SW50 b1NhZmVBcmVhOwotQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBVSUVkZ2VJbnNldHMg X3N5c3RlbUNvbnRlbnRJbnNldDsKLUBlbmQKLQogV1RGX0VYVEVSTl9DX0JFR0lOCiAKIEJPT0wg VUlLZXlib2FyZEVuYWJsZWRJbnB1dE1vZGVzQWxsb3dPbmVUb01hbnlTaG9ydGN1dHMoKTsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1t CShyZXZpc2lvbiAyMTM3NjkpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTA4LDggKzUwOCw5IEBAICAgICAvLyBX ZSBhcmUgaW4gdGhlIFZpZXcncyBpbml0aWFsaXphdGkKICAgICBbX3Njcm9sbFZpZXcgc2V0SW50 ZXJuYWxEZWxlZ2F0ZTpzZWxmXTsKICAgICBbX3Njcm9sbFZpZXcgc2V0Qm91bmNlc1pvb206WUVT XTsKIAotICAgIGlmIChbX3Njcm9sbFZpZXcgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihf c2V0RWRnZXNTY3JvbGxpbmdDb250ZW50SW50b1NhZmVBcmVhOildKQotICAgICAgICBbX3Njcm9s bFZpZXcgX3NldEVkZ2VzU2Nyb2xsaW5nQ29udGVudEludG9TYWZlQXJlYTpVSVJlY3RFZGdlQWxs XTsKKyNpZiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMTAwMDAKKyAgICBb X3Njcm9sbFZpZXcgX3NldEVkZ2VzU2Nyb2xsaW5nQ29udGVudEludG9TYWZlQXJlYTpVSVJlY3RF ZGdlQWxsXTsKKyNlbmRpZgogCiAgICAgW3NlbGYgYWRkU3Vidmlldzpfc2Nyb2xsVmlldy5nZXQo KV07CiAKQEAgLTEzNTIsMTMgKzEzNTMsMTMgQEAgLSAoVUlFZGdlSW5zZXRzKV9jb21wdXRlZENv bnRlbnRJbnNldAogCiAgICAgVUlFZGdlSW5zZXRzIGluc2V0cyA9IFtfc2Nyb2xsVmlldyBjb250 ZW50SW5zZXRdOwogCi0gICAgaWYgKFtfc2Nyb2xsVmlldyByZXNwb25kc1RvU2VsZWN0b3I6QHNl bGVjdG9yKF9zeXN0ZW1Db250ZW50SW5zZXQpXSkgewotICAgICAgICBVSUVkZ2VJbnNldHMgc3lz dGVtSW5zZXRzID0gW19zY3JvbGxWaWV3IF9zeXN0ZW1Db250ZW50SW5zZXRdOwotICAgICAgICBp bnNldHMudG9wICs9IHN5c3RlbUluc2V0cy50b3A7Ci0gICAgICAgIGluc2V0cy5ib3R0b20gKz0g c3lzdGVtSW5zZXRzLmJvdHRvbTsKLSAgICAgICAgaW5zZXRzLmxlZnQgKz0gc3lzdGVtSW5zZXRz LmxlZnQ7Ci0gICAgICAgIGluc2V0cy5yaWdodCArPSBzeXN0ZW1JbnNldHMucmlnaHQ7Ci0gICAg fQorI2lmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDExMDAwMAorICAgIFVJ RWRnZUluc2V0cyBzeXN0ZW1JbnNldHMgPSBbX3Njcm9sbFZpZXcgX3N5c3RlbUNvbnRlbnRJbnNl dF07CisgICAgaW5zZXRzLnRvcCArPSBzeXN0ZW1JbnNldHMudG9wOworICAgIGluc2V0cy5ib3R0 b20gKz0gc3lzdGVtSW5zZXRzLmJvdHRvbTsKKyAgICBpbnNldHMubGVmdCArPSBzeXN0ZW1JbnNl dHMubGVmdDsKKyAgICBpbnNldHMucmlnaHQgKz0gc3lzdGVtSW5zZXRzLnJpZ2h0OworI2VuZGlm CiAKICAgICByZXR1cm4gaW5zZXRzOwogfQpAQCAtMjIxNSwxMiArMjIxNiwxMiBAQCBzdGF0aWMg V2ViQ29yZTo6RmxvYXRTaXplIGFjdGl2ZU1pbmltdW1MCiAgICAgaWYgKHdlYlZpZXctPl9vdmVy cmlkZXNNaW5pbXVtTGF5b3V0U2l6ZSkKICAgICAgICAgcmV0dXJuIFdlYkNvcmU6OkZsb2F0U2l6 ZSh3ZWJWaWV3LT5fbWluaW11bUxheW91dFNpemVPdmVycmlkZSk7CiAKLSAgICBpZiAoW3dlYlZp ZXctPl9zY3JvbGxWaWV3IHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3N5c3RlbUNvbnRl bnRJbnNldCldKSB7Ci0gICAgICAgIFVJRWRnZUluc2V0cyBzeXN0ZW1Db250ZW50SW5zZXQgPSBb d2ViVmlldy0+X3Njcm9sbFZpZXcgX3N5c3RlbUNvbnRlbnRJbnNldF07Ci0gICAgICAgIHJldHVy biBXZWJDb3JlOjpGbG9hdFNpemUoVUlFZGdlSW5zZXRzSW5zZXRSZWN0KENHUmVjdE1ha2UoMCwg MCwgYm91bmRzLnNpemUud2lkdGgsIGJvdW5kcy5zaXplLmhlaWdodCksIHN5c3RlbUNvbnRlbnRJ bnNldCkuc2l6ZSk7Ci0gICAgfQotCisjaWYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTEwMDAwCisgICAgVUlFZGdlSW5zZXRzIHN5c3RlbUNvbnRlbnRJbnNldCA9IFt3ZWJW aWV3LT5fc2Nyb2xsVmlldyBfc3lzdGVtQ29udGVudEluc2V0XTsKKyAgICByZXR1cm4gV2ViQ29y ZTo6RmxvYXRTaXplKFVJRWRnZUluc2V0c0luc2V0UmVjdChDR1JlY3RNYWtlKDAsIDAsIGJvdW5k cy5zaXplLndpZHRoLCBib3VuZHMuc2l6ZS5oZWlnaHQpLCBzeXN0ZW1Db250ZW50SW5zZXQpLnNp emUpOworI2Vsc2UKICAgICByZXR1cm4gV2ViQ29yZTo6RmxvYXRTaXplKGJvdW5kcy5zaXplKTsK KyNlbmRpZgogfQogCiAtICh2b2lkKV9mcmFtZU9yQm91bmRzQ2hhbmdlZApAQCAtMjI2NiwxMyAr MjI2NywxNCBAQCAtIChCT09MKV9zY3JvbGxWaWV3SXNSdWJiZXJCYW5kaW5nCiAgICAgcmV0dXJu ICFwb2ludHNFcXVhbEluRGV2aWNlUGl4ZWxzKGNvbnRlbnRPZmZzZXQsIGJvdW5kZWRPZmZzZXQs IGRldmljZVNjYWxlRmFjdG9yKTsKIH0KIAorI2lmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JF UVVJUkVEID49IDExMDAwMAogLSAodm9pZClzYWZlQXJlYUluc2V0c0RpZENoYW5nZQogewotICAg IGlmIChbc3VwZXIgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihzYWZlQXJlYUluc2V0c0Rp ZENoYW5nZSldKQotICAgICAgICBbc3VwZXIgc2FmZUFyZWFJbnNldHNEaWRDaGFuZ2VdOworICAg IFtzdXBlciBzYWZlQXJlYUluc2V0c0RpZENoYW5nZV07CiAKICAgICBbc2VsZiBfc2NoZWR1bGVW aXNpYmxlQ29udGVudFJlY3RVcGRhdGVdOwogfQorI2VuZGlmCiAKIC0gKHZvaWQpX3NjaGVkdWxl VmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRlCiB7Cg==