169522 2017-03-11 22:21:39 -0800 REGRESSION (r211657): bisect-builds doesn't work 2017-05-15 16:08:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified NEW P2 Normal --- 1 ap webkit-unassigned ddkilzer lforschler mitz oldest_to_newest 1286888 0 ap 2017-03-11 22:21:39 -0800 $ bisect-builds Undefined subroutine &main::safariPathFromSafariBundle called at Tools/Scripts/bisect-builds line 132. 1286890 1 mitz 2017-03-11 22:23:04 -0800 For what it’s worth, I’m not sure it was working prior to that revision either (I think it was just failing differently). 1286893 2 304189 ap 2017-03-11 22:42:43 -0800 Created attachment 304189 fix (doesn't make it work) This looks like what it should take to fix it, but the script still doesn't work: $ bisect-builds Requires Mac OS X 10.4 (Tiger) or later at /Users/ap/Safari/OpenSource/Tools/Scripts/bisect-builds line 391. I don't understand the code that produces this error. Confirmed that $osxVersionString and $safariVersionString are as expected (10.12.3 and 10.0.3). 1286894 3 mitz 2017-03-11 22:44:40 -0800 Looks like the script hasn’t been updated for macOS Sierra. 1286895 4 304189 ap 2017-03-11 22:45:18 -0800 Comment on attachment 304189 fix (doesn't make it work) View in context: https://bugs.webkit.org/attachment.cgi?id=304189&action=review > Tools/Scripts/bisect-builds:75 > +my $safariPath = safariPath(); Actually, "/Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment" may be even more appropriate here. When bisecting with nightlies, we don't want a locally built Safari. 1286897 5 ap 2017-03-11 22:56:13 -0800 > Looks like the script hasn’t been updated for macOS Sierra. Good point. Adding the support still doesn't make it work though. I confirmed that this nightly build works when opened manually. if ($osxVersion ge v10.12 && $osxVersion lt v10.13) { @files = grep { $_->{rev} >= 205582 } @files; } elsif ($osxVersion ge v10.11 && $osxVersion lt v10.12) { $ bisect-builds Works: r205582 Fails: r213762 Checking revision r209345 (200 builds left to test after this)... Downloading WebKit-SVN-r209345.dmg to /Users/ap/Library/Caches/WebKit-Nightlies/trunk... ######################################################################## 100.0% Mounting disk image and running WebKit... LSOpenURLsWithRole() failed for the application /Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment with error -10810. Did the bug reproduce in r209345 (yes/no/retry/broken)? ^C 1286898 6 ap 2017-03-11 22:57:08 -0800 "This" being r209345. I didn't confirm whether r205582 works, I just know that this is when the nightlies got larger. 1286899 7 mitz 2017-03-11 22:59:24 -0800 (In reply to comment #5) > LSOpenURLsWithRole() failed for the application > /Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment with > error -10810. This is probably because $isBundle is true even thought the above path isn’t a bundle. 304189 2017-03-11 22:42:43 -0800 2017-03-11 22:42:43 -0800 fix (doesn't make it work) bisect-builds.txt text/plain 2588 ap SW5kZXg6IFRvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxkcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL2Jpc2VjdC1idWlsZHMJKHJldmlzaW9uIDIxMzc1MSkKKysrIFRvb2xzL1NjcmlwdHMv YmlzZWN0LWJ1aWxkcwkod29ya2luZyBjb3B5KQpAQCAtMzIsNyArMzIsNiBAQAogIwogIyAkYnJh bmNoID0gImJyYW5jaC1uYW1lIjsKICMgJG5pZ2h0bHlEb3dubG9hZERpcmVjdG9yeSA9ICJ+L3Bh dGgvdG8vbmlnaHRseS9kb3dubG9hZHMiOwotIyAkc2FmYXJpUGF0aCA9ICIvcGF0aC90by9TYWZh cmkuYXBwIjsKIAogdXNlIHN0cmljdDsKIApAQCAtNDUsNyArNDQsNyBAQCB1c2UgR2V0b3B0OjpM b25nOwogdXNlIFRpbWU6OkhpUmVzIHF3KHVzbGVlcCk7CiAKIHVzZSBsaWIgJEZpbmRCaW46OkJp bjsKLXVzZSB3ZWJraXRkaXJzIHF3KHNhZmFyaVBhdGhGcm9tU2FmYXJpQnVuZGxlKTsKK3VzZSB3 ZWJraXRkaXJzIHF3KHNhZmFyaVBhdGgpOwogCiB1c2UgY29uc3RhbnQgewogICAgIFBST01QVF9S RVNQT05TRV9CUk9LRU4gPT4gLTEsCkBAIC03Myw3ICs3Miw3IEBAIGxvYWRTZXR0aW5ncygpOwog bXkgJXZhbGlkQnJhbmNoZXMgPSBtYXAgeyAkXyA9PiAxIH0gcXcoZmVhdHVyZS1icmFuY2ggdHJ1 bmspOwogbXkgJGJyYW5jaCA9ICRTZXR0aW5nczo6YnJhbmNoOwogbXkgJG5pZ2h0bHlEb3dubG9h ZERpcmVjdG9yeSA9ICRTZXR0aW5nczo6bmlnaHRseURvd25sb2FkRGlyZWN0b3J5OwotbXkgJHNh ZmFyaVBhdGggPSAkU2V0dGluZ3M6OnNhZmFyaVBhdGg7CitteSAkc2FmYXJpUGF0aCA9IHNhZmFy aVBhdGgoKTsKIG15ICRhcHBsaWNhdGlvblBhdGg7CiAKIG15IEBuaWdodGxpZXM7CkBAIC05Nyw3 ICs5Niw2IEBAIG15ICRyZXN1bHQgPSBHZXRPcHRpb25zKAogICAgICJsfGxvY2FsISIgICAgICAg ICAgICAgICA9PiBcJGxvY2FsT25seSwKICAgICAicHxwcm9ncmVzc2lvbiEiICAgICAgICAgPT4g XCRpc1Byb2dyZXNzaW9uLAogICAgICJyfHJldmlzaW9ucz1zIiAgICAgICAgICA9PiBcJnBhcnNl UmV2aXNpb25zLAotICAgICJzYWZhcmktcGF0aD1zIiAgICAgICAgICA9PiBcJHNhZmFyaVBhdGgs CiAgICAgInN8c2FuaXR5LWNoZWNrISIgICAgICAgID0+IFwkc2FuaXR5Q2hlY2ssCiApOwogJHRl c3RVUkwgPSBzaGlmdCBAQVJHVjsKQEAgLTEyMCwxNiArMTE4LDEyIEBAIGlmICghJHJlc3VsdCB8 fCAkc2hvd0hlbHAgfHwgc2NhbGFyKEBBUkcKICAgWy1sfC0tbG9jYWxdICAgICAgICAgICAgICAg ICAgIG9ubHkgdXNlIGxvY2FsIChhbHJlYWR5IGRvd25sb2FkZWQpIG5pZ2h0bGllcwogICBbLXB8 LS1wcm9ncmVzc2lvbl0gICAgICAgICAgICAgc2VhcmNoaW5nIGZvciBhIHByb2dyZXNzaW9uLCBu b3QgYSByZWdyZXNzaW9uCiAgIFstcnwtLXJldmlzaW9uIE1bOk5dXSAgICAgICAgICBzcGVjaWZ5 IHN0YXJ0aW5nIChhbmQgb3B0aW9uYWwgZW5kaW5nKSByZXZpc2lvbnMgdG8gc2VhcmNoCi0gIFst LXNhZmFyaS1wYXRoIHBhdGhdICAgICAgICAgICBwYXRoIHRvIFNhZmFyaSBhcHBsaWNhdGlvbiBi dW5kbGUgKGRlZmF1bHQ6IC9BcHBsaWNhdGlvbnMvU2FmYXJpLmFwcCkKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICogW0RFUFJFQ0FURURdOiBUaGUgLWEvLS1hcHBsaWNhdGlvbiBh cmd1bWVudCB3aWxsIG92ZXJyaWRlIHRoaXMgYXJndW1lbnQsIGlmIGJvdGggYXJlIHNldC4KICAg Wy1zfC0tc2FuaXR5LWNoZWNrXSAgICAgICAgICAgIHZlcmlmeSBib3RoIHN0YXJ0aW5nIGFuZCBl bmRpbmcgcmV2aXNpb25zIGJlZm9yZSBiaXNlY3RpbmcKIEVORAogICAgIHByaW50IFNUREVSUiBz aGFyZWRDb21tYW5kTGluZU9wdGlvbnNVc2FnZShicmFja2V0cyA9PiAxLCBpbmRlbnQgPT4gMiwg c3dpdGNoV2lkdGggPT4gMzApOwogICAgIGV4aXQgMTsKIH0KIAotJHNhZmFyaVBhdGggPSBnbG9i KCRzYWZhcmlQYXRoKSBpZiAkc2FmYXJpUGF0aCA9fiAvXn4vOwotJHNhZmFyaVBhdGggPSBzYWZh cmlQYXRoRnJvbVNhZmFyaUJ1bmRsZSgkc2FmYXJpUGF0aCkgaWYgJHNhZmFyaVBhdGggPX4gbSNc LmFwcC8qIzsKICRhcHBsaWNhdGlvblBhdGggPSAkYXBwbGljYXRpb25QYXRoID8gRmlsZTo6U3Bl Yy0+cmVsMmFicygkYXBwbGljYXRpb25QYXRoKSA6ICRzYWZhcmlQYXRoOwogCiBteSAkbmlnaHRs eVdlYlNpdGUgPSAiaHR0cHM6Ly9uaWdodGx5LndlYmtpdC5vcmciOwpAQCAtMzE3LDcgKzMxMSw2 IEBAIHN1YiBsb2FkU2V0dGluZ3MoKQogCiAgICAgb3VyICRicmFuY2ggPSAidHJ1bmsiOwogICAg IG91ciAkbmlnaHRseURvd25sb2FkRGlyZWN0b3J5ID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKCRFTlZ7 SE9NRX0sICJMaWJyYXJ5L0NhY2hlcy9XZWJLaXQtTmlnaHRsaWVzIik7Ci0gICAgb3VyICRzYWZh cmlQYXRoID0gIi9BcHBsaWNhdGlvbnMvU2FmYXJpLmFwcCI7CiAKICAgICBteSAkcmNmaWxlID0g RmlsZTo6U3BlYy0+Y2F0ZGlyKCRFTlZ7SE9NRX0sICIuYmlzZWN0LWJ1aWxkc3JjIik7CiAgICAg cmV0dXJuIGlmICEtZiAkcmNmaWxlOwo=