169520 2017-03-11 22:06:13 -0800 Structure::willStoreValueSlow needs to keep the property table alive until the end 2017-03-12 15:58:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1286876 0 fpizlo 2017-03-11 22:06:13 -0800 Patch forthcoming. 1286879 1 304186 fpizlo 2017-03-11 22:09:10 -0800 Created attachment 304186 the patch 1286884 2 commit-queue 2017-03-11 22:12:23 -0800 Attachment 304186 did not pass style-queue: ERROR: Source/JavaScriptCore/heap/HeapCell.h:76: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1286896 3 304186 msaboff 2017-03-11 22:55:12 -0800 Comment on attachment 304186 the patch r=me You may want to add that you're keeping this alive for the conservative scan. 1286907 4 304193 fpizlo 2017-03-12 10:00:35 -0700 Created attachment 304193 patch for landing Checking windows ews 1286908 5 commit-queue 2017-03-12 10:03:16 -0700 Attachment 304193 did not pass style-queue: ERROR: Source/JavaScriptCore/heap/HeapCell.h:76: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1286962 6 fpizlo 2017-03-12 15:58:44 -0700 Landed in r213773. 304186 2017-03-11 22:09:10 -0800 2017-03-12 10:00:35 -0700 the patch blah.patch text/plain 3372 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjEzNzY1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE3LTAzLTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg U3RydWN0dXJlOjp3aWxsU3RvcmVWYWx1ZVNsb3cgbmVlZHMgdG8ga2VlcCB0aGUgcHJvcGVydHkg dGFibGUgYWxpdmUgdW50aWwgdGhlIGVuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY5NTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2UgdXNlIHBvaW50ZXJzIGxvZ2ljYWxseSBpbnRlcmlvciB0byBg cHJvcGVydHlUYWJsZWAgYWZ0ZXIgZG9pbmcgYSBHQy4gV2UgbmVlZCB0byBwcmV2ZW50IHRoZQor ICAgICAgICBjb21waWxlciBmcm9tIG9wdGltaXppbmcgYXdheSBwb2ludGVycyB0byBgcHJvcGVy dHlUYWJsZWAuCisgICAgICAgIAorICAgICAgICAqIGhlYXAvSGVhcENlbGwuY3BwOgorICAgICAg ICAoSlNDOjpIZWFwQ2VsbDo6dXNlKToKKyAgICAgICAgKiBoZWFwL0hlYXBDZWxsLmg6CisgICAg ICAgIChKU0M6OkhlYXBDZWxsOjp1c2UpOiBJbnRyb2R1Y2UgQVBJIGZvciBrZWVwaW5nIGEgcG9p bnRlciBhbGl2ZSB1bnRpbCBzb21lIHBvaW50IGluIGV4ZWN1dGlvbi4KKyAgICAgICAgKiBydW50 aW1lL1N0cnVjdHVyZS5jcHA6CisgICAgICAgIChKU0M6OlN0cnVjdHVyZTo6d2lsbFN0b3JlVmFs dWVTbG93KTogVXNlIEhlYXBDZWxsOjp1c2UoKSB0byBrZWVwIHRoZSBwb2ludGVyIGFsaXZlLgor CiAyMDE3LTAzLTExICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJH UFUgcHJvdG90eXBlIC0gRnJvbnQtRW5kCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9IZWFwQ2VsbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SGVhcENlbGwuY3BwCShyZXZpc2lvbiAyMTM3NTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9IZWFwQ2VsbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICog Q29weXJpZ2h0IChDKSAyMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENv cHlyaWdodCAoQykgMjAxNi0yMDE3IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAq CiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3 aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0 aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMjgsNiArMjgsMTYgQEAKIAogI2luY2x1 ZGUgPHd0Zi9QcmludFN0cmVhbS5oPgogCituYW1lc3BhY2UgSlNDIHsKKworI2lmICFDT01QSUxF UihHQ0NfT1JfQ0xBTkcpCit2b2lkIEhlYXBDZWxsOjp1c2UoKSBjb25zdAoreworfQorI2VuZGlm CisKK30gLy8gbmFtZXNwYWNlIEpTQworCiBuYW1lc3BhY2UgV1RGIHsKIAogdXNpbmcgbmFtZXNw YWNlIEpTQzsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXBDZWxsLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcENlbGwuaAkocmV2aXNp b24gMjEzNzU4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcENlbGwuaAkod29y a2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTYgQXBw bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE2LTIwMTcg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCkBAIC02Niw2ICs2NiwxOCBAQCBwdWJsaWM6CiAgICAgQWxsb2NhdG9yQXR0cmlidXRl cyBhbGxvY2F0b3JBdHRyaWJ1dGVzKCkgY29uc3Q7CiAgICAgRGVzdHJ1Y3Rpb25Nb2RlIGRlc3Ry dWN0aW9uTW9kZSgpIGNvbnN0OwogICAgIEtpbmQgY2VsbEtpbmQoKSBjb25zdDsKKyAgICAKKyAg ICAvLyBDYWxsIHVzZSgpIGFmdGVyIHRoZSBsYXN0IHBvaW50IHdoZXJlIHlvdSBuZWVkIGEgcG9p bnRlciB0byBiZSBrZXB0IGFsaXZlLiBZb3UgdXN1YWxseSBkb24ndCBuZWVkCisgICAgLy8gdG8g dXNlIHRoaXMsIGJ1dCBpdCBtaWdodCBiZSBuZWNlc3NhcnkgaWYgeW91J3JlIG90aGVyd2lzZSBy ZWZlcnJpbmcgdG8gYW4gb2JqZWN0J3MgaW5uYXJkcyBidXQKKyAgICAvLyBub3QgdGhlIG9iamVj dCBpdHNlbGYuCisjaWYgQ09NUElMRVIoR0NDX09SX0NMQU5HKQorICAgIHZvaWQgdXNlKCkgY29u c3QKKyAgICB7CisgICAgICAgIGFzbSB2b2xhdGlsZSAoIiIgOiA6ICJyIih0aGlzKSA6ICJtZW1v cnkiKTsKKyAgICB9CisjZWxzZQorICAgIHZvaWQgdXNlKCk7CisjZW5kaWYKIH07CiAKIH0gLy8g bmFtZXNwYWNlIEpTQwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0 dXJlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1 Y3R1cmUuY3BwCShyZXZpc2lvbiAyMTM3NTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TdHJ1Y3R1cmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MTgsNiArOTE4LDggQEAgdm9p ZCBTdHJ1Y3R1cmU6OndpbGxTdG9yZVZhbHVlU2xvdygKICAgICAgICAgdGFibGUtPm1ha2VUb3Ao dm0sIHByb3BlcnR5TmFtZSwgYWdlKTsKICAgICAgICAgZW50cnktPmhhc0luZmVycmVkVHlwZSA9 IGZhbHNlOwogICAgIH0KKyAgICAKKyAgICBwcm9wZXJ0eVRhYmxlLT51c2UoKTsgLy8gVGhpcyBt YWtlcyBpdCBzYWZlIHRvIHVzZSBlbnRyeSBhYm92ZS4KIH0KIAogI2lmIERVTVBfUFJPUEVSVFlN QVBfU1RBVFMK 304193 2017-03-12 10:00:35 -0700 2017-03-12 10:00:35 -0700 patch for landing blah.patch text/plain 3383 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjEzNzY1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE3LTAzLTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg U3RydWN0dXJlOjp3aWxsU3RvcmVWYWx1ZVNsb3cgbmVlZHMgdG8ga2VlcCB0aGUgcHJvcGVydHkg dGFibGUgYWxpdmUgdW50aWwgdGhlIGVuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY5NTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWljaGFlbCBT YWJvZmYuCisKKyAgICAgICAgV2UgdXNlIHBvaW50ZXJzIGxvZ2ljYWxseSBpbnRlcmlvciB0byBg cHJvcGVydHlUYWJsZWAgYWZ0ZXIgZG9pbmcgYSBHQy4gV2UgbmVlZCB0byBwcmV2ZW50IHRoZQor ICAgICAgICBjb21waWxlciBmcm9tIG9wdGltaXppbmcgYXdheSBwb2ludGVycyB0byBgcHJvcGVy dHlUYWJsZWAuCisgICAgICAgIAorICAgICAgICAqIGhlYXAvSGVhcENlbGwuY3BwOgorICAgICAg ICAoSlNDOjpIZWFwQ2VsbDo6dXNlKToKKyAgICAgICAgKiBoZWFwL0hlYXBDZWxsLmg6CisgICAg ICAgIChKU0M6OkhlYXBDZWxsOjp1c2UpOiBJbnRyb2R1Y2UgQVBJIGZvciBrZWVwaW5nIGEgcG9p bnRlciBhbGl2ZSB1bnRpbCBzb21lIHBvaW50IGluIGV4ZWN1dGlvbi4KKyAgICAgICAgKiBydW50 aW1lL1N0cnVjdHVyZS5jcHA6CisgICAgICAgIChKU0M6OlN0cnVjdHVyZTo6d2lsbFN0b3JlVmFs dWVTbG93KTogVXNlIEhlYXBDZWxsOjp1c2UoKSB0byBrZWVwIHRoZSBwb2ludGVyIGFsaXZlLgor CiAyMDE3LTAzLTExICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJH UFUgcHJvdG90eXBlIC0gRnJvbnQtRW5kCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9IZWFwQ2VsbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SGVhcENlbGwuY3BwCShyZXZpc2lvbiAyMTM3NTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9IZWFwQ2VsbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICog Q29weXJpZ2h0IChDKSAyMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENv cHlyaWdodCAoQykgMjAxNi0yMDE3IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAq CiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3 aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0 aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMjgsNiArMjgsMTYgQEAKIAogI2luY2x1 ZGUgPHd0Zi9QcmludFN0cmVhbS5oPgogCituYW1lc3BhY2UgSlNDIHsKKworI2lmICFDT01QSUxF UihHQ0NfT1JfQ0xBTkcpCit2b2lkIEhlYXBDZWxsOjp1c2UoKSBjb25zdAoreworfQorI2VuZGlm CisKK30gLy8gbmFtZXNwYWNlIEpTQworCiBuYW1lc3BhY2UgV1RGIHsKIAogdXNpbmcgbmFtZXNw YWNlIEpTQzsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXBDZWxsLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcENlbGwuaAkocmV2aXNp b24gMjEzNzU4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcENlbGwuaAkod29y a2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTYgQXBw bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE2LTIwMTcg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCkBAIC02Niw2ICs2NiwxOCBAQCBwdWJsaWM6CiAgICAgQWxsb2NhdG9yQXR0cmlidXRl cyBhbGxvY2F0b3JBdHRyaWJ1dGVzKCkgY29uc3Q7CiAgICAgRGVzdHJ1Y3Rpb25Nb2RlIGRlc3Ry dWN0aW9uTW9kZSgpIGNvbnN0OwogICAgIEtpbmQgY2VsbEtpbmQoKSBjb25zdDsKKyAgICAKKyAg ICAvLyBDYWxsIHVzZSgpIGFmdGVyIHRoZSBsYXN0IHBvaW50IHdoZXJlIHlvdSBuZWVkIGB0aGlz YCBwb2ludGVyIHRvIGJlIGtlcHQgYWxpdmUuIFlvdSB1c3VhbGx5IGRvbid0CisgICAgLy8gbmVl ZCB0byB1c2UgdGhpcywgYnV0IGl0IG1pZ2h0IGJlIG5lY2Vzc2FyeSBpZiB5b3UncmUgb3RoZXJ3 aXNlIHJlZmVycmluZyB0byBhbiBvYmplY3QncyBpbm5hcmRzCisgICAgLy8gYnV0IG5vdCB0aGUg b2JqZWN0IGl0c2VsZi4KKyNpZiBDT01QSUxFUihHQ0NfT1JfQ0xBTkcpCisgICAgdm9pZCB1c2Uo KSBjb25zdAorICAgIHsKKyAgICAgICAgYXNtIHZvbGF0aWxlICgiIiA6IDogInIiKHRoaXMpIDog Im1lbW9yeSIpOworICAgIH0KKyNlbHNlCisgICAgdm9pZCB1c2UoKSBjb25zdDsKKyNlbmRpZgog fTsKIAogfSAvLyBuYW1lc3BhY2UgSlNDCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TdHJ1Y3R1cmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1N0cnVjdHVyZS5jcHAJKHJldmlzaW9uIDIxMzc1OCkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkxOCw2ICs5 MTgsOCBAQCB2b2lkIFN0cnVjdHVyZTo6d2lsbFN0b3JlVmFsdWVTbG93KAogICAgICAgICB0YWJs ZS0+bWFrZVRvcCh2bSwgcHJvcGVydHlOYW1lLCBhZ2UpOwogICAgICAgICBlbnRyeS0+aGFzSW5m ZXJyZWRUeXBlID0gZmFsc2U7CiAgICAgfQorICAgIAorICAgIHByb3BlcnR5VGFibGUtPnVzZSgp OyAvLyBUaGlzIG1ha2VzIGl0IHNhZmUgdG8gdXNlIGVudHJ5IGFib3ZlLgogfQogCiAjaWYgRFVN UF9QUk9QRVJUWU1BUF9TVEFUUwo=