169504 2017-03-10 19:45:44 -0800 Database's query functions should support querying for a row with NULL value 2017-03-13 14:44:38 -0700 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez dewei_zhu kling rniwa oldest_to_newest 1286052 0 rniwa 2017-03-10 19:45:44 -0800 Right now, Database::_select_update_or_insert_row and Database::select_rows can't look for a row with NULL value because it always uses '=' for comparison. Add the support for querying a database entry with NULL value. 1286075 1 304130 rniwa 2017-03-10 21:19:48 -0800 Created attachment 304130 Adds the support 1287354 2 304130 rniwa 2017-03-13 14:44:34 -0700 Comment on attachment 304130 Adds the support Clearing flags on attachment: 304130 Committed r213870: <http://trac.webkit.org/changeset/213870> 1287355 3 rniwa 2017-03-13 14:44:38 -0700 All reviewed patches have been landed. Closing bug. 304130 2017-03-10 21:19:48 -0800 2017-03-13 14:44:34 -0700 Adds the support bug-169504-20170310211947.patch text/plain 6052 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzNzQ2CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA1OTU2OGNmMWY4YzVmZWQ2ZGE0MGYwODc3Zjk1MGY5MWI4MDM4ODllLi45NzdhYjExMTQx ZWM0ODhlNzAyMTIwN2IzMWIwMWNlZGQ3MTNhZGEyIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxNy0wMy0xMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KKworICAgICAgICBEYXRhYmFzZSdzIHF1ZXJ5IGZ1bmN0aW9ucyBzaG91bGQg c3VwcG9ydCBxdWVyeWluZyBmb3IgYSByb3cgd2l0aCBOVUxMIHZhbHVlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk1MDQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGhlIHN1cHBvcnQgZm9yIGNh bGxpbmcgc2VsZWN0Xyogd2l0aCBvbmUgb2YgY29sdW1uIHZhbHVlcyBzZXQgdG8gTlVMTC4KKyAg ICAgICAgVGhpcyBmZWF0dXJlIGlzIHVzZWZ1bCBpbiB3ZWJraXQub3JnL2IvMTQ2Mzc0IGFuZCB3 ZWJraXQub3JnL2IvMTY4OTYyLgorCisgICAgICAgICogcHVibGljL2luY2x1ZGUvZGIucGhwOgor ICAgICAgICAoRGF0YWJhc2U6OnByZXBhcmVfcGFyYW1zKTogQWRkZWQgJG51bGxfY29sdW1ucyBh cyBhbiBvcHRpb25hbCBhcmd1bWVudC4KKyAgICAgICAgKERhdGFiYXNlOjpzZWxlY3RfY29uZGl0 aW9uc193aXRoX251bGxfY29sdW1ucyk6IEFkZGVkLiBCdWlsZHMgdXAgYSBxdWVyeSBzdHJpbmcg YnkgYXBwZW5kaW5nIEFORCB4IGlzIE5VTEwKKyAgICAgICAgdG8gbWF0Y2ggY29sdW1ucyB3aG9z ZSB2YWx1ZSBtdXN0IGJlIE5VTEwuCisgICAgICAgIChEYXRhYmFzZTo6X3NlbGVjdF91cGRhdGVf b3JfaW5zZXJ0X3Jvdyk6CisgICAgICAgIChEYXRhYmFzZTo6c2VsZWN0X3Jvd3MpOgorCiAyMDE3 LTAzLTA3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVwZGF0 ZSBSZWFkTWUubWQgdG8gdXNlIGRpcmVjdG9yeSBmb3JtYXQgZm9yIGJhY2tpbmcgdXAgJiByZXN0 b3JpbmcgdGhlIGRhdGFiYXNlCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcv cHVibGljL2luY2x1ZGUvZGIucGhwIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9p bmNsdWRlL2RiLnBocAppbmRleCBkODA1ZDY3NjIyM2NjYjg0NTM5MjI0NGEzZjdmNjBkZGM0NTk5 ODI0Li4zM2ZiZWRiNWFjOGYxYThmN2UzMzI4M2Q4NWFiZTIwYWViNThkYWJhIDEwMDY0NAotLS0g YS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luY2x1ZGUvZGIucGhwCisrKyBiL1dl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9kYi5waHAKQEAgLTEwNSwyMCAr MTA1LDM4IEBAIGNsYXNzIERhdGFiYXNlCiAgICAgICAgIHJldHVybiAkcHJlZml4ID8gJHByZWZp eCAuICdfJyAuICRjb2x1bW4gOiAkY29sdW1uOwogICAgIH0KIAotICAgIHByaXZhdGUgZnVuY3Rp b24gcHJlcGFyZV9wYXJhbXMoJHBhcmFtcywgJiRwbGFjZWhvbGRlcnMsICYkdmFsdWVzKSB7Ci0g ICAgICAgICRjb2x1bW5fbmFtZXMgPSBhcnJheV9rZXlzKCRwYXJhbXMpOworICAgIHByaXZhdGUg ZnVuY3Rpb24gcHJlcGFyZV9wYXJhbXMoJHBhcmFtcywgJiRwbGFjZWhvbGRlcnMsICYkdmFsdWVz LCAkbnVsbF9jb2x1bW5zID0gTlVMTCkgeworICAgICAgICAkY29sdW1uX25hbWVzID0gYXJyYXko KTsKIAogICAgICAgICAkaSA9IGNvdW50KCR2YWx1ZXMpICsgMTsKLSAgICAgICAgZm9yZWFjaCAo JGNvbHVtbl9uYW1lcyBhcyAkbmFtZSkgeworICAgICAgICBmb3JlYWNoIChhcnJheV9rZXlzKCRw YXJhbXMpIGFzICRuYW1lKSB7CisgICAgICAgICAgICAkY3VycmVudF92YWx1ZSA9ICRwYXJhbXNb JG5hbWVdOworICAgICAgICAgICAgaWYgKCRjdXJyZW50X3ZhbHVlID09PSBOVUxMICYmICRudWxs X2NvbHVtbnMgIT09IE5VTEwpIHsKKyAgICAgICAgICAgICAgICBhcnJheV9wdXNoKCRudWxsX2Nv bHVtbnMsICRuYW1lKTsKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIH0K ICAgICAgICAgICAgIGFzc2VydChjdHlwZV9hbG51bV91bmRlcnNjb3JlKCRuYW1lKSk7CisgICAg ICAgICAgICBhcnJheV9wdXNoKCRjb2x1bW5fbmFtZXMsICRuYW1lKTsKICAgICAgICAgICAgIGFy cmF5X3B1c2goJHBsYWNlaG9sZGVycywgJyQnIC4gJGkpOwotICAgICAgICAgICAgYXJyYXlfcHVz aCgkdmFsdWVzLCAkcGFyYW1zWyRuYW1lXSk7CisgICAgICAgICAgICBhcnJheV9wdXNoKCR2YWx1 ZXMsICRjdXJyZW50X3ZhbHVlKTsKICAgICAgICAgICAgICRpKys7CiAgICAgICAgIH0KIAogICAg ICAgICByZXR1cm4gJGNvbHVtbl9uYW1lczsKICAgICB9CiAKKyAgICBwcml2YXRlIGZ1bmN0aW9u IHNlbGVjdF9jb25kaXRpb25zX3dpdGhfbnVsbF9jb2x1bW5zKCRwcmVmaXgsICRjb2x1bW5fbmFt ZXMsICRwbGFjZWhvbGRlcnMsICRudWxsX2NvbHVtbnMpIHsKKyAgICAgICAgJGNvbHVtbl9uYW1l cyA9ICR0aGlzLT5wcmVmaXhlZF9jb2x1bW5fbmFtZXMoJGNvbHVtbl9uYW1lcywgJHByZWZpeCk7 CisgICAgICAgICRwbGFjZWhvbGRlcnMgPSBqb2luKCcsICcsICRwbGFjZWhvbGRlcnMpOworCisg ICAgICAgIGlmICghJGNvbHVtbl9uYW1lcyAmJiAhJHBsYWNlaG9sZGVycykKKyAgICAgICAgICAg ICRjb2x1bW5fbmFtZXMgPSAkcGxhY2Vob2xkZXJzID0gJzEnOworICAgICAgICAkcXVlcnkgPSAi KCRjb2x1bW5fbmFtZXMpID0gKCRwbGFjZWhvbGRlcnMpIjsKKyAgICAgICAgZm9yZWFjaCAoJG51 bGxfY29sdW1ucyBhcyAkY29sdW1uX25hbWUpCisgICAgICAgICAgICAkcXVlcnkgLj0gJyBBTkQg JyAuICR0aGlzLT5wcmVmaXhlZF9uYW1lKCRjb2x1bW5fbmFtZSwgJHByZWZpeCkgLiAnIElTIE5V TEwnOworICAgICAgICByZXR1cm4gJHF1ZXJ5OworICAgIH0KKwogICAgIGZ1bmN0aW9uIGluc2Vy dF9yb3coJHRhYmxlLCAkcHJlZml4LCAkcGFyYW1zLCAkcmV0dXJuaW5nID0gJ2lkJykgewogICAg ICAgICAkcGxhY2Vob2xkZXJzID0gYXJyYXkoKTsKICAgICAgICAgJHZhbHVlcyA9IGFycmF5KCk7 CkBAIC0xNTQsNyArMTcyLDggQEAgY2xhc3MgRGF0YWJhc2UKICAgICAgICAgJHZhbHVlcyA9IGFy cmF5KCk7CiAKICAgICAgICAgJHNlbGVjdF9wbGFjZWhvbGRlcnMgPSBhcnJheSgpOwotICAgICAg ICAkc2VsZWN0X2NvbHVtbl9uYW1lcyA9ICR0aGlzLT5wcmVwYXJlX3BhcmFtcygkc2VsZWN0X3Bh cmFtcywgJHNlbGVjdF9wbGFjZWhvbGRlcnMsICR2YWx1ZXMpOworICAgICAgICAkc2VsZWN0X251 bGxfY29sdW1ucyA9IGFycmF5KCk7CisgICAgICAgICRzZWxlY3RfY29sdW1uX25hbWVzID0gJHRo aXMtPnByZXBhcmVfcGFyYW1zKCRzZWxlY3RfcGFyYW1zLCAkc2VsZWN0X3BsYWNlaG9sZGVycywg JHZhbHVlcywgJHNlbGVjdF9udWxsX2NvbHVtbnMpOwogICAgICAgICAkc2VsZWN0X3ZhbHVlcyA9 IGFycmF5X3NsaWNlKCR2YWx1ZXMsIDApOwogCiAgICAgICAgIGlmICgkaW5zZXJ0X3BhcmFtcyA9 PT0gTlVMTCkKQEAgLTE2NSw5ICsxODQsOSBAQCBjbGFzcyBEYXRhYmFzZQogICAgICAgICBhc3Nl cnQoISEkcmV0dXJuaW5nKTsKICAgICAgICAgYXNzZXJ0KCEkcHJlZml4IHx8IGN0eXBlX2FsbnVt X3VuZGVyc2NvcmUoJHByZWZpeCkpOwogICAgICAgICAkcmV0dXJuaW5nX2NvbHVtbl9uYW1lID0g JHJldHVybmluZyA9PSAnKicgPyAnKicgOiAkdGhpcy0+cHJlZml4ZWRfbmFtZSgkcmV0dXJuaW5n LCAkcHJlZml4KTsKLSAgICAgICAgJHNlbGVjdF9jb2x1bW5fbmFtZXMgPSAkdGhpcy0+cHJlZml4 ZWRfY29sdW1uX25hbWVzKCRzZWxlY3RfY29sdW1uX25hbWVzLCAkcHJlZml4KTsKLSAgICAgICAg JHNlbGVjdF9wbGFjZWhvbGRlcnMgPSBqb2luKCcsICcsICRzZWxlY3RfcGxhY2Vob2xkZXJzKTsK LSAgICAgICAgJHF1ZXJ5ID0gIlNFTEVDVCAkcmV0dXJuaW5nX2NvbHVtbl9uYW1lIEZST00gJHRh YmxlIFdIRVJFICgkc2VsZWN0X2NvbHVtbl9uYW1lcykgPSAoJHNlbGVjdF9wbGFjZWhvbGRlcnMp IjsKKworICAgICAgICAkY29uZGl0aW9uID0gJHRoaXMtPnNlbGVjdF9jb25kaXRpb25zX3dpdGhf bnVsbF9jb2x1bW5zKCRwcmVmaXgsICRzZWxlY3RfY29sdW1uX25hbWVzLCAkc2VsZWN0X3BsYWNl aG9sZGVycywgJHNlbGVjdF9udWxsX2NvbHVtbnMpOworICAgICAgICAkcXVlcnkgPSAiU0VMRUNU ICRyZXR1cm5pbmdfY29sdW1uX25hbWUgRlJPTSAkdGFibGUgV0hFUkUgJGNvbmRpdGlvbiI7CiAK ICAgICAgICAgJGluc2VydF9jb2x1bW5fbmFtZXMgPSAkdGhpcy0+cHJlZml4ZWRfY29sdW1uX25h bWVzKCRpbnNlcnRfY29sdW1uX25hbWVzLCAkcHJlZml4KTsKICAgICAgICAgJGluc2VydF9wbGFj ZWhvbGRlcnMgPSBqb2luKCcsICcsICRpbnNlcnRfcGxhY2Vob2xkZXJzKTsKQEAgLTE3Niw3ICsx OTUsNyBAQCBjbGFzcyBEYXRhYmFzZQogICAgICAgICAkcm93cyA9IE5VTEw7CiAgICAgICAgIGlm ICgkc2hvdWxkX3VwZGF0ZSkgewogICAgICAgICAgICAgJHJvd3MgPSAkdGhpcy0+cXVlcnlfYW5k X2ZldGNoX2FsbCgiVVBEQVRFICR0YWJsZSBTRVQgKCRpbnNlcnRfY29sdW1uX25hbWVzKSA9ICgk aW5zZXJ0X3BsYWNlaG9sZGVycykKLSAgICAgICAgICAgICAgICBXSEVSRSAoJHNlbGVjdF9jb2x1 bW5fbmFtZXMpID0gKCRzZWxlY3RfcGxhY2Vob2xkZXJzKSBSRVRVUk5JTkcgJHJldHVybmluZ19j b2x1bW5fbmFtZSIsICR2YWx1ZXMpOworICAgICAgICAgICAgICAgIFdIRVJFICRjb25kaXRpb24g UkVUVVJOSU5HICRyZXR1cm5pbmdfY29sdW1uX25hbWUiLCAkdmFsdWVzKTsKICAgICAgICAgfQog ICAgICAgICBpZiAoISRyb3dzICYmICRzaG91bGRfaW5zZXJ0KSB7CiAgICAgICAgICAgICAkcm93 cyA9ICR0aGlzLT5xdWVyeV9hbmRfZmV0Y2hfYWxsKCJJTlNFUlQgSU5UTyAkdGFibGUgKCRpbnNl cnRfY29sdW1uX25hbWVzKSBTRUxFQ1QgJGluc2VydF9wbGFjZWhvbGRlcnMKQEAgLTIwNiwxMSAr MjI1LDEyIEBAIGNsYXNzIERhdGFiYXNlCiAKICAgICAgICAgJHBsYWNlaG9sZGVycyA9IGFycmF5 KCk7CiAgICAgICAgICR2YWx1ZXMgPSBhcnJheSgpOwotICAgICAgICAkY29sdW1uX25hbWVzID0g JHRoaXMtPnByZWZpeGVkX2NvbHVtbl9uYW1lcygkdGhpcy0+cHJlcGFyZV9wYXJhbXMoJHBhcmFt cywgJHBsYWNlaG9sZGVycywgJHZhbHVlcyksICRwcmVmaXgpOwotICAgICAgICAkcGxhY2Vob2xk ZXJzID0gam9pbignLCAnLCAkcGxhY2Vob2xkZXJzKTsKLSAgICAgICAgaWYgKCEkY29sdW1uX25h bWVzICYmICEkcGxhY2Vob2xkZXJzKQotICAgICAgICAgICAgJGNvbHVtbl9uYW1lcyA9ICRwbGFj ZWhvbGRlcnMgPSAnMSc7Ci0gICAgICAgICRxdWVyeSA9ICJTRUxFQ1QgKiBGUk9NICR0YWJsZSBX SEVSRSAoJGNvbHVtbl9uYW1lcykgPSAoJHBsYWNlaG9sZGVycykiOworICAgICAgICAkbnVsbF9j b2x1bW5zID0gYXJyYXkoKTsKKyAgICAgICAgJGNvbHVtbl9uYW1lcyA9ICR0aGlzLT5wcmVwYXJl X3BhcmFtcygkcGFyYW1zLCAkcGxhY2Vob2xkZXJzLCAkdmFsdWVzLCAkbnVsbF9jb2x1bW5zKTsK KyAgICAgICAgJGNvbmRpdGlvbiA9ICR0aGlzLT5zZWxlY3RfY29uZGl0aW9uc193aXRoX251bGxf Y29sdW1ucygkcHJlZml4LCAkY29sdW1uX25hbWVzLCAkcGxhY2Vob2xkZXJzLCAkbnVsbF9jb2x1 bW5zKTsKKworICAgICAgICAkcXVlcnkgPSAiU0VMRUNUICogRlJPTSAkdGFibGUgV0hFUkUgJGNv bmRpdGlvbiI7CisKICAgICAgICAgaWYgKCRvcmRlcl9ieSkgewogICAgICAgICAgICAgaWYgKCFp c19hcnJheSgkb3JkZXJfYnkpKQogICAgICAgICAgICAgICAgICRvcmRlcl9ieSA9IGFycmF5KCRv cmRlcl9ieSk7Cg==