<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>169493</bug_id>
          
          <creation_ts>2017-03-10 16:32:16 -0800</creation_ts>
          <short_desc>Turn ENABLE(MASM_PROBE) on by default for OS(DARWIN) release builds.</short_desc>
          <delta_ts>2017-03-10 17:39:52 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1285972</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-03-10 16:32:16 -0800</bug_when>
    <thetext>MASM_PROBE was already enabled for debug builds.  This change makes it so that we don&apos;t have to rebuild the world every time we need to use it on a release build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1285975</commentid>
    <comment_count>1</comment_count>
      <attachid>304099</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-03-10 16:36:15 -0800</bug_when>
    <thetext>Created attachment 304099
proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1285984</commentid>
    <comment_count>2</comment_count>
      <attachid>304099</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2017-03-10 16:51:40 -0800</bug_when>
    <thetext>Comment on attachment 304099
proposed patch.

Thanks for the review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1286014</commentid>
    <comment_count>3</comment_count>
      <attachid>304099</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-10 17:39:47 -0800</bug_when>
    <thetext>Comment on attachment 304099
proposed patch.

Clearing flags on attachment: 304099

Committed r213743: &lt;http://trac.webkit.org/changeset/213743&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1286015</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-10 17:39:52 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>304099</attachid>
            <date>2017-03-10 16:36:15 -0800</date>
            <delta_ts>2017-03-10 17:39:47 -0800</delta_ts>
            <desc>proposed patch.</desc>
            <filename>bug-169493.patch</filename>
            <type>text/plain</type>
            <size>1374</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAyMTM3MzIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAzLTEwICBNYXJrIExhbSAgPG1hcmsubGFt
QGFwcGxlLmNvbT4KKworICAgICAgICBUdXJuIEVOQUJMRShNQVNNX1BST0JFKSBvbiBieSBkZWZh
dWx0IGZvciBPUyhEQVJXSU4pIHJlbGVhc2UgYnVpbGRzLgorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5NDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTUFTTV9QUk9CRSB3YXMgYWxyZWFkeSBlbmFibGVk
IGZvciBkZWJ1ZyBidWlsZHMuICBUaGlzIGNoYW5nZSBtYWtlcyBpdCBzbyB0aGF0IHdlCisgICAg
ICAgIGRvbid0IGhhdmUgdG8gcmVidWlsZCB0aGUgd29ybGQgZXZlcnkgdGltZSB3ZSBuZWVkIHRv
IHVzZSBpdCBvbiBhIHJlbGVhc2UgYnVpbGQuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoK
KwogMjAxNy0wMy0xMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAg
ICAgICAgIFVucmV2aWV3ZWQgQUFyY2g2NCBMaW51eCBidWlsZGZpeCBhZnRlciByMjEzNjQ1LgpJ
bmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RG
L3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAyMTM3MzIpCisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0
Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC04OTksNyArODk5LDcgQEAKIAogLyogRW5hYmxlIHRo
ZSBmb2xsb3dpbmcgaWYgeW91IHdhbnQgdG8gdXNlIHRoZSBNYWNyb0Fzc2VtYmxlcjo6cHJvYmUo
KSBmYWNpbGl0eQogICAgdG8gZG8gSklUIGRlYnVnZ2luZy4gKi8KLSNpZiAoQ1BVKFg4NikgfHwg
Q1BVKFg4Nl82NCkgfHwgQ1BVKEFSTTY0KSB8fCAoQ1BVKEFSTV9USFVNQjIpICYmIFBMQVRGT1JN
KElPUykpKSAmJiBFTkFCTEUoSklUKSAmJiBPUyhEQVJXSU4pICYmICFkZWZpbmVkKE5ERUJVRykK
KyNpZiAoQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkgfHwgQ1BVKEFSTTY0KSB8fCAoQ1BVKEFSTV9U
SFVNQjIpICYmIFBMQVRGT1JNKElPUykpKSAmJiBFTkFCTEUoSklUKSAmJiBPUyhEQVJXSU4pCiAj
ZGVmaW5lIEVOQUJMRV9NQVNNX1BST0JFIDEKICNlbHNlCiAjZGVmaW5lIEVOQUJMRV9NQVNNX1BS
T0JFIDAK
</data>

          </attachment>
      

    </bug>

</bugzilla>