169488 2017-03-10 15:33:38 -0800 Web Inspector: Only show "Break on..." menu if backend supports DOM breakpoints 2017-03-10 17:56:15 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes oldest_to_newest 1285942 0 mattbaker 2017-03-10 15:33:38 -0800 Summary: Only show "Break on..." menu if backend supports DOM breakpoints. Need to add a check to DOMTreeElement. 1285943 1 304086 mattbaker 2017-03-10 15:35:24 -0800 Created attachment 304086 Patch 1286003 2 304086 joepeck 2017-03-10 17:15:05 -0800 Comment on attachment 304086 Patch r=me 1286004 3 304086 hi 2017-03-10 17:15:58 -0800 Comment on attachment 304086 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304086&action=review > Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js:47 > + console.assert(WebInspector.domDebuggerManager.supported); I feel like it would be much simpler and less mistake prone in future changes if we added the support check inside this function instead of at the call sites. Considering the fact that multiple separators in a row in a context menu are collapsed, I think this may be the better (and possibly more centralized) approach. 1286021 4 304086 commit-queue 2017-03-10 17:56:11 -0800 Comment on attachment 304086 Patch Clearing flags on attachment: 304086 Committed r213744: <http://trac.webkit.org/changeset/213744> 1286022 5 commit-queue 2017-03-10 17:56:15 -0800 All reviewed patches have been landed. Closing bug. 304086 2017-03-10 15:35:24 -0800 2017-03-10 17:56:11 -0800 Patch bug-169488-20170310153523.patch text/plain 2788 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzNzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj ZTU3NmI0NjEyNGJlZjIzZWIxNGVjZDFlNzBmZDQyMGQ2NmQzMmIxLi42OGRhZGY4Zjk0OGE1MWIy YWU5Mzg5YmI0OTJjNGM1MDQ4OThiZDA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNy0wMy0xMCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogT25seSBzaG93ICJCcmVhayBvbi4uLiIgbWVudSBp ZiBiYWNrZW5kIHN1cHBvcnRzIERPTSBicmVha3BvaW50cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5NDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RP TUJyZWFrcG9pbnRUcmVlQ29udHJvbGxlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01C cmVha3BvaW50VHJlZUNvbnRyb2xsZXIuYXBwZW5kQnJlYWtwb2ludENvbnRleHRNZW51SXRlbXMp OgorICAgICAgICBBZGRlZCBhc3NlcnQgdG8gY2F0Y2ggZnV0dXJlIGNhc2VzIHdoZXJlIFVJIGlz IGJlaW5nIGFkZGVkIHdoZW4KKyAgICAgICAgYmFja2VuZCBzdXBwb3J0IGRvZXNuJ3QgZXhpc3Qu CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5fcG9wdWxhdGVOb2Rl Q29udGV4dE1lbnUpOgorICAgICAgICBDaGVjayBmb3IgYmFja2VuZCBzdXBwb3J0LgorCiAyMDE3 LTAzLTA5ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBBZGQgWEhSIGJyZWFrcG9pbnRzIFVJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9ET01CcmVha3BvaW50VHJlZUNv bnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9ET01CcmVha3BvaW50VHJlZUNvbnRyb2xsZXIuanMKaW5kZXggYmM2Nzg4MmEyZWZmNzZi ZmFiNTY2MzQ3NjVmZTQ1ZTI0YzQyMDdlNy4uOTA5MDBjODA5ZTAzNjMxZDBiMmY5Mjk5YzgxNzVj MGMwYWQ3MWIyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQ29udHJvbGxlcnMvRE9NQnJlYWtwb2ludFRyZWVDb250cm9sbGVyLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTUJyZWFrcG9pbnRU cmVlQ29udHJvbGxlci5qcwpAQCAtNDQsNiArNDQsOCBAQCBXZWJJbnNwZWN0b3IuRE9NQnJlYWtw b2ludFRyZWVDb250cm9sbGVyID0gY2xhc3MgRE9NQnJlYWtwb2ludHNUcmVlQ29udHJvbGxlciBl eAogCiAgICAgc3RhdGljIGFwcGVuZEJyZWFrcG9pbnRDb250ZXh0TWVudUl0ZW1zKGNvbnRleHRN ZW51LCBkb21Ob2RlLCBhbGxvd0VkaXRpbmcpCiAgICAgeworICAgICAgICBjb25zb2xlLmFzc2Vy dChXZWJJbnNwZWN0b3IuZG9tRGVidWdnZXJNYW5hZ2VyLnN1cHBvcnRlZCk7CisKICAgICAgICAg bGV0IHN1Yk1lbnUgPSBjb250ZXh0TWVudS5hcHBlbmRTdWJNZW51SXRlbShXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIkJyZWFrIG9u4oCmIikpOwogCiAgICAgICAgIGxldCBicmVha3BvaW50cyA9IFdl Ykluc3BlY3Rvci5kb21EZWJ1Z2dlck1hbmFnZXIuZG9tQnJlYWtwb2ludHNGb3JOb2RlKGRvbU5v ZGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvRE9NVHJlZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qcwppbmRleCBkZTY5MzU2MTRmMGEzZGFmNDNhN2I2MDhl MGJjZjIwNjg1MDBiNTgyLi4xYmI5ZjYyNjUyNWFhOWE4N2E2ZDU3NDI4N2QyMjU3MTA4YWMyZWI2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9E T01UcmVlRWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qcwpAQCAtNzYwLDcgKzc2MCw3IEBAIFdlYkluc3BlY3Rv ci5ET01UcmVlRWxlbWVudCA9IGNsYXNzIERPTVRyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVj dG9yLlRyZWVFbGVtCiAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3Bl Y3Rvci5VSVN0cmluZygiSnVtcCB0byBEZWZpbml0aW9uIiksIHRoaXMuX3Nob3dDdXN0b21FbGVt ZW50RGVmaW5pdGlvbi5iaW5kKHRoaXMpKTsKICAgICAgICAgfQogCi0gICAgICAgIGlmIChub2Rl Lm5vZGVUeXBlKCkgPT09IE5vZGUuRUxFTUVOVF9OT0RFKSB7CisgICAgICAgIGlmIChXZWJJbnNw ZWN0b3IuZG9tRGVidWdnZXJNYW5hZ2VyLnN1cHBvcnRlZCAmJiBub2RlLm5vZGVUeXBlKCkgPT09 IE5vZGUuRUxFTUVOVF9OT0RFKSB7CiAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRTZXBh cmF0b3IoKTsKIAogICAgICAgICAgICAgY29uc3QgYWxsb3dFZGl0aW5nID0gZmFsc2U7Cg==