169416 2017-03-09 09:16:58 -0800 Minimal build is broken 2017-03-09 16:07:49 -0800 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez youennf bburg cdumez cgarcia commit-queue keith_miller mark.lam mcatanzaro msaboff saam sam youennf oldest_to_newest 1285338 0 cdumez 2017-03-09 09:16:58 -0800 Minimal build is broken: JSBuiltinInternalFunctions::JSBuiltinInternalFunctions(JSC::VM& vm) #if ENABLE(READABLE_STREAM_API) || ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API) || ENABLE(WEB_RTC) || ENABLE(FETCH_API) || ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API) || ENABLE(WRITABLE_STREAM_API) : m_vm(vm) #endif // ENABLE(READABLE_STREAM_API) || ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API) || ENABLE(WEB_RTC) || ENABLE(FETCH_API) || ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API) || ENABLE(WRITABLE_STREAM_API) #if ENABLE(FETCH_API) , m_fetchInternals(m_vm) #endif // ENABLE(FETCH_API) #if ENABLE(WEB_RTC) , m_rtcPeerConnectionInternals(m_vm) #endif // ENABLE(WEB_RTC) #if ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API) , m_readableByteStreamInternals(m_vm) #endif // ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API) #if ENABLE(READABLE_STREAM_API) , m_readableStreamInternals(m_vm) #endif // ENABLE(READABLE_STREAM_API) #if ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API) , m_streamInternals(m_vm) #endif // ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API) #if ENABLE(WRITABLE_STREAM_API) , m_writableStreamInternals(m_vm) #endif // ENABLE(WRITABLE_STREAM_API) , m_jsDOMBindingInternals(m_vm) { UNUSED_PARAM(vm); } If all these features are disabled, then the initialization list no longer starts with a ':' and m_jsDOMBindingInternals(m_vm) is referring to m_vm which does not exist. 1285344 1 303924 youennf 2017-03-09 09:37:34 -0800 Created attachment 303924 Patch 1285348 2 commit-queue 2017-03-09 09:39:49 -0800 This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`) 1285500 3 cdumez 2017-03-09 13:02:15 -0800 Is the GTK failure real? 1285510 4 mark.lam 2017-03-09 13:08:49 -0800 Sorry, I closed the wrong bug. 1285515 5 youennf 2017-03-09 13:10:32 -0800 (In reply to comment #3) > Is the GTK failure real? It seems so although the log does not give any hint about the actual issue. 1285516 6 cdumez 2017-03-09 13:11:49 -0800 (In reply to comment #5) > (In reply to comment #3) > > Is the GTK failure real? > > It seems so although the log does not give any hint about the actual issue. Could be an incremental build issue. We've had such issues on the GTK EWS recently. All other EWS is green so it looks good to me. 1285626 7 youennf 2017-03-09 14:49:50 -0800 Let's see if GTK bots like it or not then. 1285633 8 303924 commit-queue 2017-03-09 15:14:23 -0800 Comment on attachment 303924 Patch Clearing flags on attachment: 303924 Committed r213680: <http://trac.webkit.org/changeset/213680> 1285634 9 commit-queue 2017-03-09 15:14:30 -0800 All reviewed patches have been landed. Closing bug. 1285660 10 youennf 2017-03-09 16:07:49 -0800 GTK bots seem happy with the patch. 303924 2017-03-09 09:37:34 -0800 2017-03-09 15:14:23 -0800 Patch bug-169416-20170309093733.patch text/plain 4946 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzNjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy YjEyYjFmOWRiZTZkNzEwY2EyYzMxNGQyY2U4ODA3ZmYyZjhkM2E2Li4zOTQ3MGViNjkwOWQ5Y2Zj NDRiMDM3YjkzZjMyYjQ2ZTcwNTQxMzE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNy0wMy0wOSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+ CisKKyAgICAgICAgTWluaW1hbCBidWlsZCBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTQxNgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHdlIG5vdyBoYXZlIHNvbWUgSlMgYnVp bHQtaW5zIHRoYXQgYXJlIG5vdCB0aWVkIHRvIGEgY29tcGlsYXRpb24gZmxhZywgd2UgY2FuIHJl bW92ZSBjb21waWxhdGlvbiBndWFyZHMgYXJvdW5kIG1fdm0uCisgICAgICAgIFdlIGNvdWxkIHBy b2JhYmx5IHJlbW92ZSBtX3ZtIGJ5IGVuc3VyaW5nIG1fanNET01CaW5kaW5nSW50ZXJuYWxzIGFw cGVhciBmaXJzdCBidXQgdGhpcyBtaWdodCBicmVhayB2ZXJ5IGVhc2lseS4KKworICAgICAgICAq IFNjcmlwdHMvYnVpbHRpbnMvYnVpbHRpbnNfZ2VuZXJhdGVfaW50ZXJuYWxzX3dyYXBwZXJfaGVh ZGVyLnB5OgorICAgICAgICAoZ2VuZXJhdGVfbWVtYmVycyk6CisgICAgICAgICogU2NyaXB0cy9i dWlsdGlucy9idWlsdGluc19nZW5lcmF0ZV9pbnRlcm5hbHNfd3JhcHBlcl9pbXBsZW1lbnRhdGlv bi5weToKKyAgICAgICAgKEJ1aWx0aW5zSW50ZXJuYWxzV3JhcHBlckltcGxlbWVudGF0aW9uR2Vu ZXJhdG9yLmdlbmVyYXRlX2NvbnN0cnVjdG9yKToKKyAgICAgICAgKiBTY3JpcHRzL3Rlc3RzL2J1 aWx0aW5zL2V4cGVjdGVkL1dlYkNvcmVKU0J1aWx0aW5zLmgtcmVzdWx0OgorCiAyMDE3LTAzLTA4 ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYkFz c2VtYmx5OiBNYWtlIE9PQiBmb3IgZmFzdCBtZW1vcnkgZG8gYW4gZXh0cmEgc2FmZXR5IGNoZWNr IGJ5IGVuc3VyaW5nIHRoZSBmYXVsdGluZyBhZGRyZXNzIGlzIGluIHRoZSByYW5nZSB3ZSBhbGxv Y2F0ZWQgZm9yIGZhc3QgbWVtb3J5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv U2NyaXB0cy9idWlsdGlucy9idWlsdGluc19nZW5lcmF0ZV9pbnRlcm5hbHNfd3JhcHBlcl9oZWFk ZXIucHkgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvU2NyaXB0cy9idWlsdGlucy9idWlsdGluc19n ZW5lcmF0ZV9pbnRlcm5hbHNfd3JhcHBlcl9oZWFkZXIucHkKaW5kZXggZGJjZDViNTVhMjY1ZjU4 YjUyM2ViYTkxNDM0Y2I2N2YyYTQxNGVlNi4uMGI5MTNkY2ZjZTAzNjEwZTQwOTYwNzVhYTQ0YTNl ZTJiNDIwMzljYiAxMDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1NjcmlwdHMvYnVp bHRpbnMvYnVpbHRpbnNfZ2VuZXJhdGVfaW50ZXJuYWxzX3dyYXBwZXJfaGVhZGVyLnB5CisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRzL2J1aWx0aW5zL2J1aWx0aW5zX2dlbmVyYXRl X2ludGVybmFsc193cmFwcGVyX2hlYWRlci5weQpAQCAtMTA2LDggKzEwNiw3IEBAIGNsYXNzIEJ1 aWx0aW5zSW50ZXJuYWxzV3JhcHBlckhlYWRlckdlbmVyYXRvcihCdWlsdGluc0dlbmVyYXRvcik6 CiAgICAgICAgIHJldHVybiAnXG4nLmpvaW4obGluZXMpCiAKICAgICBkZWYgZ2VuZXJhdGVfbWVt YmVycyhzZWxmKToKLSAgICAgICAgZ3VhcmRzID0gc2V0KFtvYmplY3QuYW5ub3RhdGlvbnMuZ2V0 KCdjb25kaXRpb25hbCcpIGZvciBvYmplY3QgaW4gc2VsZi5pbnRlcm5hbHMgaWYgJ2NvbmRpdGlv bmFsJyBpbiBvYmplY3QuYW5ub3RhdGlvbnNdKQotICAgICAgICBsaW5lcyA9IFtCdWlsdGluc0dl bmVyYXRvci53cmFwX3dpdGhfZ3VhcmQoIiB8fCAiLmpvaW4oZ3VhcmRzKSwgIiAgICBKU0M6OlZN JiBtX3ZtOyIpXQorICAgICAgICBsaW5lcyA9IFsiICAgIEpTQzo6Vk0mIG1fdm07Il0KICAgICAg ICAgZm9yIG9iamVjdCBpbiBzZWxmLmludGVybmFsczoKICAgICAgICAgICAgIG1lbWJlciA9ICIg ICAgJXMgJXM7IiAlIChzZWxmLm1lbWJlcl90eXBlKG9iamVjdCksIHNlbGYubWVtYmVyX25hbWUo b2JqZWN0KSkKICAgICAgICAgICAgIGxpbmVzLmFwcGVuZChCdWlsdGluc0dlbmVyYXRvci53cmFw X3dpdGhfZ3VhcmQob2JqZWN0LmFubm90YXRpb25zLmdldCgnY29uZGl0aW9uYWwnKSwgbWVtYmVy KSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRzL2J1aWx0aW5zL2J1 aWx0aW5zX2dlbmVyYXRlX2ludGVybmFsc193cmFwcGVyX2ltcGxlbWVudGF0aW9uLnB5IGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL1NjcmlwdHMvYnVpbHRpbnMvYnVpbHRpbnNfZ2VuZXJhdGVfaW50 ZXJuYWxzX3dyYXBwZXJfaW1wbGVtZW50YXRpb24ucHkKaW5kZXggZDJkMDljNThhODE2ZGFjMjE5 OWUxMDEzYmE2YjUzZGMxZjc2YWZkOS4uNDA1OWViZDU0Zjg5NDQ2ZmYzYjAyYTk1NGEzYmFkYzcy ZTVjNmVlZSAxMDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1NjcmlwdHMvYnVpbHRp bnMvYnVpbHRpbnNfZ2VuZXJhdGVfaW50ZXJuYWxzX3dyYXBwZXJfaW1wbGVtZW50YXRpb24ucHkK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL1NjcmlwdHMvYnVpbHRpbnMvYnVpbHRpbnNfZ2Vu ZXJhdGVfaW50ZXJuYWxzX3dyYXBwZXJfaW1wbGVtZW50YXRpb24ucHkKQEAgLTEwMSw3ICsxMDEs NyBAQCBjbGFzcyBCdWlsdGluc0ludGVybmFsc1dyYXBwZXJJbXBsZW1lbnRhdGlvbkdlbmVyYXRv cihCdWlsdGluc0dlbmVyYXRvcik6CiAgICAgZGVmIGdlbmVyYXRlX2NvbnN0cnVjdG9yKHNlbGYp OgogICAgICAgICBndWFyZHMgPSBzZXQoW29iamVjdC5hbm5vdGF0aW9ucy5nZXQoJ2NvbmRpdGlv bmFsJykgZm9yIG9iamVjdCBpbiBzZWxmLmludGVybmFscyBpZiAnY29uZGl0aW9uYWwnIGluIG9i amVjdC5hbm5vdGF0aW9uc10pCiAgICAgICAgIGxpbmVzID0gWyJKU0J1aWx0aW5JbnRlcm5hbEZ1 bmN0aW9uczo6SlNCdWlsdGluSW50ZXJuYWxGdW5jdGlvbnMoSlNDOjpWTSYgdm0pIiwKLSAgICAg ICAgICAgICAgICAgQnVpbHRpbnNHZW5lcmF0b3Iud3JhcF93aXRoX2d1YXJkKCIgfHwgIi5qb2lu KGd1YXJkcyksICIgICAgOiBtX3ZtKHZtKSIpXQorICAgICAgICAgICAgICAgICAiICAgIDogbV92 bSh2bSkiXQogICAgICAgICBmb3Igb2JqZWN0IGluIHNlbGYuaW50ZXJuYWxzOgogICAgICAgICAg ICAgaW5pdGlhbGl6ZXIgPSAiICAgICwgJXMobV92bSkiICUgc2VsZi5tZW1iZXJfbmFtZShvYmpl Y3QpCiAgICAgICAgICAgICBsaW5lcy5hcHBlbmQoQnVpbHRpbnNHZW5lcmF0b3Iud3JhcF93aXRo X2d1YXJkKG9iamVjdC5hbm5vdGF0aW9ucy5nZXQoJ2NvbmRpdGlvbmFsJyksIGluaXRpYWxpemVy KSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRzL3Rlc3RzL2J1aWx0 aW5zL2V4cGVjdGVkL1dlYkNvcmVKU0J1aWx0aW5zLmgtcmVzdWx0IGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL1NjcmlwdHMvdGVzdHMvYnVpbHRpbnMvZXhwZWN0ZWQvV2ViQ29yZUpTQnVpbHRpbnMu aC1yZXN1bHQKaW5kZXggZGFiNDI0NDMyZTgyYjI5N2M1MmZlYThhNzJmM2IzNWIxMzcxODA5YS4u MTQ3ZTAxYmQ2ZDVmNDdmYjU3Njk5NGJiZDA5YjA0OGZlMmU2NjVkNSAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL1NjcmlwdHMvdGVzdHMvYnVpbHRpbnMvZXhwZWN0ZWQvV2ViQ29y ZUpTQnVpbHRpbnMuaC1yZXN1bHQKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL1NjcmlwdHMv dGVzdHMvYnVpbHRpbnMvZXhwZWN0ZWQvV2ViQ29yZUpTQnVpbHRpbnMuaC1yZXN1bHQKQEAgLTIx Myw5ICsyMTMsNyBAQCBwdWJsaWM6CiAjZW5kaWYgLy8gRU5BQkxFKFNUUkVBTVNfQVBJKQogCiBw cml2YXRlOgotI2lmIEVOQUJMRShGRVRDSF9BUEkpIHx8IEVOQUJMRShSRUFEQUJMRV9TVFJFQU1f QVBJKSB8fCBFTkFCTEUoV1JJVEFCTEVfU1RSRUFNX0FQSSkgfHwgRU5BQkxFKFNUUkVBTVNfQVBJ KQogICAgIEpTQzo6Vk0mIG1fdm07Ci0jZW5kaWYgLy8gRU5BQkxFKEZFVENIX0FQSSkgfHwgRU5B QkxFKFJFQURBQkxFX1NUUkVBTV9BUEkpIHx8IEVOQUJMRShXUklUQUJMRV9TVFJFQU1fQVBJKSB8 fCBFTkFCTEUoU1RSRUFNU19BUEkpCiAjaWYgRU5BQkxFKEZFVENIX0FQSSkKICAgICBBbm90aGVy R3VhcmRlZEludGVybmFsQnVpbHRpbkJ1aWx0aW5GdW5jdGlvbnMgbV9hbm90aGVyR3VhcmRlZElu dGVybmFsQnVpbHRpbjsKICNlbmRpZiAvLyBFTkFCTEUoRkVUQ0hfQVBJKQpAQCAtMjc0LDkgKzI3 Miw3IEBAIHByaXZhdGU6CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIEpTQnVpbHRpbkludGVybmFs RnVuY3Rpb25zOjpKU0J1aWx0aW5JbnRlcm5hbEZ1bmN0aW9ucyhKU0M6OlZNJiB2bSkKLSNpZiBF TkFCTEUoRkVUQ0hfQVBJKSB8fCBFTkFCTEUoUkVBREFCTEVfU1RSRUFNX0FQSSkgfHwgRU5BQkxF KFdSSVRBQkxFX1NUUkVBTV9BUEkpIHx8IEVOQUJMRShTVFJFQU1TX0FQSSkKICAgICA6IG1fdm0o dm0pCi0jZW5kaWYgLy8gRU5BQkxFKEZFVENIX0FQSSkgfHwgRU5BQkxFKFJFQURBQkxFX1NUUkVB TV9BUEkpIHx8IEVOQUJMRShXUklUQUJMRV9TVFJFQU1fQVBJKSB8fCBFTkFCTEUoU1RSRUFNU19B UEkpCiAjaWYgRU5BQkxFKEZFVENIX0FQSSkKICAgICAsIG1fYW5vdGhlckd1YXJkZWRJbnRlcm5h bEJ1aWx0aW4obV92bSkKICNlbmRpZiAvLyBFTkFCTEUoRkVUQ0hfQVBJKQo=