169415 2017-03-09 08:41:55 -0800 MiniBrowser: a tab closed from javascript always closes the window 2017-03-13 02:16:05 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply lforschler oldest_to_newest 1285326 0 cgarcia 2017-03-09 08:41:55 -0800 When I implemented tabs support in MiniBroser I forgot about web view close. We connect to the signal (only for the active tab) and close the window. That worked when we didn't have tabs, but now we should close the tab o the window if it's the last tab. 1285332 1 303922 cgarcia 2017-03-09 08:46:14 -0800 Created attachment 303922 Patch 1285800 2 303922 mcatanzaro 2017-03-10 07:35:06 -0800 Comment on attachment 303922 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303922&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:268 > + for (int i = 0; i < tabsCount; ++i) { It fails with GCC 4.9: ../../Tools/MiniBrowser/gtk/BrowserWindow.c: In function 'webViewClose': ../../Tools/MiniBrowser/gtk/BrowserWindow.c:268:5: error: 'for' loop initial declarations are only allowed in C99 or C11 mode ../../Tools/MiniBrowser/gtk/BrowserWindow.c:268:5: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code Maybe we should specify --std=c11 for compiling MiniBrowser, since that's clearly what we are all using. 1287116 3 cgarcia 2017-03-13 02:16:05 -0700 Committed r213789: <http://trac.webkit.org/changeset/213789> 303922 2017-03-09 08:46:14 -0800 2017-03-10 07:35:06 -0800 Patch mb-close-tab.diff text/plain 2675 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjOWY3 MWE3OWIxOS4uMGQyM2E2NmIxZGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNy0wMy0wOSAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgTWluaUJyb3dzZXI6IGEg dGFiIGNsb3NlZCBmcm9tIGphdmFzY3JpcHQgYWx3YXlzIGNsb3NlcyB0aGUgd2luZG93CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk0MTUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIEkgaW1wbGVt ZW50ZWQgdGFicyBzdXBwb3J0IGluIE1pbmlCcm93c2VyIEkgZm9yZ290IGFib3V0IHdlYiB2aWV3 IGNsb3NlLiBXZSBjb25uZWN0IHRvIHRoZSBzaWduYWwgKG9ubHkgZm9yCisgICAgICAgIHRoZSBh Y3RpdmUgdGFiKSBhbmQgY2xvc2UgdGhlIHdpbmRvdy4gVGhhdCB3b3JrZWQgd2hlbiB3ZSBkaWRu J3QgaGF2ZSB0YWJzLCBidXQgbm93IHdlIHNob3VsZCBjbG9zZSB0aGUgdGFiLCBvcgorICAgICAg ICB0aGUgd2luZG93IGlmIGl0J3MgdGhlIGxhc3QgdGFiLgorCisgICAgICAgICogTWluaUJyb3dz ZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYzoKKyAgICAgICAgKHdlYlZpZXdDbG9zZSk6IERlc3Ryb3kg dGhlIHdpbmRvdyBpZiB0aGVydGUncyBvbmx5IG9uZSB0YWIsIG90aGVyd2lzZSBzZWFyY2ggZm9y IHRoZSB0YWIgY29ycmVzcG9uZGluZyB0byB0aGUgd2ViCisgICAgICAgIHZpZXcgYW5kIGRlc3Ry b3kgaXQuCisgICAgICAgIChicm93c2VyV2luZG93U3dpdGNoVGFiKTogUmUtY29ubmVjdCB0byBj bG9zZSBzaWduYWwsIHdlIHdhbnQgdG8gaGFuZGxlIGNsb3NlIG9uIGFsbCB0YWJzLgorCiAyMDE3 LTAzLTA4ICBTcmluaXZhc2FuIFZpamF5YXJhZ2hhdmFuICA8c3ZpamF5YXJhZ2hhdmFuQGFwcGxl LmNvbT4KIAogICAgICAgICBGaXggZXJyb3Ivd2FybmluZyBkdXBsaWNhdGlvbiBpbiBKU09OIGJp bmRpbmdzIHJlc3VsdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2Vy V2luZG93LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCmluZGV4IGI0 MjJjMTM1ZDY5Li5hNDk2NDY2ZjA3MiAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3Rr L0Jyb3dzZXJXaW5kb3cuYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRv dy5jCkBAIC0yNTksNyArMjU5LDE5IEBAIHN0YXRpYyB2b2lkIGJhY2tGb3J3YWRsaXN0Q2hhbmdl ZChXZWJLaXRCYWNrRm9yd2FyZExpc3QgKmJhY2tGb3J3YWRsaXN0LCBXZWJLaXRCCiAKIHN0YXRp YyB2b2lkIHdlYlZpZXdDbG9zZShXZWJLaXRXZWJWaWV3ICp3ZWJWaWV3LCBCcm93c2VyV2luZG93 ICp3aW5kb3cpCiB7Ci0gICAgZ3RrX3dpZGdldF9kZXN0cm95KEdUS19XSURHRVQod2luZG93KSk7 CisgICAgaW50IHRhYnNDb3VudCA9IGd0a19ub3RlYm9va19nZXRfbl9wYWdlcyhHVEtfTk9URUJP T0sod2luZG93LT5ub3RlYm9vaykpOworICAgIGlmICh0YWJzQ291bnQgPT0gMSkgeworICAgICAg ICBndGtfd2lkZ2V0X2Rlc3Ryb3koR1RLX1dJREdFVCh3aW5kb3cpKTsKKyAgICAgICAgcmV0dXJu OworICAgIH0KKworICAgIGZvciAoaW50IGkgPSAwOyBpIDwgdGFic0NvdW50OyArK2kpIHsKKyAg ICAgICAgQnJvd3NlclRhYiAqdGFiID0gKEJyb3dzZXJUYWIgKilndGtfbm90ZWJvb2tfZ2V0X250 aF9wYWdlKEdUS19OT1RFQk9PSyh3aW5kb3ctPm5vdGVib29rKSwgaSk7CisgICAgICAgIGlmIChi cm93c2VyX3RhYl9nZXRfd2ViX3ZpZXcodGFiKSA9PSB3ZWJWaWV3KSB7CisgICAgICAgICAgICBn dGtfd2lkZ2V0X2Rlc3Ryb3koR1RLX1dJREdFVCh0YWIpKTsKKyAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgfQorICAgIH0KIH0KIAogc3RhdGljIHZvaWQgd2ViVmlld1J1bkFzTW9kYWwoV2Vi S2l0V2ViVmlldyAqd2ViVmlldywgQnJvd3NlcldpbmRvdyAqd2luZG93KQpAQCAtODAwLDYgKzgx Miw5IEBAIHN0YXRpYyB2b2lkIGJyb3dzZXJXaW5kb3dTd2l0Y2hUYWIoR3RrTm90ZWJvb2sgKm5v dGVib29rLCBCcm93c2VyVGFiICp0YWIsIGd1aW50CiAgICAgICAgIFdlYktpdFdlYlZpZXcgKndl YlZpZXcgPSBicm93c2VyX3RhYl9nZXRfd2ViX3ZpZXcod2luZG93LT5hY3RpdmVUYWIpOwogICAg ICAgICBnX3NpZ25hbF9oYW5kbGVyc19kaXNjb25uZWN0X2J5X2RhdGEod2ViVmlldywgd2luZG93 KTsKIAorICAgICAgICAvKiBXZSBhbHdheXMgd2FudCBjbG9zZSB0byBiZSBjb25uZWN0ZWQgZXZl biBmb3Igbm90IGFjdGl2ZSB0YWJzICovCisgICAgICAgIGdfc2lnbmFsX2Nvbm5lY3Qod2ViVmll dywgImNsb3NlIiwgR19DQUxMQkFDSyh3ZWJWaWV3Q2xvc2UpLCB3aW5kb3cpOworCiAgICAgICAg IFdlYktpdEJhY2tGb3J3YXJkTGlzdCAqYmFja0ZvcndhZGxpc3QgPSB3ZWJraXRfd2ViX3ZpZXdf Z2V0X2JhY2tfZm9yd2FyZF9saXN0KHdlYlZpZXcpOwogICAgICAgICBnX3NpZ25hbF9oYW5kbGVy c19kaXNjb25uZWN0X2J5X2RhdGEoYmFja0ZvcndhZGxpc3QsIHdpbmRvdyk7CiAgICAgfQo=