169407 2017-03-09 01:54:27 -0800 Web Automation: automation commands hang when trying to navigate go/back and it's not possible 2017-05-12 10:06:29 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1285262 0 cgarcia 2017-03-09 01:54:27 -0800 Trying to navigate back or forward when there are no back/forward items makes the web driver to hang, because navigation callback is never called. 1285263 1 303901 cgarcia 2017-03-09 01:58:25 -0800 Created attachment 303901 Patch 1285937 2 303901 bburg 2017-03-10 15:09:32 -0800 Comment on attachment 303901 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303901&action=review r=me as well, nice catch. > Source/WebKit2/ChangeLog:8 > + Trying to navigate back or forward when there are no back/forward items makes the web driver to hang, because s/the web driver/automation command(s)/ There is no mention of WebDriver anywhere in the code, because WebAutomationSession and friends are intentionally isolated from WebDriver API and spec concerns. So I'd prefer you not plaster the name all over. =) 1287118 3 cgarcia 2017-03-13 02:21:49 -0700 Committed r213790: <http://trac.webkit.org/changeset/213790> 1307912 4 bburg 2017-05-12 10:06:29 -0700 <rdar://problem/30288513> 303901 2017-03-09 01:58:25 -0800 2017-03-10 07:40:28 -0800 Patch wk2-web-driver-go-back-forward.diff text/plain 2891 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ZmE1NWJlNzc2NS4uMzI4ZmRmNzMxNmQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNy0wMy0wOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgV2ViIEF1dG9tYXRpb246IHdlYiBkcml2ZXIgaGFuZ3Mgd2hl biBuYXZpZ2F0aW5nIGdvL2JhY2sgd2hlbiBub3QgcG9zc2libGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTQwNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRyeWluZyB0byBuYXZpZ2F0ZSBiYWNrIG9y IGZvcndhcmQgd2hlbiB0aGVyZSBhcmUgbm8gYmFjay9mb3J3YXJkIGl0ZW1zIG1ha2VzIHRoZSB3 ZWIgZHJpdmVyIHRvIGhhbmcsIGJlY2F1c2UKKyAgICAgICAgbmF2aWdhdGlvbiBjYWxsYmFjayBp cyBuZXZlciBjYWxsZWQuIFdlYlBhZ2VQcm94eSByZXR1cm5zIG51bGxwdHIgdG8gaW5kaWNhdGUg bm8gbmF2aWdhdGlvbiB3aWxsIHRha2UgcGxhY2UuIEluCisgICAgICAgIHRoYXQgY2FzZSB3ZSBj YW4gY29uc2lkZXIgdGhhdCB0aGUgb3BlcmF0aW9uIHN1Y2NlZWRlZCBsaWtlIG90aGVyIHdlYiBk cml2ZXIgaW1wbGVtZW50YXRpb25zIGRvLgorCisgICAgICAgICogVUlQcm9jZXNzL0F1dG9tYXRp b24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJBdXRvbWF0 aW9uU2Vzc2lvbjo6Z29CYWNrSW5Ccm93c2luZ0NvbnRleHQpOgorICAgICAgICAoV2ViS2l0OjpX ZWJBdXRvbWF0aW9uU2Vzc2lvbjo6Z29Gb3J3YXJkSW5Ccm93c2luZ0NvbnRleHQpOgorCiAyMDE3 LTAzLTA4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAg IEFkZCBwbHVtYmluZyBmb3IgV2ViQ29yZSB0byBub3RpZnkgV2ViS2l0MiB3aGVuIGFuIGVkaXQg ZHJhZyBoYXMgY29uY2x1ZGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKaW5kZXggZGU1YmU5ZTJk OTAuLmNiMWYzYjYzZjkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0 b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwCkBAIC0zMDksOSArMzA5 LDExIEBAIHZvaWQgV2ViQXV0b21hdGlvblNlc3Npb246OmdvQmFja0luQnJvd3NpbmdDb250ZXh0 KEluc3BlY3Rvcjo6RXJyb3JTdHJpbmcmIGVycm9yCiAKICAgICBpZiAoYXV0byBjYWxsYmFjayA9 IG1fcGVuZGluZ05hdmlnYXRpb25JbkJyb3dzaW5nQ29udGV4dENhbGxiYWNrc1BlclBhZ2UudGFr ZShwYWdlLT5wYWdlSUQoKSkpCiAgICAgICAgIGNhbGxiYWNrLT5zZW5kRmFpbHVyZShTVFJJTkdf Rk9SX1BSRURFRklORURfRVJST1JfTkFNRShUaW1lb3V0KSk7Ci0gICAgbV9wZW5kaW5nTmF2aWdh dGlvbkluQnJvd3NpbmdDb250ZXh0Q2FsbGJhY2tzUGVyUGFnZS5zZXQocGFnZS0+cGFnZUlEKCks IFdURk1vdmUoY2FsbGJhY2spKTsKIAotICAgIHBhZ2UtPmdvQmFjaygpOworICAgIGlmIChwYWdl LT5nb0JhY2soKSkKKyAgICAgICAgbV9wZW5kaW5nTmF2aWdhdGlvbkluQnJvd3NpbmdDb250ZXh0 Q2FsbGJhY2tzUGVyUGFnZS5zZXQocGFnZS0+cGFnZUlEKCksIFdURk1vdmUoY2FsbGJhY2spKTsK KyAgICBlbHNlCisgICAgICAgIGNhbGxiYWNrLT5zZW5kU3VjY2VzcygpOwogfQogCiB2b2lkIFdl YkF1dG9tYXRpb25TZXNzaW9uOjpnb0ZvcndhcmRJbkJyb3dzaW5nQ29udGV4dChJbnNwZWN0b3I6 OkVycm9yU3RyaW5nJiBlcnJvclN0cmluZywgY29uc3QgU3RyaW5nJiBoYW5kbGUsIFJlZjxHb0Zv cndhcmRJbkJyb3dzaW5nQ29udGV4dENhbGxiYWNrPiYmIGNhbGxiYWNrKQpAQCAtMzIyLDkgKzMy NCwxMSBAQCB2b2lkIFdlYkF1dG9tYXRpb25TZXNzaW9uOjpnb0ZvcndhcmRJbkJyb3dzaW5nQ29u dGV4dChJbnNwZWN0b3I6OkVycm9yU3RyaW5nJiBlcgogCiAgICAgaWYgKGF1dG8gY2FsbGJhY2sg PSBtX3BlbmRpbmdOYXZpZ2F0aW9uSW5Ccm93c2luZ0NvbnRleHRDYWxsYmFja3NQZXJQYWdlLnRh a2UocGFnZS0+cGFnZUlEKCkpKQogICAgICAgICBjYWxsYmFjay0+c2VuZEZhaWx1cmUoU1RSSU5H X0ZPUl9QUkVERUZJTkVEX0VSUk9SX05BTUUoVGltZW91dCkpOwotICAgIG1fcGVuZGluZ05hdmln YXRpb25JbkJyb3dzaW5nQ29udGV4dENhbGxiYWNrc1BlclBhZ2Uuc2V0KHBhZ2UtPnBhZ2VJRCgp LCBXVEZNb3ZlKGNhbGxiYWNrKSk7CiAKLSAgICBwYWdlLT5nb0ZvcndhcmQoKTsKKyAgICBpZiAo cGFnZS0+Z29Gb3J3YXJkKCkpCisgICAgICAgIG1fcGVuZGluZ05hdmlnYXRpb25JbkJyb3dzaW5n Q29udGV4dENhbGxiYWNrc1BlclBhZ2Uuc2V0KHBhZ2UtPnBhZ2VJRCgpLCBXVEZNb3ZlKGNhbGxi YWNrKSk7CisgICAgZWxzZQorICAgICAgICBjYWxsYmFjay0+c2VuZFN1Y2Nlc3MoKTsKIH0KIAog dm9pZCBXZWJBdXRvbWF0aW9uU2Vzc2lvbjo6cmVsb2FkQnJvd3NpbmdDb250ZXh0KEluc3BlY3Rv cjo6RXJyb3JTdHJpbmcmIGVycm9yU3RyaW5nLCBjb25zdCBTdHJpbmcmIGhhbmRsZSwgUmVmPFJl bG9hZEJyb3dzaW5nQ29udGV4dENhbGxiYWNrPiYmIGNhbGxiYWNrKQo=