169404 2017-03-08 21:22:56 -0800 Fix DataInteraction guards 2017-03-09 13:20:00 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 megan_gardner megan_gardner bdakin thorton wenson_hsieh oldest_to_newest 1285219 0 megan_gardner 2017-03-08 21:22:56 -0800 Fix DataInteraction guards 1285220 1 303895 megan_gardner 2017-03-08 21:23:17 -0800 Created attachment 303895 Patch 1285376 2 303930 megan_gardner 2017-03-09 10:12:12 -0800 Created attachment 303930 Patch 1285383 3 303930 wenson_hsieh 2017-03-09 10:25:40 -0800 Comment on attachment 303930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303930&action=review > Source/WebKit/mac/WebCoreSupport/WebDragClient.mm:217 > +#endif Does this #endif here correspond to the #if PLATFORM(MAC) above? This looks like it might cause WebDragClient::declareAndWriteAttachment to be implemented twice. 1285389 4 303935 megan_gardner 2017-03-09 10:34:29 -0800 Created attachment 303935 Patch 1285391 5 303935 wenson_hsieh 2017-03-09 10:36:08 -0800 Comment on attachment 303935 Patch r=mews 1285533 6 megan_gardner 2017-03-09 13:20:00 -0800 https://trac.webkit.org/r213660 303895 2017-03-08 21:23:17 -0800 2017-03-09 10:12:10 -0800 Patch bug-169404-20170308212316.patch text/plain 2033 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzYyNykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAzLTA4 ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4 IERhdGFJbnRlcmFjdGlvbiBndWFyZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2OTQwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRHJhZ0NsaWVudC5tbToKKwogMjAx Ny0wMy0wOCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgcGx1bWJpbmcgZm9yIFdlYkNvcmUgdG8gbm90aWZ5IFdlYktpdDIgd2hlbiBhbiBlZGl0 IGRyYWcgaGFzIGNvbmNsdWRlZApJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBv cnQvV2ViRHJhZ0NsaWVudC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJD b3JlU3VwcG9ydC9XZWJEcmFnQ2xpZW50Lm1tCShyZXZpc2lvbiAyMTM1ODgpCisrKyBTb3VyY2Uv V2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJEcmFnQ2xpZW50Lm1tCSh3b3JraW5nIGNvcHkp CkBAIC0xNzksNyArMTc5LDcgQEAgdm9pZCBXZWJEcmFnQ2xpZW50OjpkZWNsYXJlQW5kV3JpdGVB dHRhYwogfQogI2VuZGlmCiAKLSNlbHNlCisjZWxzZWlmICFFTkFCTEUoREFUQV9JTlRFUkFDVElP TikKIAogYm9vbCBXZWJEcmFnQ2xpZW50Ojp1c2VMZWdhY3lEcmFnQ2xpZW50KCkKIHsKQEAgLTIw MiwxMSArMjAyLDExIEBAIFdlYkNvcmU6OkRyYWdTb3VyY2VBY3Rpb24gV2ViRHJhZ0NsaWVudDoK IHZvaWQgV2ViRHJhZ0NsaWVudDo6d2lsbFBlcmZvcm1EcmFnU291cmNlQWN0aW9uKFdlYkNvcmU6 OkRyYWdTb3VyY2VBY3Rpb24sIGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiwgV2ViQ29yZTo6RGF0 YVRyYW5zZmVyJikKIHsKIH0KLSNpZiAhRU5BQkxFKERBVEFfSU5URVJBQ1RJT04pCisKIHZvaWQg V2ViRHJhZ0NsaWVudDo6c3RhcnREcmFnKFdlYkNvcmU6OkRyYWdJbWFnZSwgY29uc3QgSW50UG9p bnQmLCBjb25zdCBJbnRQb2ludCYsIGNvbnN0IEZsb2F0UG9pbnQmLCBEYXRhVHJhbnNmZXImLCBG cmFtZSYsIFdlYkNvcmU6OkRyYWdTb3VyY2VBY3Rpb24pCiB7CiB9Ci0jZW5kaWYKKwogdm9pZCBX ZWJEcmFnQ2xpZW50OjpiZWdpbkRyYWcoRHJhZ0l0ZW0sIEZyYW1lJiwgY29uc3QgSW50UG9pbnQm LCBjb25zdCBJbnRQb2ludCYsIERhdGFUcmFuc2ZlciYsIERyYWdTb3VyY2VBY3Rpb24pCiB7CiB9 CkBAIC0yMTQsNiArMjE0LDcgQEAgdm9pZCBXZWJEcmFnQ2xpZW50OjpiZWdpbkRyYWcoRHJhZ0l0 ZW0sIAogdm9pZCBXZWJEcmFnQ2xpZW50OjpkZWNsYXJlQW5kV3JpdGVEcmFnSW1hZ2UoY29uc3Qg U3RyaW5nJiwgRWxlbWVudCYsIGNvbnN0IFVSTCYsIGNvbnN0IFN0cmluZyYsIFdlYkNvcmU6OkZy YW1lKikKIHsKIH0KKyNlbmRpZgogCiAjaWYgRU5BQkxFKEFUVEFDSE1FTlRfRUxFTUVOVCkKIHZv aWQgV2ViRHJhZ0NsaWVudDo6ZGVjbGFyZUFuZFdyaXRlQXR0YWNobWVudChjb25zdCBTdHJpbmcm LCBFbGVtZW50JiwgY29uc3QgVVJMJiwgY29uc3QgU3RyaW5nJiwgV2ViQ29yZTo6RnJhbWUqKQpA QCAtMjIxLDggKzIyMiw2IEBAIHZvaWQgV2ViRHJhZ0NsaWVudDo6ZGVjbGFyZUFuZFdyaXRlQXR0 YWMKIH0KICNlbmRpZgogCi0jZW5kaWYKLQogdm9pZCBXZWJEcmFnQ2xpZW50OjpkcmFnQ29udHJv bGxlckRlc3Ryb3llZCgpIAogewogICAgIGRlbGV0ZSB0aGlzOwo= 303930 2017-03-09 10:12:12 -0800 2017-03-09 10:34:27 -0800 Patch bug-169404-20170309101212.patch text/plain 2031 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzYyNykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAzLTA4 ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4 IERhdGFJbnRlcmFjdGlvbiBndWFyZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2OTQwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRHJhZ0NsaWVudC5tbToKKwogMjAx Ny0wMy0wOCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgcGx1bWJpbmcgZm9yIFdlYkNvcmUgdG8gbm90aWZ5IFdlYktpdDIgd2hlbiBhbiBlZGl0 IGRyYWcgaGFzIGNvbmNsdWRlZApJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBv cnQvV2ViRHJhZ0NsaWVudC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJD b3JlU3VwcG9ydC9XZWJEcmFnQ2xpZW50Lm1tCShyZXZpc2lvbiAyMTM1ODgpCisrKyBTb3VyY2Uv V2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJEcmFnQ2xpZW50Lm1tCSh3b3JraW5nIGNvcHkp CkBAIC0xNzksNyArMTc5LDcgQEAgdm9pZCBXZWJEcmFnQ2xpZW50OjpkZWNsYXJlQW5kV3JpdGVB dHRhYwogfQogI2VuZGlmCiAKLSNlbHNlCisjZWxpZiAhRU5BQkxFKERBVEFfSU5URVJBQ1RJT04p CiAKIGJvb2wgV2ViRHJhZ0NsaWVudDo6dXNlTGVnYWN5RHJhZ0NsaWVudCgpCiB7CkBAIC0yMDIs MTEgKzIwMiwxMSBAQCBXZWJDb3JlOjpEcmFnU291cmNlQWN0aW9uIFdlYkRyYWdDbGllbnQ6CiB2 b2lkIFdlYkRyYWdDbGllbnQ6OndpbGxQZXJmb3JtRHJhZ1NvdXJjZUFjdGlvbihXZWJDb3JlOjpE cmFnU291cmNlQWN0aW9uLCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYsIFdlYkNvcmU6OkRhdGFU cmFuc2ZlciYpCiB7CiB9Ci0jaWYgIUVOQUJMRShEQVRBX0lOVEVSQUNUSU9OKQorCiB2b2lkIFdl YkRyYWdDbGllbnQ6OnN0YXJ0RHJhZyhXZWJDb3JlOjpEcmFnSW1hZ2UsIGNvbnN0IEludFBvaW50 JiwgY29uc3QgSW50UG9pbnQmLCBjb25zdCBGbG9hdFBvaW50JiwgRGF0YVRyYW5zZmVyJiwgRnJh bWUmLCBXZWJDb3JlOjpEcmFnU291cmNlQWN0aW9uKQogewogfQotI2VuZGlmCisKIHZvaWQgV2Vi RHJhZ0NsaWVudDo6YmVnaW5EcmFnKERyYWdJdGVtLCBGcmFtZSYsIGNvbnN0IEludFBvaW50Jiwg Y29uc3QgSW50UG9pbnQmLCBEYXRhVHJhbnNmZXImLCBEcmFnU291cmNlQWN0aW9uKQogewogfQpA QCAtMjE0LDYgKzIxNCw3IEBAIHZvaWQgV2ViRHJhZ0NsaWVudDo6YmVnaW5EcmFnKERyYWdJdGVt LCAKIHZvaWQgV2ViRHJhZ0NsaWVudDo6ZGVjbGFyZUFuZFdyaXRlRHJhZ0ltYWdlKGNvbnN0IFN0 cmluZyYsIEVsZW1lbnQmLCBjb25zdCBVUkwmLCBjb25zdCBTdHJpbmcmLCBXZWJDb3JlOjpGcmFt ZSopCiB7CiB9CisjZW5kaWYKIAogI2lmIEVOQUJMRShBVFRBQ0hNRU5UX0VMRU1FTlQpCiB2b2lk IFdlYkRyYWdDbGllbnQ6OmRlY2xhcmVBbmRXcml0ZUF0dGFjaG1lbnQoY29uc3QgU3RyaW5nJiwg RWxlbWVudCYsIGNvbnN0IFVSTCYsIGNvbnN0IFN0cmluZyYsIFdlYkNvcmU6OkZyYW1lKikKQEAg LTIyMSw4ICsyMjIsNiBAQCB2b2lkIFdlYkRyYWdDbGllbnQ6OmRlY2xhcmVBbmRXcml0ZUF0dGFj CiB9CiAjZW5kaWYKIAotI2VuZGlmCi0KIHZvaWQgV2ViRHJhZ0NsaWVudDo6ZHJhZ0NvbnRyb2xs ZXJEZXN0cm95ZWQoKSAKIHsKICAgICBkZWxldGUgdGhpczsK 303935 2017-03-09 10:34:29 -0800 2017-03-09 10:36:08 -0800 Patch bug-169404-20170309103429.patch text/plain 1538 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzYyNykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAzLTA4 ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4 IERhdGFJbnRlcmFjdGlvbiBndWFyZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2OTQwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRHJhZ0NsaWVudC5tbToKKwogMjAx Ny0wMy0wOCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgcGx1bWJpbmcgZm9yIFdlYkNvcmUgdG8gbm90aWZ5IFdlYktpdDIgd2hlbiBhbiBlZGl0 IGRyYWcgaGFzIGNvbmNsdWRlZApJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBv cnQvV2ViRHJhZ0NsaWVudC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJD b3JlU3VwcG9ydC9XZWJEcmFnQ2xpZW50Lm1tCShyZXZpc2lvbiAyMTM1ODgpCisrKyBTb3VyY2Uv V2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJEcmFnQ2xpZW50Lm1tCSh3b3JraW5nIGNvcHkp CkBAIC0xNzksNyArMTc5LDcgQEAgdm9pZCBXZWJEcmFnQ2xpZW50OjpkZWNsYXJlQW5kV3JpdGVB dHRhYwogfQogI2VuZGlmCiAKLSNlbHNlCisjZWxpZiAhRU5BQkxFKERBVEFfSU5URVJBQ1RJT04p CiAKIGJvb2wgV2ViRHJhZ0NsaWVudDo6dXNlTGVnYWN5RHJhZ0NsaWVudCgpCiB7CkBAIC0yMDIs MTEgKzIwMiwxMSBAQCBXZWJDb3JlOjpEcmFnU291cmNlQWN0aW9uIFdlYkRyYWdDbGllbnQ6CiB2 b2lkIFdlYkRyYWdDbGllbnQ6OndpbGxQZXJmb3JtRHJhZ1NvdXJjZUFjdGlvbihXZWJDb3JlOjpE cmFnU291cmNlQWN0aW9uLCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYsIFdlYkNvcmU6OkRhdGFU cmFuc2ZlciYpCiB7CiB9Ci0jaWYgIUVOQUJMRShEQVRBX0lOVEVSQUNUSU9OKQorCiB2b2lkIFdl YkRyYWdDbGllbnQ6OnN0YXJ0RHJhZyhXZWJDb3JlOjpEcmFnSW1hZ2UsIGNvbnN0IEludFBvaW50 JiwgY29uc3QgSW50UG9pbnQmLCBjb25zdCBGbG9hdFBvaW50JiwgRGF0YVRyYW5zZmVyJiwgRnJh bWUmLCBXZWJDb3JlOjpEcmFnU291cmNlQWN0aW9uKQogewogfQotI2VuZGlmCisKIHZvaWQgV2Vi RHJhZ0NsaWVudDo6YmVnaW5EcmFnKERyYWdJdGVtLCBGcmFtZSYsIGNvbnN0IEludFBvaW50Jiwg Y29uc3QgSW50UG9pbnQmLCBEYXRhVHJhbnNmZXImLCBEcmFnU291cmNlQWN0aW9uKQogewogfQo=