169385 2017-03-08 14:29:56 -0800 webkitpy: Add unit test to prevent breakage of EWS 2017-03-09 11:08:45 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbedard jbedard commit-queue glenn lforschler webkit oldest_to_newest 1285025 0 jbedard 2017-03-08 14:29:56 -0800 We should have a test to prevent something like <http://trac.webkit.org/changeset/213545> from happening in the future. 1285027 1 303846 jbedard 2017-03-08 14:31:02 -0800 Created attachment 303846 Patch 1285057 2 303846 webkit 2017-03-08 15:33:17 -0800 Comment on attachment 303846 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303846&action=review Nice test! I'd suggest making more use of python's in-built types to keep the code more readable, something like below: > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:177 > + expected_names = [ > + 'gtk-wk2-ews', > + 'win-ews', > + 'ios-ews', > + 'ios-sim-ews', > + 'mac-ews', > + 'mac-wk2-ews', > + 'mac-debug-ews', > + 'mac-32bit-ews', > + 'jsc-ews', > + ] > + classes = AbstractEarlyWarningSystem.load_ews_classes() > + for name in expected_names: > + flag = False > + for cls in classes: > + if name == cls.name: > + flag = True > + break > + if not flag: > + raise Exception("'{}' is not a valid EWS command but is used by EWS's infrastructure".format(name)) expected_names = set([ 'gtk-wk2-ews', 'gtk-wk2-ews', 'win-ews', 'ios-ews', 'ios-sim-ews', 'mac-ews', 'mac-wk2-ews', 'mac-debug-ews', 'mac-32bit-ews', 'jsc-ews', ]) classes = AbstractEarlyWarningSystem.load_ews_classes() names = set([cls.name for cls in classes]) unexpected_names = names - expected_names if unexpected_names: raise Exception("'{}' is not a valid EWS command but is used by EWS's infrastructure".format(unexpected_names.pop())) 1285065 3 webkit 2017-03-08 15:53:19 -0800 Actually, since we're ultimately inheriting from unittest.TestCase, raise an AssertionError("message") instead of the generic Exception. 1285070 4 303858 jbedard 2017-03-08 16:03:39 -0800 Created attachment 303858 Patch 1285071 5 303859 jbedard 2017-03-08 16:04:58 -0800 Created attachment 303859 Patch 1285340 6 303859 ap 2017-03-09 09:35:12 -0800 Comment on attachment 303859 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303859&action=review > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:157 > + # These are the names EWS's infrastructure expects, check that they work Can the test get the names from ews.json? Those are the ones that the infrastructure really expects. > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:169 > + classes = AbstractEarlyWarningSystem.load_ews_classes() Is this a persistent change that can affect other tests? Adding new globally defined classes seems less than ideal if that can be avoided. But other EWS tests already do the same, so I think that the patch doesn't make it worse. 1285355 7 303859 jbedard 2017-03-09 09:42:48 -0800 Comment on attachment 303859 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303859&action=review >> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:157 >> + # These are the names EWS's infrastructure expects, check that they work > > Can the test get the names from ews.json? Those are the ones that the infrastructure really expects. So this is actually exactly what is being tested here. 'load_ews_classes()' reads from ews.json and parses the names of the ports themselves and uses that combination to construct commands. This list of commands is essentially what our EWS infrastructure currently expects to be able to run. If we intend to change this infrastructure, this set would need to be modified. I think this is the right way to test this, though. It is not intuitive that changing the name of a port in webkitpy could break EWS because changing the port name will change the EWS command. 1285367 8 303859 dean_johnson 2017-03-09 10:04:17 -0800 Comment on attachment 303859 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303859&action=review > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:158 > + expected_names = set([ This could be constructed without a set cast by using {} (Python's set syntax). It would look like the following expected_names = { 'gtk-wk2-ews', ...., 'jsc-ews', } > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:170 > + names = set([cls.name for cls in classes]) Similarly: names = {cls.name for cls in classes} 1285384 9 303932 jbedard 2017-03-09 10:28:40 -0800 Created attachment 303932 Patch for landing 1285390 10 webkit 2017-03-09 10:36:03 -0800 I didn't suggest the set literal syntax since it's 2.7 only, but I guess the bots have all been updated now. 1285401 11 303932 commit-queue 2017-03-09 11:08:41 -0800 Comment on attachment 303932 Patch for landing Clearing flags on attachment: 303932 Committed r213651: <http://trac.webkit.org/changeset/213651> 1285402 12 commit-queue 2017-03-09 11:08:45 -0800 All reviewed patches have been landed. Closing bug. 303846 2017-03-08 14:31:02 -0800 2017-03-08 16:03:37 -0800 Patch bug-169385-20170308143101.patch text/plain 2067 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMzU5NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTAzLTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogQWRkIHVuaXQgdGVzdCB0byBwcmV2ZW50IGJyZWFrYWdl IG9mIEVXUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY5Mzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UHJldmVudCA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjEzNTQ1PiBmcm9tIGhh cHBlbmluZyBpbiB0aGUgZnV0dXJlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weToKKyAgICAgICAgKHRlc3Rf ZXdzX25hbWUpOiBBZGRlZC4KKwogMjAxNy0wMy0wOCAgTWF0dCBSYWpjYSAgPG1yYWpjYUBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIHVwZGF0aW5nIGF1dG9wbGF5IHBvbGlj aWVzIGFmdGVyIGEgcGFnZSBoYXMgYmVlbiBsb2FkZWQuCkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5p bmdzeXN0ZW1fdW5pdHRlc3QucHkJKHJldmlzaW9uIDIxMzU5MykKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkJKHdv cmtpbmcgY29weSkKQEAgLTE1MiwzICsxNTIsMjYgQEAgUnVubmluZzogd2Via2l0LXBhdGNoIC0t c3RhdHVzLWhvc3Q9ZXhhbQogICAgICAgICB0ZXN0X2NsYXNzZXMgPSBmaWx0ZXIobGFtYmRhIHg6 IHgucnVuX3Rlc3RzIGFuZCB4Lmdyb3VwID09ICJqc2MiLCBjbGFzc2VzKQogICAgICAgICBmb3Ig ZXdzX2NsYXNzIGluIHRlc3RfY2xhc3NlczoKICAgICAgICAgICAgIHNlbGYuX3Rlc3RfZXdzKGV3 c19jbGFzcygpLCBGYWxzZSkKKworICAgIGRlZiB0ZXN0X2V3c19uYW1lKHNlbGYpOgorICAgICAg ICAjIFRoZXNlIGFyZSB0aGUgbmFtZXMgRVdTJ3MgaW5mcmFzdHJ1Y3R1cmUgZXhwZWN0cywgY2hl Y2sgdGhhdCB0aGV5IHdvcmsKKyAgICAgICAgZXhwZWN0ZWRfbmFtZXMgPSBbCisgICAgICAgICAg ICAnZ3RrLXdrMi1ld3MnLAorICAgICAgICAgICAgJ3dpbi1ld3MnLAorICAgICAgICAgICAgJ2lv cy1ld3MnLAorICAgICAgICAgICAgJ2lvcy1zaW0tZXdzJywKKyAgICAgICAgICAgICdtYWMtZXdz JywKKyAgICAgICAgICAgICdtYWMtd2syLWV3cycsCisgICAgICAgICAgICAnbWFjLWRlYnVnLWV3 cycsCisgICAgICAgICAgICAnbWFjLTMyYml0LWV3cycsCisgICAgICAgICAgICAnanNjLWV3cycs CisgICAgICAgIF0KKyAgICAgICAgY2xhc3NlcyA9IEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVt LmxvYWRfZXdzX2NsYXNzZXMoKQorICAgICAgICBmb3IgbmFtZSBpbiBleHBlY3RlZF9uYW1lczoK KyAgICAgICAgICAgIGZsYWcgPSBGYWxzZQorICAgICAgICAgICAgZm9yIGNscyBpbiBjbGFzc2Vz OgorICAgICAgICAgICAgICAgIGlmIG5hbWUgPT0gY2xzLm5hbWU6CisgICAgICAgICAgICAgICAg ICAgIGZsYWcgPSBUcnVlCisgICAgICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgICAgICBp ZiBub3QgZmxhZzoKKyAgICAgICAgICAgICAgICByYWlzZSBFeGNlcHRpb24oIid7fScgaXMgbm90 IGEgdmFsaWQgRVdTIGNvbW1hbmQgYnV0IGlzIHVzZWQgYnkgRVdTJ3MgaW5mcmFzdHJ1Y3R1cmUi LmZvcm1hdChuYW1lKSkK 303858 2017-03-08 16:03:39 -0800 2017-03-08 16:04:56 -0800 Patch bug-169385-20170308160338.patch text/plain 2004 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMzYwMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTAzLTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogQWRkIHVuaXQgdGVzdCB0byBwcmV2ZW50IGJyZWFrYWdl IG9mIEVXUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY5Mzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UHJldmVudCA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjEzNTQ1PiBmcm9tIGhh cHBlbmluZyBpbiB0aGUgZnV0dXJlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weToKKyAgICAgICAgKHRlc3Rf ZXdzX25hbWUpOiBBZGRlZC4KKwogMjAxNy0wMy0wOCAgTWF0dCBSYWpjYSAgPG1yYWpjYUBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIHVwZGF0aW5nIGF1dG9wbGF5IHBvbGlj aWVzIGFmdGVyIGEgcGFnZSBoYXMgYmVlbiBsb2FkZWQuCkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5p bmdzeXN0ZW1fdW5pdHRlc3QucHkJKHJldmlzaW9uIDIxMzYwMykKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkJKHdv cmtpbmcgY29weSkKQEAgLTE1MiwzICsxNTIsMjIgQEAgUnVubmluZzogd2Via2l0LXBhdGNoIC0t c3RhdHVzLWhvc3Q9ZXhhbQogICAgICAgICB0ZXN0X2NsYXNzZXMgPSBmaWx0ZXIobGFtYmRhIHg6 IHgucnVuX3Rlc3RzIGFuZCB4Lmdyb3VwID09ICJqc2MiLCBjbGFzc2VzKQogICAgICAgICBmb3Ig ZXdzX2NsYXNzIGluIHRlc3RfY2xhc3NlczoKICAgICAgICAgICAgIHNlbGYuX3Rlc3RfZXdzKGV3 c19jbGFzcygpLCBGYWxzZSkKKworICAgIGRlZiB0ZXN0X2V3c19uYW1lKHNlbGYpOgorICAgICAg ICAjIFRoZXNlIGFyZSB0aGUgbmFtZXMgRVdTJ3MgaW5mcmFzdHJ1Y3R1cmUgZXhwZWN0cywgY2hl Y2sgdGhhdCB0aGV5IHdvcmsKKyAgICAgICAgZXhwZWN0ZWRfbmFtZXMgPSBzZXQoWworICAgICAg ICAgICAgJ2d0ay13azItZXdzJywKKyAgICAgICAgICAgICd3aW4tZXdzJywKKyAgICAgICAgICAg ICdpb3MtZXdzJywKKyAgICAgICAgICAgICdpb3Mtc2ltLWV3cycsCisgICAgICAgICAgICAnbWFj LWV3cycsCisgICAgICAgICAgICAnbWFjLXdrMi1ld3MnLAorICAgICAgICAgICAgJ21hYy1kZWJ1 Zy1ld3MnLAorICAgICAgICAgICAgJ21hYy0zMmJpdC1ld3MnLAorICAgICAgICAgICAgJ2pzYy1l d3MnLAorICAgICAgICBdKQorICAgICAgICBjbGFzc2VzID0gQWJzdHJhY3RFYXJseVdhcm5pbmdT eXN0ZW0ubG9hZF9ld3NfY2xhc3NlcygpCisgICAgICAgIG5hbWVzID0gc2V0KFtjbHMubmFtZSBm b3IgY2xzIGluIGNsYXNzZXNdKQorICAgICAgICB1bmV4cGVjdGVkX25hbWVzID0gbmFtZXMgLSBl eHBlY3RlZF9uYW1lcworICAgICAgICBpZiB1bmV4cGVjdGVkX25hbWVzOgorICAgICAgICAgICAg cmFpc2UgQXNzZXJ0aW9uRXJyb3IoIid7fScgaXMgbm90IGEgdmFsaWQgRVdTIGNvbW1hbmQgYnV0 IGlzIHVzZWQgYnkgRVdTJ3MgaW5mcmFzdHJ1Y3R1cmUiLmZvcm1hdCh1bmV4cGVjdGVkX25hbWVz LnBvcCgpKSkK 303859 2017-03-08 16:04:58 -0800 2017-03-09 10:28:37 -0800 Patch bug-169385-20170308160457.patch text/plain 2004 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMzYwMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTAzLTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogQWRkIHVuaXQgdGVzdCB0byBwcmV2ZW50IGJyZWFrYWdl IG9mIEVXUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY5Mzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UHJldmVudCA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjEzNTQ1PiBmcm9tIGhh cHBlbmluZyBpbiB0aGUgZnV0dXJlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weToKKyAgICAgICAgKHRlc3Rf ZXdzX25hbWUpOiBBZGRlZC4KKwogMjAxNy0wMy0wOCAgTWF0dCBSYWpjYSAgPG1yYWpjYUBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIHVwZGF0aW5nIGF1dG9wbGF5IHBvbGlj aWVzIGFmdGVyIGEgcGFnZSBoYXMgYmVlbiBsb2FkZWQuCkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5p bmdzeXN0ZW1fdW5pdHRlc3QucHkJKHJldmlzaW9uIDIxMzYwMykKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkJKHdv cmtpbmcgY29weSkKQEAgLTE1MiwzICsxNTIsMjIgQEAgUnVubmluZzogd2Via2l0LXBhdGNoIC0t c3RhdHVzLWhvc3Q9ZXhhbQogICAgICAgICB0ZXN0X2NsYXNzZXMgPSBmaWx0ZXIobGFtYmRhIHg6 IHgucnVuX3Rlc3RzIGFuZCB4Lmdyb3VwID09ICJqc2MiLCBjbGFzc2VzKQogICAgICAgICBmb3Ig ZXdzX2NsYXNzIGluIHRlc3RfY2xhc3NlczoKICAgICAgICAgICAgIHNlbGYuX3Rlc3RfZXdzKGV3 c19jbGFzcygpLCBGYWxzZSkKKworICAgIGRlZiB0ZXN0X2V3c19uYW1lKHNlbGYpOgorICAgICAg ICAjIFRoZXNlIGFyZSB0aGUgbmFtZXMgRVdTJ3MgaW5mcmFzdHJ1Y3R1cmUgZXhwZWN0cywgY2hl Y2sgdGhhdCB0aGV5IHdvcmsKKyAgICAgICAgZXhwZWN0ZWRfbmFtZXMgPSBzZXQoWworICAgICAg ICAgICAgJ2d0ay13azItZXdzJywKKyAgICAgICAgICAgICd3aW4tZXdzJywKKyAgICAgICAgICAg ICdpb3MtZXdzJywKKyAgICAgICAgICAgICdpb3Mtc2ltLWV3cycsCisgICAgICAgICAgICAnbWFj LWV3cycsCisgICAgICAgICAgICAnbWFjLXdrMi1ld3MnLAorICAgICAgICAgICAgJ21hYy1kZWJ1 Zy1ld3MnLAorICAgICAgICAgICAgJ21hYy0zMmJpdC1ld3MnLAorICAgICAgICAgICAgJ2pzYy1l d3MnLAorICAgICAgICBdKQorICAgICAgICBjbGFzc2VzID0gQWJzdHJhY3RFYXJseVdhcm5pbmdT eXN0ZW0ubG9hZF9ld3NfY2xhc3NlcygpCisgICAgICAgIG5hbWVzID0gc2V0KFtjbHMubmFtZSBm b3IgY2xzIGluIGNsYXNzZXNdKQorICAgICAgICB1bmV4cGVjdGVkX25hbWVzID0gZXhwZWN0ZWRf bmFtZXMgLSBuYW1lcworICAgICAgICBpZiB1bmV4cGVjdGVkX25hbWVzOgorICAgICAgICAgICAg cmFpc2UgQXNzZXJ0aW9uRXJyb3IoIid7fScgaXMgbm90IGEgdmFsaWQgRVdTIGNvbW1hbmQgYnV0 IGlzIHVzZWQgYnkgRVdTJ3MgaW5mcmFzdHJ1Y3R1cmUiLmZvcm1hdCh1bmV4cGVjdGVkX25hbWVz LnBvcCgpKSkK 303932 2017-03-09 10:28:40 -0800 2017-03-09 11:08:41 -0800 Patch for landing bug-169385-20170309102839.patch text/plain 2194 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMzY0NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTAzLTA5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogQWRkIHVuaXQgdGVzdCB0byBwcmV2ZW50IGJyZWFrYWdl IG9mIEVXUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY5Mzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAg ICAgICBQcmV2ZW50IDxodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yMTM1NDU+IGZy b20gaGFwcGVuaW5nIGluIHRoZSBmdXR1cmUuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5OgorICAgICAgICAo dGVzdF9ld3NfbmFtZSk6IEFkZGVkLgorCiAyMDE3LTAzLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CiAKICAgICAgICAgV1RGIHNob3VsZCBtYWtlIGl0IHN1cGVyIGVhc3kgdG8g ZG8gQVJNIGNvbmN1cnJlbmN5IHRyaWNrcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVt X3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyMTM2NDYpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNv cHkpCkBAIC0xNTIsMyArMTUyLDI1IEBAIFJ1bm5pbmc6IHdlYmtpdC1wYXRjaCAtLXN0YXR1cy1o b3N0PWV4YW0KICAgICAgICAgdGVzdF9jbGFzc2VzID0gZmlsdGVyKGxhbWJkYSB4OiB4LnJ1bl90 ZXN0cyBhbmQgeC5ncm91cCA9PSAianNjIiwgY2xhc3NlcykKICAgICAgICAgZm9yIGV3c19jbGFz cyBpbiB0ZXN0X2NsYXNzZXM6CiAgICAgICAgICAgICBzZWxmLl90ZXN0X2V3cyhld3NfY2xhc3Mo KSwgRmFsc2UpCisKKyAgICBkZWYgdGVzdF9ld3NfbmFtZShzZWxmKToKKyAgICAgICAgIyBUaGVz ZSBhcmUgdGhlIG5hbWVzIEVXUydzIGluZnJhc3RydWN0dXJlIGV4cGVjdHMsIGNoZWNrIHRoYXQg dGhleSB3b3JrCisgICAgICAgIGV4cGVjdGVkX25hbWVzID0geworICAgICAgICAgICAgJ2d0ay13 azItZXdzJywKKyAgICAgICAgICAgICd3aW4tZXdzJywKKyAgICAgICAgICAgICdpb3MtZXdzJywK KyAgICAgICAgICAgICdpb3Mtc2ltLWV3cycsCisgICAgICAgICAgICAnbWFjLWV3cycsCisgICAg ICAgICAgICAnbWFjLXdrMi1ld3MnLAorICAgICAgICAgICAgJ21hYy1kZWJ1Zy1ld3MnLAorICAg ICAgICAgICAgJ21hYy0zMmJpdC1ld3MnLAorICAgICAgICAgICAgJ2pzYy1ld3MnLAorICAgICAg ICB9CisgICAgICAgIGNsYXNzZXMgPSBBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbS5sb2FkX2V3 c19jbGFzc2VzKCkKKyAgICAgICAgbmFtZXMgPSB7Y2xzLm5hbWUgZm9yIGNscyBpbiBjbGFzc2Vz fQorICAgICAgICBtaXNzaW5nX25hbWVzID0gZXhwZWN0ZWRfbmFtZXMgLSBuYW1lcworICAgICAg ICB1bmV4cGVjdGVkX25hbWVzID0gbmFtZXMgLSBleHBlY3RlZF9uYW1lcworICAgICAgICBpZiBt aXNzaW5nX25hbWVzOgorICAgICAgICAgICAgcmFpc2UgQXNzZXJ0aW9uRXJyb3IoIid7fScgaXMg bm90IGEgdmFsaWQgRVdTIGNvbW1hbmQgYnV0IGlzIHVzZWQgYnkgRVdTJ3MgaW5mcmFzdHJ1Y3R1 cmUiLmZvcm1hdChtaXNzaW5nX25hbWVzLnBvcCgpKSkKKyAgICAgICAgaWYgdW5leHBlY3RlZF9u YW1lczoKKyAgICAgICAgICAgIHJhaXNlIEFzc2VydGlvbkVycm9yKCIne30nIGlzIGEgdmFsaWQg RVdTIGNvbW1hbmQgYnV0IGlzIG5vdCB1c2VkIGJ5IEVXUydzIGluZnJhc3RydWN0dXJlIi5mb3Jt YXQodW5leHBlY3RlZF9uYW1lcy5wb3AoKSkpCg==