169383 2017-03-08 14:05:51 -0800 Use H264 hardware encoder for Mac libwebrtc 2017-03-23 09:41:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen commit-queue eric.carlson jer.noble jonlee webkit-bug-importer oldest_to_newest 1285007 0 youennf 2017-03-08 14:05:51 -0800 Currently we are only using the software one 1285054 1 303853 youennf 2017-03-08 15:30:05 -0800 Created attachment 303853 Patch 1285056 2 commit-queue 2017-03-08 15:31:45 -0800 Attachment 303853 did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:558: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:560: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:561: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:562: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:580: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:582: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:582: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:586: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:588: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:590: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 13 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1285080 3 303853 commit-queue 2017-03-08 16:21:12 -0800 Comment on attachment 303853 Patch Clearing flags on attachment: 303853 Committed r213605: <http://trac.webkit.org/changeset/213605> 1285081 4 commit-queue 2017-03-08 16:21:16 -0800 All reviewed patches have been landed. Closing bug. 1290472 5 webkit-bug-importer 2017-03-23 09:37:19 -0700 <rdar://problem/31221148> 303853 2017-03-08 15:30:05 -0800 2017-03-08 16:21:12 -0800 Patch bug-169383-20170308153004.patch text/plain 4812 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzNTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCAzZjdkMjk5MDZlODIzMjI5MGQzNWMzYzAwMzBiYjEyMjRmOTU2Yjg0Li5mOWI4 OTNkYmE0Nzc2MGQ1YWViMmE3NGMwMjE3MzA0OTNlMDNjN2M2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNy0wMy0wOCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIEgyNjQgaGFyZHdhcmUgZW5j b2RlciBmb3IgTWFjIGxpYndlYnJ0YworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY5MzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU3dpdGNoaW5nIHRvIEgyNjQgaGFyZHdhcmUgZW5jb2RlciBpZiBhdmFp bGFibGUgZm9yIE1hYy4KKyAgICAgICAgQWRkaW5nIGxvZ3MgaW4gY2FzZSBoYXJkd2FyZSBlbmNv ZGVyIGNhbm5vdCBiZSB1c2VkLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvbGlid2VicnRj LnhjY29uZmlnOgorICAgICAgICAqIFNvdXJjZS93ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0Ns YXNzZXMvaDI2NF92aWRlb190b29sYm94X2VuY29kZXIubW06CisgICAgICAgICh3ZWJydGM6Okgy NjRWaWRlb1Rvb2xib3hFbmNvZGVyOjpSZXNldENvbXByZXNzaW9uU2Vzc2lvbik6CisgICAgICAg ICh3ZWJydGM6OkgyNjRWaWRlb1Rvb2xib3hFbmNvZGVyOjpDb25maWd1cmVDb21wcmVzc2lvblNl c3Npb24pOgorCiAyMDE3LTAzLTA3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4K IAogICAgICAgICBUdXJuUG9ydDo6T25Tb2NrZXRDb25uZWN0IGlzIGNyYXNoaW5nCmRpZmYgLS1n aXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlvbnMvbGlid2VicnRj LnhjY29uZmlnIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NvbmZpZ3VyYXRpb25zL2xp YndlYnJ0Yy54Y2NvbmZpZwppbmRleCAyZDgxNTcwZDkwNDJhNmFkNTI5NzkxYzUwNmIxZjViYzQ0 OWQ5ZWM3Li5jNWY1NGRhNmFiOTljMzI1OGQ4ZTE5Yzc1OWUxZTdmMTk5YzlkZGNkIDEwMDY0NAot LS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlvbnMvbGlid2VicnRj LnhjY29uZmlnCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9u cy9saWJ3ZWJydGMueGNjb25maWcKQEAgLTI4LDcgKzI4LDcgQEAgV0FSTklOR19DRkxBR1MgPSAt V25vLWV4aXQtdGltZS1kZXN0cnVjdG9ycyAtV25vLW9iamMtcHJvcGVydHktbm8tYXR0cmlidXRl IC1Xbm8KIAogR0NDX1BSRVBST0NFU1NPUl9ERUZJTklUSU9OUyA9IFdFQlJUQ19QT1NJWCBXRUJS VENfTUFDIFNTTF9VU0VfT1BFTlNTTCBGRUFUVVJFX0VOQUJMRV9TU0wgSEFWRV9TUlRQIEhBVkVf T1BFTlNTTF9TU0xfSCBTQ1RQX1BST0NFU1NfTEVWRUxfTE9DS1MgU0NUUF9TSU1QTEVfQUxMT0NB VE9SIFNDVFBfVVNFX09QRU5TU0xfU0hBMSBfX1VzZXJzcGFjZV9fIEhBVkVfU0FfTEVOIEhBVkVf U0NPTk5fTEVOIF9fQVBQTEVfVVNFX1JGQ18yMjkyIF9fVXNlcnNwYWNlX29zX0RhcndpbiBOT05f V0lORE9XU19ERUZJTkUgSEFWRV9XRUJSVENfVklERU8gSEFWRV9XRUJSVENfVk9JQ0UgV0VCUlRD X0lOVEVMTElHSUJJTElUWV9FTkhBTkNFUj0wIFdFQlJUQ19BUE1fREVCVUdfRFVNUD0wIFdFQlJU Q19OU19GTE9BVCBXRUJSVENfQ09ERUNfSUxCQyBXRUJSVENfQ09ERUNfT1BVUyBXRUJSVENfQ09E RUNfSVNBQyBXRUJSVENfQ09ERUNfUkVEIFJUQ19ESVNBQkxFX1ZQOSBSVENfRElTQUJMRV9WUDgg SEFWRV9TVERJTlRfSCBIQVZFX1NURExJQl9IIEhBVkVfVUlOVDY0X1QgT1BFTlNTTCBIQVZFX0NP TkZJR19IIFdFQlJUQ19XRUJLSVRfQlVJTEQgSEFWRV9QVEhSRUFEX0NPTkRfVElNRURXQUlUX1JF TEFUSVZFICBIQVZFX1NDVFAgV0VCUlRDX0NPREVDX0c3MTEgV0VCUlRDX0NPREVDX0c3MjI7CiAK LUdDQ19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlNbc2RrPW1hY29zeCpdID0gJChpbmhlcml0ZWQp OworR0NDX1BSRVBST0NFU1NPUl9ERUZJTklUSU9OU1tzZGs9bWFjb3N4Kl0gPSAkKGluaGVyaXRl ZCkgV0VCUlRDX1VTRV9WVEJfSEFSRFdBUkVfRU5DT0RFUjsKIEdDQ19QUkVQUk9DRVNTT1JfREVG SU5JVElPTlNbc2RrPWlwaG9uZW9zKl0gPSAkKGluaGVyaXRlZCkgV0VCUlRDX0lPUzsKIEdDQ19Q UkVQUk9DRVNTT1JfREVGSU5JVElPTlNbc2RrPWlwaG9uZXNpbXVsYXRvcipdID0gJChpbmhlcml0 ZWQpIFdFQlJUQ19JT1M7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0 Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpjL0ZyYW1ld29yay9DbGFzc2VzL2gyNjRfdmlkZW9fdG9v bGJveF9lbmNvZGVyLm1tIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJy dGMvc2RrL29iamMvRnJhbWV3b3JrL0NsYXNzZXMvaDI2NF92aWRlb190b29sYm94X2VuY29kZXIu bW0KaW5kZXggNGQ0YTE0MWZjMWM4MjAwM2Q0YjcxMjU4ZDNhOThkZGQyNTU2MDY4NC4uMzdmYmM5 MTE0NGMwYTU5NDE3NzRjZGNkMmIxMjA2NDkxZDVlZTg5MyAxMDA2NDQKLS0tIGEvU291cmNlL1Ro aXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0NsYXNz ZXMvaDI2NF92aWRlb190b29sYm94X2VuY29kZXIubW0KKysrIGIvU291cmNlL1RoaXJkUGFydHkv bGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0NsYXNzZXMvaDI2NF92 aWRlb190b29sYm94X2VuY29kZXIubW0KQEAgLTU1NCwxMyArNTU0LDQyIEBAIGludCBIMjY0Vmlk ZW9Ub29sYm94RW5jb2Rlcjo6UmVzZXRDb21wcmVzc2lvblNlc3Npb24oKSB7CiAgICAgQ0ZSZWxl YXNlKHBpeGVsX2Zvcm1hdCk7CiAgICAgcGl4ZWxfZm9ybWF0ID0gbnVsbHB0cjsKICAgfQorCisg IC8vIFdFQktJVCBDaGFuZ2VzOiB1c2UgaGFyZHdhcmUgZW5jb2RlciBpZiBmZWFzaWJsZS4KKyNp ZiBkZWZpbmVkKFdFQlJUQ19VU0VfVlRCX0hBUkRXQVJFX0VOQ09ERVIpCisgIENGVHlwZVJlZiBz ZXNzaW9uS2V5c1tdID0ge2tWVFZpZGVvRW5jb2RlclNwZWNpZmljYXRpb25fRW5hYmxlSGFyZHdh cmVBY2NlbGVyYXRlZFZpZGVvRW5jb2Rlcn07CisgIENGVHlwZVJlZiBzZXNzaW9uVmFsdWVzW10g PSB7a0NGQm9vbGVhblRydWV9OworICBDRkRpY3Rpb25hcnlSZWYgZW5jb2RlclNwZWNpZmljYXRp b24gPSBpbnRlcm5hbDo6Q3JlYXRlQ0ZEaWN0aW9uYXJ5KHNlc3Npb25LZXlzLCBzZXNzaW9uVmFs dWVzLCAxKTsKKyNlbmRpZgorCiAgIE9TU3RhdHVzIHN0YXR1cyA9IFZUQ29tcHJlc3Npb25TZXNz aW9uQ3JlYXRlKAogICAgICAgbnVsbHB0ciwgIC8vIHVzZSBkZWZhdWx0IGFsbG9jYXRvcgogICAg ICAgd2lkdGhfLCBoZWlnaHRfLCBrQ01WaWRlb0NvZGVjVHlwZV9IMjY0LAorI2lmIGRlZmluZWQo V0VCUlRDX1VTRV9WVEJfSEFSRFdBUkVfRU5DT0RFUikKKyAgICAgIGVuY29kZXJTcGVjaWZpY2F0 aW9uLAorI2Vsc2UKICAgICAgIG51bGxwdHIsICAvLyB1c2UgZGVmYXVsdCBlbmNvZGVyCisjZW5k aWYKICAgICAgIHNvdXJjZV9hdHRyaWJ1dGVzLAogICAgICAgbnVsbHB0ciwgIC8vIHVzZSBkZWZh dWx0IGNvbXByZXNzZWQgZGF0YSBhbGxvY2F0b3IKICAgICAgIGludGVybmFsOjpWVENvbXByZXNz aW9uT3V0cHV0Q2FsbGJhY2ssIHRoaXMsICZjb21wcmVzc2lvbl9zZXNzaW9uXyk7CisKKyNpZiBk ZWZpbmVkKFdFQlJUQ19VU0VfVlRCX0hBUkRXQVJFX0VOQ09ERVIpCisgIENGTnVtYmVyUmVmIHVz ZUhhcmR3YXJlRW5jb2RlclZhbHVlID0gbnVsbHB0cjsKKyAgT1NTdGF0dXMgc3RhdHVzR2V0dGVy ID0gVlRTZXNzaW9uQ29weVByb3BlcnR5KGNvbXByZXNzaW9uX3Nlc3Npb25fLCBrVlRDb21wcmVz c2lvblByb3BlcnR5S2V5X1VzaW5nSGFyZHdhcmVBY2NlbGVyYXRlZFZpZGVvRW5jb2RlciwgbnVs bHB0ciwgJnVzZUhhcmR3YXJlRW5jb2RlclZhbHVlKTsKKyAgaWYgKHN0YXR1c0dldHRlciB8fCAh dXNlSGFyZHdhcmVFbmNvZGVyVmFsdWUpIHsKKyAgICBMT0coTFNfV0FSTklORykgPDwgIkNhbm5v dCBrbm93IHdoZXRoZXIgdXNpbmcgaGFyZHdhcmUgSDI2NCBlbmNvZGVyLCBlcnI6ICIgPDwgc3Rh dHVzR2V0dGVyOworICB9IGVsc2UgeworICAgIGludCB1c2VIYXJkd2FyZUVuY29kZXIgPSAwOwor ICAgIENGTnVtYmVyR2V0VmFsdWUodXNlSGFyZHdhcmVFbmNvZGVyVmFsdWUsIGtDRk51bWJlcklu dFR5cGUsICZ1c2VIYXJkd2FyZUVuY29kZXIpOworICAgIGlmICghdXNlSGFyZHdhcmVFbmNvZGVy KQorICAgICAgTE9HKExTX1dBUk5JTkcpIDw8ICJVc2luZyBzb2Z0d2FyZSBIMjY0IGVuY29kZXIg aW5zdGVhZCBvZiBoYXJkd2FyZSBIMjY0IGVuY29kZXIiOworICAgIGVsc2UKKyAgICAgIExPRyhM U19JTkZPKSA8PCAiVXNpbmcgaGFyZHdhcmUgSDI2NCBlbmNvZGVyIjsKKyAgICBDRlJlbGVhc2Uo dXNlSGFyZHdhcmVFbmNvZGVyVmFsdWUpOworICB9CisjZW5kaWYKKwogICBpZiAoc291cmNlX2F0 dHJpYnV0ZXMpIHsKICAgICBDRlJlbGVhc2Uoc291cmNlX2F0dHJpYnV0ZXMpOwogICAgIHNvdXJj ZV9hdHRyaWJ1dGVzID0gbnVsbHB0cjsK