169331 2017-03-07 18:18:03 -0800 [Mac][WK2] Whitelist iokit-get-properties 2018-02-12 17:11:58 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build All macOS 10.12 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=182722 InRadar P2 Normal --- 169391 171020 1 bfulgham bfulgham oldest_to_newest 1284687 0 bfulgham 2017-03-07 18:18:03 -0800 We only need access to some of the many IOKit properties. Instead of allowing blanket access to all of them, restrict our access to just the ones we use. 1284688 1 bfulgham 2017-03-07 18:19:01 -0800 <rdar://problem/16363632> 1284690 2 303755 bfulgham 2017-03-07 18:20:19 -0800 Created attachment 303755 Patch 1284735 3 bfulgham 2017-03-07 20:49:29 -0800 Committed r213564: <http://trac.webkit.org/changeset/213564> 303755 2017-03-07 18:20:19 -0800 2017-03-07 18:27:50 -0800 Patch bug-169331-20170307182019.patch text/plain 7212 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzU2MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAzLTA3ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdW1dLMl0gV2hpdGVs aXN0IGlva2l0LWdldC1wcm9wZXJ0aWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjkzMzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2MzYzNjMy PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJsb2Nr IGFjY2VzcyB0byBhbGwgSU9LaXQgcHJvcGVydGllcyBieSBkZWZhdWx0LiBUdXJuIG9uIG9ubHkg dGhvc2UgcHJvcGVydGllcworICAgICAgICB0aGF0IGFyZSBhY3R1YWxseSBuZWVkZWQgYnkgb3Vy IGVuZ2luZS4KKworICAgICAgICAqIERhdGFiYXNlUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktp dC5EYXRhYmFzZXMuc2IuaW46CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvbWFjL2NvbS5hcHBs ZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2IuaW46CisgICAgICAgICogUGx1Z2luUHJvY2Vzcy9t YWMvY29tLmFwcGxlLldlYktpdC5wbHVnaW4tY29tbW9uLnNiLmluOgorICAgICAgICAqIFdlYlBy b2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW46CisKIDIwMTctMDMtMDcgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIFN1YnBpeGVs QW50aWFsaWFzZWRMYXllclRleHRFbmFibGVkIGJ5IGRlZmF1bHQgb24gc29tZSB2ZXJzaW9ucyBv ZiBtYWNPUwpJbmRleDogU291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNzL21hYy9jb20uYXBw bGUuV2ViS2l0LkRhdGFiYXNlcy5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9E YXRhYmFzZVByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuRGF0YWJhc2VzLnNiLmluCShyZXZp c2lvbiAyMTM1NDQpCisrKyBTb3VyY2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvbWFjL2NvbS5h cHBsZS5XZWJLaXQuRGF0YWJhc2VzLnNiLmluCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw4 IEBACiAgICAgICAgICJody5uY3B1IgogICAgICAgICAiaHcubW9kZWwiCiAgICAgICAgICJrZXJu Lm1lbW9yeXN0YXR1c19sZXZlbCIpKQorCisoZGVueSBpb2tpdC1nZXQtcHJvcGVydGllcykKICNl bmRpZgogCiA7OyBVdGlsaXR5IGZ1bmN0aW9ucyBmb3IgaG9tZSBkaXJlY3RvcnkgcmVsYXRpdmUg cGF0aCBmaWx0ZXJzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9tYWMvY29t LmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vz cy5zYi5pbgkocmV2aXNpb24gMjEzNTQ0KQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2IuaW4JKHdvcmtpbmcgY29w eSkKQEAgLTQwLDYgKzQwLDggQEAKICAgICAgICAgImh3Lm5jcHUiCiAgICAgICAgICJody5tb2Rl bCIKICAgICAgICAgImtlcm4ubWVtb3J5c3RhdHVzX2xldmVsIikpCisKKyhkZW55IGlva2l0LWdl dC1wcm9wZXJ0aWVzKQogI2VuZGlmCiAKIDs7IFV0aWxpdHkgZnVuY3Rpb25zIGZvciBob21lIGRp cmVjdG9yeSByZWxhdGl2ZSBwYXRoIGZpbHRlcnMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsdWdp blByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQucGx1Z2luLWNvbW1vbi5zYi5pbgo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0 LnBsdWdpbi1jb21tb24uc2IuaW4JKHJldmlzaW9uIDIxMzU0NCkKKysrIFNvdXJjZS9XZWJLaXQy L1BsdWdpblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQucGx1Z2luLWNvbW1vbi5zYi5pbgko d29ya2luZyBjb3B5KQpAQCAtNDAsNiArNDAsMzMgQEAKICAgICAgICAgImh3Lm5jcHUiCiAgICAg ICAgICJody5tb2RlbCIKICAgICAgICAgImtlcm4ubWVtb3J5c3RhdHVzX2xldmVsIikpCisKKyhk ZW55IGlva2l0LWdldC1wcm9wZXJ0aWVzKQorKGFsbG93IGlva2l0LWdldC1wcm9wZXJ0aWVzCisg ICAgKGlva2l0LXByb3BlcnR5ICJBbGxvd0Rpc3BsYXlTbGVlcCIpCisgICAgKGlva2l0LXByb3Bl cnR5ICJEaXNwbGF5Um91dGluZyIpCisgICAgKGlva2l0LXByb3BlcnR5LXJlZ2V4ICMiXklPQXVk aW9Db250cm9sKENoYW5uZWxJRHxJRHxTdWJUeXBlfFVzYWdlKSIpCisgICAgKGlva2l0LXByb3Bl cnR5LXJlZ2V4ICMiXklPQXVkaW9EZXZpY2UoQ2FuQmVEZWZhdWx0c3xUcmFuc3BvcnRUeXBlKSIp CisgICAgKGlva2l0LXByb3BlcnR5LXJlZ2V4ICMiXklPQXVkaW9FbmdpbmUoQ2hhbm5lbE5hbWVz fENsaWVudERlc2NyaXB0aW9ufENvcmVBdWRpb1BsdWdJbnxEZXNjcmlwdGlvbnxGbGF2b3J8R2xv YmFsVW5pcXVlSUR8T3V0cHV0Q2hhbm5lbExheW91dHxTYW1wbGVPZmZzZXR8U3RhdGUpIikKKyAg ICAoaW9raXQtcHJvcGVydHktcmVnZXggIyJeSU9BdWRpb0VuZ2luZUNsb2NrKERvbWFpbnxJc1N0 YWJsZSkiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAiSU9BdWRpb0VuZ2luZURpc2FibGVDbG9ja0Jv dW5kc0NoZWNrIikKKyAgICAoaW9raXQtcHJvcGVydHktcmVnZXggIyJeSU9BdWRpb0VuZ2luZShJ bnB1dHxPdXRwdXQpU2FtcGxlKExhdGVuY3l8T2Zmc2V0KSIpCisgICAgKGlva2l0LXByb3BlcnR5 LXJlZ2V4ICMiXklPQXVkaW9FbmdpbmVOdW0oQWN0aXZlVXNlckNsaWVudHN8U2FtcGxlRnJhbWVz UGVyQnVmZmVyKSIpCisgICAgKGlva2l0LXByb3BlcnR5ICJJT0F1ZGlvU2FtcGxlUmF0ZSIpCisg ICAgKGlva2l0LXByb3BlcnR5ICJJT0F1ZGlvU3RyZWFtU2FtcGxlRm9ybWF0Qnl0ZU9yZGVyIikK KyAgICAoaW9raXQtcHJvcGVydHkgIklPQ2xhc3NOYW1lT3ZlcnJpZGUiKQorICAgIChpb2tpdC1w cm9wZXJ0eSAiSU9Db25zb2xlVXNlcnMiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAiSU9GQkN1cnJl bnRQaXhlbENsb2NrIikKKyAgICAoaW9raXQtcHJvcGVydHktcmVnZXggIyJeSU9GQkN1cnJlbnRQ aXhlbENvdW50KFJlYWwpIikKKyAgICAoaW9raXQtcHJvcGVydHkgIklPR2VuZXJhbEludGVyZXN0 IikKKyAgICAoaW9raXQtcHJvcGVydHkgIklPR0xCdW5kbGVOYW1lIikKKyAgICAoaW9raXQtcHJv cGVydHkgIklPU2NyZWVuUmVzdG9yZVN0YXRlIikKKyAgICAoaW9raXQtcHJvcGVydHkgIklPVkFS ZW5kZXJlcklEIikKKyAgICAoaW9raXQtcHJvcGVydHktcmVnZXggIyJeTWV0YWxQbHVnaW4oTmFt ZXxDbGFzc05hbWUpIikKKyAgICAoaW9raXQtcHJvcGVydHkgIlN1cHBvcnRBdWRpb0FVVUMiKQor ICAgIChpb2tpdC1wcm9wZXJ0eSAiYm9hcmQtaWQiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAiaWRQ cm9kdWN0IikKKyAgICAoaW9raXQtcHJvcGVydHkgImlkVmVuZG9yIikpCiAjZW5kaWYKIAogOzsg VXRpbGl0eSBmdW5jdGlvbnMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvY29tLmFw cGxlLldlYlByb2Nlc3Muc2IuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkocmV2aXNpb24gMjEzNTQ0KQorKysgU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkod29ya2lu ZyBjb3B5KQpAQCAtNDMsNiArNDMsNjAgQEAKICAgICAgICAgImh3Lm5jcHUiCiAgICAgICAgICJo dy5tb2RlbCIKICAgICAgICAgImtlcm4ubWVtb3J5c3RhdHVzX2xldmVsIikpCisKKyhkZW55IGlv a2l0LWdldC1wcm9wZXJ0aWVzKQorKGFsbG93IGlva2l0LWdldC1wcm9wZXJ0aWVzCisgICAgKGlv a2l0LXByb3BlcnR5ICJBbGxvd0Rpc3BsYXlTbGVlcCIpCisgICAgKGlva2l0LXByb3BlcnR5ICJB QVBMLG11eC1zd2l0Y2gtc3RhdGUiKQorICAgIChpb2tpdC1wcm9wZXJ0eS1yZWdleCAjIl5BVFks ZmJfKGxpbmVieXRlc3xvZmZzZXR8c2l6ZSkiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAiQ0ZCdW5k bGVJZGVudGlmaWVyIikKKyAgICAoaW9raXQtcHJvcGVydHkgIkRpc3BsYXlSb3V0aW5nIikKKyAg ICAoaW9raXQtcHJvcGVydHktcmVnZXggIyJeSU9BY2NlbChJbmRleHxUeXBlc3xSZXZpc2lvbiki KQorICAgIChpb2tpdC1wcm9wZXJ0eS1yZWdleCAjIl5JTyhDbGFzc3xNYXRjaENhdGVnb3J5fE5h bWVNYXRjaCkiKQorICAgIChpb2tpdC1wcm9wZXJ0eS1yZWdleCAjIl5JT0F1ZGlvQ29udHJvbChD aGFubmVsSUR8SUR8U3ViVHlwZXxVc2FnZSkiKQorICAgIChpb2tpdC1wcm9wZXJ0eS1yZWdleCAj Il5JT0F1ZGlvRGV2aWNlKENhbkJlRGVmYXVsdHN8VHJhbnNwb3J0VHlwZSkiKQorICAgIChpb2tp dC1wcm9wZXJ0eS1yZWdleCAjIl5JT0F1ZGlvRW5naW5lKENoYW5uZWxOYW1lc3xDbGllbnREZXNj cmlwdGlvbnxDb3JlQXVkaW9QbHVnSW58RGVzY3JpcHRpb258Rmxhdm9yfEdsb2JhbFVuaXF1ZUlE fE91dHB1dENoYW5uZWxMYXlvdXR8U2FtcGxlT2Zmc2V0fFN0YXRlKSIpCisgICAgKGlva2l0LXBy b3BlcnR5LXJlZ2V4ICMiXklPQXVkaW9FbmdpbmVDbG9jayhEb21haW58SXNTdGFibGUpIikKKyAg ICAoaW9raXQtcHJvcGVydHkgIklPQXVkaW9FbmdpbmVEaXNhYmxlQ2xvY2tCb3VuZHNDaGVjayIp CisgICAgKGlva2l0LXByb3BlcnR5LXJlZ2V4ICMiXklPQXVkaW9FbmdpbmUoSW5wdXR8T3V0cHV0 KVNhbXBsZShMYXRlbmN5fE9mZnNldCkiKQorICAgIChpb2tpdC1wcm9wZXJ0eS1yZWdleCAjIl5J T0F1ZGlvRW5naW5lTnVtKEFjdGl2ZVVzZXJDbGllbnRzfFNhbXBsZUZyYW1lc1BlckJ1ZmZlciki KQorICAgIChpb2tpdC1wcm9wZXJ0eSAiSU9BdWRpb1NhbXBsZVJhdGUiKQorICAgIChpb2tpdC1w cm9wZXJ0eSAiSU9BdWRpb1N0cmVhbVNhbXBsZUZvcm1hdEJ5dGVPcmRlciIpCisgICAgKGlva2l0 LXByb3BlcnR5ICJJT0NGUGx1Z0luVHlwZXMiKQorICAgIChpb2tpdC1wcm9wZXJ0eS1yZWdleCAj Il5JT0NsYXNzKHxOYW1lT3ZlcnJpZGUpIikKKyAgICAoaW9raXQtcHJvcGVydHkgIklPQ29uc29s ZVVzZXJzIikKKyAgICAoaW9raXQtcHJvcGVydHkgIklPRFZEQnVuZGxlTmFtZSIpCisgICAgKGlv a2l0LXByb3BlcnR5ICJJT0Rpc3BsYXlQYXJhbWV0ZXJzIikKKyAgICAoaW9raXQtcHJvcGVydHkt cmVnZXggIyJeSU9GQihDTFVURGVmZXJ8Q29uZmlnfEN1cnNvckluZm98RGVwZW5kZW50KElEfElu ZGV4KSkiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAiSU9GQkN1cnJlbnRQaXhlbENsb2NrIikKKyAg ICAoaW9raXQtcHJvcGVydHktcmVnZXggIyJeSU9GQkN1cnJlbnRQaXhlbENvdW50KHxSZWFsKSIp CisgICAgKGlva2l0LXByb3BlcnR5LXJlZ2V4ICMiXklPRkIoRGV0YWlsZWRUaW1pbmdzfEdhbW1h KENvdW50fEhlYWRlclNpemV8V2lkdGgpKSIpCisgICAgKGlva2l0LXByb3BlcnR5LXJlZ2V4ICMi XklPRkJJMkNJbnRlcmZhY2UoSURzfEluZm8pIikKKyAgICAoaW9raXQtcHJvcGVydHktcmVnZXgg IyJeSU9GQihNZW1vcnlTaXplfE5lZWRzUmVmcmVzaHxQcm9iZU9wdGlvbnN8U2NhbGVySW5mb3xU aW1pbmdSYW5nZXxUcmFuc2Zvcm18VUlTY2FsZXxXYWl0Q3Vyc29yKEZyYW1lc3xQZXJpb2QpKSIp CisgICAgKGlva2l0LXByb3BlcnR5ICJJT0ZyYW1lYnVmZmVyT3BlbkdMSW5kZXgiKQorICAgIChp b2tpdC1wcm9wZXJ0eSAiSU9HZW5lcmFsSW50ZXJlc3QiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAi SU9HTEJ1bmRsZU5hbWUiKQorICAgIChpb2tpdC1wcm9wZXJ0eS1yZWdleCAjIl5JT0dWQShDb2Rl Y3xFbmNvZGVyUmVzdHJpY3RlZCkiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAiSU9NYXRjaENhdGVn b3J5IikKKyAgICAoaW9raXQtcHJvcGVydHktcmVnZXggIyJeSU9OYW1lTWF0Y2gofGVkKSIpCisg ICAgKGlva2l0LXByb3BlcnR5ICJJT1BNU3RyaWN0VHJlZU9yZGVyIikKKyAgICAoaW9raXQtcHJv cGVydHkgIklPUG93ZXJNYW5hZ2VtZW50IikKKyAgICAoaW9raXQtcHJvcGVydHkgIklPUHJvYmVT Y29yZSIpCisgICAgKGlva2l0LXByb3BlcnR5ICJJT1Byb3ZpZGVyQ2xhc3MiKQorICAgIChpb2tp dC1wcm9wZXJ0eSAiSU9TY3JlZW5SZXN0b3JlU3RhdGUiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAi SU9WQVJlbmRlcmVySUQiKQorICAgIChpb2tpdC1wcm9wZXJ0eS1yZWdleCAjIl5NZXRhbFBsdWdp bihOYW1lfENsYXNzTmFtZSkiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAiUHJvdG9jb2wgQ2hhcmFj dGVyaXN0aWNzIikKKyAgICAoaW9raXQtcHJvcGVydHkgIlN1cHBvcnRBdWRpb0FVVUMiKQorICAg IChpb2tpdC1wcm9wZXJ0eS1yZWdleCAjIl5hdWRpby0oY29kZWMtaW5mb3xzZWxlY3RvcikiKQor ICAgIChpb2tpdC1wcm9wZXJ0eSAiYXYtc2lnbmFsLXR5cGUiKQorICAgIChpb2tpdC1wcm9wZXJ0 eSAiYm9hcmQtaWQiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAiYm9vdC1nYW1tYS1yZXN0b3JlZCIp CisgICAgKGlva2l0LXByb3BlcnR5ICJncmFwaGljLW9wdGlvbnMiKQorICAgIChpb2tpdC1wcm9w ZXJ0eSAiaWRQcm9kdWN0IikKKyAgICAoaW9raXQtcHJvcGVydHkgImlkVmVuZG9yIikKKyAgICAo aW9raXQtcHJvcGVydHkgImlvZmJfdmVyc2lvbiIpCisgICAgKGlva2l0LXByb3BlcnR5ICJzdGFy dHVwLXRpbWluZyIpKQogI2VuZGlmCiAKIDs7IFV0aWxpdHkgZnVuY3Rpb25zIGZvciBob21lIGRp cmVjdG9yeSByZWxhdGl2ZSBwYXRoIGZpbHRlcnMK