169323 2017-03-07 17:25:13 -0800 Web Inspector: RTL: Switching back to System Direction doesn't change the dock side 2017-03-08 17:47:40 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes oldest_to_newest 1284658 0 hi 2017-03-07 17:25:13 -0800 * STEPS TO REPRODUCE 1. Open WebInspector 2. Go to Settings tab 3. Change Layout Direction to Right to Left (RTL) 4. Wait for WebInspector to reload after docking on the left side of the page 5. Go to Settings tab 6. Change Layout Direction to System Default * EXPECTED WebInspector is docked on the right side of the page with left-to-right text direction. * ACTUAL WebInspector is docked on the left side of the page with left-to-right text direction. 1284659 1 303746 hi 2017-03-07 17:26:55 -0800 Created attachment 303746 Patch 1285108 2 303746 bburg 2017-03-08 16:58:07 -0800 Comment on attachment 303746 Patch r=me, that was an amateurish mistake by me :) 1285141 3 303746 commit-queue 2017-03-08 17:47:36 -0800 Comment on attachment 303746 Patch Clearing flags on attachment: 303746 Committed r213615: <http://trac.webkit.org/changeset/213615> 1285142 4 commit-queue 2017-03-08 17:47:40 -0800 All reviewed patches have been landed. Closing bug. 303746 2017-03-07 17:26:55 -0800 2017-03-08 17:47:36 -0800 Patch bug-169323-20170307172654.patch text/plain 2162 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGIwM2IxNGUyMTM3OTAwYWMzZmRiYmY3NjM3ZGZj ODA3ZTIwMGJmN2MuLjg1MzYxOTUwY2M3ZDEzNTcxMjJjMmEwYjE5NTA1NTg3YzQ0NDNjNDAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAzLTA3ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFJUTDogU3dpdGNoaW5nIGJhY2sgdG8gU3lzdGVtIERpcmVjdGlvbiBkb2Vzbid0IGNo YW5nZSB0aGUgZG9jayBzaWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjkzMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLnNldExheW91dERpcmVjdGlvbik6CisgICAgICAgIENoYW5nZSB0aGUgZG9jayBzaWRl IGJhc2VkIG9uIHRoZSByZXNvbHZlZCBsYXlvdXQgZGlyZWN0aW9uLCBub3QgdGhlIGN1cnJlbnQg c2V0dGluZyB2YWx1ZS4KKwogMjAxNy0wMy0wNCAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2 QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTaG93IFdlYiBTb2NrZXQgY29u bmVjdGlvbnMgaW4gTmV0d29yayB0YWIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCAwYTdkN2U0OTU1NTY0Y2Q4YTMwYzYwYmMwZGNh OThlNGM3YjVjODc1Li45NjBlMWM0N2EzZWE1NGY2NTc0NzcwNzMzYzc1MGFhZTQwNGQ4ZmY1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4u anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpz CkBAIC0yMTc2LDcgKzIxNzYsNyBAQCBXZWJJbnNwZWN0b3IucmVzb2x2ZWRMYXlvdXREaXJlY3Rp b24gPSBmdW5jdGlvbigpCiAgICAgICAgIGxheW91dERpcmVjdGlvbiA9IEluc3BlY3RvckZyb250 ZW5kSG9zdC51c2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uKCk7CiAKICAgICByZXR1cm4gbGF5 b3V0RGlyZWN0aW9uOwotfQorfTsKIAogV2ViSW5zcGVjdG9yLnNldExheW91dERpcmVjdGlvbiA9 IGZ1bmN0aW9uKHZhbHVlKQogewpAQCAtMjE4OCwxMCArMjE4OCwxMCBAQCBXZWJJbnNwZWN0b3Iu c2V0TGF5b3V0RGlyZWN0aW9uID0gZnVuY3Rpb24odmFsdWUpCiAKICAgICBXZWJJbnNwZWN0b3Iu c2V0dGluZ3MubGF5b3V0RGlyZWN0aW9uLnZhbHVlID0gdmFsdWU7CiAKLSAgICBpZiAodmFsdWUg PT09IFdlYkluc3BlY3Rvci5MYXlvdXREaXJlY3Rpb24uUlRMICYmIHRoaXMuX2RvY2tDb25maWd1 cmF0aW9uID09PSBXZWJJbnNwZWN0b3IuRG9ja0NvbmZpZ3VyYXRpb24uUmlnaHQpCisgICAgaWYg KFdlYkluc3BlY3Rvci5yZXNvbHZlZExheW91dERpcmVjdGlvbigpID09PSBXZWJJbnNwZWN0b3Iu TGF5b3V0RGlyZWN0aW9uLlJUTCAmJiB0aGlzLl9kb2NrQ29uZmlndXJhdGlvbiA9PT0gV2ViSW5z cGVjdG9yLkRvY2tDb25maWd1cmF0aW9uLlJpZ2h0KQogICAgICAgICB0aGlzLl9kb2NrTGVmdCgp OwogCi0gICAgaWYgKHZhbHVlID09PSBXZWJJbnNwZWN0b3IuTGF5b3V0RGlyZWN0aW9uLkxUUiAm JiB0aGlzLl9kb2NrQ29uZmlndXJhdGlvbiA9PT0gV2ViSW5zcGVjdG9yLkRvY2tDb25maWd1cmF0 aW9uLkxlZnQpCisgICAgaWYgKFdlYkluc3BlY3Rvci5yZXNvbHZlZExheW91dERpcmVjdGlvbigp ID09PSBXZWJJbnNwZWN0b3IuTGF5b3V0RGlyZWN0aW9uLkxUUiAmJiB0aGlzLl9kb2NrQ29uZmln dXJhdGlvbiA9PT0gV2ViSW5zcGVjdG9yLkRvY2tDb25maWd1cmF0aW9uLkxlZnQpCiAgICAgICAg IHRoaXMuX2RvY2tSaWdodCgpOwogCiAgICAgd2luZG93LmxvY2F0aW9uLnJlbG9hZCgpOwo=