169295 2017-03-07 11:40:32 -0800 Drop non-standard MessageEvent.webkitInitMessageEvent() 2017-03-07 14:45:04 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 169176 1 cdumez cdumez achristensen cdumez commit-queue darin dbates esprehn+autocc joepeck kangil.han kondapallykalyan rniwa sam oldest_to_newest 1284450 0 cdumez 2017-03-07 11:40:32 -0800 Drop non-standard MessageEvent.webkitInitMessageEvent(). Chrome dropped it almost 3 years ago. They had UseCounter data showing consistent 0% usage: - https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/H6lsGFqdy3Y - https://www.chromestatus.com/metrics/feature/timeline/popularity/223 - https://src.chromium.org/viewvc/blink?revision=174967&view=revision 1284453 1 303692 cdumez 2017-03-07 11:45:48 -0800 Created attachment 303692 Patch 1284508 2 cdumez 2017-03-07 12:57:00 -0800 The GTK bot failure looks like an incremental build issue. 1284563 3 303692 joepeck 2017-03-07 14:28:31 -0800 Comment on attachment 303692 Patch r=me! 1284565 4 303692 joepeck 2017-03-07 14:29:11 -0800 Comment on attachment 303692 Patch Making cq? because red GTK EWS bubble seems related (but could just need a clean build). 1284569 5 303692 cdumez 2017-03-07 14:44:58 -0800 Comment on attachment 303692 Patch Clearing flags on attachment: 303692 Committed r213543: <http://trac.webkit.org/changeset/213543> 1284570 6 cdumez 2017-03-07 14:45:04 -0800 All reviewed patches have been landed. Closing bug. 303692 2017-03-07 11:45:48 -0800 2017-03-07 14:44:58 -0800 Patch bug-169295-20170307114547.patch text/plain 6633 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzNTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA3N2I4YTJmYmY4YmEx MmU4ODJjYTM1NTIyMzIxNDgzNzMzNmU5YS4uNjk5OWUxZjBlNDJkOTAxZTUwZTc2MjZiN2UxZTU3 ZGZkMzE2YWIyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTAzLTA3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBub24tc3RhbmRhcmQg TWVzc2FnZUV2ZW50LndlYmtpdEluaXRNZXNzYWdlRXZlbnQoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5Mjk1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRHJvcCBub24tc3RhbmRhcmQgTWVzc2FnZUV2 ZW50LndlYmtpdEluaXRNZXNzYWdlRXZlbnQoKS4KKworICAgICAgICBDaHJvbWUgZHJvcHBlZCBp dCBhbG1vc3QgMyB5ZWFycyBhZ28uIFRoZXkgaGFkIFVzZUNvdW50ZXIgZGF0YSBzaG93aW5nCisg ICAgICAgIGNvbnNpc3RlbnQgMCUgdXNhZ2U6CisgICAgICAgIC0gaHR0cHM6Ly9ncm91cHMuZ29v Z2xlLmNvbS9hL2Nocm9taXVtLm9yZy9mb3J1bS8jIXRvcGljL2JsaW5rLWRldi9INmxzR0ZxZHkz WQorICAgICAgICAtIGh0dHBzOi8vd3d3LmNocm9tZXN0YXR1cy5jb20vbWV0cmljcy9mZWF0dXJl L3RpbWVsaW5lL3BvcHVsYXJpdHkvMjIzCisgICAgICAgIC0gaHR0cHM6Ly9zcmMuY2hyb21pdW0u b3JnL3ZpZXd2Yy9ibGluaz9yZXZpc2lvbj0xNzQ5Njcmdmlldz1yZXZpc2lvbgorCisgICAgICAg ICogYmluZGluZ3MvanMvSlNNZXNzYWdlRXZlbnRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6aGFuZGxlSW5pdE1lc3NhZ2VFdmVudCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpK U01lc3NhZ2VFdmVudDo6d2Via2l0SW5pdE1lc3NhZ2VFdmVudCk6IERlbGV0ZWQuCisgICAgICAg ICogZG9tL01lc3NhZ2VFdmVudC5pZGw6CisKIDIwMTctMDMtMDcgIFlvdWVubiBGYWJsZXQgIDx5 b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEV4cG9zZSBXZWJSVEMgY3VycmVudC9wZW5kaW5n IGRlc2NyaXB0aW9uIGdldHRlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGIwM2IxNGUy MTM3OTAwYWMzZmRiYmY3NjM3ZGZjODA3ZTIwMGJmN2MuLjFkMzY0NzZjMTBmZDI3Y2Y4ODRjNDhh OTIyNzk3OTU2OWIwMjNiMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE3LTAzLTA3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgRHJvcCBub24tc3RhbmRhcmQgTWVzc2FnZUV2ZW50LndlYmtpdEluaXRNZXNzYWdlRXZlbnQo KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5Mjk1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRHJvcCBN ZXNzYWdlRXZlbnQud2Via2l0SW5pdE1lc3NhZ2VFdmVudCBhbmQgdXBkYXRlIHBhcmFtZXRlcnMg Zm9yIHZhcmlvdXMKKyAgICAgICAgaW5pdCpFdmVudCgpIG9wZXJhdGlvbnMgdG8gbWF0Y2ggdGhl IGN1cnJlbnQgaW1wbGVtZW50YXRpb24uCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVs cy9OYXRpdmVGdW5jdGlvblBhcmFtZXRlcnMuanM6CisKIDIwMTctMDMtMDQgIE5pa2l0YSBWYXNp bHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2hv dyBXZWIgU29ja2V0IGNvbm5lY3Rpb25zIGluIE5ldHdvcmsgdGFiCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU01lc3NhZ2VFdmVudEN1c3RvbS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU01lc3NhZ2VFdmVudEN1c3RvbS5jcHAKaW5kZXggZTA4ODZh YjI1Yzk5ZjcwMTU1YTliMjU5MTc5NzhkZmNjMWVhOTNlYi4uZTQzMmU1YmZlMjE3MmNhZDUwMTUz ZmQ1ZTVhNzhiNmFiMzU0ZTU5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNNZXNzYWdlRXZlbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTTWVzc2FnZUV2ZW50Q3VzdG9tLmNwcApAQCAtMTAzLDQ2ICsxMDMsNCBAQCBKU1ZhbHVl IEpTTWVzc2FnZUV2ZW50OjpkYXRhKEV4ZWNTdGF0ZSYgc3RhdGUpIGNvbnN0CiAgICAgcmV0dXJu IHJlc3VsdDsKIH0KIAotc3RhdGljIEpTQzo6SlNWYWx1ZSBoYW5kbGVJbml0TWVzc2FnZUV2ZW50 KEpTTWVzc2FnZUV2ZW50KiBqc0V2ZW50LCBKU0M6OkV4ZWNTdGF0ZSYgc3RhdGUpCi17Ci0gICAg Vk0mIHZtID0gc3RhdGUudm0oKTsKLSAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09Q RSh2bSk7Ci0KLSAgICBjb25zdCBTdHJpbmcmIHR5cGVBcmcgPSBzdGF0ZS5hcmd1bWVudCgwKS50 b1dURlN0cmluZygmc3RhdGUpOwotICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIEpTVmFs dWUoKSk7Ci0KLSAgICBib29sIGNhbkJ1YmJsZUFyZyA9IHN0YXRlLmFyZ3VtZW50KDEpLnRvQm9v bGVhbigmc3RhdGUpOwotICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIEpTVmFsdWUoKSk7 Ci0KLSAgICBib29sIGNhbmNlbGFibGVBcmcgPSBzdGF0ZS5hcmd1bWVudCgyKS50b0Jvb2xlYW4o JnN0YXRlKTsKLSAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBKU1ZhbHVlKCkpOwotCi0g ICAgSlNWYWx1ZSBkYXRhQXJnID0gc3RhdGUuYXJndW1lbnQoMyk7Ci0KLSAgICBjb25zdCBTdHJp bmcgb3JpZ2luQXJnID0gY29udmVydDxJRExVU1ZTdHJpbmc+KHN0YXRlLCBzdGF0ZS5hcmd1bWVu dCg0KSk7Ci0gICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgSlNWYWx1ZSgpKTsKLQotICAg IGNvbnN0IFN0cmluZyBsYXN0RXZlbnRJZEFyZyA9IHN0YXRlLmFyZ3VtZW50KDUpLnRvV1RGU3Ry aW5nKCZzdGF0ZSk7Ci0gICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgSlNWYWx1ZSgpKTsK LQotICAgIGF1dG8gc291cmNlQXJnID0gY29udmVydDxJRExOdWxsYWJsZTxJRExVbmlvbjxJRExJ bnRlcmZhY2U8RE9NV2luZG93PiwgSURMSW50ZXJmYWNlPE1lc3NhZ2VQb3J0Pj4+PihzdGF0ZSwg c3RhdGUuYXJndW1lbnQoNikpOwotICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIEpTVmFs dWUoKSk7Ci0gICAgCi0gICAgVmVjdG9yPFJlZlB0cjxNZXNzYWdlUG9ydD4+IG1lc3NhZ2VQb3J0 czsKLSAgICBpZiAoIXN0YXRlLmFyZ3VtZW50KDcpLmlzVW5kZWZpbmVkT3JOdWxsKCkpIHsKLSAg ICAgICAgbWVzc2FnZVBvcnRzID0gY29udmVydDxJRExTZXF1ZW5jZTxJRExJbnRlcmZhY2U8TWVz c2FnZVBvcnQ+Pj4oc3RhdGUsIHN0YXRlLmFyZ3VtZW50KDcpKTsKLSAgICAgICAgUkVUVVJOX0lG X0VYQ0VQVElPTihzY29wZSwgSlNWYWx1ZSgpKTsKLSAgICB9Ci0KLSAgICBNZXNzYWdlRXZlbnQm IGV2ZW50ID0ganNFdmVudC0+d3JhcHBlZCgpOwotICAgIGV2ZW50LmluaXRNZXNzYWdlRXZlbnQo c3RhdGUsIHR5cGVBcmcsIGNhbkJ1YmJsZUFyZywgY2FuY2VsYWJsZUFyZywgZGF0YUFyZywgb3Jp Z2luQXJnLCBsYXN0RXZlbnRJZEFyZywgV1RGTW92ZShzb3VyY2VBcmcpLCBXVEZNb3ZlKG1lc3Nh Z2VQb3J0cykpOwotICAgIGpzRXZlbnQtPm1fZGF0YS5zZXQodm0sIGpzRXZlbnQsIGRhdGFBcmcp OwotICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOwotfQotCi1KU0M6OkpTVmFsdWUgSlNNZXNzYWdl RXZlbnQ6OndlYmtpdEluaXRNZXNzYWdlRXZlbnQoSlNDOjpFeGVjU3RhdGUmIHN0YXRlKQotewot ICAgIHJldHVybiBoYW5kbGVJbml0TWVzc2FnZUV2ZW50KHRoaXMsIHN0YXRlKTsKLX0KLQogfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL01lc3Nh Z2VFdmVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTWVzc2FnZUV2ZW50LmlkbAppbmRleCBl ZTY5NmI5YmU3ZjFiYTU2OGE2MzUwMDRlMTc2ZGY5NTAyNzVhMzA2Li5jYjkyZTAxMmU5ZWM3MDRk YjNhNjc1OGIxMjBiM2RmYmJmYjNjY2Q0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v TWVzc2FnZUV2ZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTWVzc2FnZUV2ZW50Lmlk bApAQCAtNDAsOSArNDAsNiBAQAogICAgIFtDYWxsV2l0aD1TY3JpcHRTdGF0ZV0gdm9pZCBpbml0 TWVzc2FnZUV2ZW50KERPTVN0cmluZyB0eXBlLCBvcHRpb25hbCBib29sZWFuIGJ1YmJsZXMgPSBm YWxzZSwgb3B0aW9uYWwgYm9vbGVhbiBjYW5jZWxhYmxlID0gZmFsc2UsCiAgICAgICAgIG9wdGlv bmFsIGFueSBkYXRhID0gbnVsbCwgb3B0aW9uYWwgVVNWU3RyaW5nIG9yaWdpbkFyZyA9ICIiLCBv cHRpb25hbCBET01TdHJpbmcgbGFzdEV2ZW50SWQgPSAiIiwgb3B0aW9uYWwgKERPTVdpbmRvdyBv ciBNZXNzYWdlUG9ydCk/IHNvdXJjZSA9IG51bGwsCiAgICAgICAgIG9wdGlvbmFsIHNlcXVlbmNl PE1lc3NhZ2VQb3J0PiBtZXNzYWdlUG9ydHMgPSBbXSk7Ci0gICAgW0N1c3RvbV0gdm9pZCB3ZWJr aXRJbml0TWVzc2FnZUV2ZW50KG9wdGlvbmFsIERPTVN0cmluZyB0eXBlQXJnLCBvcHRpb25hbCBi b29sZWFuIGNhbkJ1YmJsZUFyZywgb3B0aW9uYWwgYm9vbGVhbiBjYW5jZWxhYmxlQXJnLAotICAg ICAgICBvcHRpb25hbCBhbnkgZGF0YUFyZywgb3B0aW9uYWwgVVNWU3RyaW5nIG9yaWdpbkFyZywg b3B0aW9uYWwgRE9NU3RyaW5nIGxhc3RFdmVudElkQXJnLCBvcHRpb25hbCAoRE9NV2luZG93IG9y IE1lc3NhZ2VQb3J0KT8gc291cmNlQXJnLAotICAgICAgICBvcHRpb25hbCBzZXF1ZW5jZTxNZXNz YWdlUG9ydD4gbWVzc2FnZVBvcnRzKTsKIH07CiAKIGRpY3Rpb25hcnkgTWVzc2FnZUV2ZW50SW5p dCA6IEV2ZW50SW5pdCB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Nb2RlbHMvTmF0aXZlRnVuY3Rpb25QYXJhbWV0ZXJzLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL05hdGl2ZUZ1bmN0aW9uUGFyYW1ldGVycy5q cwppbmRleCAwNjMzYTIwOWVhNDgzM2ViMjU3NTUwYTUwZGJjOTdhYjliNTVkMTZmLi41ZmNiZWMx ZDk0Nzc1NmI4NWIwOWEzZTA3MjI5MjhjODFmYjI2ZjMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvTmF0aXZlRnVuY3Rpb25QYXJhbWV0ZXJz LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9OYXRp dmVGdW5jdGlvblBhcmFtZXRlcnMuanMKQEAgLTcyOCw3ICs3MjgsNyBAQCBXZWJJbnNwZWN0b3Iu TmF0aXZlUHJvdG90eXBlRnVuY3Rpb25QYXJhbWV0ZXJzID0gewogICAgIH0sCiAKICAgICBDdXN0 b21FdmVudDogewotICAgICAgICBpbml0Q3VzdG9tRXZlbnQ6ICJbdHlwZUFyZ10sIFtjYW5CdWJi bGVBcmddLCBbY2FuY2VsYWJsZUFyZ10sIFtkZXRhaWxBcmddIiwKKyAgICAgICAgaW5pdEN1c3Rv bUV2ZW50OiAidHlwZSwgW2J1YmJsZXNdLCBbY2FuY2VsYWJsZV0sIFtkZXRhaWxdIiwKICAgICAg ICAgX19wcm90b19fOiBudWxsLAogICAgIH0sCiAKQEAgLTgyMCw3ICs4MjAsNyBAQCBXZWJJbnNw ZWN0b3IuTmF0aXZlUHJvdG90eXBlRnVuY3Rpb25QYXJhbWV0ZXJzID0gewogICAgIH0sCiAKICAg ICBFdmVudDogewotICAgICAgICBpbml0RXZlbnQ6ICJ0eXBlLCBjYW5CdWJibGUsIGNhbmNlbGFi bGUiLAorICAgICAgICBpbml0RXZlbnQ6ICJ0eXBlLCBbYnViYmxlc10sIFtjYW5jZWxhYmxlXSIs CiAgICAgICAgIF9fcHJvdG9fXzogbnVsbCwKICAgICB9LAogCkBAIC0xMTE5LDggKzExMTksNyBA QCBXZWJJbnNwZWN0b3IuTmF0aXZlUHJvdG90eXBlRnVuY3Rpb25QYXJhbWV0ZXJzID0gewogICAg IH0sCiAKICAgICBNZXNzYWdlRXZlbnQ6IHsKLSAgICAgICAgaW5pdE1lc3NhZ2VFdmVudDogIlt0 eXBlQXJnXSwgW2NhbkJ1YmJsZUFyZ10sIFtjYW5jZWxhYmxlQXJnXSwgW2RhdGFBcmddLCBbb3Jp Z2luQXJnXSwgW2xhc3RFdmVudElkQXJnXSwgW3NvdXJjZUFyZ10sIFttZXNzYWdlUG9ydHNdIiwK LSAgICAgICAgd2Via2l0SW5pdE1lc3NhZ2VFdmVudDogIlt0eXBlQXJnXSwgW2NhbkJ1YmJsZUFy Z10sIFtjYW5jZWxhYmxlQXJnXSwgW2RhdGFBcmddLCBbb3JpZ2luQXJnXSwgW2xhc3RFdmVudElk QXJnXSwgW3NvdXJjZUFyZ10sIFt0cmFuc2ZlcmFibGVzXSIsCisgICAgICAgIGluaXRNZXNzYWdl RXZlbnQ6ICJ0eXBlLCBbYnViYmxlc10sIFtjYW5jZWxhYmxlXSwgW2RhdGFdLCBbb3JpZ2luXSwg W2xhc3RFdmVudElkXSwgW3NvdXJjZV0sIFttZXNzYWdlUG9ydHNdIiwKICAgICAgICAgX19wcm90 b19fOiBudWxsLAogICAgIH0sCiAK