169275 2017-03-07 05:23:05 -0800 watchlists seem to be failing sometimes 2019-09-18 12:53:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=190793 https://bugs.webkit.org/show_bug.cgi?id=201433 P2 Normal --- 1 rego aakash_jain aakash_jain ap dbates jfernandez lforschler rego svillar oldest_to_newest 1284278 0 rego 2017-03-07 05:23:05 -0800 At least I'm finding issues with the CSS Grid Layout watchlist. The watchlist is defined like: "CSSGridLayout": { "filename": r"Source/WebCore/rendering/.*Grid.*" r"|Source/WebCore/css/.*Grid.*" r"|LayoutTests/fast/css-grid-layout/" r"|LayoutTests/ietestcenter/css3/grid/" r"|LayoutTests/platform/.*/fast/css-grid-layout/" r"|LayoutTests/platform/.*/ietestcenter/css3/grid/", }, And the people subscribed are @jfernandez, @svillar and me. But in the last weeks we were not CC in some patches: * https://bugs.webkit.org/show_bug.cgi?id=168657 * https://bugs.webkit.org/show_bug.cgi?id=169203 But I did a small test and it worked: * https://bugs.webkit.org/show_bug.cgi?id=169073 So I'm not sure what's going on, but it'd be really nice to get this fixed. Thanks! 1285226 1 ap 2017-03-08 21:38:18 -0800 I never looked into how the watchlist works. Is it part of style queue on EWS? 1485332 2 lforschler 2018-12-05 11:24:57 -0800 the style queue runs the watch list. It is throwing errors in the logs: style-queue_2018-12-05_07-12.log:2018-12-05 07:48:04,975 - Failed to run "['/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-misc-style', 'apply-watchlist-local', 190625]" exit_code: 1 cwd: /Volumes/Data/StyleQueue/WebKit style-queue_2018-12-05_07-12.log: File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/steps/applywatchlist.py", line 56, in run style-queue_2018-12-05_07-12.log:2018-12-05 07:48:04,975 - Unabled to apply watchlist 1485428 3 lforschler 2018-12-05 14:21:51 -0800 I looked through this a bit more, and it seems the most current errors being thrown are cases where the bugs are security bugs, and the EWS account does not have access. This is by expected. We do not want the watchlist to elevate access for security bugs. However, the ones from Manuel are NOT security bugs. I don't have logs from that far back to investigate. webkit-patch apply-watchlist-local bug_id -v 1485429 4 lforschler 2018-12-05 14:22:40 -0800 running the above command would give some insight to why it's not working. If you could follow up with log output from running, we can diagnose more. 1486069 5 aakash_jain 2018-12-07 11:12:04 -0800 (In reply to Lucas Forschler from comment #3) > I looked through this a bit more, and it seems the most current errors being thrown are cases where the bugs are security bugs Watchlist was definitely having issues with Security bugs. It has been fixed in https://bugs.webkit.org/show_bug.cgi?id=190793