<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>169244</bug_id>
          
          <creation_ts>2017-03-06 18:47:57 -0800</creation_ts>
          <short_desc>[CMake] SN-DBS fails to build: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;</short_desc>
          <delta_ts>2017-03-06 20:17:07 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>lforschler</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1284108</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2017-03-06 18:47:57 -0800</bug_when>
    <thetext>[CMake] SN-DBS fails to build: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;

I&apos;m using SN-DBS &lt;http://www.snsystems.com/&gt; for distributed compilation on Windows.
WebCoreTestSupport module specifies WebCoreTestSupportPrefix.h as a precompiled header without an include path to it.
This causes no problem for Visual Studio because WebCoreTestSupportPrefix.h is searched in PCH file.
However, SN-DBS does not use PCH file, and can not find WebCoreTestSupportPrefix.h.

&gt; ------ Rebuild All started: Project: WebCoreTestSupport, Configuration: Debug x64 ------
&gt;   Building Custom Rule C:/webkit/ga/Source/WebCore/CMakeLists.txt
&gt;   CMake does not need to re-run because C:\webkit\ga\WebKitBuild\Debug\Source\WebCore\CMakeFiles\generate.stamp is up-to-date.
&gt;   WebCoreTestSupportPrefix.cpp
&gt;   PlatformSpeechSynthesizerMock.cpp
&gt;   MockBox.cpp
&gt;   MockMediaPlayerMediaSource.cpp
&gt;   MockMediaSourcePrivate.cpp
&gt;   MockSourceBufferPrivate.cpp
&gt;   MockCDMFactory.cpp
&gt;   MockGamepad.cpp
&gt;   MockGamepadProvider.cpp
&gt;   JSMallocStatistics.cpp
&gt;   JSMemoryInfo.cpp
&gt;   InternalSettingsGenerated.cpp
&gt; C:\webkit\ga\WebKitBuild\Debug\DerivedSources\WebCore\InternalSettingsGenerated.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   JSInternalSettings.cpp
&gt; C:\webkit\ga\WebKitBuild\Debug\DerivedSources\WebCore\JSInternalSettings.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   JSGCObservation.cpp
&gt; C:\webkit\ga\WebKitBuild\Debug\DerivedSources\WebCore\JSGCObservation.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   JSTypeConversions.cpp
&gt; C:\webkit\ga\WebKitBuild\Debug\DerivedSources\WebCore\JSTypeConversions.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   JSInternalSettingsGenerated.cpp
&gt; C:\webkit\ga\WebKitBuild\Debug\DerivedSources\WebCore\JSInternalSettingsGenerated.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   JSMockPageOverlay.cpp
&gt; C:\webkit\ga\WebKitBuild\Debug\DerivedSources\WebCore\JSMockPageOverlay.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   JSMockContentFilterSettings.cpp
&gt; C:\webkit\ga\WebKitBuild\Debug\DerivedSources\WebCore\JSMockContentFilterSettings.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   InternalSettings.cpp
&gt; C:\webkit\ga\Source\WebCore\testing\InternalSettings.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   JSMockCDMFactory.cpp
&gt; C:\webkit\ga\WebKitBuild\Debug\DerivedSources\WebCore\JSMockCDMFactory.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   GCObservation.cpp
&gt; C:\webkit\ga\Source\WebCore\testing\GCObservation.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   MockPageOverlayClient.cpp
&gt; C:\webkit\ga\Source\WebCore\testing\MockPageOverlayClient.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   MockPageOverlay.cpp
&gt; C:\webkit\ga\Source\WebCore\testing\MockPageOverlay.cpp : fatal error C1083: Cannot open include file: &apos;WebCoreTestSupportPrefix.h&apos;: No such file or directory
&gt;   WebCoreTestSupport.cpp
&gt;   JSInternals.cpp
&gt;   Internals.cpp
&gt; ========== Rebuild All: 0 succeeded, 1 failed, 0 skipped ==========</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1284123</commentid>
    <comment_count>1</comment_count>
      <attachid>303603</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2017-03-06 19:00:42 -0800</bug_when>
    <thetext>Created attachment 303603
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1284152</commentid>
    <comment_count>2</comment_count>
      <attachid>303603</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-06 20:17:04 -0800</bug_when>
    <thetext>Comment on attachment 303603
Patch

Clearing flags on attachment: 303603

Committed r213493: &lt;http://trac.webkit.org/changeset/213493&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1284153</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-06 20:17:07 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>303603</attachid>
            <date>2017-03-06 19:00:42 -0800</date>
            <delta_ts>2017-03-06 20:17:04 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-169244-20170307120041.patch</filename>
            <type>text/plain</type>
            <size>1287</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzNDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNiYTNiM2MwZDlkNjky
N2ZjMDJlNDBlM2YzMWI3YmY0YWY5MzRjMS4uOWZhZmExMzQ0OTRiOTMxYWUzNTg2OWRmNjYwZjY4
ZGU0NTgxYTYxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAzLTA2ICBGdWpp
aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV0g
U04tREJTIGZhaWxzIHRvIGJ1aWxkOiBDYW5ub3Qgb3BlbiBpbmNsdWRlIGZpbGU6ICdXZWJDb3Jl
VGVzdFN1cHBvcnRQcmVmaXguaCcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE2OTI0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIEEgZGlzdHJpYnV0ZWQgYnVpbGQgc3lzdGVtIFNOLURCUyBjYW4gbm90IGZp
bmQKKyAgICAgICAgV2ViQ29yZVRlc3RTdXBwb3J0UHJlZml4Lmggd2l0aG91dCBhbiBpbmNsdWRl
IHBhdGggdG8gaXQuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogQWRkICdXZWJDb3JlL3Rl
c3RpbmcvanMnIHRvIGluY2x1ZGUgcGF0aHMuCisKIDIwMTctMDMtMDYgIENocmlzIER1bWV6ICA8
Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBUaHJvdHRsZSBDU1MgYW5pbWF0aW9u
cyB0byAzMGZwcyBpbiBsb3cgcG93ZXIgbW9kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv
Q01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBkZDJh
YTdiOGFkYWJkYTgwZGM3N2QwY2UzNjdhOWQxYzlkZjEyZGJlLi5mOTgzZWRmNmQwYjk5YzI5OGE0
MzRlNDE1YzYxMjA1NTZhMWQ5NzAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxp
c3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMzQxNiw2ICsz
NDE2LDcgQEAgZW5kaWYgKCkKIHNldChXZWJDb3JlVGVzdFN1cHBvcnRfSU5DTFVERV9ESVJFQ1RP
UklFUwogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9tb2NrIgogICAgICIke1dFQkNPUkVf
RElSfS90ZXN0aW5nIgorICAgICIke1dFQkNPUkVfRElSfS90ZXN0aW5nL2pzIgogICAgICIke0RF
UklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0iCiApCiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>