169241 2017-03-06 17:37:36 -0800 [Mac][WK2] Support new CoreMedia routing features 2017-03-06 19:09:46 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham achristensen ap bfulgham oldest_to_newest 1284084 0 bfulgham 2017-03-06 17:37:36 -0800 Update the WebProcess sandbox (on macOS) to support two new XPC connection points. 1284085 1 bfulgham 2017-03-06 17:38:38 -0800 <rdar://problem/30077969> 1284086 2 303592 bfulgham 2017-03-06 17:39:23 -0800 Created attachment 303592 Patch 1284103 3 303592 ap 2017-03-06 18:32:29 -0800 Comment on attachment 303592 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303592&action=review > Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:370 > + ; Note: "com.apple.coremedia.endpointpicker.xpc" can be removed when <rdar://problem/30081582> is resolved. Please remove "Note: ", as all comments are notes. > Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:372 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED > 101200 Does __MAC_OS_X_VERSION_MIN_REQUIRED ever change for point update SDKs? Maybe the check should be ">= 101300". 1284124 4 303592 bfulgham 2017-03-06 19:04:50 -0800 Comment on attachment 303592 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303592&action=review >> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:372 >> +#if __MAC_OS_X_VERSION_MIN_REQUIRED > 101200 > > Does __MAC_OS_X_VERSION_MIN_REQUIRED ever change for point update SDKs? Maybe the check should be ">= 101300". I am told by our build team that this value is only ever set to a full release version, though there's no specific reason why this must be true. I'm happy to change to 101300. 1284126 5 bfulgham 2017-03-06 19:09:46 -0800 Committed r213490: <http://trac.webkit.org/changeset/213490> 303592 2017-03-06 17:39:23 -0800 2017-03-06 18:32:29 -0800 Patch bug-169241-20170306173923.patch text/plain 1636 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzQ4MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAzLTA2ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdW1dLMl0gU3VwcG9y dCBuZXcgQ29yZU1lZGlhIHJvdXRpbmcgZmVhdHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTI0MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MzAwNzc5Njk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluOgorCiAyMDE3LTAzLTAz ICBNYXR0IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYTogbm90aWZ5 IGNsaWVudHMgd2hlbiB0aGUgdXNlciBuZXZlciBwbGF5cyBhIG1lZGlhIGVsZW1lbnQgdGhhdCB3 YXMgcHJldmVudGVkIGZyb20gYXV0by1wbGF5aW5nCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4JKHJldmlzaW9uIDIx MzQ1OSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Mu c2IuaW4JKHdvcmtpbmcgY29weSkKQEAgLTM2Nyw3ICszNjcsMTMgQEAKICAgICAoZ2xvYmFsLW5h bWUgImNvbS5hcHBsZS5jb3JlbWVkaWEuZW5kcG9pbnQueHBjIikKICAgICAoZ2xvYmFsLW5hbWUg ImNvbS5hcHBsZS5jb3JlbWVkaWEuZW5kcG9pbnRzdHJlYW0ueHBjIikKICAgICAoZ2xvYmFsLW5h bWUgImNvbS5hcHBsZS5jb3JlbWVkaWEuZW5kcG9pbnRwbGF5YmFja3Nlc3Npb24ueHBjIikKLSAg ICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5jb3JlbWVkaWEuZW5kcG9pbnRwaWNrZXIueHBjIikp CisgICAgOyBOb3RlOiAiY29tLmFwcGxlLmNvcmVtZWRpYS5lbmRwb2ludHBpY2tlci54cGMiIGNh biBiZSByZW1vdmVkIHdoZW4gPHJkYXI6Ly9wcm9ibGVtLzMwMDgxNTgyPiBpcyByZXNvbHZlZC4K KyAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5jb3JlbWVkaWEuZW5kcG9pbnRwaWNrZXIueHBj IikKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID4gMTAxMjAwCisgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUuY29yZW1lZGlhLnJvdXRlZGlzY292ZXJlci54cGMiKQorICAg IChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5yb3V0aW5nY29udGV4dC54cGMiKQor I2VuZGlmCispCiAKIDs7IERhdGEgRGV0ZWN0b3JzCiAoYWxsb3cgZmlsZS1yZWFkKiAoc3VicGF0 aCAiL3ByaXZhdGUvdmFyL2RiL2RhdGFkZXRlY3RvcnMvc3lzIikpCg==