169225 2017-03-06 15:15:39 -0800 Add WK_CLASS_AVAILABLE to _WKLinkIconParameters and _WKWebViewPrintFormatter 2017-03-06 20:23:02 -0800 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue juergen mitz thorton oldest_to_newest 1283997 0 aakash_jain 2017-03-06 15:15:39 -0800 So as to match headers exactly with the binary and make TAPI happy. 1283999 1 303567 aakash_jain 2017-03-06 15:19:20 -0800 Created attachment 303567 Proposed patch 1284003 2 303567 ap 2017-03-06 15:26:22 -0800 Comment on attachment 303567 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=303567&action=review > Source/WebKit2/UIProcess/API/Cocoa/_WKLinkIconParameters.h:38 > +WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0)) I don't think that this one is accurate. I don't see _WKLinkIconParameters in any shipping WebKit version. 1284073 3 303589 aakash_jain 2017-03-06 17:17:04 -0800 Created attachment 303589 Updated patch 1284077 4 303589 thorton 2017-03-06 17:20:57 -0800 Comment on attachment 303589 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=303589&action=review > Source/WebKit2/UIProcess/_WKWebViewPrintFormatter.h:33 > +WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0)) I think this file should be in UIProcess/API/Cocoa? 1284079 5 303589 thorton 2017-03-06 17:22:47 -0800 Comment on attachment 303589 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=303589&action=review >> Source/WebKit2/UIProcess/_WKWebViewPrintFormatter.h:33 >> +WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0)) > > I think this file should be in UIProcess/API/Cocoa? Also, not available on Mac 1284125 6 aakash_jain 2017-03-06 19:08:14 -0800 Let's do that in a separate patch. This patch focus on fixing errors from TAPI. 1284131 7 ap 2017-03-06 19:20:21 -0800 > Also, not available on Mac That part can be fixed in this patch - I think that "macosx(NA)" would be right. 1284132 8 aakash_jain 2017-03-06 19:26:21 -0800 Yeah. I believe removing macos() and just keeping WK_CLASS_AVAILABLE(ios(8.0)) should be fine. Similar to: https://trac.webkit.org/changeset/205559/trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreviewElementInfo.h 1284134 9 303604 aakash_jain 2017-03-06 19:42:21 -0800 Created attachment 303604 Updated patch patch for landing. 1284158 10 303604 commit-queue 2017-03-06 20:22:57 -0800 Comment on attachment 303604 Updated patch Clearing flags on attachment: 303604 Committed r213495: <http://trac.webkit.org/changeset/213495> 1284159 11 commit-queue 2017-03-06 20:23:02 -0800 All reviewed patches have been landed. Closing bug. 303567 2017-03-06 15:19:20 -0800 2017-03-06 17:17:04 -0800 Proposed patch patch_WKWebViewPrintFormatter text/plain 1828 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzQ3MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAzLTA2ICBBYWthc2gg SmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgV0tfQ0xBU1NfQVZB SUxBQkxFIHRvIF9XS0xpbmtJY29uUGFyYW1ldGVycyBhbmQgX1dLV2ViVmlld1ByaW50Rm9ybWF0 dGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjky MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvQ29jb2EvX1dLTGlua0ljb25QYXJhbWV0ZXJzLmg6CisgICAgICAgICogVUlQ cm9jZXNzL19XS1dlYlZpZXdQcmludEZvcm1hdHRlci5oOgorCiAyMDE3LTAzLTAzICBNYXR0IFJh amNhICA8bXJhamNhQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYTogbm90aWZ5IGNsaWVudHMg d2hlbiB0aGUgdXNlciBuZXZlciBwbGF5cyBhIG1lZGlhIGVsZW1lbnQgdGhhdCB3YXMgcHJldmVu dGVkIGZyb20gYXV0by1wbGF5aW5nCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvX1dL V2ViVmlld1ByaW50Rm9ybWF0dGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL19XS1dlYlZpZXdQcmludEZvcm1hdHRlci5oCShyZXZpc2lvbiAyMTM0NjEpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvX1dLV2ViVmlld1ByaW50Rm9ybWF0dGVyLmgJKHdvcmtp bmcgY29weSkKQEAgLTI2LDkgKzI2LDExIEBACiAjaWYgVEFSR0VUX09TX0lQSE9ORQogCiAjaW1w b3J0IDxVSUtpdC9VSVByaW50Rm9ybWF0dGVyLmg+CisjaW1wb3J0IDxXZWJLaXQvV0tGb3VuZGF0 aW9uLmg+CiAKIEBjbGFzcyBfV0tGcmFtZUhhbmRsZTsKIAorV0tfQ0xBU1NfQVZBSUxBQkxFKG1h Y29zeCgxMC4xMCksIGlvcyg4LjApKQogQGludGVyZmFjZSBfV0tXZWJWaWV3UHJpbnRGb3JtYXR0 ZXIgOiBVSVZpZXdQcmludEZvcm1hdHRlcgogCiBAcHJvcGVydHkgKG5vbmF0b21pYywgc3Ryb25n KSBfV0tGcmFtZUhhbmRsZSAqZnJhbWVUb1ByaW50OwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9fV0tMaW5rSWNvblBhcmFtZXRlcnMuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0xpbmtJY29uUGFyYW1ldGVycy5o CShyZXZpc2lvbiAyMTM0NjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L19XS0xpbmtJY29uUGFyYW1ldGVycy5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw2ICszNSw3IEBA IHR5cGVkZWYgTlNfRU5VTShOU0ludGVnZXIsIFdLTGlua0ljb25UeXAKICAgICBXS0xpbmtJY29u VHlwZVRvdWNoUHJlY29tcG9zZWRJY29uLAogfTsKIAorV0tfQ0xBU1NfQVZBSUxBQkxFKG1hY29z eCgxMC4xMCksIGlvcyg4LjApKQogQGludGVyZmFjZSBfV0tMaW5rSWNvblBhcmFtZXRlcnMgOiBO U09iamVjdAogCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGNvcHkpIE5TVVJMICp1 cmw7Cg== 303589 2017-03-06 17:17:04 -0800 2017-03-06 19:42:21 -0800 Updated patch patch_WKWebViewPrintFormatter_v2 text/plain 1840 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzQ3OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAzLTA2ICBBYWthc2gg SmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgV0tfQ0xBU1NfQVZB SUxBQkxFIHRvIF9XS0xpbmtJY29uUGFyYW1ldGVycyBhbmQgX1dLV2ViVmlld1ByaW50Rm9ybWF0 dGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjky MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvQ29jb2EvX1dLTGlua0ljb25QYXJhbWV0ZXJzLmg6CisgICAgICAgICogVUlQ cm9jZXNzL19XS1dlYlZpZXdQcmludEZvcm1hdHRlci5oOgorCiAyMDE3LTAzLTAzICBNYXR0IFJh amNhICA8bXJhamNhQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYTogbm90aWZ5IGNsaWVudHMg d2hlbiB0aGUgdXNlciBuZXZlciBwbGF5cyBhIG1lZGlhIGVsZW1lbnQgdGhhdCB3YXMgcHJldmVu dGVkIGZyb20gYXV0by1wbGF5aW5nCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvX1dL V2ViVmlld1ByaW50Rm9ybWF0dGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL19XS1dlYlZpZXdQcmludEZvcm1hdHRlci5oCShyZXZpc2lvbiAyMTM0NjEpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvX1dLV2ViVmlld1ByaW50Rm9ybWF0dGVyLmgJKHdvcmtp bmcgY29weSkKQEAgLTI2LDkgKzI2LDExIEBACiAjaWYgVEFSR0VUX09TX0lQSE9ORQogCiAjaW1w b3J0IDxVSUtpdC9VSVByaW50Rm9ybWF0dGVyLmg+CisjaW1wb3J0IDxXZWJLaXQvV0tGb3VuZGF0 aW9uLmg+CiAKIEBjbGFzcyBfV0tGcmFtZUhhbmRsZTsKIAorV0tfQ0xBU1NfQVZBSUxBQkxFKG1h Y29zeCgxMC4xMCksIGlvcyg4LjApKQogQGludGVyZmFjZSBfV0tXZWJWaWV3UHJpbnRGb3JtYXR0 ZXIgOiBVSVZpZXdQcmludEZvcm1hdHRlcgogCiBAcHJvcGVydHkgKG5vbmF0b21pYywgc3Ryb25n KSBfV0tGcmFtZUhhbmRsZSAqZnJhbWVUb1ByaW50OwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9fV0tMaW5rSWNvblBhcmFtZXRlcnMuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0xpbmtJY29uUGFyYW1ldGVycy5o CShyZXZpc2lvbiAyMTM0NjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L19XS0xpbmtJY29uUGFyYW1ldGVycy5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw2ICszNSw3IEBA IHR5cGVkZWYgTlNfRU5VTShOU0ludGVnZXIsIFdLTGlua0ljb25UeXAKICAgICBXS0xpbmtJY29u VHlwZVRvdWNoUHJlY29tcG9zZWRJY29uLAogfTsKIAorV0tfQ0xBU1NfQVZBSUxBQkxFKG1hY29z eChXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKQogQGludGVyZmFjZSBfV0tMaW5rSWNvblBh cmFtZXRlcnMgOiBOU09iamVjdAogCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGNv cHkpIE5TVVJMICp1cmw7Cg== 303604 2017-03-06 19:42:21 -0800 2017-03-06 20:22:57 -0800 Updated patch patch_WKWebViewPrintFormatter_v3 text/plain 1821 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzQ3OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAzLTA2ICBBYWthc2gg SmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgV0tfQ0xBU1NfQVZB SUxBQkxFIHRvIF9XS0xpbmtJY29uUGFyYW1ldGVycyBhbmQgX1dLV2ViVmlld1ByaW50Rm9ybWF0 dGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjky MjUKKworICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9Db2NvYS9fV0tMaW5rSWNvblBhcmFtZXRlcnMuaDoKKyAgICAgICAgKiBVSVByb2Nl c3MvX1dLV2ViVmlld1ByaW50Rm9ybWF0dGVyLmg6CisKIDIwMTctMDMtMDMgIE1hdHQgUmFqY2Eg IDxtcmFqY2FAYXBwbGUuY29tPgogCiAgICAgICAgIE1lZGlhOiBub3RpZnkgY2xpZW50cyB3aGVu IHRoZSB1c2VyIG5ldmVyIHBsYXlzIGEgbWVkaWEgZWxlbWVudCB0aGF0IHdhcyBwcmV2ZW50ZWQg ZnJvbSBhdXRvLXBsYXlpbmcKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9fV0tXZWJW aWV3UHJpbnRGb3JtYXR0ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvX1dLV2ViVmlld1ByaW50Rm9ybWF0dGVyLmgJKHJldmlzaW9uIDIxMzQ2MSkKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9fV0tXZWJWaWV3UHJpbnRGb3JtYXR0ZXIuaAkod29ya2luZyBj b3B5KQpAQCAtMjYsOSArMjYsMTEgQEAKICNpZiBUQVJHRVRfT1NfSVBIT05FCiAKICNpbXBvcnQg PFVJS2l0L1VJUHJpbnRGb3JtYXR0ZXIuaD4KKyNpbXBvcnQgPFdlYktpdC9XS0ZvdW5kYXRpb24u aD4KIAogQGNsYXNzIF9XS0ZyYW1lSGFuZGxlOwogCitXS19DTEFTU19BVkFJTEFCTEUoaW9zKDgu MCkpCiBAaW50ZXJmYWNlIF9XS1dlYlZpZXdQcmludEZvcm1hdHRlciA6IFVJVmlld1ByaW50Rm9y bWF0dGVyCiAKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzdHJvbmcpIF9XS0ZyYW1lSGFuZGxlICpm cmFtZVRvUHJpbnQ7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19X S0xpbmtJY29uUGFyYW1ldGVycy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvX1dLTGlua0ljb25QYXJhbWV0ZXJzLmgJKHJldmlzaW9uIDIxMzQ2MSkK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLTGlua0ljb25QYXJhbWV0 ZXJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAgdHlwZWRlZiBOU19FTlVNKE5T SW50ZWdlciwgV0tMaW5rSWNvblR5cAogICAgIFdLTGlua0ljb25UeXBlVG91Y2hQcmVjb21wb3Nl ZEljb24sCiB9OwogCitXS19DTEFTU19BVkFJTEFCTEUobWFjb3N4KFdLX01BQ19UQkEpLCBpb3Mo V0tfSU9TX1RCQSkpCiBAaW50ZXJmYWNlIF9XS0xpbmtJY29uUGFyYW1ldGVycyA6IE5TT2JqZWN0 CiAKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSwgY29weSkgTlNVUkwgKnVybDsK