169223 2017-03-06 15:05:44 -0800 [Cocoa] Expose API::InjectedBundle::EditorClient::didChange via the Objective-C bundle SPI 2017-03-06 21:15:45 -0800 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz commit-queue oldest_to_newest 1283990 0 mitz 2017-03-06 15:05:44 -0800 A WebKit client requires a bundle notification when the contents change due to editing. 1284072 1 303588 mitz 2017-03-06 17:16:11 -0800 Created attachment 303588 Add _webProcessPlugInBrowserContextControllerDidChange: 1284075 2 commit-queue 2017-03-06 17:17:29 -0800 Attachment 303588 did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:626: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1284076 3 303588 thorton 2017-03-06 17:17:55 -0800 Comment on attachment 303588 Add _webProcessPlugInBrowserContextControllerDidChange: View in context: https://bugs.webkit.org/attachment.cgi?id=303588&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h:58 > +- (void)_webProcessPlugInBrowserContextControllerDidChange:(WKWebProcessPlugInBrowserContextController *)controller; I do not love this name. 1284145 4 303588 mitz 2017-03-06 20:04:51 -0800 Comment on attachment 303588 Add _webProcessPlugInBrowserContextControllerDidChange: View in context: https://bugs.webkit.org/attachment.cgi?id=303588&action=review >> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h:58 >> +- (void)_webProcessPlugInBrowserContextControllerDidChange:(WKWebProcessPlugInBrowserContextController *)controller; > > I do not love this name. We are going to append “ByEditing”. 1284178 5 mitz 2017-03-06 21:15:45 -0800 Committed <https://trac.webkit.org/r213498>. 303588 2017-03-06 17:16:11 -0800 2017-03-06 17:17:55 -0800 Add _webProcessPlugInBrowserContextControllerDidChange: bug-169223-20170306171611.patch text/plain 4947 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzQ3OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAzLTA2ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBFeHBvc2UgQVBJOjpJ bmplY3RlZEJ1bmRsZTo6RWRpdG9yQ2xpZW50OjpkaWRDaGFuZ2UgdmlhIHRoZSBPYmplY3RpdmUt QyBidW5kbGUgU1BJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjkyMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1Bs dWdJbkVkaXRpbmdEZWxlZ2F0ZS5oOiBEZWNsYXJlZCBuZXcKKyAgICAgICAgICBkZWxlZ2F0ZSBt ZXRob2QgLV93ZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyRGlkQ2hhbmdl Oi4KKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9j ZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS1dlYlBy b2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXIgX3NldEVkaXRpbmdEZWxlZ2F0ZTpd KTogQWRkZWQgYW4gb3ZlcnJpZGUKKyAgICAgICAgICBvZiBBUEk6OkluamVjdGVkQnVuZGxlOjpF ZGl0b3JDbGllbnQ6OmRpZENoYW5nZSB0aGF0IGNhbGxzIHRoZSBuZXcgZGVsZWdhdGUgbWV0aG9k LgorCiAyMDE3LTAzLTAzICBNYXR0IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KIAogICAgICAg ICBNZWRpYTogbm90aWZ5IGNsaWVudHMgd2hlbiB0aGUgdXNlciBuZXZlciBwbGF5cyBhIG1lZGlh IGVsZW1lbnQgdGhhdCB3YXMgcHJldmVudGVkIGZyb20gYXV0by1wbGF5aW5nCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nl c3NQbHVnSW5FZGl0aW5nRGVsZWdhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVnSW5FZGl0 aW5nRGVsZWdhdGUuaAkocmV2aXNpb24gMjEzNDYwKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luRWRpdGluZ0Rl bGVnYXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTU1LDYgKzU1LDcgQEAgV0tfQVBJX0FWQUlMQUJM RShtYWNvc3goV0tfTUFDX1RCQSksIGlvcwogI2Vsc2UKIC0gKEJPT0wpX3dlYlByb2Nlc3NQbHVn SW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXI6KFdLV2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250 ZXh0Q29udHJvbGxlciAqKWNvbnRyb2xsZXIgc2hvdWxkQ2hhbmdlU2VsZWN0ZWRSYW5nZTooV0tE T01SYW5nZSAqKWN1cnJlbnRSYW5nZSB0b1JhbmdlOihXS0RPTVJhbmdlICopcHJvcG9zZWRSYW5n ZSBhZmZpbml0eTooTlNTZWxlY3Rpb25BZmZpbml0eSlzZWxlY3Rpb25BZmZpbml0eSBzdGlsbFNl bGVjdGluZzooQk9PTClzdGlsbFNlbGVjdGluZzsKICNlbmRpZgorLSAodm9pZClfd2ViUHJvY2Vz c1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlckRpZENoYW5nZTooV0tXZWJQcm9jZXNzUGx1 Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyICopY29udHJvbGxlcjsKIC0gKHZvaWQpX3dlYlBy b2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXI6KFdLV2ViUHJvY2Vzc1BsdWdJbkJy b3dzZXJDb250ZXh0Q29udHJvbGxlciAqKWNvbnRyb2xsZXIgd2lsbFdyaXRlUmFuZ2VUb1Bhc3Rl Ym9hcmQ6KFdLV2ViUHJvY2Vzc1BsdWdJblJhbmdlSGFuZGxlICopcmFuZ2U7CiAtIChOU0RpY3Rp b25hcnk8TlNTdHJpbmcgKiwgTlNEYXRhICo+ICopX3dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29u dGV4dENvbnRyb2xsZXI6KFdLV2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxl ciAqKWNvbnRyb2xsZXIgcGFzdGVib2FyZERhdGFGb3JSYW5nZTooV0tXZWJQcm9jZXNzUGx1Z0lu UmFuZ2VIYW5kbGUgKilyYW5nZTsKIC0gKHZvaWQpX3dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29u dGV4dENvbnRyb2xsZXJEaWRXcml0ZVRvUGFzdGVib2FyZDooV0tXZWJQcm9jZXNzUGx1Z0luQnJv d3NlckNvbnRleHRDb250cm9sbGVyICopY29udHJvbGxlcjsKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL21hYy9XS1dlYlByb2Nlc3NQbHVnSW5Ccm93 c2VyQ29udGV4dENvbnRyb2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJD b250ZXh0Q29udHJvbGxlci5tbQkocmV2aXNpb24gMjEzNDYwKQorKysgU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2ViUHJvY2Vzc1BsdWdJbkJyb3dz ZXJDb250ZXh0Q29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtNjIyLDYgKzYyMiwxNCBA QCAtICh2b2lkKV9zZXRFZGl0aW5nRGVsZWdhdGU6KGlkIDxXS1dlYlByCiAgICAgICAgICAgICBy ZXR1cm4gW21fY29udHJvbGxlci0+X2VkaXRpbmdEZWxlZ2F0ZS5nZXQoKSBfd2ViUHJvY2Vzc1Bs dWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlcjptX2NvbnRyb2xsZXIgc2hvdWxkQ2hhbmdlU2Vs ZWN0ZWRSYW5nZTphcGlGcm9tUmFuZ2UuZ2V0KCkgdG9SYW5nZTphcGlUb1JhbmdlLmdldCgpIGFm ZmluaXR5OmFwaUFmZmluaXR5IHN0aWxsU2VsZWN0aW5nOnN0aWxsU2VsZWN0aW5nXTsKICAgICAg ICAgfQogCisgICAgICAgIHZvaWQgZGlkQ2hhbmdlKFdlYktpdDo6V2ViUGFnZSYsIFN0cmluZ0lt cGwqKSBmaW5hbAorICAgICAgICB7CisgICAgICAgICAgICBpZiAoIW1fZGVsZWdhdGVNZXRob2Rz LmRpZENoYW5nZSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgICAgIFttX2Nv bnRyb2xsZXItPl9lZGl0aW5nRGVsZWdhdGUuZ2V0KCkgX3dlYlByb2Nlc3NQbHVnSW5Ccm93c2Vy Q29udGV4dENvbnRyb2xsZXJEaWRDaGFuZ2U6bV9jb250cm9sbGVyXTsKKyAgICAgICAgfQorCiAg ICAgICAgIHZvaWQgd2lsbFdyaXRlVG9QYXN0ZWJvYXJkKFdlYktpdDo6V2ViUGFnZSYsIFdlYkNv cmU6OlJhbmdlKiByYW5nZSkgZmluYWwKICAgICAgICAgewogICAgICAgICAgICAgaWYgKCFtX2Rl bGVnYXRlTWV0aG9kcy53aWxsV3JpdGVUb1Bhc3RlYm9hcmQpCkBAIC02NTUsNiArNjYzLDcgQEAg LSAodm9pZClfc2V0RWRpdGluZ0RlbGVnYXRlOihpZCA8V0tXZWJQcgogICAgICAgICAgICAgRGVs ZWdhdGVNZXRob2RzKFJldGFpblB0cjxpZCA8V0tXZWJQcm9jZXNzUGx1Z0luRWRpdGluZ0RlbGVn YXRlPj4gZGVsZWdhdGUpCiAgICAgICAgICAgICAgICAgOiBzaG91bGRJbnNlcnRUZXh0KFtkZWxl Z2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJQcm9jZXNzUGx1Z0luQnJvd3Nl ckNvbnRleHRDb250cm9sbGVyOnNob3VsZEluc2VydFRleHQ6cmVwbGFjaW5nUmFuZ2U6Z2l2ZW5B Y3Rpb246KV0pCiAgICAgICAgICAgICAgICAgLCBzaG91bGRDaGFuZ2VTZWxlY3RlZFJhbmdlKFtk ZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJQcm9jZXNzUGx1Z0luQnJv d3NlckNvbnRleHRDb250cm9sbGVyOnNob3VsZENoYW5nZVNlbGVjdGVkUmFuZ2U6dG9SYW5nZTph ZmZpbml0eTpzdGlsbFNlbGVjdGluZzopXSkKKyAgICAgICAgICAgICAgICAsIGRpZENoYW5nZShb ZGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihfd2ViUHJvY2Vzc1BsdWdJbkJy b3dzZXJDb250ZXh0Q29udHJvbGxlckRpZENoYW5nZTopXSkKICAgICAgICAgICAgICAgICAsIHdp bGxXcml0ZVRvUGFzdGVib2FyZChbZGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rv cihfd2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlcjp3aWxsV3JpdGVSYW5n ZVRvUGFzdGVib2FyZDopXSkKICAgICAgICAgICAgICAgICAsIGdldFBhc3RlYm9hcmREYXRhRm9y UmFuZ2UoW2RlbGVnYXRlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlByb2Nlc3NQ bHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXI6cGFzdGVib2FyZERhdGFGb3JSYW5nZTopXSkK ICAgICAgICAgICAgICAgICAsIGRpZFdyaXRlVG9QYXN0ZWJvYXJkKFtkZWxlZ2F0ZSByZXNwb25k c1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250 cm9sbGVyRGlkV3JpdGVUb1Bhc3RlYm9hcmQ6KV0pCkBAIC02NjMsNiArNjcyLDcgQEAgLSAodm9p ZClfc2V0RWRpdGluZ0RlbGVnYXRlOihpZCA8V0tXZWJQcgogCiAgICAgICAgICAgICBib29sIHNo b3VsZEluc2VydFRleHQ7CiAgICAgICAgICAgICBib29sIHNob3VsZENoYW5nZVNlbGVjdGVkUmFu Z2U7CisgICAgICAgICAgICBib29sIGRpZENoYW5nZTsKICAgICAgICAgICAgIGJvb2wgd2lsbFdy aXRlVG9QYXN0ZWJvYXJkOwogICAgICAgICAgICAgYm9vbCBnZXRQYXN0ZWJvYXJkRGF0YUZvclJh bmdlOwogICAgICAgICAgICAgYm9vbCBkaWRXcml0ZVRvUGFzdGVib2FyZDsK