169220 2017-03-06 14:42:45 -0800 webkitpy: Refactor setup_test_run for IOSPort and IOSSimulator 2017-03-07 12:05:59 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 169054 1 jbedard jbedard commit-queue dbates glenn lforschler webkit-bug-importer oldest_to_newest 1283972 0 jbedard 2017-03-06 14:42:45 -0800 IOSPort should hold the setup_test_run function for IOSSimulator. Rename current IOSSimulator.setup_test_run and call this function from IOSPort. 1283974 1 303562 jbedard 2017-03-06 14:48:18 -0800 Created attachment 303562 Patch 1283981 2 webkit-bug-importer 2017-03-06 14:49:24 -0800 <rdar://problem/30879645> 1284409 3 303562 dbates 2017-03-07 10:52:25 -0800 Comment on attachment 303562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303562&action=review > Tools/ChangeLog:7 > + Please explain the motivation for this change. 1284410 4 303562 dbates 2017-03-07 10:53:11 -0800 Comment on attachment 303562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303562&action=review > Tools/ChangeLog:5 > + Please add the Radar bug URL here. 1284438 5 303684 jbedard 2017-03-07 11:26:00 -0800 Created attachment 303684 Patch for landing 1284466 6 303684 commit-queue 2017-03-07 12:05:54 -0800 Comment on attachment 303684 Patch for landing Clearing flags on attachment: 303684 Committed r213530: <http://trac.webkit.org/changeset/213530> 1284467 7 commit-queue 2017-03-07 12:05:59 -0800 All reviewed patches have been landed. Closing bug. 303562 2017-03-06 14:48:18 -0800 2017-03-07 11:25:56 -0800 Patch bug-169220-20170306144818.patch text/plain 2222 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMzQ2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE3LTAzLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogUmVmYWN0b3Igc2V0dXBfdGVzdF9ydW4gZm9yIElPU1Bv cnQgYW5kIElPU1NpbXVsYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY5MjIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5OgorICAgICAgICAoSU9T UG9ydCk6CisgICAgICAgIChJT1NQb3J0Ll9jcmVhdGVfZGV2aWNlcyk6IEFkZGVkLgorICAgICAg ICAoSU9TUG9ydC5zZXR1cF90ZXN0X3J1bik6IFNoYXJlZCBpT1MgZGV2aWNlIHNldHVwIGNvZGUu CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvc19zaW11bGF0b3IucHk6CisgICAg ICAgIChJT1NTaW11bGF0b3JQb3J0Ll9jcmVhdGVfZGV2aWNlcyk6IFJlbmFtZWQgZnJvbSBzZXR1 cF90ZXN0X3J1bi4KKyAgICAgICAgKElPU1NpbXVsYXRvclBvcnQuc2V0dXBfdGVzdF9ydW4pOiBS ZW5hbWVkIGFzIF9jcmVhdGVfZGV2aWNlcy4KKwogMjAxNy0wMy0wNiAgTXlsZXMgQy4gTWF4Zmll bGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIEV4cGFuZCBmb250LXdlaWdodCBh bmQgZm9udC1zdHJldGNoIHRvIHRha2UgYW55IG51bWJlcgpJbmRleDogVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L2lvcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvaW9zLnB5CShyZXZpc2lvbiAyMTM0NjYpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvaW9zLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03NiwzICs3Niw5IEBAIGNsYXNzIElPU1Bv cnQoRGFyd2luUG9ydCk6CiAgICAgICAgIGlmIHNlbGYudXNpbmdfbXVsdGlwbGVfZGV2aWNlcygp OgogICAgICAgICAgICAgcmV0dXJuIHNlbGYuX3Rlc3RpbmdfZGV2aWNlKG51bWJlcikKICAgICAg ICAgcmV0dXJuIHNlbGYuX2N1cnJlbnRfZGV2aWNlCisKKyAgICBkZWYgX2NyZWF0ZV9kZXZpY2Vz KHNlbGYsIGRldmljZV9jbGFzcyk6CisgICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IK KworICAgIGRlZiBzZXR1cF90ZXN0X3J1bihzZWxmLCBkZXZpY2VfY2xhc3M9Tm9uZSk6CisgICAg ICAgIHNlbGYuX2NyZWF0ZV9kZXZpY2VzKGRldmljZV9jbGFzcykKSW5kZXg6IFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5CShyZXZpc2lvbiAyMTM0NjYpCisr KyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zX3NpbXVsYXRvci5weQkod29ya2luZyBj b3B5KQpAQCAtMjEwLDcgKzIxMCw3IEBAIGNsYXNzIElPU1NpbXVsYXRvclBvcnQoSU9TUG9ydCk6 CiAgICAgICAgICAgICAgICAgX2xvZy53YXJuKCJFeHBlY3RlZCBzaW11bGF0b3Igb2YgdHlwZSAn IiArIHNlbGYuc2ltdWxhdG9yX2RldmljZV90eXBlKCkubmFtZSArICInIGJ1dCBmb3VuZCBzaW11 bGF0b3Igb2YgdHlwZSAnIiArIHNlbGYuX2N1cnJlbnRfZGV2aWNlLm5hbWUgKyAiJyIpCiAgICAg ICAgICAgICAgICAgX2xvZy53YXJuKCdUaGUgbmV4dCBibG9jayBvZiB0ZXN0cyBtYXkgZmFpbCBk dWUgdG8gZGV2aWNlIG1pcy1tYXRjaCcpCiAKLSAgICBkZWYgc2V0dXBfdGVzdF9ydW4oc2VsZiwg ZGV2aWNlX2NsYXNzPU5vbmUpOgorICAgIGRlZiBfY3JlYXRlX2RldmljZXMoc2VsZiwgZGV2aWNl X2NsYXNzKToKICAgICAgICAgbWFjX29zX3ZlcnNpb24gPSBzZWxmLmhvc3QucGxhdGZvcm0ub3Nf dmVyc2lvbgogCiAgICAgICAgIHNlbGYuX3NldF9kZXZpY2VfY2xhc3MoZGV2aWNlX2NsYXNzKQo= 303684 2017-03-07 11:26:00 -0800 2017-03-07 12:05:54 -0800 Patch for landing bug-169220-20170307112559.patch text/plain 2351 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMzUyNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE3LTAzLTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogUmVmYWN0b3Igc2V0dXBfdGVzdF9ydW4gZm9yIElPU1Bv cnQgYW5kIElPU1NpbXVsYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY5MjIwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDg3OTY0NT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCisKKyAgICAgICAgUHJvdmlkZSBtb3Jl IHNwZWNpZmljIHBvcnQgc2V0dXAgZnVuY3Rpb25zIGZvciBpT1MgcG9ydHMgdG8gYWxsb3cgbW9y ZSBzaGFyaW5nIG9mIGNvbW1vbiBjb2RlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9w b3J0L2lvcy5weToKKyAgICAgICAgKElPU1BvcnQpOgorICAgICAgICAoSU9TUG9ydC5fY3JlYXRl X2RldmljZXMpOiBBZGRlZC4KKyAgICAgICAgKElPU1BvcnQuc2V0dXBfdGVzdF9ydW4pOiBTaGFy ZWQgaU9TIGRldmljZSBzZXR1cCBjb2RlLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9y dC9pb3Nfc2ltdWxhdG9yLnB5OgorICAgICAgICAoSU9TU2ltdWxhdG9yUG9ydC5fY3JlYXRlX2Rl dmljZXMpOiBSZW5hbWVkIGZyb20gc2V0dXBfdGVzdF9ydW4uCisgICAgICAgIChJT1NTaW11bGF0 b3JQb3J0LnNldHVwX3Rlc3RfcnVuKTogUmVuYW1lZCBhcyBfY3JlYXRlX2RldmljZXMuCisKIDIw MTctMDMtMDcgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAg ICAgICBBZGQgRGF2aWQgSm9uYXRoYW4gUm9zcyB0byBjb250cmlidXRvcnMuanNvbgpJbmRleDog VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5CShyZXZpc2lvbiAyMTM1MjYpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03NiwzICs3Niw5 IEBAIGNsYXNzIElPU1BvcnQoRGFyd2luUG9ydCk6CiAgICAgICAgIGlmIHNlbGYudXNpbmdfbXVs dGlwbGVfZGV2aWNlcygpOgogICAgICAgICAgICAgcmV0dXJuIHNlbGYuX3Rlc3RpbmdfZGV2aWNl KG51bWJlcikKICAgICAgICAgcmV0dXJuIHNlbGYuX2N1cnJlbnRfZGV2aWNlCisKKyAgICBkZWYg X2NyZWF0ZV9kZXZpY2VzKHNlbGYsIGRldmljZV9jbGFzcyk6CisgICAgICAgIHJhaXNlIE5vdElt cGxlbWVudGVkRXJyb3IKKworICAgIGRlZiBzZXR1cF90ZXN0X3J1bihzZWxmLCBkZXZpY2VfY2xh c3M9Tm9uZSk6CisgICAgICAgIHNlbGYuX2NyZWF0ZV9kZXZpY2VzKGRldmljZV9jbGFzcykKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5CShyZXZp c2lvbiAyMTM1MjYpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zX3NpbXVsYXRv ci5weQkod29ya2luZyBjb3B5KQpAQCAtMjEwLDcgKzIxMCw3IEBAIGNsYXNzIElPU1NpbXVsYXRv clBvcnQoSU9TUG9ydCk6CiAgICAgICAgICAgICAgICAgX2xvZy53YXJuKCJFeHBlY3RlZCBzaW11 bGF0b3Igb2YgdHlwZSAnIiArIHNlbGYuc2ltdWxhdG9yX2RldmljZV90eXBlKCkubmFtZSArICIn IGJ1dCBmb3VuZCBzaW11bGF0b3Igb2YgdHlwZSAnIiArIHNlbGYuX2N1cnJlbnRfZGV2aWNlLm5h bWUgKyAiJyIpCiAgICAgICAgICAgICAgICAgX2xvZy53YXJuKCdUaGUgbmV4dCBibG9jayBvZiB0 ZXN0cyBtYXkgZmFpbCBkdWUgdG8gZGV2aWNlIG1pcy1tYXRjaCcpCiAKLSAgICBkZWYgc2V0dXBf dGVzdF9ydW4oc2VsZiwgZGV2aWNlX2NsYXNzPU5vbmUpOgorICAgIGRlZiBfY3JlYXRlX2Rldmlj ZXMoc2VsZiwgZGV2aWNlX2NsYXNzKToKICAgICAgICAgbWFjX29zX3ZlcnNpb24gPSBzZWxmLmhv c3QucGxhdGZvcm0ub3NfdmVyc2lvbgogCiAgICAgICAgIHNlbGYuX3NldF9kZXZpY2VfY2xhc3Mo ZGV2aWNlX2NsYXNzKQo=