16922 2008-01-18 04:14:28 -0800 _NPN_GetIntIdentifier does not work for values 0 or -1 due to using HashMap 2008-01-18 06:14:11 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Other Other RESOLVED WORKSFORME P2 Normal --- 0 john.ripley webkit-unassigned mrowe oldest_to_newest 67589 0 john.ripley 2008-01-18 04:14:28 -0800 The implementation of HashMap for integer keys uses values 0 and -1 as special empty and deleted bins. However, a plug-in can call NPN_GetIntIdentifier for integers 0 or -1. I'm currently working around this by remapping the incoming int32 space to uint64 with bit 32 set, which messily avoids 0 or -1. This causes any plug-in which tries to get an NPIdentifier from Javascript to fail an assertion check. 67592 1 mrowe 2008-01-18 04:37:06 -0800 Which revision are you seeing this problem in? The problem you describe sounds like one which was fixed with <http://trac.webkit.org/projects/webkit/changeset/28366>. 67595 2 john.ripley 2008-01-18 05:59:53 -0800 Sorry - somehow I missed that. The tree I'm working off is mostly 523.x and doesn't have this fix. The trunk version of npruntime.cpp can be taken in isolation, so I'll just grab that. 67598 3 mrowe 2008-01-18 06:14:11 -0800 Closing as WFM as this is fixed in HEAD.