169170 2017-03-04 10:12:02 -0800 [Cocoa] libwebrtc.dylib’s current version is fixed at 1.0.0 2017-03-04 23:41:33 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz commit-queue joepeck sam oldest_to_newest 1283438 0 mitz 2017-03-04 10:12:02 -0800 libwebrtc.dylib’s current version is fixed at 1.0.0, so it’s impossible to tell which version of the library was present at link time, and harder to diagnose version incompatibilities at runtime. Patch forthcoming. 1283443 1 303398 mitz 2017-03-04 10:21:33 -0800 Created attachment 303398 Set DYLIB_CURRENT_VERSION 1283548 2 303398 achristensen 2017-03-04 23:00:43 -0800 Comment on attachment 303398 Set DYLIB_CURRENT_VERSION View in context: https://bugs.webkit.org/attachment.cgi?id=303398&action=review > Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig:1 > +// Copyright (C) 2009 Apple Inc. All rights reserved. 2017? > Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig:36 > +SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Why 8? This definitely matches what is done elsewhere. 1283552 3 303398 mitz 2017-03-04 23:12:55 -0800 Comment on attachment 303398 Set DYLIB_CURRENT_VERSION View in context: https://bugs.webkit.org/attachment.cgi?id=303398&action=review >> Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig:1 >> +// Copyright (C) 2009 Apple Inc. All rights reserved. > > 2017? Making a copy of this file in 2017 doesn’t introduce any new content. >> Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig:36 >> +SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; > > Why 8? This definitely matches what is done elsewhere. My recollection is during the time the iOS fork of WebKit existed, it would occasionally update this to match the most recent upstream Mac OS X version, and that most recently happened with 10.8. Because of the way iOS software updates are installed, it’s not important to use different prefixes for different target OS versions. Because the libwebrtc project doesn’t build any bundles, it doesn’t use the bundle version prefix, but we use the same Version.xcconfig across all projects. 1283557 4 303398 commit-queue 2017-03-04 23:41:28 -0800 Comment on attachment 303398 Set DYLIB_CURRENT_VERSION Clearing flags on attachment: 303398 Committed r213432: <http://trac.webkit.org/changeset/213432> 1283558 5 commit-queue 2017-03-04 23:41:33 -0800 All reviewed patches have been landed. Closing bug. 303398 2017-03-04 10:21:33 -0800 2017-03-04 23:41:28 -0800 Set DYLIB_CURRENT_VERSION bug-169170-20170304102133.patch text/plain 4590 mitz SW5kZXg6IFNvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5nZUxvZwkocmV2aXNpb24gMjEzNDI1 KQorKysgU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAzLTA0ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBs ZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBsaWJ3ZWJydGMuZHlsaWLigJlzIGN1cnJlbnQgdmVy c2lvbiBpcyBmaXhlZCBhdCAxLjAuMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY5MTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmlnOiBDb3BpZWQg ZnJvbSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvVmVyc2lvbi54Y2NvbmZp Zy4KKyAgICAgICAgICBUaGlzIGRlZmluZXMgRFlMSUJfQ1VSUkVOVF9WRVJTSU9OLgorICAgICAg ICAqIENvbmZpZ3VyYXRpb25zL2xpYndlYnJ0Yy54Y2NvbmZpZzogSW5jbHVkZSBWZXJzaW9uLnhj Y29uZmlnLgorCiAyMDE3LTAzLTA0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQ2xlYW51cCBhZnRlciByMjEzNDE4CkluZGV4OiBTb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlvbnMvVmVyc2lvbi54Y2NvbmZpZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlvbnMvVmVy c2lvbi54Y2NvbmZpZwkocmV2aXNpb24gMjEzNDIyKQkoZnJvbSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvQ29uZmlndXJhdGlvbnMvVmVyc2lvbi54Y2NvbmZpZzoyMTM0MjIpCisrKyBTb3VyY2UvVGhp cmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlvbnMvVmVyc2lvbi54Y2NvbmZpZwkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDYwIEBACisvLyBDb3B5cmlnaHQgKEMpIDIwMDkgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorLy8KKy8vIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4g c291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorLy8gbW9kaWZpY2F0aW9u LCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisv LyBhcmUgbWV0OgorLy8gMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0 YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKy8vICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRp dGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKy8vIDIuIFJlZGlzdHJpYnV0aW9u cyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisvLyAg ICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2Ns YWltZXIgaW4gdGhlCisvLyAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMg cHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorLy8KKy8vIFRISVMgU09GVFdBUkUgSVMg UFJPVklERUQgQlkgQVBQTEUgSU5DLiBgYEFTIElTJycgQU5EIEFOWQorLy8gRVhQUkVTUyBPUiBJ TVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKKy8v IElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEg UEFSVElDVUxBUgorLy8gUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxM IEFQUExFIElOQy4gT1IKKy8vIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1Qs IElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLAorLy8gRVhFTVBMQVJZLCBPUiBDT05TRVFV RU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorLy8gUFJPQ1VS RU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEs IE9SCisvLyBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VE IEFORCBPTiBBTlkgVEhFT1JZCisvLyBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1Qs IFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKy8vIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP VEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorLy8gT0YgVEhJUyBT T0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFH RS4gCisKK01BSk9SX1ZFUlNJT04gPSA2MDQ7CitNSU5PUl9WRVJTSU9OID0gMTsKK1RJTllfVkVS U0lPTiA9IDk7CitNSUNST19WRVJTSU9OID0gMDsKK05BTk9fVkVSU0lPTiA9IDA7CitGVUxMX1ZF UlNJT04gPSAkKE1BSk9SX1ZFUlNJT04pLiQoTUlOT1JfVkVSU0lPTikuJChUSU5ZX1ZFUlNJT04p OworCisvLyBUaGUgYnVuZGxlIHZlcnNpb24gYW5kIHNob3J0IHZlcnNpb24gc3RyaW5nIGFyZSBz ZXQgYmFzZWQgb24gdGhlIGN1cnJlbnQgYnVpbGQgY29uZmlndXJhdGlvbiwgc2VlIGJlbG93Lgor QlVORExFX1ZFUlNJT04gPSAkKEJVTkRMRV9WRVJTSU9OXyQoQ09ORklHVVJBVElPTikpOworU0hP UlRfVkVSU0lPTl9TVFJJTkcgPSAkKFNIT1JUX1ZFUlNJT05fU1RSSU5HXyQoQ09ORklHVVJBVElP TikpCisKKy8vIFRoZSBzeXN0ZW0gdmVyc2lvbiBwcmVmaXggaXMgYmFzZWQgb24gdGhlIGN1cnJl bnQgc3lzdGVtIHZlcnNpb24uCitTWVNURU1fVkVSU0lPTl9QUkVGSVhbc2RrPWlwaG9uZSpdID0g ODsKK1NZU1RFTV9WRVJTSU9OX1BSRUZJWCA9ICQoU1lTVEVNX1ZFUlNJT05fUFJFRklYXyQoUExB VEZPUk1fTkFNRSlfJChUQVJHRVRfTUFDX09TX1hfVkVSU0lPTl9NQUpPUikpOworU1lTVEVNX1ZF UlNJT05fUFJFRklYX21hY29zeF8xMDEwMDAgPSAxMDsKK1NZU1RFTV9WRVJTSU9OX1BSRUZJWF9t YWNvc3hfMTAxMTAwID0gMTE7CitTWVNURU1fVkVSU0lPTl9QUkVGSVhfbWFjb3N4XzEwMTIwMCA9 IDEyOworU1lTVEVNX1ZFUlNJT05fUFJFRklYX21hY29zeF8xMDEzMDAgPSAxMzsKKworLy8gVGhl IHByb2R1Y3Rpb24gYnVpbGQgYWx3YXlzIHVzZXMgdGhlIGZ1bGwgdmVyc2lvbiB3aXRoIGEgc3lz dGVtIHZlcnNpb24gcHJlZml4LgorQlVORExFX1ZFUlNJT05fUHJvZHVjdGlvbiA9ICQoU1lTVEVN X1ZFUlNJT05fUFJFRklYKSQoRlVMTF9WRVJTSU9OKTsKK0JVTkRMRV9WRVJTSU9OXyA9ICQoQlVO RExFX1ZFUlNJT05fUHJvZHVjdGlvbik7CisKKy8vIFRoZSBwcm9kdWN0aW9uIGJ1aWxkIGFsd2F5 cyB1c2VzIHRoZSBtYWpvciB2ZXJzaW9uIHdpdGggYSBzeXN0ZW0gdmVyc2lvbiBwcmVmaXgKK1NI T1JUX1ZFUlNJT05fU1RSSU5HX1Byb2R1Y3Rpb24gPSAkKFNZU1RFTV9WRVJTSU9OX1BSRUZJWCkk KE1BSk9SX1ZFUlNJT04pOworU0hPUlRfVkVSU0lPTl9TVFJJTkdfID0gJChTSE9SVF9WRVJTSU9O X1NUUklOR19Qcm9kdWN0aW9uKTsKKworLy8gTG9jYWwgYnVpbGRzIGFyZSB0aGUgZnVsbCB2ZXJz aW9uIHdpdGggYSBwbHVzIHN1ZmZpeC4KK0JVTkRMRV9WRVJTSU9OX1JlbGVhc2UgPSAkKEZVTExf VkVSU0lPTikrOworQlVORExFX1ZFUlNJT05fRGVidWcgPSAkKEJVTkRMRV9WRVJTSU9OX1JlbGVh c2UpOworCisvLyBMb2NhbCBidWlsZHMgdXNlIHRoZSBtYWpvciB2ZXJzaW9uIHdpdGggYSBwbHVz IHN1ZmZpeAorU0hPUlRfVkVSU0lPTl9TVFJJTkdfUmVsZWFzZSA9ICQoTUFKT1JfVkVSU0lPTikr OworU0hPUlRfVkVSU0lPTl9TVFJJTkdfRGVidWcgPSAkKFNIT1JUX1ZFUlNJT05fU1RSSU5HX1Jl bGVhc2UpOworCitEWUxJQl9DT01QQVRJQklMSVRZX1ZFUlNJT04gPSAxOworRFlMSUJfQ1VSUkVO VF9WRVJTSU9OID0gJChGVUxMX1ZFUlNJT04pOwpJbmRleDogU291cmNlL1RoaXJkUGFydHkvbGli d2VicnRjL0NvbmZpZ3VyYXRpb25zL2xpYndlYnJ0Yy54Y2NvbmZpZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlvbnMvbGlid2VicnRjLnhjY29u ZmlnCShyZXZpc2lvbiAyMTM0MjIpCisrKyBTb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29u ZmlndXJhdGlvbnMvbGlid2VicnRjLnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs NSBAQAorI2luY2x1ZGUgIlZlcnNpb24ueGNjb25maWciCisKIFBST0RVQ1RfTkFNRSA9IGxpYndl YnJ0YzsKIAogSU5TVEFMTF9QQVRIID0gJChOT1JNQUxfV0VCQ09SRV9GUkFNRVdPUktTX0RJUikv V2ViQ29yZS5mcmFtZXdvcmsvRnJhbWV3b3JrczsK