169167 2017-03-04 00:26:51 -0800 REGRESSION: Content Blocker: Blocking "a[href*=randomString]" doesn't work 2017-03-27 04:59:37 -0700 1 1 1 Unclassified WebKit New Bugs Safari Technology Preview iPhone / iPad iOS 10 RESOLVED FIXED InRadar P2 Major --- 1 jonathan.arnold webkit-unassigned achristensen am ap simon.fraser webkit-bug-importer oldest_to_newest 1283416 0 jonathan.arnold 2017-03-04 00:26:51 -0800 With the newest xcode beta this won't work anymore: { "trigger": { "url-filter": ".*" }, "action": { "selector": "a[href*=randomString]", "type": "css-display-none" } } In older version it worked perfectly fine. 1283449 1 ap 2017-03-04 11:24:36 -0800 Just to confirm, this regressed with new SDK, and Safari version is the same? 1283450 2 webkit-bug-importer 2017-03-04 11:24:52 -0800 <rdar://problem/30852110> 1283451 3 webkit-bug-importer 2017-03-04 11:24:53 -0800 <rdar://problem/30852111> 1283457 4 jonathan.arnold 2017-03-04 12:25:29 -0800 yes, its with the new SDK. (iOS Beta 10.3) 1288509 5 am 2017-03-16 03:15:48 -0700 Moreover, selectors like `[attribute="value"]` do not work anymore. This issue is easily reproducible in iOS 10.3 Beta. Relevant discussion: https://forum.adguard.com/index.php?threads/ad-blocking-is-not-working-properly-in-ios-10-3-beta.19898/ 1288518 6 jonathan.arnold 2017-03-16 04:28:32 -0700 Dear Webkit Developers, any chance on fixing this issue soon? 1288821 7 achristensen 2017-03-16 16:15:45 -0700 I tried to reproduce this and found everything working correctly. Here are my steps for reproduction: 1) Put this into test.json on my desktop: [{"trigger":{"url-filter": ".*"},"action":{"selector":"a[href*=randomString]","type":"css-display-none"}}] 2) Put this into test.html on my desktop: <body><a href="http://webkit.org/randomString">This should be hidden.</a>This should not</body> 2) Compile WebKit and run Tools/Scripts/run-minibrowser 3) Open a new WebKit2 window in MiniBrowser. 4) In MiniBrowser's Debug menu, open the extensions manager. 5) Add test.json. 6) Notice that "This should be hidden." disappears. This indicates that everything seems to be working correctly. If you find a modification to my reproduction steps that shows incorrect behavior, please elaborate. 1288943 8 jonathan.arnold 2017-03-16 22:33:16 -0700 Hi Alex, thank you for looking into it. :-) Have you tried the same with the current iOS beta? This where the issue came up. Maybe it is only iOS that is effected of this. In the new iOS beta its not working for me :-( 1290873 9 305300 achristensen 2017-03-24 11:11:43 -0700 Created attachment 305300 patch 1290877 10 achristensen 2017-03-24 11:18:11 -0700 http://trac.webkit.org/r214358 1291448 11 jonathan.arnold 2017-03-27 04:59:37 -0700 Thank you Alex! Will this fix be included in the next beta? 305300 2017-03-24 11:11:43 -0700 2017-03-24 11:14:35 -0700 patch patch text/plain 4751 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNDMwOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE3LTAzLTI0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lP TjogQ29udGVudCBCbG9ja2VyOiBCbG9ja2luZyAiYVtocmVmKj1yYW5kb21TdHJpbmddIiBkb2Vz bid0IHdvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2OTE2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdoZW4gdGVzdGluZyBjb250ZW50IGV4dGVuc2lvbnMsIHdlIGhhdmUgYWx3YXlzIGNhbGxlZCBh biBBUEkgZnVuY3Rpb24gdGhhdCBpbnRlcm5hbGx5CisgICAgICAgIGhhcyBjYWxsZWQgQXRvbWlj U3RyaW5nOjppbml0IHNvbWV3aGVyZSBiZWZvcmUgd2Ugc3RhcnQgY29tcGlsaW5nIHRoZSBjb250 ZW50IGV4dGVuc2lvbi4KKyAgICAgICAgT24gaU9TLCB0aG91Z2gsIHdlIGNhbGwgW19XS1VzZXJD b250ZW50RXh0ZW5zaW9uU3RvcmUgY29tcGlsZUNvbnRlbnRFeHRlbnNpb25Gb3JJZGVudGlmaWVy Oi4uLl0KKyAgICAgICAgd2l0aG91dCBoYXZpbmcgYWxyZWFkeSBjYWxsZWQgYW55dGhpbmcgdGhh dCBjYWxscyBBdG9taWNTdHJpbmc6OmluaXQuICBUaGUgbmV3IENTUyBwYXJzZXIgaXMgbm93Cisg ICAgICAgIGZhaWxpbmcgdG8gcGFyc2Ugc29tZSBzZWxlY3RvcnMgYmVjYXVzZSBDU1NTZWxlY3Rv clBhcnNlcjo6ZGVmYXVsdE5hbWVzcGFjZSBpcyByZXR1cm5pbmcgc3RhckF0b20sCisgICAgICAg IHdoaWNoIGlzIGEgbnVsbCBhdG9taWMgc3RyaW5nIGJlZm9yZSBBdG9taWNTdHJpbmc6OmluaXQg aXMgY2FsbGVkLgorCisgICAgICAgIENvdmVyZWQgYnkgYSBuZXcgQVBJIHRlc3QuCisKKyAgICAg ICAgKiBjb250ZW50ZXh0ZW5zaW9ucy9Db250ZW50RXh0ZW5zaW9uUGFyc2VyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNvbnRlbnRFeHRlbnNpb25zOjppc1ZhbGlkQ1NTU2VsZWN0b3IpOgorICAg ICAgICAoV2ViQ29yZTo6Q29udGVudEV4dGVuc2lvbnM6OmxvYWRBY3Rpb24pOgorICAgICAgICAo V2ViQ29yZTo6Q29udGVudEV4dGVuc2lvbnM6OmlzVmFsaWRTZWxlY3Rvcik6IERlbGV0ZWQuCisg ICAgICAgICogY29udGVudGV4dGVuc2lvbnMvQ29udGVudEV4dGVuc2lvblBhcnNlci5oOgorICAg ICAgICBDYWxsIEF0b21pY1N0cmluZzo6aW5pdCBiZWZvcmUgY2hlY2tpbmcgaWYgYSBjc3Mgc2Vs ZWN0b3IgaXMgdmFsaWQuCisKIDIwMTctMDMtMjIgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUu Y29tPgogCiAgICAgICAgIE5ldmVyRGVzdHJveWVkPE1lZGlhUXVlcnlFdmFsdWF0b3I+IG11c3Qg ZXhwbGljaXRseSBjb25zdHJ1Y3Qgd2l0aCBhIFN0cmluZwpJbmRleDogU291cmNlL1dlYkNvcmUv Y29udGVudGV4dGVuc2lvbnMvQ29udGVudEV4dGVuc2lvblBhcnNlci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvY29udGVudGV4dGVuc2lvbnMvQ29udGVudEV4dGVuc2lvblBhcnNl ci5jcHAJKHJldmlzaW9uIDIxNDMwOCkKKysrIFNvdXJjZS9XZWJDb3JlL2NvbnRlbnRleHRlbnNp b25zL0NvbnRlbnRFeHRlbnNpb25QYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzEsOCAr MjMxLDkgQEAKICAgICByZXR1cm4gV1RGTW92ZSh0cmlnZ2VyKTsKIH0KIAotc3RhdGljIGJvb2wg aXNWYWxpZFNlbGVjdG9yKGNvbnN0IFN0cmluZyYgc2VsZWN0b3IpCitib29sIGlzVmFsaWRDU1NT ZWxlY3Rvcihjb25zdCBTdHJpbmcmIHNlbGVjdG9yKQogeworICAgIEF0b21pY1N0cmluZzo6aW5p dCgpOwogICAgIENTU1BhcnNlckNvbnRleHQgY29udGV4dChIVE1MUXVpcmtzTW9kZSk7CiAgICAg Q1NTUGFyc2VyIHBhcnNlcihjb250ZXh0KTsKICAgICBDU1NTZWxlY3Rvckxpc3Qgc2VsZWN0b3JM aXN0OwpAQCAtMjY3LDcgKzI2OCw3IEBACiAgICAgICAgICAgICByZXR1cm4gbWFrZVVuZXhwZWN0 ZWQoQ29udGVudEV4dGVuc2lvbkVycm9yOjpKU09OSW52YWxpZENTU0Rpc3BsYXlOb25lQWN0aW9u VHlwZSk7CiAKICAgICAgICAgU3RyaW5nIHNlbGVjdG9yU3RyaW5nID0gYXNTdHJpbmcoc2VsZWN0 b3IpLT52YWx1ZSgmZXhlYyk7Ci0gICAgICAgIGlmICghaXNWYWxpZFNlbGVjdG9yKHNlbGVjdG9y U3RyaW5nKSkgeworICAgICAgICBpZiAoIWlzVmFsaWRDU1NTZWxlY3RvcihzZWxlY3RvclN0cmlu ZykpIHsKICAgICAgICAgICAgIC8vIFNraXAgcnVsZXMgd2l0aCBpbnZhbGlkIHNlbGVjdG9ycyB0 byBiZSBiYWNrd2FyZHMtY29tcGF0aWJsZS4KICAgICAgICAgICAgIHJldHVybiB7c3RkOjpudWxs b3B0fTsKICAgICAgICAgfQpJbmRleDogU291cmNlL1dlYkNvcmUvY29udGVudGV4dGVuc2lvbnMv Q29udGVudEV4dGVuc2lvblBhcnNlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nv bnRlbnRleHRlbnNpb25zL0NvbnRlbnRFeHRlbnNpb25QYXJzZXIuaAkocmV2aXNpb24gMjE0MzA4 KQorKysgU291cmNlL1dlYkNvcmUvY29udGVudGV4dGVuc2lvbnMvQ29udGVudEV4dGVuc2lvblBh cnNlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw2ICszOSw3IEBACiBjbGFzcyBDb250ZW50RXh0 ZW5zaW9uUnVsZTsKIAogRXhwZWN0ZWQ8VmVjdG9yPENvbnRlbnRFeHRlbnNpb25SdWxlPiwgc3Rk OjplcnJvcl9jb2RlPiBwYXJzZVJ1bGVMaXN0KFN0cmluZyYmKTsKK1dFQkNPUkVfRVhQT1JUIGJv b2wgaXNWYWxpZENTU1NlbGVjdG9yKGNvbnN0IFN0cmluZyYpOwogCiB9IC8vIG5hbWVzcGFjZSBD b250ZW50RXh0ZW5zaW9ucwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogVG9vbHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMjE0MzU2KQor KysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTct MDMtMjQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAg ICAgICBSRUdSRVNTSU9OOiBDb250ZW50IEJsb2NrZXI6IEJsb2NraW5nICJhW2hyZWYqPXJhbmRv bVN0cmluZ10iIGRvZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY5MTY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvQ29udGVudEV4dGVu c2lvbnMuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVF9GKToKKyAgICAgICAgVGVz dCBhbiBleGFtcGxlIG9mIGEgc2VsZWN0b3IgdGhhdCB3YXMgaW5jb3JyZWN0bHkgZGV0ZXJtaW5l ZCB0byBiZSBpbnZhbGlkLgorCiAyMDE3LTAzLTI0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJk QGFwcGxlLmNvbT4KIAogICAgICAgICBJbmNyZWFzZSB0aW1lb3V0IGZvciBib290aW5nIHNpbXVs YXRvcnMuCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvQ29udGVudEV4 dGVuc2lvbnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi Q29yZS9Db250ZW50RXh0ZW5zaW9ucy5jcHAJKHJldmlzaW9uIDIxNDMwOCkKKysrIFRvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9Db250ZW50RXh0ZW5zaW9ucy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlIDxXZWJDb3JlL0NvbWJpbmVkVVJMRmls dGVycy5oPgogI2luY2x1ZGUgPFdlYkNvcmUvQ29udGVudEV4dGVuc2lvbkNvbXBpbGVyLmg+CiAj aW5jbHVkZSA8V2ViQ29yZS9Db250ZW50RXh0ZW5zaW9uRXJyb3IuaD4KKyNpbmNsdWRlIDxXZWJD b3JlL0NvbnRlbnRFeHRlbnNpb25QYXJzZXIuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0NvbnRlbnRF eHRlbnNpb25zQmFja2VuZC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvREZBLmg+CiAjaW5jbHVkZSA8 V2ViQ29yZS9ERkFCeXRlY29kZUNvbXBpbGVyLmg+CkBAIC0yODcwLDQgKzI4NzEsOSBAQAogICAg IHRlc3RSZXF1ZXN0KHNlYXJjaEJhY2tlbmQsIG1haW5Eb2N1bWVudFJlcXVlc3QoInp6ejovL3d3 dy5kZGpqeXl5Lnh4eC8iKSwgeyBDb250ZW50RXh0ZW5zaW9uczo6QWN0aW9uVHlwZTo6Q1NTRGlz cGxheU5vbmVTZWxlY3RvciB9KTsKIH0KIAorVEVTVF9GKENvbnRlbnRFeHRlbnNpb25UZXN0LCBW YWxpZFNlbGVjdG9yKQoreworICAgIEVYUEVDVF9UUlVFKFdlYkNvcmU6OkNvbnRlbnRFeHRlbnNp b25zOjppc1ZhbGlkQ1NTU2VsZWN0b3IoImFbaHJlZio9aHN2XSIpKTsKK30KKwogfSAvLyBuYW1l c3BhY2UgVGVzdFdlYktpdEFQSQo=