169148 2017-03-03 14:06:27 -0800 [MediaStream iOS] REGRESSION(r212883): Missing function definition breaks sandbox 2017-03-03 16:33:41 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 168756 1 bfulgham bfulgham ap bfulgham eric.carlson jonlee youennf oldest_to_newest 1283246 0 bfulgham 2017-03-03 14:06:27 -0800 The changes in <https://trac.webkit.org/changeset/212883> add a new call to 'shared-preferences-read'. Unfortunately, 'shared-preferences-read' is a custom function defined in com.apple.WebKit.WebContent.sb.in, but not the iOS-specific com.apple.WebKit.WebContent.sb file. This causes the sandbox to fail to parse. 1283250 1 bfulgham 2017-03-03 14:12:09 -0800 <rdar://problem/30825728> 1283252 2 303341 bfulgham 2017-03-03 14:14:17 -0800 Created attachment 303341 Patch 1283270 3 303341 ap 2017-03-03 14:52:06 -0800 Comment on attachment 303341 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303341&action=review > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:116 > + (literal (string-append "/Library/Preferences/" domain ".plist")) Is this where preferences live on iOS? Perhaps we don't need this fallback path at all, and just rely on user-preference-read. It may be best to just use user-preference-read instead of defining a function. > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:117 > + (home-library-preferences-literal (string-append "/" domain ".plist")) Wouldn't we need to define this function too? 1283289 4 303352 bfulgham 2017-03-03 16:15:19 -0800 Created attachment 303352 Patch 1283290 5 303353 bfulgham 2017-03-03 16:15:50 -0800 Created attachment 303353 Patch 1283295 6 bfulgham 2017-03-03 16:33:41 -0800 Committed r213394: <http://trac.webkit.org/changeset/213394> 303341 2017-03-03 14:14:17 -0800 2017-03-03 16:15:16 -0800 Patch bug-169148-20170303141417.patch text/plain 2311 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzM4NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAzLTAzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVhbSBpT1Nd IFJFR1JFU1NJT04ocjIxMjg4Myk6IE1pc3NpbmcgZnVuY3Rpb24gZGVmaW5pdGlvbiBicmVha3Mg c2FuZGJveAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY5MTQ4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDgyNTcyOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY2hhbmdlcyBpbiByMjEyODgz IGFkZGVkIGEgY2FsbCB0byAnc2hhcmVkLXByZWZlcmVuY2VzLXJlYWQnLCB3aGljaCBpcyBub3Qg ZGVmaW5lZAorICAgICAgICBmb3IgaU9TLiBXZSBuZWVkIHRvIGNvcHkgdGhlIGZ1bmN0aW9uIGRl ZmluaXRpb24gZnJvbSB0aGUgbWFjT1Mgc2FuZGJveCBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRl bnQuc2IuaW4KKyAgICAgICAgdG8gdGhlIGlPUy1zcGVjaWZpYyB2ZXJzaW9uIChpb3MvY29tLmFw cGxlLldlYktpdC5XZWJDb250ZW50LnNiKS4KKworICAgICAgICAqIFJlc291cmNlcy9TYW5kYm94 UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYjogQWRkIG1pc3Npbmcg ZnVuY3Rpb24KKwogMjAxNy0wMy0wMyAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5j b20+CiAKICAgICAgICAgTW92ZSBkZWNsYXJhdGlvbiBvZiBfV0tTZXRDcmFzaFJlcG9ydEFwcGxp Y2F0aW9uU3BlY2lmaWNJbmZvcm1hdGlvbiB0byBoZWFkZXIgZmlsZQpJbmRleDogU291cmNlL1dl YktpdDIvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJD b250ZW50LnNiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9TYW5kYm94 UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgkocmV2aXNpb24gMjEz MjAwKQorKysgU291cmNlL1dlYktpdDIvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29t LmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCSh3b3JraW5nIGNvcHkpCkBAIC0xMDYsNiArMTA2 LDE4IEBACiAod2l0aC1maWx0ZXIgKGV4dGVuc2lvbiAiY29tLmFwcGxlLndlYmtpdC5taWNyb3Bo b25lIikKICAgICAoYWxsb3cgZGV2aWNlLW1pY3JvcGhvbmUpKQogCisoZGVmaW5lIChzaGFyZWQt cHJlZmVyZW5jZXMtcmVhZCAuIGRvbWFpbnMpCisgICAgKGZvci1lYWNoIChsYW1iZGEgKGRvbWFp bikKKyAgICAgICAgICAgICAgICAoYmVnaW4KKyAgICAgICAgICAgICAgICAgICAgKGlmIChkZWZp bmVkPyBgdXNlci1wcmVmZXJlbmNlLXJlYWQpCisgICAgICAgICAgICAgICAgICAgICAgICAoYWxs b3cgdXNlci1wcmVmZXJlbmNlLXJlYWQgKHByZWZlcmVuY2UtZG9tYWluIGRvbWFpbikpKQorICAg ICAgICAgICAgICAgICAgICA7IChUZW1wb3JhcnkpIGJhY2t3YXJkIGNvbXBhdGliaWxpdHkgd2l0 aCBub24tQ0ZQcmVmZXJlbmNlcyByZWFkZXJzLgorICAgICAgICAgICAgICAgICAgICAoYWxsb3cg ZmlsZS1yZWFkKgorICAgICAgICAgICAgICAgICAgICAgICAgKGxpdGVyYWwgKHN0cmluZy1hcHBl bmQgIi9MaWJyYXJ5L1ByZWZlcmVuY2VzLyIgZG9tYWluICIucGxpc3QiKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgIChob21lLWxpYnJhcnktcHJlZmVyZW5jZXMtbGl0ZXJhbCAoc3RyaW5nLWFw cGVuZCAiLyIgZG9tYWluICIucGxpc3QiKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChob21l LWxpYnJhcnktcHJlZmVyZW5jZXMtcmVnZXggKHN0cmluZy1hcHBlbmQgIyIvQnlIb3N0LyIgKHJl Z2V4LXF1b3RlIGRvbWFpbikgIyJcLi4qXC5wbGlzdCQiKSkpKSkKKyAgICAgICAgICAgIGRvbWFp bnMpKQorCiA7OyBNZWRpYSBjYXB0dXJlLCBjYW1lcmEgYWNjZXNzCiAod2l0aC1maWx0ZXIgKGV4 dGVuc2lvbiAiY29tLmFwcGxlLndlYmtpdC5jYW1lcmEiKQogICAgIChzaGFyZWQtcHJlZmVyZW5j ZXMtcmVhZCAiY29tLmFwcGxlLmNvcmVtZWRpYSIpCg== 303352 2017-03-03 16:15:19 -0800 2017-03-03 16:15:47 -0800 Patch bug-169148-20170303161519.patch text/plain 1721 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzM5MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAzLTAzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVhbSBpT1Nd IFJFR1JFU1NJT04ocjIxMjg4Myk6IE1pc3NpbmcgZnVuY3Rpb24gZGVmaW5pdGlvbiBicmVha3Mg c2FuZGJveAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY5MTQ4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDgyNTcyOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY2hhbmdlcyBpbiByMjEyODgz IGFkZGVkIGEgY2FsbCB0byAnc2hhcmVkLXByZWZlcmVuY2VzLXJlYWQnLCB3aGljaCBpcyBub3Qg ZGVmaW5lZAorICAgICAgICBmb3IgaU9TLiBJbiBmYWN0LCBpdCdzIG5vdCBuZWVkZWQgc2luY2Ug J3VzZXItcHJlZmVyZW5jZS1yZWFkJyBkb2VzIGV2ZXJ5dGhpbmcgd2UgbmVlZCBvbiBpT1MuCisg ICAgICAgIFN3aXRjaCB0byB0aGUgY29ycmVjdCBwcmVmZXJlbmNlIHJ1bGUuCisKKyAgICAgICAg KiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRl bnQuc2I6IEFkZCBtaXNzaW5nIGZ1bmN0aW9uCisKIDIwMTctMDMtMDMgIEFha2FzaCBKYWluICA8 YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgZGVjbGFyYXRpb24gb2YgX1dL U2V0Q3Jhc2hSZXBvcnRBcHBsaWNhdGlvblNwZWNpZmljSW5mb3JtYXRpb24gdG8gaGVhZGVyIGZp bGUKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2Nv bS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRl bnQuc2IJKHJldmlzaW9uIDIxMzM5MykKKysrIFNvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9TYW5k Ym94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgkod29ya2luZyBj b3B5KQpAQCAtMTA4LDcgKzEwOCw4IEBACiAKIDs7IE1lZGlhIGNhcHR1cmUsIGNhbWVyYSBhY2Nl c3MKICh3aXRoLWZpbHRlciAoZXh0ZW5zaW9uICJjb20uYXBwbGUud2Via2l0LmNhbWVyYSIpCi0g ICAgKHNoYXJlZC1wcmVmZXJlbmNlcy1yZWFkICJjb20uYXBwbGUuY29yZW1lZGlhIikKKyAgICAo YWxsb3cgdXNlci1wcmVmZXJlbmNlLXJlYWQKKyAgICAgICAgKHByZWZlcmVuY2UtZG9tYWluICJj b20uYXBwbGUuY29yZW1lZGlhIikpCiAgICAgKGFsbG93IGZpbGUtcmVhZCogKHN1YnBhdGggIi9M aWJyYXJ5L0NvcmVNZWRpYUlPL1BsdWctSW5zL0RBTCIpKQogICAgIChhbGxvdyBtYWNoLWxvb2t1 cCAoZXh0ZW5zaW9uICJjb20uYXBwbGUuYXBwLXNhbmRib3gubWFjaCIpKQogICAgIChhbGxvdyBt YWNoLWxvb2t1cAo= 303353 2017-03-03 16:15:50 -0800 2017-03-03 16:27:17 -0800 Patch bug-169148-20170303161549.patch text/plain 1721 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzM5MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAzLTAzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVhbSBpT1Nd IFJFR1JFU1NJT04ocjIxMjg4Myk6IE1pc3NpbmcgZnVuY3Rpb24gZGVmaW5pdGlvbiBicmVha3Mg c2FuZGJveAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY5MTQ4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDgyNTcyOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY2hhbmdlcyBpbiByMjEyODgz IGFkZGVkIGEgY2FsbCB0byAnc2hhcmVkLXByZWZlcmVuY2VzLXJlYWQnLCB3aGljaCBpcyBub3Qg ZGVmaW5lZAorICAgICAgICBmb3IgaU9TLiBJbiBmYWN0LCBpdCdzIG5vdCBuZWVkZWQgc2luY2Ug J3VzZXItcHJlZmVyZW5jZS1yZWFkJyBkb2VzIGV2ZXJ5dGhpbmcgd2UgbmVlZCBvbiBpT1MuCisg ICAgICAgIFN3aXRjaCB0byB0aGUgY29ycmVjdCBwcmVmZXJlbmNlIHJ1bGUuCisKKyAgICAgICAg KiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRl bnQuc2I6IEFkZCBtaXNzaW5nIGZ1bmN0aW9uCisKIDIwMTctMDMtMDMgIEFha2FzaCBKYWluICA8 YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgZGVjbGFyYXRpb24gb2YgX1dL U2V0Q3Jhc2hSZXBvcnRBcHBsaWNhdGlvblNwZWNpZmljSW5mb3JtYXRpb24gdG8gaGVhZGVyIGZp bGUKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2Nv bS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRl bnQuc2IJKHJldmlzaW9uIDIxMzM5MykKKysrIFNvdXJjZS9XZWJLaXQyL1Jlc291cmNlcy9TYW5k Ym94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgkod29ya2luZyBj b3B5KQpAQCAtMTA4LDcgKzEwOCw4IEBACiAKIDs7IE1lZGlhIGNhcHR1cmUsIGNhbWVyYSBhY2Nl c3MKICh3aXRoLWZpbHRlciAoZXh0ZW5zaW9uICJjb20uYXBwbGUud2Via2l0LmNhbWVyYSIpCi0g ICAgKHNoYXJlZC1wcmVmZXJlbmNlcy1yZWFkICJjb20uYXBwbGUuY29yZW1lZGlhIikKKyAgICAo YWxsb3cgdXNlci1wcmVmZXJlbmNlLXJlYWQKKyAgICAgICAgKHByZWZlcmVuY2UtZG9tYWluICJj b20uYXBwbGUuY29yZW1lZGlhIikpCiAgICAgKGFsbG93IGZpbGUtcmVhZCogKHN1YnBhdGggIi9M aWJyYXJ5L0NvcmVNZWRpYUlPL1BsdWctSW5zL0RBTCIpKQogICAgIChhbGxvdyBtYWNoLWxvb2t1 cCAoZXh0ZW5zaW9uICJjb20uYXBwbGUuYXBwLXNhbmRib3gubWFjaCIpKQogICAgIChhbGxvdyBt YWNoLWxvb2t1cAo=