169147 2017-03-03 14:00:02 -0800 Further optimize checkWebRTCAvailability 2017-03-27 10:48:28 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168913 InRadar P2 Normal --- 1 jonlee youennf achristensen commit-queue joepeck mitz webkit-bug-importer youennf oldest_to_newest 1283242 0 jonlee 2017-03-03 14:00:02 -0800 Further optimization on b168913 as suggested by Dan: > This check can be implemented by null-checking any of the symbols known to be exported from the dylib, which is a single branch. An implementation that involves a function call still seems unoptimal. 1291039 1 youennf 2017-03-24 16:14:21 -0700 I'll go other it this week-end if nobody gets it before. 1291284 2 305409 youennf 2017-03-25 18:02:46 -0700 Created attachment 305409 Patch 1291285 3 youennf 2017-03-25 18:04:14 -0700 Might be related to radar://31242422 1291307 4 305415 youennf 2017-03-25 23:30:28 -0700 Created attachment 305415 Moving the routine within LIBWEBRTC flag 1291344 5 webkit-bug-importer 2017-03-26 11:15:46 -0700 <rdar://problem/31263660> 1291519 6 305415 commit-queue 2017-03-27 10:48:25 -0700 Comment on attachment 305415 Moving the routine within LIBWEBRTC flag Clearing flags on attachment: 305415 Committed r214418: <http://trac.webkit.org/changeset/214418> 1291520 7 commit-queue 2017-03-27 10:48:28 -0700 All reviewed patches have been landed. Closing bug. 305409 2017-03-25 18:02:46 -0700 2017-03-25 23:30:23 -0700 Patch bug-169147-20170325180245.patch text/plain 2279 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTcxOTY2OGVjY2IxMWM3 ZGMzYjkwNGIzN2VkNjU4ZmU4MmQ5Njc2MC4uNmRjMDczMzlkZjMxNGY3YWI1NWQ2MjFhNGNjZGM1 MzQwMjE5MjdjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAzLTI1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBGdXJ0aGVyIG9wdGltaXpl IGNoZWNrV2ViUlRDQXZhaWxhYmlsaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjkxNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUZXN0ZWQgbG9jYWxseSBieSByZW1vdmluZyBsaWJ3ZWJydGMuZHls aWIuCisgICAgICAgIFJlcGxhY2luZyBkbG9wZW4gY2hlY2sgYnkgY2hlY2tpbmcgYW4gZXhwb3J0 ZWQgc3ltYm9sLCBydGM6OkxvZ01lc3NhZ2U6OkxvZ1RvRGVidWcuCisgICAgICAgIFRoaXMgY2hl Y2sgaXMgbW9yZSBlZmZpY2llbnQgYW5kIGFjY3VyYXRlLiBJdCBzaG91bGQgd29yayBpbiBtb3Jl IGNvbmZpZ3VyYXRpb25zIHRoYW4gdGhlIHByZXZpb3VzIG9uZS4KKworICAgICAgICAqIHBsYXRm b3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjppc051bGxGdW5jdGlvblBvaW50ZXIpOgorICAgICAgICAoV2ViQ29yZTo6TGli V2ViUlRDUHJvdmlkZXI6OndlYlJUQ0F2YWlsYWJsZSk6CisKIDIwMTctMDMtMjQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBSVENS dHBSZWNlaXZlci9SVENSdHBTZW5kZXIgZ2V0UGFyYW1ldGVycwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJX ZWJSVENQcm92aWRlci5jcHAKaW5kZXggZjZmY2FjZjQ3YzBjODgyMmJjZDhiZGM1M2MxNTdmZjFi MDk0ZmFhYy4uZmNlYzcxYTUyMGIxMjBmYzE5ZjIyMTVhMzFiM2RiZGQyYzdmZDkwNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldl YlJUQ1Byb3ZpZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlkZXIuY3BwCkBAIC0xNzIsMTcgKzE3MiwyMiBAQCBy dGM6OnNjb3BlZF9yZWZwdHI8d2VicnRjOjpQZWVyQ29ubmVjdGlvbkludGVyZmFjZT4gTGliV2Vi UlRDUHJvdmlkZXI6OmNyZWF0ZVBlZQogfQogI2VuZGlmIC8vIFVTRShMSUJXRUJSVEMpCiAKK3N0 YXRpYyBpbmxpbmUgYm9vbCBpc051bGxGdW5jdGlvblBvaW50ZXIodm9pZCogZnVuY3Rpb25Qb2lu dGVyKQoreworICAgIHZvaWQqIHJlc3VsdDsKKyAgICBhc20oCisgICAgICAgICJtb3YgJTEsICUw IgorICAgICAgICA6ICI9ciIgKHJlc3VsdCkKKyAgICAgICAgOiAiciIgKGZ1bmN0aW9uUG9pbnRl cikKKyAgICApOworICAgIHJldHVybiAhcmVzdWx0OworfQorCiBib29sIExpYldlYlJUQ1Byb3Zp ZGVyOjp3ZWJSVENBdmFpbGFibGUoKQogewogI2lmIFVTRShMSUJXRUJSVEMpCiAgICAgc3RhdGlj IGJvb2wgYXZhaWxhYmxlID0gW10gewotICAgICAgICB2b2lkKiBsaWJ3ZWJydGNMaWJyYXJ5ID0g ZGxvcGVuKCJsaWJ3ZWJydGMuZHlsaWIiLCBSVExEX0xBWlkpOwotICAgICAgICBpZiAoIWxpYndl YnJ0Y0xpYnJhcnkpIHsKLSAgICAgICAgICAgIFJFTEVBU0VfTE9HKFdlYlJUQywgIkF0dGVtcHRl ZCB0byBsb2FkIGxpYndlYnJ0YyB3aXRob3V0IHN1Y2Nlc3M6ICVzIiwgZGxlcnJvcigpKTsKLSAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgfQotICAgICAgICBkbGNsb3NlKGxpYndl YnJ0Y0xpYnJhcnkpOwotICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgcmV0dXJuICFpc051 bGxGdW5jdGlvblBvaW50ZXIocmVpbnRlcnByZXRfY2FzdDx2b2lkKj4ocnRjOjpMb2dNZXNzYWdl OjpMb2dUb0RlYnVnKSk7CiAgICAgfSgpOwogICAgIHJldHVybiBhdmFpbGFibGU7CiAjZWxzZQo= 305415 2017-03-25 23:30:28 -0700 2017-03-27 10:48:25 -0700 Moving the routine within LIBWEBRTC flag bug-169147-20170325233028.patch text/plain 2357 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTcxOTY2OGVjY2IxMWM3 ZGMzYjkwNGIzN2VkNjU4ZmU4MmQ5Njc2MC4uNmRjMDczMzlkZjMxNGY3YWI1NWQ2MjFhNGNjZGM1 MzQwMjE5MjdjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAzLTI1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBGdXJ0aGVyIG9wdGltaXpl IGNoZWNrV2ViUlRDQXZhaWxhYmlsaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjkxNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUZXN0ZWQgbG9jYWxseSBieSByZW1vdmluZyBsaWJ3ZWJydGMuZHls aWIuCisgICAgICAgIFJlcGxhY2luZyBkbG9wZW4gY2hlY2sgYnkgY2hlY2tpbmcgYW4gZXhwb3J0 ZWQgc3ltYm9sLCBydGM6OkxvZ01lc3NhZ2U6OkxvZ1RvRGVidWcuCisgICAgICAgIFRoaXMgY2hl Y2sgaXMgbW9yZSBlZmZpY2llbnQgYW5kIGFjY3VyYXRlLiBJdCBzaG91bGQgd29yayBpbiBtb3Jl IGNvbmZpZ3VyYXRpb25zIHRoYW4gdGhlIHByZXZpb3VzIG9uZS4KKworICAgICAgICAqIHBsYXRm b3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjppc051bGxGdW5jdGlvblBvaW50ZXIpOgorICAgICAgICAoV2ViQ29yZTo6TGli V2ViUlRDUHJvdmlkZXI6OndlYlJUQ0F2YWlsYWJsZSk6CisKIDIwMTctMDMtMjQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBSVENS dHBSZWNlaXZlci9SVENSdHBTZW5kZXIgZ2V0UGFyYW1ldGVycwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJX ZWJSVENQcm92aWRlci5jcHAKaW5kZXggZjZmY2FjZjQ3YzBjODgyMmJjZDhiZGM1M2MxNTdmZjFi MDk0ZmFhYy4uZTYyNjJlYzJiODBmOGJkYzQ4NWU3MWNiYzM1YzY4YjUwYTZlYmY2MiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldl YlJUQ1Byb3ZpZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlkZXIuY3BwCkBAIC0xNzAsMTkgKzE3MCwyNSBAQCBy dGM6OnNjb3BlZF9yZWZwdHI8d2VicnRjOjpQZWVyQ29ubmVjdGlvbkludGVyZmFjZT4gTGliV2Vi UlRDUHJvdmlkZXI6OmNyZWF0ZVBlZQogCiAgICAgcmV0dXJuIGNyZWF0ZUFjdHVhbFBlZXJDb25u ZWN0aW9uKG9ic2VydmVyLCBXVEZNb3ZlKHBvcnRBbGxvY2F0b3IpKTsKIH0KKworc3RhdGljIGlu bGluZSBib29sIGlzTnVsbEZ1bmN0aW9uUG9pbnRlcih2b2lkKiBmdW5jdGlvblBvaW50ZXIpCit7 CisgICAgdm9pZCogcmVzdWx0OworICAgIGFzbSgKKyAgICAgICAgIm1vdiAlMSwgJTAiCisgICAg ICAgIDogIj1yIiAocmVzdWx0KQorICAgICAgICA6ICJyIiAoZnVuY3Rpb25Qb2ludGVyKQorICAg ICk7CisgICAgcmV0dXJuICFyZXN1bHQ7Cit9CisKICNlbmRpZiAvLyBVU0UoTElCV0VCUlRDKQog CiBib29sIExpYldlYlJUQ1Byb3ZpZGVyOjp3ZWJSVENBdmFpbGFibGUoKQogewogI2lmIFVTRShM SUJXRUJSVEMpCiAgICAgc3RhdGljIGJvb2wgYXZhaWxhYmxlID0gW10gewotICAgICAgICB2b2lk KiBsaWJ3ZWJydGNMaWJyYXJ5ID0gZGxvcGVuKCJsaWJ3ZWJydGMuZHlsaWIiLCBSVExEX0xBWlkp OwotICAgICAgICBpZiAoIWxpYndlYnJ0Y0xpYnJhcnkpIHsKLSAgICAgICAgICAgIFJFTEVBU0Vf TE9HKFdlYlJUQywgIkF0dGVtcHRlZCB0byBsb2FkIGxpYndlYnJ0YyB3aXRob3V0IHN1Y2Nlc3M6 ICVzIiwgZGxlcnJvcigpKTsKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgfQot ICAgICAgICBkbGNsb3NlKGxpYndlYnJ0Y0xpYnJhcnkpOwotICAgICAgICByZXR1cm4gdHJ1ZTsK KyAgICAgICAgcmV0dXJuICFpc051bGxGdW5jdGlvblBvaW50ZXIocmVpbnRlcnByZXRfY2FzdDx2 b2lkKj4ocnRjOjpMb2dNZXNzYWdlOjpMb2dUb0RlYnVnKSk7CiAgICAgfSgpOwogICAgIHJldHVy biBhdmFpbGFibGU7CiAjZWxzZQo=