<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>169146</bug_id>
          
          <creation_ts>2017-03-03 13:53:15 -0800</creation_ts>
          <short_desc>Replace -sub_umbrella linker flag with a build setting</short_desc>
          <delta_ts>2017-03-06 17:39:37 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>Safari 9</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Proskuryakov">ap</reporter>
          <assigned_to name="Alexey Proskuryakov">ap</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>commit-queue</cc>
    
    <cc>juergen</cc>
    
    <cc>mitz</cc>
    
    <cc>thorton</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1283240</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-03-03 13:53:15 -0800</bug_when>
    <thetext>Using a build setting make is possible for other tools in the chain to share the configuration.

cf. rdar://problem/30820233</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1283241</commentid>
    <comment_count>1</comment_count>
      <attachid>303338</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-03-03 13:54:27 -0800</bug_when>
    <thetext>Created attachment 303338
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1284087</commentid>
    <comment_count>2</comment_count>
      <attachid>303338</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-06 17:39:34 -0800</bug_when>
    <thetext>Comment on attachment 303338
proposed patch

Clearing flags on attachment: 303338

Committed r213481: &lt;http://trac.webkit.org/changeset/213481&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1284088</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-06 17:39:37 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>303338</attachid>
            <date>2017-03-03 13:54:27 -0800</date>
            <delta_ts>2017-03-06 17:39:34 -0800</delta_ts>
            <desc>proposed patch</desc>
            <filename>sub_umbrella.txt</filename>
            <type>text/plain</type>
            <size>2161</size>
            <attacher name="Alexey Proskuryakov">ap</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzM4NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAzLTAzICBBbGV4ZXkg
UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlcGxhY2UgLXN1Yl91bWJy
ZWxsYSBsaW5rZXIgZmxhZyB3aXRoIGEgYnVpbGQgc2V0dGluZworICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5MTQ2CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9XZWJLaXQueGNj
b25maWc6CisKIDIwMTctMDMtMDMgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29t
PgogCiAgICAgICAgIE1vdmUgZGVjbGFyYXRpb24gb2YgX1dLU2V0Q3Jhc2hSZXBvcnRBcHBsaWNh
dGlvblNwZWNpZmljSW5mb3JtYXRpb24gdG8gaGVhZGVyIGZpbGUKSW5kZXg6IFNvdXJjZS9XZWJL
aXQyL0NvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0Mi9Db25maWd1cmF0aW9ucy9XZWJLaXQueGNjb25maWcJKHJldmlzaW9uIDIxMzMyNCkK
KysrIFNvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZwkod29ya2lu
ZyBjb3B5KQpAQCAtNTUsMTEgKzU1LDE0IEBAIExJQldFQlJUQ19MSUJSQVJZX0RJUltzZGs9bWFj
b3N4Kl0gPSAkKEwKIExJQldFQlJUQ19MSUJSQVJZX0RJUl9VU0VfT1ZFUlJJREVfRlJBTUVXT1JL
U19ESVJfTk8gPSAkKFdFQkNPUkVfRlJBTUVXT1JLU19ESVIpL1dlYkNvcmUuZnJhbWV3b3JrL1Zl
cnNpb25zL0EvRnJhbWV3b3JrczsKIExJQldFQlJUQ19MSUJSQVJZX0RJUl9VU0VfT1ZFUlJJREVf
RlJBTUVXT1JLU19ESVJfWUVTID0gJChXS19PVkVSUklERV9GUkFNRVdPUktTX0RJUik7CiAKLU9U
SEVSX0xERkxBR1MgPSAkKGluaGVyaXRlZCkgJChVTkVYUE9SVEVEX1NZTUJPTF9MREZMQUdTKSAk
KEFTQU5fT1RIRVJfTERGTEFHUykgJChGUkFNRVdPUktfQU5EX0xJQlJBUllfTERGTEFHUykgJChP
VEhFUl9MREZMQUdTX1BMQVRGT1JNKSAtZnJhbWV3b3JrIFdlYktpdExlZ2FjeSAtc3ViX3VtYnJl
bGxhIFdlYktpdExlZ2FjeTsKLU9USEVSX0xERkxBR1NfUExBVEZPUk1bc2RrPW1hY29zeCpdID0g
LXN1Yl91bWJyZWxsYSBXZWJDb3JlICQoTElCV0VCUlRDX0xERkxBR1MpOworT1RIRVJfTERGTEFH
UyA9ICQoaW5oZXJpdGVkKSAkKFVORVhQT1JURURfU1lNQk9MX0xERkxBR1MpICQoQVNBTl9PVEhF
Ul9MREZMQUdTKSAkKEZSQU1FV09SS19BTkRfTElCUkFSWV9MREZMQUdTKSAkKE9USEVSX0xERkxB
R1NfUExBVEZPUk0pIC1mcmFtZXdvcmsgV2ViS2l0TGVnYWN5OworT1RIRVJfTERGTEFHU19QTEFU
Rk9STVtzZGs9bWFjb3N4Kl0gPSAkKExJQldFQlJUQ19MREZMQUdTKTsKIE9USEVSX0xERkxBR1Nf
UExBVEZPUk1bc2RrPWlwaG9uZW9zKl0gPSAtbEFjY2Vzc2liaWxpdHkgJChMSUJXRUJSVENfTERG
TEFHUyk7CiBPVEhFUl9MREZMQUdTX1BMQVRGT1JNW3Nkaz1pcGhvbmVzaW11bGF0b3IqXSA9IC1s
QWNjZXNzaWJpbGl0eSAkKExJQldFQlJUQ19MREZMQUdTKTsKIAorUkVFWFBPUlRFRF9GUkFNRVdP
UktfTkFNRVMgPSBXZWJLaXRMZWdhY3k7CitSRUVYUE9SVEVEX0ZSQU1FV09SS19OQU1FU1tzZGs9
bWFjb3N4Kl0gPSAkKGluaGVyaXRlZCkgV2ViQ29yZTsKKwogU0VDVE9SREVSX0ZMQUdTID0gJChT
RUNUT1JERVJfRkxBR1NfJChDT05GSUdVUkFUSU9OKSk7CiBTRUNUT1JERVJfRkxBR1NfUHJvZHVj
dGlvbltzZGs9aXBob25lb3MqXSA9IC1XbCwtb3JkZXJfZmlsZSwkKFNES1JPT1QpL0FwcGxlSW50
ZXJuYWwvT3JkZXJGaWxlcy9XZWJLaXQub3JkZXI7CiBTRUNUT1JERVJfRkxBR1NfUHJvZHVjdGlv
bltzZGs9bWFjb3N4Kl0gPSAtV2wsLW9yZGVyX2ZpbGUsbWFjL1dlYktpdDIub3JkZXI7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>