169126 2017-03-03 02:57:23 -0800 [GTK] Two file reset tests are failing in the bots since they were added in r213042 2017-03-05 03:10:19 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned aestes bugs-noreply commit-queue lforschler thorton oldest_to_newest 1283125 0 cgarcia 2017-03-03 02:57:23 -0800 They are failing because the GTK+ event sender is not firing the second UIHelper.activateAt() after the change event. In onse case this causes that the reset button is not locked, and in the other one the file input is not unfocused. https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r213357%20(21247)/fast/forms/file/file-input-reset-using-open-panel-diffs.html https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r213357%20(21247)/fast/forms/file/file-reset-in-change-using-open-panel-diffs.html This is because the change event is emitted before the mouse up, and the GTK+ event sender ignores mouse down events when the button is already down to not confuse Xvfb. So, we can easily fix theses tests by using a timeout to ensure the next UIHelper.activateAt() happens in a different run loop iteration, after the mouse up. 1283126 1 303309 cgarcia 2017-03-03 02:59:51 -0800 Created attachment 303309 Patch 1283572 2 303309 commit-queue 2017-03-05 03:10:13 -0800 Comment on attachment 303309 Patch Clearing flags on attachment: 303309 Committed r213434: <http://trac.webkit.org/changeset/213434> 1283573 3 commit-queue 2017-03-05 03:10:19 -0800 All reviewed patches have been landed. Closing bug. 303309 2017-03-03 02:59:51 -0800 2017-03-05 03:10:13 -0800 Patch lt-mouse-down.diff text/plain 3836 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiOTlmMzIxZjg1OS4uYTc2OTBlYjBlZjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMiBAQAog MjAxNy0wMy0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK KyAgICAgICAgW0dUS10gVHdvIGZpbGUgcmVzZXQgdGVzdHMgYXJlIGZhaWxpbmcgaW4gdGhlIGJv dHMgc2luY2UgdGhleSB3ZXJlIGFkZGVkIGluIHIyMTMwNDIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTEyNgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXkgYXJlIGZhaWxpbmcgYmVjYXVzZSB0aGUg R1RLKyBldmVudCBzZW5kZXIgaXMgbm90IGZpcmluZyB0aGUgc2Vjb25kIFVJSGVscGVyLmFjdGl2 YXRlQXQoKSBhZnRlciB0aGUgY2hhbmdlCisgICAgICAgIGV2ZW50LiBJbiBvbmUgY2FzZSB0aGlz IGNhdXNlcyB0aGF0IHRoZSByZXNldCBidXR0b24gaXMgbm90IGNsaWNrZWQsIGFuZCBpbiB0aGUg b3RoZXIgb25lIHRoZSBmaWxlIGlucHV0IGlzIG5vdAorICAgICAgICB1bmZvY3VzZWQuIFRoaXMg aXMgYmVjYXVzZSB0aGUgY2hhbmdlIGV2ZW50IGlzIGVtaXR0ZWQgYmVmb3JlIHRoZSBtb3VzZSB1 cCwgYW5kIHRoZSBHVEsrIGV2ZW50IHNlbmRlciBpZ25vcmVzCisgICAgICAgIG1vdXNlIGRvd24g ZXZlbnRzIHdoZW4gdGhlIGJ1dHRvbiBpcyBhbHJlYWR5IGRvd24gdG8gbm90IGNvbmZ1c2UgWHZm Yi4gU28sIHdlIGNhbiBlYXNpbHkgZml4IHRoZXNlcyB0ZXN0cyBieQorICAgICAgICB1c2luZyBh IHRpbWVvdXQgdG8gZW5zdXJlIHRoZSBuZXh0IFVJSGVscGVyLmFjdGl2YXRlQXQoKSBoYXBwZW5z IGluIGEgZGlmZmVyZW50IHJ1biBsb29wIGl0ZXJhdGlvbiwgYWZ0ZXIgdGhlCisgICAgICAgIG1v dXNlIHVwLgorCisgICAgICAgICogZmFzdC9mb3Jtcy9maWxlL2ZpbGUtaW5wdXQtcmVzZXQtdXNp bmctb3Blbi1wYW5lbC5odG1sOgorICAgICAgICAqIGZhc3QvZm9ybXMvZmlsZS9maWxlLXJlc2V0 LWluLWNoYW5nZS11c2luZy1vcGVuLXBhbmVsLmh0bWw6CisKKzIwMTctMDMtMDMgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQg R1RLKyBnYXJkZW5pbmcuIEFub3RoZXIgcmVmdGVzdCBmYWlsaW5nIHdpdGggMiBwaXhlbHMgaW4g aW1hZ2UgZGlmZi4KIAogICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWxlL2ZpbGUtaW5wdXQtcmVzZXQt dXNpbmctb3Blbi1wYW5lbC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWxlL2ZpbGUt aW5wdXQtcmVzZXQtdXNpbmctb3Blbi1wYW5lbC5odG1sCmluZGV4IDNkYTAyMDI2ZmYwLi5mMjI2 YzZjZjA1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWxlL2ZpbGUtaW5w dXQtcmVzZXQtdXNpbmctb3Blbi1wYW5lbC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvZmlsZS9maWxlLWlucHV0LXJlc2V0LXVzaW5nLW9wZW4tcGFuZWwuaHRtbApAQCAtMjMsMTIg KzIzLDE1IEBAIGlmICh0ZXN0UnVubmVyICYmIGV2ZW50U2VuZGVyKSB7CiAKICAgICBmaWxlLmFk ZEV2ZW50TGlzdGVuZXIoImNoYW5nZSIsIGZ1bmN0aW9uKCkgewogICAgICAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmlubmVySFRNTCA9IGZpbGUudmFsdWUgKyAiIGlzIHNl bGVjdGVkLiI7Ci0gICAgICAgIFVJSGVscGVyLmFjdGl2YXRlQXQocmVzZXQub2Zmc2V0TGVmdCAr IHJlc2V0Lm9mZnNldFdpZHRoIC8gMiwgcmVzZXQub2Zmc2V0VG9wICsgcmVzZXQub2Zmc2V0SGVp Z2h0IC8gMikudGhlbihmdW5jdGlvbigpIHsKLSAgICAgICAgICAgIC8vIE1vdmUgYSBjdXJzb3Ig b3V0IG9mIHRoZSByZXNldCBidXR0b24uCi0gICAgICAgICAgICBVSUhlbHBlci5hY3RpdmF0ZUF0 KHJlc2V0Lm9mZnNldExlZnQgKyByZXNldC5vZmZzZXRXaWR0aCArIDEwLCByZXNldC5vZmZzZXRU b3AgKyByZXNldC5vZmZzZXRIZWlnaHQgKyAxMCkudGhlbihmdW5jdGlvbigpIHsKLSAgICAgICAg ICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgLy8gVGhlIGNoYW5nZSBl dmVudCBjYW4gYmUgZmlyZWQgYmVmb3JlIHRoZSBtb3VzZSB1cCwgc28gdXNlIGEgdGltZW91dCBo ZXJlIHRvIGVuc3VyZSB0aGUgbmV4dCBtb3VzZSBkb3duIGhhcHBlbnMgYWZ0ZXIgdGhlIHBlbmRp bmcgbW91c2UgdXAuCisgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAg ICAgICAgICAgVUlIZWxwZXIuYWN0aXZhdGVBdChyZXNldC5vZmZzZXRMZWZ0ICsgcmVzZXQub2Zm c2V0V2lkdGggLyAyLCByZXNldC5vZmZzZXRUb3AgKyByZXNldC5vZmZzZXRIZWlnaHQgLyAyKS50 aGVuKGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgIC8vIE1vdmUgYSBjdXJzb3Igb3V0IG9m IHRoZSByZXNldCBidXR0b24uCisgICAgICAgICAgICAgICAgVUlIZWxwZXIuYWN0aXZhdGVBdChy ZXNldC5vZmZzZXRMZWZ0ICsgcmVzZXQub2Zmc2V0V2lkdGggKyAxMCwgcmVzZXQub2Zmc2V0VG9w ICsgcmVzZXQub2Zmc2V0SGVpZ2h0ICsgMTApLnRoZW4oZnVuY3Rpb24oKSB7CisgICAgICAgICAg ICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgICAgICAgICAgIH0pOwog ICAgICAgICAgICAgfSk7Ci0gICAgICAgIH0pOworICAgICAgICB9LCAwKTsKICAgICB9KTsKIAog ICAgIG9wZW5GaWxlc0luRWxlbWVudChmaWxlLCBbImZvby50eHQiXSk7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ZpbGUvZmlsZS1yZXNldC1pbi1jaGFuZ2UtdXNpbmctb3Bl bi1wYW5lbC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9maWxlL2ZpbGUtcmVzZXQtaW4t Y2hhbmdlLXVzaW5nLW9wZW4tcGFuZWwuaHRtbAppbmRleCA5MDE4MTdhMDUxOC4uZTk4NzdhZTli ODAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvZmlsZS9maWxlLXJlc2V0LWlu LWNoYW5nZS11c2luZy1vcGVuLXBhbmVsLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9maWxlL2ZpbGUtcmVzZXQtaW4tY2hhbmdlLXVzaW5nLW9wZW4tcGFuZWwuaHRtbApAQCAtMTUs OSArMTUsMTIgQEAgZnVuY3Rpb24gb3BlbkZpbGVzSW5FbGVtZW50KGVsZW1lbnQsIGZpbGVzKSB7 CiAKIGZ1bmN0aW9uIGhhbmRsZUNoYW5nZSgpIHsKICAgICBmaWxlMS52YWx1ZSA9ICcnOwotICAg IFVJSGVscGVyLmFjdGl2YXRlQXQoMSwgMSkudGhlbihmdW5jdGlvbigpIHsKLSAgICAgICAgdGVz dFJ1bm5lci5ub3RpZnlEb25lKCk7Ci0gICAgfSk7CisgICAgLy8gVGhlIGNoYW5nZSBldmVudCBj YW4gYmUgZmlyZWQgYmVmb3JlIHRoZSBtb3VzZSB1cCwgc28gdXNlIGEgdGltZW91dCBoZXJlIHRv IGVuc3VyZSB0aGUgbmV4dCBtb3VzZSBkb3duIGhhcHBlbnMgYWZ0ZXIgdGhlIHBlbmRpbmcgbW91 c2UgdXAuCisgICAgd2luZG93LnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgIFVJSGVs cGVyLmFjdGl2YXRlQXQoMSwgMSkudGhlbihmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHRlc3RS dW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9KTsKKyAgICB9LCAwKTsKIH0KIAogaWYgKHdp bmRvdy50ZXN0UnVubmVyKQo=