169123 2017-03-03 00:27:20 -0800 [WinCairo] '__int128_t': undeclared identifier in MediaTime.cpp 2017-03-06 16:58:36 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 169098 1 fujii jer.noble achristensen basuke don.olmstead jer.noble oldest_to_newest 1283109 0 fujii 2017-03-03 00:27:20 -0800 [WinCairo] '__int128_t': undeclared identifier in MediaTime.cpp WinCairo x64 build fails since r213324 (Bug 169098). > [6/1400] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\MediaTime.cpp.obj > FAILED: C:\PROGRA~2\MICROS~3.0\VC\bin\amd64\cl.exe /nologo /TP /DWIN32 /D_WINDOWS /W4 /GR- /EHs- /EHc- /MT /O2 /Ob2 /D NDEBUG -IDerivedSources\ForwardingHeaders -IDerivedSources -I..\..\WebKitLibraries\win\include -I..\..\Source\bmalloc -I..\..\Source\WTF -I..\..\Source\WTF\wtf -I..\..\Source\WTF\wtf\dtoa -I..\..\Source\WTF\wtf\persistence -I..\..\Source\WTF\wtf\text -I..\..\Source\WTF\wtf\text\icu -I..\..\Source\WTF\wtf\threads -I..\..\Source\WTF\wtf\unicode -I..\..\Source\ThirdParty -I. /wd4018 /wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180 /wd4189 /wd4201 /wd4206 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305 /wd4309 /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459 /wd4481 /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611 /wd4646 /wd4702 /wd4706 /wd4722 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996 /wd6011 /wd6031 /wd6211 /wd6246 /wd6255 /wd6387 /Zi /GS /EHa- /EHc- /EHs- /fp:except- /analyze- /bigobj /Gy- /openmp- /GF- /Oy- /showIncludes -DBUILDING_WITH_CMAKE=1 -DBUILDING_WTF -DHAVE_CONFIG_H=1 -DNOMINMAX -DUNICODE -DWINVER=0x601 -DWTF_EXPORTS -DWTF_PLATFORM_WIN_CAIRO=1 -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WINDOWS /FoSource\WTF\wtf\CMakeFiles\WTF.dir\MediaTime.cpp.obj /FdSource\WTF\wtf\CMakeFiles\WTF.dir\ /FS -c ..\..\Source\WTF\wtf\MediaTime.cpp > ..\..\Source\WTF\wtf\MediaTime.cpp(493): error C2065: '__int128_t': undeclared identifier > ..\..\Source\WTF\wtf\MediaTime.cpp(493): error C2146: syntax error: missing ';' before identifier 'newValue' > ..\..\Source\WTF\wtf\MediaTime.cpp(493): error C2065: 'newValue': undeclared identifier > ..\..\Source\WTF\wtf\MediaTime.cpp(493): error C2061: syntax error: identifier '__int128_t' > ..\..\Source\WTF\wtf\MediaTime.cpp(494): error C2065: 'newValue': undeclared identifier > ..\..\Source\WTF\wtf\MediaTime.cpp(495): error C2065: 'newValue': undeclared identifier > ..\..\Source\WTF\wtf\MediaTime.cpp(497): error C2065: 'newValue': undeclared identifier > ..\..\Source\WTF\wtf\MediaTime.cpp(502): error C2065: 'newValue': undeclared identifier > ..\..\Source\WTF\wtf\MediaTime.cpp(518): error C2065: 'newValue': undeclared identifier > ninja: build stopped: subcommand failed. 1283192 1 303327 jer.noble 2017-03-03 10:20:30 -0800 Created attachment 303327 Patch 1283193 2 jer.noble 2017-03-03 10:21:45 -0800 Would someone with access to a 64-bit Windows builder please try out this patch and verify that it fixes the compiler error? 1283194 3 don.olmstead 2017-03-03 10:25:17 -0800 Jer Noble would a more effective patch be to actually test for the presence of int128_t? I was looking at this and was thinking of doing a HAVE version of it. 1283196 4 jer.noble 2017-03-03 10:57:39 -0800 (In reply to comment #3) > Jer Noble would a more effective patch be to actually test for the presence > of int128_t? I was looking at this and was thinking of doing a HAVE version > of it. I couldn't find a directive I could use for such a test; if you can, more the better! 1283199 5 303329 don.olmstead 2017-03-03 11:18:35 -0800 Created attachment 303329 Patch with CMake checks for HAVE Here's a version that checks for the presence of __int128_t through CMake. 1283254 6 303329 achristensen 2017-03-03 14:17:10 -0800 Comment on attachment 303329 Patch with CMake checks for HAVE View in context: https://bugs.webkit.org/attachment.cgi?id=303329&action=review > Source/WTF/wtf/Platform.h:553 > #if CPU(X86_64) > #define HAVE_NETWORK_EXTENSION 1 > #define USE_PLUGIN_HOST_PROCESS 1 > +#define HAVE_INT128_T 1 I don't think this properly reflects the fact that Visual Studio doesn't support the __int128_t type. 1283256 7 don.olmstead 2017-03-03 14:18:27 -0800 All the changes to Platform.h are for the Mac side since its not using CMake. 1283414 8 achristensen 2017-03-04 00:21:24 -0800 Sorry, Don. Jer's fix passed EWS and was simpler. If we feel it's worth it to optimize this for Windows, we can do so later, but we need to fix the build. 1284063 9 fujii 2017-03-06 16:58:08 -0800 Landed manually. https://trac.webkit.org/changeset/213419 303327 2017-03-03 10:20:30 -0800 2017-03-04 00:20:44 -0800 Patch bug-169123-20170303102029.patch text/plain 1452 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDFkNzM1NzZlNWQ2ZTU0ZDI5NTI3Y2Iy MzhmM2M3OWJjNzU2MjVhNjcuLjA2MjQ2MjA1NjRkNjZhYmZjNDIyMGJmZmU1MTQ0OWQ0MjNkMTRi M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDMtMDMgIEplciBOb2JsZSAgPGplci5ub2Js ZUBhcHBsZS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSAnX19pbnQxMjhfdCc6IHVuZGVjbGFy ZWQgaWRlbnRpZmllciBpbiBNZWRpYVRpbWUuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjkxMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBwZXJmb3JtIHRoZSAxMjgtYml0IG9wdGltaXpl ZCBwYXRoIG9uIFdpbmRvd3MsIHdoZXJlIHRoZSBfX2ludDEyOF90IGludHJpbnNpYyBpc24ndCBh dmFpbGFibGUuCisKKyAgICAgICAgKiB3dGYvTWVkaWFUaW1lLmNwcDoKKyAgICAgICAgKFdURjo6 TWVkaWFUaW1lOjpzZXRUaW1lU2NhbGUpOgorCiAyMDE3LTAzLTAyICBKZXIgTm9ibGUgIDxqZXIu bm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFN1ZmZpY2VudGx5IGxhcmdlIHRpbWVWYWx1ZSBh bmQgdGltZVNjYWxlIGFyZ3VtZW50cyB0byBNZWRpYVRpbWUgd2lsbCBjYXVzZSB3cmFwcGluZyBp biB0b1RpbWVTY2FsZSgpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTWVkaWFUaW1lLmNw cCBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5jcHAKaW5kZXggOGYxNjhmYzRjZTlhNTViMWUy OWYzZjBhYmI5MzYwYmVlMmMwN2M2Yy4uYjBhMTI0MmMwNWQ2MTM2YjRmZjdhZWQxOTA1OTBlZDRk NTI5ODNhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWVkaWFUaW1lLmNwcAorKysgYi9T b3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuY3BwCkBAIC00ODksNyArNDg5LDcgQEAgdm9pZCBNZWRp YVRpbWU6OnNldFRpbWVTY2FsZSh1aW50MzJfdCB0aW1lU2NhbGUsIFJvdW5kaW5nRmxhZ3MgZmxh Z3MpCiAKICAgICB0aW1lU2NhbGUgPSBzdGQ6Om1pbihNYXhpbXVtVGltZVNjYWxlLCB0aW1lU2Nh bGUpOwogCi0jaWYgQ1BVKFg4Nl82NCkgfHwgQ1BVKEFSTTY0KQorI2lmICFQTEFURk9STShXSU4p ICYmIChDUFUoWDg2XzY0KSB8fCBDUFUoQVJNNjQpKQogICAgIF9faW50MTI4X3QgbmV3VmFsdWUg PSBzdGF0aWNfY2FzdDxfX2ludDEyOF90PihtX3RpbWVWYWx1ZSkgKiB0aW1lU2NhbGU7CiAgICAg aW50NjRfdCByZW1haW5kZXIgPSBuZXdWYWx1ZSAlIG1fdGltZVNjYWxlOwogICAgIG5ld1ZhbHVl ID0gbmV3VmFsdWUgLyBtX3RpbWVTY2FsZTsK 303329 2017-03-03 11:18:35 -0800 2017-03-06 16:58:36 -0800 Patch with CMake checks for HAVE bug169123.diff text/plain 3100 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkMjI0M2VhLi5hODFiZDhl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTctMDMtMDMgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBhbS5zb255LmNvbT4KKwor ICAgICAgICBbV2luQ2Fpcm9dICdfX2ludDEyOF90JzogdW5kZWNsYXJlZCBpZGVudGlmaWVyIGlu IE1lZGlhVGltZS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2OTEyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2U6CisKIDIwMTctMDMtMDEg IEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGxpYndlYnJ0 YyBhcyBwYXJ0IG9mIHRoZSBBbGwgU291cmNlIHNjaGVtZSBpbiBXZWJLaXQueGN3b3Jrc3BhY2Uu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9n CmluZGV4IDFkNzM1NzYuLjExOWUwM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDMtMDMg IERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBhbS5zb255LmNvbT4KKworICAgICAgICBbV2lu Q2Fpcm9dICdfX2ludDEyOF90JzogdW5kZWNsYXJlZCBpZGVudGlmaWVyIGluIE1lZGlhVGltZS5j cHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTEy MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3Rm L01lZGlhVGltZS5jcHA6CisgICAgICAgIChXVEY6Ok1lZGlhVGltZTo6c2V0VGltZVNjYWxlKToK KyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxNy0wMy0wMiAgSmVyIE5vYmxlICA8amVy Lm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBTdWZmaWNlbnRseSBsYXJnZSB0aW1lVmFsdWUg YW5kIHRpbWVTY2FsZSBhcmd1bWVudHMgdG8gTWVkaWFUaW1lIHdpbGwgY2F1c2Ugd3JhcHBpbmcg aW4gdG9UaW1lU2NhbGUoKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5j cHAgYi9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuY3BwCmluZGV4IDhmMTY4ZmMuLjY0NjI3OWQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5jcHAKKysrIGIvU291cmNlL1dU Ri93dGYvTWVkaWFUaW1lLmNwcApAQCAtNDg5LDcgKzQ4OSw3IEBAIHZvaWQgTWVkaWFUaW1lOjpz ZXRUaW1lU2NhbGUodWludDMyX3QgdGltZVNjYWxlLCBSb3VuZGluZ0ZsYWdzIGZsYWdzKQogCiAg ICAgdGltZVNjYWxlID0gc3RkOjptaW4oTWF4aW11bVRpbWVTY2FsZSwgdGltZVNjYWxlKTsKIAot I2lmIENQVShYODZfNjQpIHx8IENQVShBUk02NCkKKyNpZiBIQVZFKElOVDEyOF9UKSAmJiAoQ1BV KFg4Nl82NCkgfHwgQ1BVKEFSTTY0KSkKICAgICBfX2ludDEyOF90IG5ld1ZhbHVlID0gc3RhdGlj X2Nhc3Q8X19pbnQxMjhfdD4obV90aW1lVmFsdWUpICogdGltZVNjYWxlOwogICAgIGludDY0X3Qg cmVtYWluZGVyID0gbmV3VmFsdWUgJSBtX3RpbWVTY2FsZTsKICAgICBuZXdWYWx1ZSA9IG5ld1Zh bHVlIC8gbV90aW1lU2NhbGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5o IGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCA3YWJhMDQ4Li42OTBiOWUwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtLmgKQEAgLTU1MCw2ICs1NTAsNyBAQAogI2lmIENQVShYODZfNjQpCiAjZGVmaW5lIEhB VkVfTkVUV09SS19FWFRFTlNJT04gMQogI2RlZmluZSBVU0VfUExVR0lOX0hPU1RfUFJPQ0VTUyAx CisjZGVmaW5lIEhBVkVfSU5UMTI4X1QgMQogI2VuZGlmCiAKICNpZiBfX01BQ19PU19YX1ZFUlNJ T05fTUlOX1JFUVVJUkVEID49IDEwMTEwMApAQCAtNTkwLDYgKzU5MSw3IEBACiAKICNpZiBDUFUo QVJNNjQpCiAjZGVmaW5lIEVOQUJMRV9KSVRfQ09OU1RBTlRfQkxJTkRJTkcgMAorI2RlZmluZSBI QVZFX0lOVDEyOF9UIDEKICNlbmRpZgogCiAjaWYgQ1BVKEFSTV9ORU9OKQpkaWZmIC0tZ2l0IGEv U291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0Nv bW1vbi5jbWFrZQppbmRleCAxZWE0ZThkLi4yYmJjNWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21h a2UvT3B0aW9uc0NvbW1vbi5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5j bWFrZQpAQCAtMjI1LDYgKzIyNSw3IEBAIGluY2x1ZGUoQ2hlY2tJbmNsdWRlRmlsZSkKIGluY2x1 ZGUoQ2hlY2tGdW5jdGlvbkV4aXN0cykKIGluY2x1ZGUoQ2hlY2tTeW1ib2xFeGlzdHMpCiBpbmNs dWRlKENoZWNrU3RydWN0SGFzTWVtYmVyKQoraW5jbHVkZShDaGVja1R5cGVTaXplKQogCiBtYWNy byhfSEFWRV9DSEVDS19JTkNMVURFIF92YXJpYWJsZSBfaGVhZGVyKQogICAgIGNoZWNrX2luY2x1 ZGVfZmlsZSgke19oZWFkZXJ9ICR7X3ZhcmlhYmxlfV92YWx1ZSkKQEAgLTI3NiwzICsyNzcsMTEg QEAgX0hBVkVfQ0hFQ0tfU1lNQk9MKEhBVkVfU0lHTkFMX0ggU0lHVFJBUCBzaWduYWwuaCkKIF9I QVZFX0NIRUNLX1NUUlVDVChIQVZFX1NUQVRfQklSVEhUSU1FICJzdHJ1Y3Qgc3RhdCIgc3RfYmly dGh0aW1lIHN5cy9zdGF0LmgpCiBfSEFWRV9DSEVDS19TVFJVQ1QoSEFWRV9UTV9HTVRPRkYgInN0 cnVjdCB0bSIgdG1fZ210b2ZmIHRpbWUuaCkKIF9IQVZFX0NIRUNLX1NUUlVDVChIQVZFX1RNX1pP TkUgInN0cnVjdCB0bSIgdG1fem9uZSB0aW1lLmgpCisKKyMgQ2hlY2sgZm9yIGludCB0eXBlcwor Y2hlY2tfdHlwZV9zaXplKCJfX2ludDEyOF90IiBJTlQxMjhfVkFMVUUpCisKK2lmIChIQVZFX0lO VDEyOF9WQUxVRSkKKyAgU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoSEFWRV9JTlQxMjhfVCBJTlQx MjhfVkFMVUUpCitlbmRpZiAoKQorCg==