169104 2017-03-02 15:31:52 -0800 Move part of NetworkRTCProvider::close implementation in NetworkRTCProvider destructor 2017-03-02 17:28:51 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf achristensen commit-queue eric.carlson oldest_to_newest 1282920 0 youennf 2017-03-02 15:31:52 -0800 It is safer to delete as many fields as possible in NetworkRTCPRovider destructor. We still need close so that we can cleanproperly rtc network thread related members by taking a ref of NetworkRTCPRovider. 1282924 1 303256 youennf 2017-03-02 15:36:20 -0800 Created attachment 303256 Patch 1282964 2 303256 achristensen 2017-03-02 16:11:11 -0800 Comment on attachment 303256 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303256&action=review > Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp:74 > + stopResolver(identifier); mention in changelog 1282973 3 303266 youennf 2017-03-02 16:24:05 -0800 Created attachment 303266 Patch for landing 1282999 4 303266 commit-queue 2017-03-02 17:28:47 -0800 Comment on attachment 303266 Patch for landing Clearing flags on attachment: 303266 Committed r213330: <http://trac.webkit.org/changeset/213330> 1283000 5 commit-queue 2017-03-02 17:28:51 -0800 All reviewed patches have been landed. Closing bug. 303256 2017-03-02 15:36:20 -0800 2017-03-02 16:24:02 -0800 Patch bug-169104-20170302153619.patch text/plain 3554 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTAxZDg4YTY0NTIwYzE3 ZDhlNGMyNmIxMjQ0MGM5Y2E0ODJiNjQxMi4uODAxYjI4ZTdkNWQ1ZTAyYWRiNDdhMjU2NDU2YTI5 YWQyZTU5MDgwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE3LTAzLTAyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBNb3ZlIHBhcnQgb2YgTmV0 d29ya1JUQ1Byb3ZpZGVyOjpjbG9zZSBpbXBsZW1lbnRhdGlvbiBpbiBOZXR3b3JrUlRDUHJvdmlk ZXIgZGVzdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY5MTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW1wcm92aW5nIE5ldHdvcmtSVENQcm92aWRlciBjbGVhbi11cCBieSBtb3Zpbmcgc29t ZSBtZW1iZXIgZmllbGQgY2xlYW5pbmcgdG8gdGhlIGRlc3RydWN0b3IuCisgICAgICAgIFRoZSBy ZW1haW5pbmcgY2xlYW5pbmcgaXMgc3RpbGwga2VwdCBpbiBOZXR3b3JrUlRDUHJvdmlkZXI6OmNs b3NlIGFzIHdlIG5lZWQgdG8gZ28gdG8gdGhlIHJ0YyBuZXR3b3JrIHRocmVhZCBhbmQKKyAgICAg ICAgZm9yIHRoYXQsIHdlIHRha2UgYSByZWYgb2YgTmV0d29ya1JUQ1Byb3ZpZGVyLgorCisgICAg ICAgICogTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENNb25pdG9yLmg6CisgICAgICAg ICogTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHA6CisgICAgICAg IChXZWJLaXQ6Ok5ldHdvcmtSVENQcm92aWRlcjo6fk5ldHdvcmtSVENQcm92aWRlcik6CisgICAg ICAgIChXZWJLaXQ6Ok5ldHdvcmtSVENQcm92aWRlcjo6Y2xvc2UpOgorICAgICAgICAqIE5ldHdv cmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuaDoKKworMjAxNy0wMy0wMiAgWW91 ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKICAgICAgICAgQWN0aXZhdGUgc29tZSBu ZXcgd2VicnRjIHRlc3RzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjg4NTAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3Mvd2VicnRjL05ldHdvcmtSVENNb25pdG9yLmggYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy93ZWJydGMvTmV0d29ya1JUQ01vbml0b3IuaAppbmRleCA0ODUwMGE3Nzk4Njc2MWE0MDRk MmE5ODMyMWFiMDVkMjBhNzc3NzFhLi4xNDg4MmNkOTM2ODAyZGZjNmU4OGFjNThmZjE1N2M1YjA3 YjZkYjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy93ZWJydGMv TmV0d29ya1JUQ01vbml0b3IuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy93 ZWJydGMvTmV0d29ya1JUQ01vbml0b3IuaApAQCAtNDgsNiArNDgsNyBAQCBwdWJsaWM6CiAKICAg ICB2b2lkIGRpZFJlY2VpdmVNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiYsIElQQzo6RGVjb2RlciYp OwogICAgIHZvaWQgc3RvcFVwZGF0aW5nKCk7CisgICAgYm9vbCBpc1N0YXJ0ZWQoKSBjb25zdCB7 IHJldHVybiBtX2lzU3RhcnRlZDsgfQogCiBwcml2YXRlOgogICAgIHZvaWQgc3RhcnRVcGRhdGlu ZygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05l dHdvcmtSVENQcm92aWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy93ZWJy dGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcAppbmRleCAwMjRmYzk3MzlkYWRkOWQ1M2UxNzEzOWM2 NmUzNDBhYmJlYjhlZmNmLi5lMmExMDgwZWIzOGUzN2YxMTNjM2QyNDdjMzM0ZGVlMDMyZmQwNzEx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29y a1JUQ1Byb3ZpZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy93ZWJy dGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcApAQCAtNjQsMTAgKzY0LDE5IEBAIE5ldHdvcmtSVENQ cm92aWRlcjo6TmV0d29ya1JUQ1Byb3ZpZGVyKE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNz JiBjb25uZWN0aW9uCiAjZW5kaWYKIH0KIAorTmV0d29ya1JUQ1Byb3ZpZGVyOjp+TmV0d29ya1JU Q1Byb3ZpZGVyKCkKK3sKKyAgICBBU1NFUlQoIW1fY29ubmVjdGlvbik7CisgICAgQVNTRVJUKCFt X3NvY2tldHMuc2l6ZSgpKTsKKyAgICBBU1NFUlQoIW1fcnRjTW9uaXRvci5pc1N0YXJ0ZWQoKSk7 CisKKyAgICBmb3IgKGF1dG8gaWRlbnRpZmllciA6IG1fcmVzb2x2ZXJzLmtleXMoKSkKKyAgICAg ICAgc3RvcFJlc29sdmVyKGlkZW50aWZpZXIpOworfQorCiB2b2lkIE5ldHdvcmtSVENQcm92aWRl cjo6Y2xvc2UoKQogewogICAgIG1fY29ubmVjdGlvbiA9IG51bGxwdHI7Ci0gICAgbV9yZXNvbHZl cnMuY2xlYXIoKTsKICAgICBtX3J0Y01vbml0b3Iuc3RvcFVwZGF0aW5nKCk7CiAKICAgICBjYWxs T25SVENOZXR3b3JrVGhyZWFkKFt0aGlzXSgpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuaCBiL1NvdXJjZS9XZWJL aXQyL05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuaAppbmRleCAyZTg4 MDZkYmU0ZGZjZjBlZTVjOWJiMjgyNmI5MDU1ZDUxYjBlOTY3Li4zNGZmNWRiMjI5NTliNzNmMThh ZmE5MjQyNmQ2NmJkZDNmY2M5OGVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmgKKysrIGIvU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5oCkBAIC01Miw2ICs1Miw3 IEBAIGNsYXNzIE5ldHdvcmtSVENTb2NrZXQ7CiBjbGFzcyBOZXR3b3JrUlRDUHJvdmlkZXIgOiBw dWJsaWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8TmV0d29ya1JUQ1Byb3ZpZGVyPiwgcHVibGljIHJ0 Yzo6TWVzc2FnZUhhbmRsZXIgewogcHVibGljOgogICAgIHN0YXRpYyBSZWY8TmV0d29ya1JUQ1By b3ZpZGVyPiBjcmVhdGUoTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MmIGNvbm5lY3Rpb24p IHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgTmV0d29ya1JUQ1Byb3ZpZGVyKGNvbm5lY3Rpb24pKTsg fQorICAgIH5OZXR3b3JrUlRDUHJvdmlkZXIoKTsKIAogICAgIHZvaWQgZGlkUmVjZWl2ZU1lc3Nh Z2UoSVBDOjpDb25uZWN0aW9uJiwgSVBDOjpEZWNvZGVyJik7CiAgICAgdm9pZCBkaWRSZWNlaXZl TmV0d29ya1JUQ01vbml0b3JNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiYgY29ubmVjdGlvbiwgSVBD OjpEZWNvZGVyJiBkZWNvZGVyKSB7IG1fcnRjTW9uaXRvci5kaWRSZWNlaXZlTWVzc2FnZShjb25u ZWN0aW9uLCBkZWNvZGVyKTsgfQo= 303266 2017-03-02 16:24:05 -0800 2017-03-02 17:28:47 -0800 Patch for landing bug-169104-20170302162405.patch text/plain 3579 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzMzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDdiMjYzMTRkYzJiMzQ3 ZWNhZTZkYWVlYjllMjE1ZmU0YThjZTI3OS4uMWU1MjgxYWZhNTIwZjc0MmRlYTA1NDg2ODJlMjk0 YzVmYjM1ZWFiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTAzLTAyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIHBhcnQgb2YgTmV0 d29ya1JUQ1Byb3ZpZGVyOjpjbG9zZSBpbXBsZW1lbnRhdGlvbiBpbiBOZXR3b3JrUlRDUHJvdmlk ZXIgZGVzdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY5MTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleCBDaHJpc3RlbnNlbi4KKwor ICAgICAgICBJbXByb3ZpbmcgTmV0d29ya1JUQ1Byb3ZpZGVyIGNsZWFuLXVwIGJ5IG1vdmluZyBz b21lIG1lbWJlciBmaWVsZCBjbGVhbmluZyB0byB0aGUgZGVzdHJ1Y3Rvci4KKyAgICAgICAgVGhl IHJlbWFpbmluZyBjbGVhbmluZyBpcyBzdGlsbCBrZXB0IGluIE5ldHdvcmtSVENQcm92aWRlcjo6 Y2xvc2UgYXMgd2UgbmVlZCB0byBnbyB0byB0aGUgcnRjIG5ldHdvcmsgdGhyZWFkIGFuZAorICAg ICAgICBmb3IgdGhhdCwgd2UgdGFrZSBhIHJlZiBvZiBOZXR3b3JrUlRDUHJvdmlkZXIuCisgICAg ICAgIFN0b3BwaW5nIGFueSByZXNvbHZlciBiZWZvcmUgZnJlZWluZyB0aGVtLgorCisgICAgICAg ICogTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENNb25pdG9yLmg6CisgICAgICAgICog TmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHA6CisgICAgICAgIChX ZWJLaXQ6Ok5ldHdvcmtSVENQcm92aWRlcjo6fk5ldHdvcmtSVENQcm92aWRlcik6CisgICAgICAg IChXZWJLaXQ6Ok5ldHdvcmtSVENQcm92aWRlcjo6Y2xvc2UpOgorICAgICAgICAqIE5ldHdvcmtQ cm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuaDoKKwogMjAxNy0wMy0wMiAgQWFrYXNo IEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBzdHJpbmdNYXRj aGVzV2lsZGNhcmRTdHJpbmcgZnJvbSBXZWJLaXQyIHRvIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDTW9uaXRvci5oIGIv U291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENNb25pdG9yLmgK aW5kZXggNDg1MDBhNzc5ODY3NjFhNDA0ZDJhOTgzMjFhYjA1ZDIwYTc3NzcxYS4uMTQ4ODJjZDkz NjgwMmRmYzZlODhhYzU4ZmYxNTdjNWIwN2I2ZGI5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENNb25pdG9yLmgKKysrIGIvU291cmNl L1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENNb25pdG9yLmgKQEAgLTQ4 LDYgKzQ4LDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBkaWRSZWNlaXZlTWVzc2FnZShJUEM6OkNv bm5lY3Rpb24mLCBJUEM6OkRlY29kZXImKTsKICAgICB2b2lkIHN0b3BVcGRhdGluZygpOworICAg IGJvb2wgaXNTdGFydGVkKCkgY29uc3QgeyByZXR1cm4gbV9pc1N0YXJ0ZWQ7IH0KIAogcHJpdmF0 ZToKICAgICB2b2lkIHN0YXJ0VXBkYXRpbmcoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuY3BwIGIvU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHAKaW5kZXgg MDI0ZmM5NzM5ZGFkZDlkNTNlMTcxMzljNjZlMzQwYWJiZWI4ZWZjZi4uZTJhMTA4MGViMzhlMzdm MTEzYzNkMjQ3YzMzNGRlZTAzMmZkMDcxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0 d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHAKQEAgLTY0 LDEwICs2NCwxOSBAQCBOZXR3b3JrUlRDUHJvdmlkZXI6Ok5ldHdvcmtSVENQcm92aWRlcihOZXR3 b3JrQ29ubmVjdGlvblRvV2ViUHJvY2VzcyYgY29ubmVjdGlvbgogI2VuZGlmCiB9CiAKK05ldHdv cmtSVENQcm92aWRlcjo6fk5ldHdvcmtSVENQcm92aWRlcigpCit7CisgICAgQVNTRVJUKCFtX2Nv bm5lY3Rpb24pOworICAgIEFTU0VSVCghbV9zb2NrZXRzLnNpemUoKSk7CisgICAgQVNTRVJUKCFt X3J0Y01vbml0b3IuaXNTdGFydGVkKCkpOworCisgICAgZm9yIChhdXRvIGlkZW50aWZpZXIgOiBt X3Jlc29sdmVycy5rZXlzKCkpCisgICAgICAgIHN0b3BSZXNvbHZlcihpZGVudGlmaWVyKTsKK30K Kwogdm9pZCBOZXR3b3JrUlRDUHJvdmlkZXI6OmNsb3NlKCkKIHsKICAgICBtX2Nvbm5lY3Rpb24g PSBudWxscHRyOwotICAgIG1fcmVzb2x2ZXJzLmNsZWFyKCk7CiAgICAgbV9ydGNNb25pdG9yLnN0 b3BVcGRhdGluZygpOwogCiAgICAgY2FsbE9uUlRDTmV0d29ya1RocmVhZChbdGhpc10oKSB7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JU Q1Byb3ZpZGVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29y a1JUQ1Byb3ZpZGVyLmgKaW5kZXggMmU4ODA2ZGJlNGRmY2YwZWU1YzliYjI4MjZiOTA1NWQ1MWIw ZTk2Ny4uMzRmZjVkYjIyOTU5YjczZjE4YWZhOTI0MjZkNjZiZGQzZmNjOThlZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRl ci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRD UHJvdmlkZXIuaApAQCAtNTIsNiArNTIsNyBAQCBjbGFzcyBOZXR3b3JrUlRDU29ja2V0OwogY2xh c3MgTmV0d29ya1JUQ1Byb3ZpZGVyIDogcHVibGljIFRocmVhZFNhZmVSZWZDb3VudGVkPE5ldHdv cmtSVENQcm92aWRlcj4sIHB1YmxpYyBydGM6Ok1lc3NhZ2VIYW5kbGVyIHsKIHB1YmxpYzoKICAg ICBzdGF0aWMgUmVmPE5ldHdvcmtSVENQcm92aWRlcj4gY3JlYXRlKE5ldHdvcmtDb25uZWN0aW9u VG9XZWJQcm9jZXNzJiBjb25uZWN0aW9uKSB7IHJldHVybiBhZG9wdFJlZigqbmV3IE5ldHdvcmtS VENQcm92aWRlcihjb25uZWN0aW9uKSk7IH0KKyAgICB+TmV0d29ya1JUQ1Byb3ZpZGVyKCk7CiAK ICAgICB2b2lkIGRpZFJlY2VpdmVNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiYsIElQQzo6RGVjb2Rl ciYpOwogICAgIHZvaWQgZGlkUmVjZWl2ZU5ldHdvcmtSVENNb25pdG9yTWVzc2FnZShJUEM6OkNv bm5lY3Rpb24mIGNvbm5lY3Rpb24sIElQQzo6RGVjb2RlciYgZGVjb2RlcikgeyBtX3J0Y01vbml0 b3IuZGlkUmVjZWl2ZU1lc3NhZ2UoY29ubmVjdGlvbiwgZGVjb2Rlcik7IH0K