16910 2008-01-17 13:41:29 -0800 [GTK] REGRESSION: keyboard cursor doesn't blink 2010-02-19 14:23:47 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P1 Normal --- 1 lethalman88 webkit-unassigned alp aroben tonikitoo oldest_to_newest 67528 0 lethalman88 2008-01-17 13:41:29 -0800 In latest clean build r29592 i discovered the cursor doesn't blink when in entry texts or in other text widgets. I'm using GTK+ 2.12.1-r2. 67580 1 alp 2008-01-18 00:55:55 -0800 Regression appears to have been introduced in r29581. Upgrading to P1. 67604 2 timothy 2008-01-18 11:52:19 -0800 This should be fixed in r29629. 67605 3 aroben 2008-01-18 12:00:15 -0800 Lethalman in #webkit-gtk says this is not fixed. 67606 4 aroben 2008-01-18 12:07:36 -0800 Looks like the GTK code never calls FocusController::setActive. This used to happen as a side-effect of FocusController::setFocusedFrarme, but no longer does. GTK's WebView needs to call FocusController::setActive whenever the window containing the WebView becomes the topmost window. 67607 5 aroben 2008-01-18 12:13:35 -0800 (In reply to comment #4) > GTK's WebView needs to call FocusController::setActive whenever the window > containing the WebView becomes the topmost window. This may not be strictly true. On Mac/Windows, we have to call setActive at this time because we want the color of the form controls in the WebView to change regardless of whether the WebView is focused or not. If in GTK there's nothing that changes based on whether the window is the topmost or not, then you could call setActive when, for example, the WebView gets focused. 67608 6 alp 2008-01-18 12:20:11 -0800 (In reply to comment #5) > (In reply to comment #4) > > GTK's WebView needs to call FocusController::setActive whenever the window > > containing the WebView becomes the topmost window. > > This may not be strictly true. On Mac/Windows, we have to call setActive at > this time because we want the color of the form controls in the WebView to > change regardless of whether the WebView is focused or not. If in GTK there's > nothing that changes based on whether the window is the topmost or not, then > you could call setActive when, for example, the WebView gets focused. > GTK+ also has this concept of top-level window focus, so we probably need to do the same thing. 67615 7 18532 lethalman88 2008-01-18 13:38:51 -0800 Created attachment 18532 patch for focusing Fixes also http://bugs.webkit.org/show_bug.cgi?id=16863 67616 8 18532 aroben 2008-01-18 13:40:38 -0800 Comment on attachment 18532 patch for focusing Is there a way to hook this call up to the "top-most window" concept, which Alp says GTK does have? 67624 9 18533 lethalman88 2008-01-18 14:18:55 -0800 Created attachment 18533 toplevel focus From devhelp: gtk_window_has_toplevel_focus Returns whether the input focus is within this GtkWindow. Does this match the Mac meaning of topmost window? I'm poor with English in this case :) 67663 10 18533 alp 2008-01-18 23:45:34 -0800 Comment on attachment 18533 toplevel focus r=me This fixes the regressions. We will still need to look at fixing focus handling properly some time. There are a few * position style issues here I'll have to fix up before landing. 67665 11 alp 2008-01-18 23:51:37 -0800 Landed in r29665. 18532 2008-01-18 13:38:51 -0800 2008-01-18 14:18:55 -0800 patch for focusing caret.patch text/plain 1916 lethalman88 SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiAyOTYzNikKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDEtMTggIEx1Y2EgQnJ1bm8gIDxsZXRoYWxt YW44OEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5MTAKKyAg ICAgICAgW0dUS10gUkVHUkVTU0lPTjoga2V5Ym9hcmQgY3Vyc29yIGRvZXNuJ3QgYmxpbmsKKwor ICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg2MworICAg ICAgICBbR1RLXSBSRUdSRVNTSU9OOiB0YWIgZm9jdXNpbmcgZG9lc24ndCB3b3JrCisKKyAgICAg ICAgKiBXZWJWaWV3L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3 X2ZvY3VzX2luX2V2ZW50KTogQWRkZWQuIFNldCB0aGUgYWN0aXZlIGZyYW1lLgorICAgICAgICAo d2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQpOgorCiAyMDA4LTAxLTE2ICBBbHAgVG9rZXIgIDxh bHBAYXRva2VyLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBX ZWJLaXQvZ3RrL1dlYlZpZXcvd2Via2l0d2Vidmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L2d0ay9XZWJWaWV3L3dlYmtpdHdlYnZpZXcuY3BwCShyZXZpc2lvbiAyOTYzMCkKKysrIFdlYktp dC9ndGsvV2ViVmlldy93ZWJraXR3ZWJ2aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzM5LDYg KzMzOSwxNCBAQAogICAgIGZyYW1lLT52aWV3KCktPmFkanVzdFZpZXdTaXplKCk7CiB9CiAKK3N0 YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfZm9jdXNfaW5fZXZlbnQoR3RrV2lkZ2V0KiB3 aWRnZXQsIEdka0V2ZW50Rm9jdXMgKmV2ZW50KQoreworICAgIFdlYktpdFdlYlZpZXcgKndlYlZp ZXcgPSBXRUJLSVRfV0VCX1ZJRVcod2lkZ2V0KTsKKyAgICBGcmFtZSogZnJhbWUgPSBjb3JlKHdl YmtpdF93ZWJfdmlld19nZXRfbWFpbl9mcmFtZSh3ZWJWaWV3KSk7CisgICAgY29yZSh3ZWJWaWV3 KS0+Zm9jdXNDb250cm9sbGVyKCktPnNldEFjdGl2ZShmcmFtZSk7CisgICAgcmV0dXJuIEdUS19X SURHRVRfQ0xBU1Mod2Via2l0X3dlYl92aWV3X3BhcmVudF9jbGFzcyktPmZvY3VzX2luX2V2ZW50 KHdpZGdldCwgZXZlbnQpOworfQorCiBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfcmVhbGl6 ZShHdGtXaWRnZXQqIHdpZGdldCkKIHsKICAgICBHVEtfV0lER0VUX1NFVF9GTEFHUyh3aWRnZXQs IEdUS19SRUFMSVpFRCk7CkBAIC05MjksNiArOTM3LDcgQEAKICAgICB3aWRnZXRDbGFzcy0+c2Ny b2xsX2V2ZW50ID0gd2Via2l0X3dlYl92aWV3X3Njcm9sbF9ldmVudDsKICAgICB3aWRnZXRDbGFz cy0+c2l6ZV9hbGxvY2F0ZSA9IHdlYmtpdF93ZWJfdmlld19zaXplX2FsbG9jYXRlOwogICAgIHdp ZGdldENsYXNzLT5wb3B1cF9tZW51ID0gd2Via2l0X3dlYl92aWV3X3BvcHVwX21lbnVfaGFuZGxl cjsKKyAgICB3aWRnZXRDbGFzcy0+Zm9jdXNfaW5fZXZlbnQgPSB3ZWJraXRfd2ViX3ZpZXdfZm9j dXNfaW5fZXZlbnQ7CiAKICAgICBHdGtDb250YWluZXJDbGFzcyogY29udGFpbmVyQ2xhc3MgPSBH VEtfQ09OVEFJTkVSX0NMQVNTKHdlYlZpZXdDbGFzcyk7CiAgICAgY29udGFpbmVyQ2xhc3MtPmFk ZCA9IHdlYmtpdF93ZWJfdmlld19jb250YWluZXJfYWRkOwo= 18533 2008-01-18 14:18:55 -0800 2008-01-18 23:45:34 -0800 toplevel focus caret.patch text/plain 2093 lethalman88 SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiAyOTYzNikKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDEtMTggIEx1Y2EgQnJ1bm8gIDxsZXRoYWxt YW44OEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5MTAKKyAg ICAgICAgW0dUS10gUkVHUkVTU0lPTjoga2V5Ym9hcmQgY3Vyc29yIGRvZXNuJ3QgYmxpbmsKKwor ICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg2MworICAg ICAgICBbR1RLXSBSRUdSRVNTSU9OOiB0YWIgZm9jdXNpbmcgZG9lc24ndCB3b3JrCisKKyAgICAg ICAgKiBXZWJWaWV3L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3 X2ZvY3VzX2luX2V2ZW50KTogQWRkZWQuIFNldCB0aGUgYWN0aXZlIGZyYW1lLgorICAgICAgICAo d2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQpOgorCiAyMDA4LTAxLTE2ICBBbHAgVG9rZXIgIDxh bHBAYXRva2VyLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBX ZWJLaXQvZ3RrL1dlYlZpZXcvd2Via2l0d2Vidmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L2d0ay9XZWJWaWV3L3dlYmtpdHdlYnZpZXcuY3BwCShyZXZpc2lvbiAyOTYzMCkKKysrIFdlYktp dC9ndGsvV2ViVmlldy93ZWJraXR3ZWJ2aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzM5LDYg KzMzOSwxNyBAQAogICAgIGZyYW1lLT52aWV3KCktPmFkanVzdFZpZXdTaXplKCk7CiB9CiAKK3N0 YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfZm9jdXNfaW5fZXZlbnQoR3RrV2lkZ2V0KiB3 aWRnZXQsIEdka0V2ZW50Rm9jdXMgKmV2ZW50KQoreworICAgIEd0a1dpZGdldCAqdG9wbGV2ZWwg PSBndGtfd2lkZ2V0X2dldF90b3BsZXZlbCAod2lkZ2V0KTsKKyAgICBpZiAoR1RLX1dJREdFVF9U T1BMRVZFTCh0b3BsZXZlbCkgJiYgZ3RrX3dpbmRvd19oYXNfdG9wbGV2ZWxfZm9jdXMoR1RLX1dJ TkRPVyh0b3BsZXZlbCkpKSB7CisgICAgICAgIFdlYktpdFdlYlZpZXcgKndlYlZpZXcgPSBXRUJL SVRfV0VCX1ZJRVcod2lkZ2V0KTsKKyAgICAgICAgRnJhbWUqIGZyYW1lID0gY29yZSh3ZWJraXRf d2ViX3ZpZXdfZ2V0X21haW5fZnJhbWUod2ViVmlldykpOworICAgICAgICBjb3JlKHdlYlZpZXcp LT5mb2N1c0NvbnRyb2xsZXIoKS0+c2V0QWN0aXZlKGZyYW1lKTsKKyAgICB9CisgICAgcmV0dXJu IEdUS19XSURHRVRfQ0xBU1Mod2Via2l0X3dlYl92aWV3X3BhcmVudF9jbGFzcyktPmZvY3VzX2lu X2V2ZW50KHdpZGdldCwgZXZlbnQpOworfQorCiBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdf cmVhbGl6ZShHdGtXaWRnZXQqIHdpZGdldCkKIHsKICAgICBHVEtfV0lER0VUX1NFVF9GTEFHUyh3 aWRnZXQsIEdUS19SRUFMSVpFRCk7CkBAIC05MjksNiArOTQwLDcgQEAKICAgICB3aWRnZXRDbGFz cy0+c2Nyb2xsX2V2ZW50ID0gd2Via2l0X3dlYl92aWV3X3Njcm9sbF9ldmVudDsKICAgICB3aWRn ZXRDbGFzcy0+c2l6ZV9hbGxvY2F0ZSA9IHdlYmtpdF93ZWJfdmlld19zaXplX2FsbG9jYXRlOwog ICAgIHdpZGdldENsYXNzLT5wb3B1cF9tZW51ID0gd2Via2l0X3dlYl92aWV3X3BvcHVwX21lbnVf aGFuZGxlcjsKKyAgICB3aWRnZXRDbGFzcy0+Zm9jdXNfaW5fZXZlbnQgPSB3ZWJraXRfd2ViX3Zp ZXdfZm9jdXNfaW5fZXZlbnQ7CiAKICAgICBHdGtDb250YWluZXJDbGFzcyogY29udGFpbmVyQ2xh c3MgPSBHVEtfQ09OVEFJTkVSX0NMQVNTKHdlYlZpZXdDbGFzcyk7CiAgICAgY29udGFpbmVyQ2xh c3MtPmFkZCA9IHdlYmtpdF93ZWJfdmlld19jb250YWluZXJfYWRkOwo=